use credo style

lib/memex/release.ex

@@ -7,7 +7,9 @@ defmodule Memex.Release do
 
   def rollback(repo, version) do
     load_app()
-    {:ok, _, _} = Ecto.Migrator.with_repo(repo, &Ecto.Migrator.run(&1, :down, to: version))
+
+    {:ok, _fun_return, _apps} =
+      Ecto.Migrator.with_repo(repo, &Ecto.Migrator.run(&1, :down, to: version))
   end
 
   defp load_app do
@@ -18,7 +20,8 @@ defmodule Memex.Release do
     load_app()
 
     for repo <- Application.fetch_env!(@app, :ecto_repos) do
-      {:ok, _, _} = Ecto.Migrator.with_repo(repo, &Ecto.Migrator.run(&1, :up, all: true))
+      {:ok, _fun_return, _apps} =
+        Ecto.Migrator.with_repo(repo, &Ecto.Migrator.run(&1, :up, all: true))
     end
   end
 end

lib/memex/repo/migrator.ex

@@ -6,11 +6,11 @@ defmodule Memex.Repo.Migrator do
   use GenServer
   require Logger
 
-  def start_link(_) do
+  def start_link(_opts) do
     GenServer.start_link(__MODULE__, [], [])
   end
 
-  def init(_) do
+  def init(_opts) do
     migrate!()
     {:ok, nil}
   end

lib/memex_web.ex

@@ -73,15 +73,16 @@ defmodule MemexWeb do
     quote do
       use Phoenix.Router
 
+      import Phoenix.{Controller, LiveView.Router}
+      # credo:disable-for-next-line Credo.Check.Consistency.MultiAliasImportRequireUse
       import Plug.Conn
-      import Phoenix.Controller
-      import Phoenix.LiveView.Router
     end
   end
 
   def channel do
     quote do
       use Phoenix.Channel
+      # credo:disable-for-next-line Credo.Check.Consistency.MultiAliasImportRequireUse
       import MemexWeb.Gettext
     end
   end
@@ -89,16 +90,15 @@ defmodule MemexWeb do
   defp view_helpers do
     quote do
       # Use all HTML functionality (forms, tags, etc)
+      # credo:disable-for-next-line Credo.Check.Consistency.MultiAliasImportRequireUse
       use Phoenix.HTML
 
       # Import LiveView and .heex helpers (live_render, live_patch, <.form>, etc)
-      import Phoenix.Component
-      import MemexWeb.LiveHelpers
-
       # Import basic rendering functionality (render, render_layout, etc)
-      import Phoenix.View
-
+      import Phoenix.{Component, View}
       import MemexWeb.{ErrorHelpers, Gettext, LiveHelpers, ViewHelpers}
+
+      # credo:disable-for-next-line Credo.Check.Consistency.MultiAliasImportRequireUse
       alias MemexWeb.Endpoint
       alias MemexWeb.Router.Helpers, as: Routes
     end

lib/memex_web/live/context_live/show.ex

@@ -11,7 +11,7 @@ defmodule MemexWeb.ContextLive.Show do
   @impl true
   def handle_params(
         %{"slug" => slug},
-        _,
+        _params,
         %{assigns: %{live_action: live_action, current_user: current_user}} = socket
       ) do
     context =

lib/memex_web/live/home_live.ex

@@ -3,12 +3,12 @@ defmodule MemexWeb.HomeLive do
   Liveview for the main home page
   """
 
-  @version Mix.Project.config()[:version]
-
   use MemexWeb, :live_view
   alias Memex.Accounts
   alias MemexWeb.{Endpoint, FaqLive}
 
+  @version Mix.Project.config()[:version]
+
   @impl true
   def mount(_params, _session, socket) do
     admins = Accounts.list_users_by_role(:admin)

lib/memex_web/live/invite_live/index.ex

@@ -124,7 +124,7 @@ defmodule MemexWeb.InviteLive.Index do
   end
 
   @impl true
-  def handle_event("copy_to_clipboard", _, socket) do
+  def handle_event("copy_to_clipboard", _params, socket) do
     prompt = dgettext("prompts", "copied to clipboard")
     {:noreply, socket |> put_flash(:info, prompt)}
   end

lib/memex_web/live/note_live/show.ex

@@ -11,7 +11,7 @@ defmodule MemexWeb.NoteLive.Show do
   @impl true
   def handle_params(
         %{"slug" => slug},
-        _,
+        _params,
         %{assigns: %{live_action: live_action, current_user: current_user}} = socket
       ) do
     note =

lib/memex_web/views/email_view.ex

@@ -2,7 +2,6 @@ defmodule MemexWeb.EmailView do
   @moduledoc """
   A view for email-related helper functions
   """
-  alias MemexWeb.HomeLive
-
   use MemexWeb, :view
+  alias MemexWeb.HomeLive
 end

lib/memex_web/views/error_view.ex

@@ -8,7 +8,7 @@ defmodule MemexWeb.ErrorView do
       case error_path do
         "404.html" -> dgettext("errors", "not found")
         "401.html" -> dgettext("errors", "unauthorized")
-        _ -> dgettext("errors", "internal server error")
+        _other_path -> dgettext("errors", "internal server error")
       end
 
     render("error.html", %{error_string: error_string})