work on pipelines

test/memex/pipelines_test.exs

@@ -1,68 +1,120 @@
 defmodule Memex.PipelinesTest do
   use Memex.DataCase
-
-  alias Memex.Pipelines
+  import Memex.PipelinesFixtures
+  alias Memex.{Pipelines, Pipelines.Pipeline}
+  @moduletag :pipelines_test
+  @invalid_attrs %{description: nil, tag: nil, title: nil, visibility: nil}
 
   describe "pipelines" do
-    alias Memex.Pipelines.Pipeline
-
-    import Memex.PipelinesFixtures
-
-    @invalid_attrs %{description: nil, title: nil, visibility: nil}
-
-    test "list_pipelines/0 returns all pipelines" do
-      pipeline = pipeline_fixture()
-      assert Pipelines.list_pipelines() == [pipeline]
+    setup do
+      [user: user_fixture()]
     end
 
-    test "get_pipeline!/1 returns the pipeline with given id" do
-      pipeline = pipeline_fixture()
-      assert Pipelines.get_pipeline!(pipeline.id) == pipeline
+    test "list_pipelines/1 returns all pipelines for a user", %{user: user} do
+      pipeline_a = pipeline_fixture(%{title: "a", visibility: :public}, user)
+      pipeline_b = pipeline_fixture(%{title: "b", visibility: :unlisted}, user)
+      pipeline_c = pipeline_fixture(%{title: "c", visibility: :private}, user)
+      assert Pipelines.list_pipelines(user) == [pipeline_a, pipeline_b, pipeline_c]
     end
 
-    test "create_pipeline/1 with valid data creates a pipeline" do
-      valid_attrs = %{description: "some description", title: "some title", visibility: :public}
+    test "list_public_pipelines/0 returns public pipelines", %{user: user} do
+      public_pipeline = pipeline_fixture(%{visibility: :public}, user)
+      pipeline_fixture(%{visibility: :unlisted}, user)
+      pipeline_fixture(%{visibility: :private}, user)
+      assert Pipelines.list_public_pipelines() == [public_pipeline]
+    end
 
-      assert {:ok, %Pipeline{} = pipeline} = Pipelines.create_pipeline(valid_attrs)
+    test "get_pipeline!/1 returns the pipeline with given id", %{user: user} do
+      pipeline = pipeline_fixture(%{visibility: :public}, user)
+      assert Pipelines.get_pipeline!(pipeline.id, user) == pipeline
+
+      pipeline = pipeline_fixture(%{visibility: :unlisted}, user)
+      assert Pipelines.get_pipeline!(pipeline.id, user) == pipeline
+
+      pipeline = pipeline_fixture(%{visibility: :private}, user)
+      assert Pipelines.get_pipeline!(pipeline.id, user) == pipeline
+    end
+
+    test "get_pipeline!/1 only returns unlisted or public pipelines for other users", %{
+      user: user
+    } do
+      another_user = user_fixture()
+      pipeline = pipeline_fixture(%{visibility: :public}, another_user)
+      assert Pipelines.get_pipeline!(pipeline.id, user) == pipeline
+
+      pipeline = pipeline_fixture(%{visibility: :unlisted}, another_user)
+      assert Pipelines.get_pipeline!(pipeline.id, user) == pipeline
+
+      pipeline = pipeline_fixture(%{visibility: :private}, another_user)
+
+      assert_raise Ecto.NoResultsError, fn ->
+        Pipelines.get_pipeline!(pipeline.id, user)
+      end
+    end
+
+    test "create_pipeline/1 with valid data creates a pipeline", %{user: user} do
+      valid_attrs = %{
+        "description" => "some description",
+        "tags_string" => "tag1,tag2",
+        "title" => "some title",
+        "visibility" => :public
+      }
+
+      assert {:ok, %Pipeline{} = pipeline} = Pipelines.create_pipeline(valid_attrs, user)
       assert pipeline.description == "some description"
+      assert pipeline.tags == ["tag1", "tag2"]
       assert pipeline.title == "some title"
       assert pipeline.visibility == :public
     end
 
-    test "create_pipeline/1 with invalid data returns error changeset" do
-      assert {:error, %Ecto.Changeset{}} = Pipelines.create_pipeline(@invalid_attrs)
+    test "create_pipeline/1 with invalid data returns error changeset", %{user: user} do
+      assert {:error, %Ecto.Changeset{}} = Pipelines.create_pipeline(@invalid_attrs, user)
     end
 
-    test "update_pipeline/2 with valid data updates the pipeline" do
-      pipeline = pipeline_fixture()
+    test "update_pipeline/2 with valid data updates the pipeline", %{user: user} do
+      pipeline = pipeline_fixture(user)
 
       update_attrs = %{
-        description: "some updated description",
-        title: "some updated title",
-        visibility: :private
+        "description" => "some updated description",
+        "tags_string" => "tag1,tag2",
+        "title" => "some updated title",
+        "visibility" => :private
       }
 
-      assert {:ok, %Pipeline{} = pipeline} = Pipelines.update_pipeline(pipeline, update_attrs)
+      assert {:ok, %Pipeline{} = pipeline} =
+               Pipelines.update_pipeline(pipeline, update_attrs, user)
+
       assert pipeline.description == "some updated description"
+      assert pipeline.tags == ["tag1", "tag2"]
       assert pipeline.title == "some updated title"
       assert pipeline.visibility == :private
     end
 
-    test "update_pipeline/2 with invalid data returns error changeset" do
-      pipeline = pipeline_fixture()
-      assert {:error, %Ecto.Changeset{}} = Pipelines.update_pipeline(pipeline, @invalid_attrs)
-      assert pipeline == Pipelines.get_pipeline!(pipeline.id)
+    test "update_pipeline/2 with invalid data returns error changeset", %{user: user} do
+      pipeline = pipeline_fixture(user)
+
+      assert {:error, %Ecto.Changeset{}} =
+               Pipelines.update_pipeline(pipeline, @invalid_attrs, user)
+
+      assert pipeline == Pipelines.get_pipeline!(pipeline.id, user)
     end
 
-    test "delete_pipeline/1 deletes the pipeline" do
-      pipeline = pipeline_fixture()
-      assert {:ok, %Pipeline{}} = Pipelines.delete_pipeline(pipeline)
-      assert_raise Ecto.NoResultsError, fn -> Pipelines.get_pipeline!(pipeline.id) end
+    test "delete_pipeline/1 deletes the pipeline", %{user: user} do
+      pipeline = pipeline_fixture(user)
+      assert {:ok, %Pipeline{}} = Pipelines.delete_pipeline(pipeline, user)
+      assert_raise Ecto.NoResultsError, fn -> Pipelines.get_pipeline!(pipeline.id, user) end
     end
 
-    test "change_pipeline/1 returns a pipeline changeset" do
-      pipeline = pipeline_fixture()
-      assert %Ecto.Changeset{} = Pipelines.change_pipeline(pipeline)
+    test "delete_pipeline/1 deletes the pipeline for an admin user", %{user: user} do
+      admin_user = admin_fixture()
+      pipeline = pipeline_fixture(user)
+      assert {:ok, %Pipeline{}} = Pipelines.delete_pipeline(pipeline, admin_user)
+      assert_raise Ecto.NoResultsError, fn -> Pipelines.get_pipeline!(pipeline.id, user) end
+    end
+
+    test "change_pipeline/1 returns a pipeline changeset", %{user: user} do
+      pipeline = pipeline_fixture(user)
+      assert %Ecto.Changeset{} = Pipelines.change_pipeline(pipeline, user)
     end
   end
 end

test/memex_web/live/pipeline_live_test.exs

@@ -4,26 +4,36 @@ defmodule MemexWeb.PipelineLiveTest do
   import Phoenix.LiveViewTest
   import Memex.PipelinesFixtures
 
-  @create_attrs %{description: "some description", title: "some title", visibility: :public}
-  @update_attrs %{
-    description: "some updated description",
-    title: "some updated title",
-    visibility: :private
+  @create_attrs %{
+    "description" => "some description",
+    "tags_string" => "tag1",
+    "title" => "some title",
+    "visibility" => :public
+  }
+  @update_attrs %{
+    "description" => "some updated description",
+    "tags_string" => "tag1,tag2",
+    "title" => "some updated title",
+    "visibility" => :private
+  }
+  @invalid_attrs %{
+    "description" => nil,
+    "tags_string" => "",
+    "title" => nil,
+    "visibility" => nil
   }
-  @invalid_attrs %{description: nil, title: nil, visibility: nil}
 
-  defp create_pipeline(_) do
-    pipeline = pipeline_fixture()
-    %{pipeline: pipeline}
+  defp create_pipeline(%{user: user}) do
+    [pipeline: pipeline_fixture(user)]
   end
 
   describe "Index" do
-    setup [:create_pipeline]
+    setup [:register_and_log_in_user, :create_pipeline]
 
     test "lists all pipelines", %{conn: conn, pipeline: pipeline} do
       {:ok, _index_live, html} = live(conn, Routes.pipeline_index_path(conn, :index))
 
-      assert html =~ "listing pipelines"
+      assert html =~ "pipelines"
       assert html =~ pipeline.description
     end
 
@@ -45,15 +55,15 @@ defmodule MemexWeb.PipelineLiveTest do
         |> render_submit()
         |> follow_redirect(conn, Routes.pipeline_index_path(conn, :index))
 
-      assert html =~ "pipeline created successfully"
+      assert html =~ "#{@create_attrs |> Map.get("title")} created"
       assert html =~ "some description"
     end
 
     test "updates pipeline in listing", %{conn: conn, pipeline: pipeline} do
       {:ok, index_live, _html} = live(conn, Routes.pipeline_index_path(conn, :index))
 
-      assert index_live |> element("#pipeline-#{pipeline.id} a", "edit") |> render_click() =~
-               "edit pipeline"
+      assert index_live |> element("[data-qa=\"pipeline-edit-#{pipeline.id}\"]") |> render_click() =~
+               "edit"
 
       assert_patch(index_live, Routes.pipeline_index_path(conn, :edit, pipeline))
 
@@ -67,20 +77,23 @@ defmodule MemexWeb.PipelineLiveTest do
         |> render_submit()
         |> follow_redirect(conn, Routes.pipeline_index_path(conn, :index))
 
-      assert html =~ "pipeline updated successfully"
+      assert html =~ "#{@update_attrs |> Map.get("title")} saved"
       assert html =~ "some updated description"
     end
 
     test "deletes pipeline in listing", %{conn: conn, pipeline: pipeline} do
       {:ok, index_live, _html} = live(conn, Routes.pipeline_index_path(conn, :index))
 
-      assert index_live |> element("#pipeline-#{pipeline.id} a", "delete") |> render_click()
+      assert index_live
+             |> element("[data-qa=\"delete-pipeline-#{pipeline.id}\"]")
+             |> render_click()
+
       refute has_element?(index_live, "#pipeline-#{pipeline.id}")
     end
   end
 
   describe "show" do
-    setup [:create_pipeline]
+    setup [:register_and_log_in_user, :create_pipeline]
 
     test "displays pipeline", %{conn: conn, pipeline: pipeline} do
       {:ok, _show_live, html} = live(conn, Routes.pipeline_show_path(conn, :show, pipeline))
@@ -92,8 +105,7 @@ defmodule MemexWeb.PipelineLiveTest do
     test "updates pipeline within modal", %{conn: conn, pipeline: pipeline} do
       {:ok, show_live, _html} = live(conn, Routes.pipeline_show_path(conn, :show, pipeline))
 
-      assert show_live |> element("a", "edit") |> render_click() =~
-               "edit pipeline"
+      assert show_live |> element("a", "edit") |> render_click() =~ "edit"
 
       assert_patch(show_live, Routes.pipeline_show_path(conn, :edit, pipeline))
 
@@ -107,8 +119,20 @@ defmodule MemexWeb.PipelineLiveTest do
         |> render_submit()
         |> follow_redirect(conn, Routes.pipeline_show_path(conn, :show, pipeline))
 
-      assert html =~ "pipeline updated successfully"
+      assert html =~ "#{@update_attrs |> Map.get("title")} saved"
       assert html =~ "some updated description"
     end
+
+    test "deletes pipeline", %{conn: conn, pipeline: pipeline} do
+      {:ok, show_live, _html} = live(conn, Routes.pipeline_show_path(conn, :show, pipeline))
+
+      {:ok, index_live, _html} =
+        show_live
+        |> element("[data-qa=\"delete-pipeline-#{pipeline.id}\"]")
+        |> render_click()
+        |> follow_redirect(conn, Routes.pipeline_index_path(conn, :index))
+
+      refute has_element?(index_live, "#pipeline-#{pipeline.id}")
+    end
   end
 end

test/support/fixtures/pipelines_fixtures.ex

@@ -3,19 +3,23 @@ defmodule Memex.PipelinesFixtures do
   This module defines test helpers for creating
   entities via the `Memex.Pipelines` context.
   """
+  alias Memex.{Accounts.User, Pipelines, Pipelines.Pipeline}
 
   @doc """
   Generate a pipeline.
   """
-  def pipeline_fixture(attrs \\ %{}) do
+  @spec pipeline_fixture(User.t()) :: Pipeline.t()
+  @spec pipeline_fixture(attrs :: map(), User.t()) :: Pipeline.t()
+  def pipeline_fixture(attrs \\ %{}, user) do
     {:ok, pipeline} =
       attrs
       |> Enum.into(%{
         description: "some description",
+        tag: [],
         title: "some title",
-        visibility: :public
+        visibility: :private
       })
-      |> Memex.Pipelines.create_pipeline()
+      |> Pipelines.create_pipeline(user)
 
     pipeline
   end