improve tests

test/memex/accounts/invites_test.exs

@@ -11,11 +11,11 @@ defmodule Memex.InvitesTest do
   @moduletag :invites_test
 
   @valid_attrs %{
-    "name" => "some name"
+    name: "some name"
   }
   @invalid_attrs %{
-    "name" => nil,
-    "token" => nil
+    name: nil,
+    token: nil
   }
 
   describe "invites" do
@@ -57,7 +57,7 @@ defmodule Memex.InvitesTest do
 
       assert {:ok, _user} =
                Accounts.register_user(
-                 %{"email" => unique_user_email(), "password" => valid_user_password()},
+                 %{email: unique_user_email(), password: valid_user_password()},
                  token
                )
 
@@ -65,7 +65,7 @@ defmodule Memex.InvitesTest do
 
       assert {:ok, _user} =
                Accounts.register_user(
-                 %{"email" => unique_user_email(), "password" => valid_user_password()},
+                 %{email: unique_user_email(), password: valid_user_password()},
                  token
                )
 
@@ -81,13 +81,13 @@ defmodule Memex.InvitesTest do
 
       assert {:ok, _user} =
                Accounts.register_user(
-                 %{"email" => unique_user_email(), "password" => valid_user_password()},
+                 %{email: unique_user_email(), password: valid_user_password()},
                  token
                )
 
       assert {:ok, _user} =
                Accounts.register_user(
-                 %{"email" => unique_user_email(), "password" => valid_user_password()},
+                 %{email: unique_user_email(), password: valid_user_password()},
                  another_token
                )
 
@@ -97,7 +97,7 @@ defmodule Memex.InvitesTest do
 
       assert {:ok, _user} =
                Accounts.register_user(
-                 %{"email" => unique_user_email(), "password" => valid_user_password()},
+                 %{email: unique_user_email(), password: valid_user_password()},
                  token
                )
 
@@ -138,10 +138,7 @@ defmodule Memex.InvitesTest do
 
     test "create_invite/1 with valid data creates an unlimited invite",
          %{current_user: current_user} do
-      assert {:ok, %Invite{} = invite} =
-               Invites.create_invite(current_user, %{
-                 "name" => "some name"
-               })
+      assert {:ok, %Invite{} = invite} = Invites.create_invite(current_user, %{name: "some name"})
 
       assert invite.name == "some name"
     end
@@ -149,10 +146,7 @@ defmodule Memex.InvitesTest do
     test "create_invite/1 with valid data creates a limited invite",
          %{current_user: current_user} do
       assert {:ok, %Invite{} = invite} =
-               Invites.create_invite(current_user, %{
-                 "name" => "some name",
-                 "uses_left" => 10
-               })
+               Invites.create_invite(current_user, %{name: "some name", uses_left: 10})
 
       assert invite.name == "some name"
       assert invite.uses_left == 10
@@ -168,7 +162,7 @@ defmodule Memex.InvitesTest do
       assert {:ok, %Invite{} = new_invite} =
                Invites.update_invite(
                  invite,
-                 %{"name" => "some updated name", "uses_left" => 5},
+                 %{name: "some updated name", uses_left: 5},
                  current_user
                )
 
@@ -183,7 +177,7 @@ defmodule Memex.InvitesTest do
       assert {:ok, %Invite{} = new_invite} =
                Invites.update_invite(
                  invite,
-                 %{"name" => "some updated name", "uses_left" => nil},
+                 %{name: "some updated name", uses_left: nil},
                  current_user
                )
 

test/memex/contexts_test.exs

@@ -1,6 +1,6 @@
 defmodule Memex.ContextsTest do
   use Memex.DataCase
-  import Memex.ContextsFixtures
+  import Memex.Fixtures
   alias Memex.{Contexts, Contexts.Context}
   @moduletag :contexts_test
   @invalid_attrs %{content: nil, tag: nil, slug: nil, visibility: nil}
@@ -152,10 +152,10 @@ defmodule Memex.ContextsTest do
 
     test "create_context/1 with valid data creates a context", %{user: user} do
       valid_attrs = %{
-        "content" => "some content",
-        "tags_string" => "tag1,tag2",
-        "slug" => "some-slug",
-        "visibility" => :public
+        content: "some content",
+        tags_string: "tag1,tag2",
+        slug: "some-slug",
+        visibility: :public
       }
 
       assert {:ok, %Context{} = context} = Contexts.create_context(valid_attrs, user)
@@ -173,10 +173,10 @@ defmodule Memex.ContextsTest do
       context = context_fixture(user)
 
       update_attrs = %{
-        "content" => "some updated content",
-        "tags_string" => "tag1,tag2",
-        "slug" => "some-updated-slug",
-        "visibility" => :private
+        content: "some updated content",
+        tags_string: "tag1,tag2",
+        slug: "some-updated-slug",
+        visibility: :private
       }
 
       assert {:ok, %Context{} = context} = Contexts.update_context(context, update_attrs, user)

test/memex/notes_test.exs

@@ -1,6 +1,6 @@
 defmodule Memex.NotesTest do
   use Memex.DataCase
-  import Memex.NotesFixtures
+  import Memex.Fixtures
   alias Memex.{Notes, Notes.Note}
   @moduletag :notes_test
   @invalid_attrs %{content: nil, tag: nil, slug: nil, visibility: nil}
@@ -154,10 +154,10 @@ defmodule Memex.NotesTest do
 
     test "create_note/1 with valid data creates a note", %{user: user} do
       valid_attrs = %{
-        "content" => "some content",
-        "tags_string" => "tag1,tag2",
-        "slug" => "some-slug",
-        "visibility" => :public
+        content: "some content",
+        tags_string: "tag1,tag2",
+        slug: "some-slug",
+        visibility: :public
       }
 
       assert {:ok, %Note{} = note} = Notes.create_note(valid_attrs, user)
@@ -175,10 +175,10 @@ defmodule Memex.NotesTest do
       note = note_fixture(user)
 
       update_attrs = %{
-        "content" => "some updated content",
-        "tags_string" => "tag1,tag2",
-        "slug" => "some-updated-slug",
-        "visibility" => :private
+        content: "some updated content",
+        tags_string: "tag1,tag2",
+        slug: "some-updated-slug",
+        visibility: :private
       }
 
       assert {:ok, %Note{} = note} = Notes.update_note(note, update_attrs, user)

test/memex/pipelines_test.exs

@@ -1,6 +1,6 @@
 defmodule Memex.PipelinesTest do
   use Memex.DataCase
-  import Memex.PipelinesFixtures
+  import Memex.Fixtures
   alias Memex.{Pipelines, Pipelines.Pipeline}
   @moduletag :pipelines_test
   @invalid_attrs %{description: nil, tag: nil, slug: nil, visibility: nil}
@@ -154,10 +154,10 @@ defmodule Memex.PipelinesTest do
 
     test "create_pipeline/1 with valid data creates a pipeline", %{user: user} do
       valid_attrs = %{
-        "description" => "some description",
-        "tags_string" => "tag1,tag2",
-        "slug" => "some-slug",
-        "visibility" => :public
+        description: "some description",
+        tags_string: "tag1,tag2",
+        slug: "some-slug",
+        visibility: :public
       }
 
       assert {:ok, %Pipeline{} = pipeline} = Pipelines.create_pipeline(valid_attrs, user)
@@ -175,10 +175,10 @@ defmodule Memex.PipelinesTest do
       pipeline = pipeline_fixture(user)
 
       update_attrs = %{
-        "description" => "some updated description",
-        "tags_string" => "tag1,tag2",
-        "slug" => "some-updated-slug",
-        "visibility" => :private
+        description: "some updated description",
+        tags_string: "tag1,tag2",
+        slug: "some-updated-slug",
+        visibility: :private
       }
 
       assert {:ok, %Pipeline{} = pipeline} =

test/memex/steps_test.exs

@@ -1,6 +1,6 @@
 defmodule Memex.StepsTest do
   use Memex.DataCase
-  import Memex.{PipelinesFixtures, StepsFixtures}
+  import Memex.Fixtures
   alias Memex.Pipelines.{Steps, Steps.Step}
   @moduletag :steps_test
   @invalid_attrs %{content: nil, title: nil}
@@ -37,8 +37,8 @@ defmodule Memex.StepsTest do
 
     test "create_step/4 with valid data creates a step", %{pipeline: pipeline, user: user} do
       valid_attrs = %{
-        "content" => "some content",
-        "title" => "some title"
+        content: "some content",
+        title: "some title"
       }
 
       assert {:ok, %Step{} = step} = Steps.create_step(valid_attrs, 0, pipeline, user)
@@ -55,8 +55,8 @@ defmodule Memex.StepsTest do
       step = step_fixture(0, pipeline, user)
 
       update_attrs = %{
-        "content" => "some updated content",
-        "title" => "some updated title"
+        content: "some updated content",
+        title: "some updated title"
       }
 
       assert {:ok, %Step{} = step} = Steps.update_step(step, update_attrs, user)