better code style

This commit is contained in:
2025-02-15 04:04:10 +00:00
parent 2a8a1d11b8
commit 3e686fa199
32 changed files with 225 additions and 186 deletions

View File

@ -73,7 +73,7 @@ defmodule MemexWeb.PipelineLive.FormComponent do
|> push_navigate(to: return_to)
{:error, %Changeset{} = changeset} ->
assign(socket, changeset: changeset)
assign(socket, :changeset, changeset)
end
{:noreply, socket}

View File

@ -4,11 +4,11 @@ defmodule MemexWeb.PipelineLive.Index do
@impl true
def mount(%{"search" => search}, _session, socket) do
{:ok, socket |> assign(search: search) |> display_pipelines()}
{:ok, socket |> assign(:search, search) |> display_pipelines()}
end
def mount(_params, _session, socket) do
{:ok, socket |> assign(search: nil) |> display_pipelines()}
{:ok, socket |> assign(:search, nil) |> display_pipelines()}
end
@impl true
@ -20,29 +20,37 @@ defmodule MemexWeb.PipelineLive.Index do
%{slug: slug} = pipeline = Pipelines.get_pipeline_by_slug(slug, current_user)
socket
|> assign(page_title: gettext("edit %{slug}", slug: slug))
|> assign(pipeline: pipeline)
|> assign(
page_title: gettext("edit %{slug}", slug: slug),
pipeline: pipeline
)
end
defp apply_action(%{assigns: %{current_user: %{id: current_user_id}}} = socket, :new, _params) do
socket
|> assign(page_title: gettext("new pipeline"))
|> assign(pipeline: %Pipeline{visibility: :private, user_id: current_user_id})
|> assign(
page_title: gettext("new pipeline"),
pipeline: %Pipeline{visibility: :private, user_id: current_user_id}
)
end
defp apply_action(socket, :index, _params) do
socket
|> assign(page_title: gettext("pipelines"))
|> assign(search: nil)
|> assign(pipeline: nil)
|> assign(
page_title: gettext("pipelines"),
pipeline: nil,
search: nil
)
|> display_pipelines()
end
defp apply_action(socket, :search, %{"search" => search}) do
socket
|> assign(page_title: gettext("pipelines"))
|> assign(search: search)
|> assign(pipeline: nil)
|> assign(
page_title: gettext("pipelines"),
pipeline: nil,
search: search
)
|> display_pipelines()
end
@ -53,7 +61,7 @@ defmodule MemexWeb.PipelineLive.Index do
socket =
socket
|> assign(pipelines: Pipelines.list_pipelines(current_user))
|> assign(:pipelines, Pipelines.list_pipelines(current_user))
|> put_flash(:info, gettext("%{slug} deleted", slug: slug))
{:noreply, socket}
@ -67,12 +75,11 @@ defmodule MemexWeb.PipelineLive.Index do
{:noreply, socket |> push_patch(to: ~p"/pipelines/#{search_term}")}
end
defp display_pipelines(%{assigns: %{current_user: current_user, search: search}} = socket)
when not (current_user |> is_nil()) do
socket |> assign(pipelines: Pipelines.list_pipelines(search, current_user))
defp display_pipelines(%{assigns: %{current_user: %{} = current_user, search: search}} = socket) do
socket |> assign(:pipelines, Pipelines.list_pipelines(search, current_user))
end
defp display_pipelines(%{assigns: %{search: search}} = socket) do
socket |> assign(pipelines: Pipelines.list_public_pipelines(search))
socket |> assign(:pipelines, Pipelines.list_public_pipelines(search))
end
end

View File

@ -21,9 +21,11 @@ defmodule MemexWeb.PipelineLive.Show do
socket =
socket
|> assign(:page_title, page_title(live_action, pipeline))
|> assign(:pipeline, pipeline)
|> assign(:steps, pipeline |> Steps.list_steps(current_user))
|> assign(
page_title: page_title(live_action, pipeline),
pipeline: pipeline,
steps: pipeline |> Steps.list_steps(current_user)
)
|> apply_action(live_action, params)
{:noreply, socket}
@ -47,8 +49,8 @@ defmodule MemexWeb.PipelineLive.Show do
socket
|> assign(
step: %Step{
position: steps |> Enum.count(),
pipeline_id: pipeline_id,
position: steps |> Enum.count(),
user_id: current_user_id
}
)
@ -59,7 +61,7 @@ defmodule MemexWeb.PipelineLive.Show do
:edit_step,
%{"step_id" => step_id}
) do
socket |> assign(step: step_id |> Steps.get_step!(current_user))
socket |> assign(:step, step_id |> Steps.get_step!(current_user))
end
@impl true