5.3 KiB
Contribution Guide
Thanks for contributing to Cannery! Please read over the style tips to help make contributing to Cannery (hopefully) as great of an experience as you found it!
Translations needed!
If you're multilingual, this project can use your translations! Visit weblate for more information.
Style Tips
- In order to cut down on code verbosity and readability, please try to use
inline
do:blocks for short functions and make your aliases as short as possible without introducing ambiguity.- I.e. since there's only one
Changesetin the app, please aliasChangeset.t(Type.t())instead of usingEcto.Changeset.t(Long.Type.t())
- I.e. since there's only one
- Use pipelines when possible. If a function only calls a single method, a pipeline isn't strictly necessary but still encouraged for future modification.
- Please add typespecs to your functions! Even your private functions may be
used by others later down the line, and typespecs will be able to help
document your code just a little bit better, and improve the debugging
process.
- Typespec arguments can be named like
@spec function(arg_name :: type()) :: return_type(). Please use these for generic types, such asmap()when the input data isn't immediately obvious. - Please define all typespecs for a function together in one place, instead of each function.
- Typespec arguments can be named like
- When making new models, please take inspiration from the existing models in regards to layout of sections, typespec design, and formatting.
- With Elixir convention, for methods that raise on error please name them like
function_that_raises!(), and functions that return a boolean likefunction_that_returns_boolean?(). For other methods, it's encouraged to use status tuples for other functions like{:ok, result}or{:error, reason_or_changeset}instead of just returningresultornilfor easy pattern matching. - When adding text, please use
gettextmacros to enable things to be translated in the future. After addinggettextmacros, runmix formatin order to add your new text strings to the files inpriv/gettext. - Before submitting a PR, please make sure all tests are passing using
mix test.
And as always, thank you!
Technical Information
- Created using the Phoenix Framework
- User Registration/Sign in via
phx_gen_auth. Dockerfileand exampledocker-compose.yml- Automatic migrations in
MIX_ENV=prodor Docker image - JS linting with standard.js, HEEx linting with heex_formatter
Instructions
- Clone the repo
- Install the elixir and erlang binaries. I recommend using asdf version
manager,
which will use the
.tool-versionsfile to install the correct versions of Erlang, Elixir and npm for this project! - Run
mix deps.getandmix compileto fetch all dependencies - Run
mix setupto initialize your database. - Run
mix phx.serverto start the development server.
Configuration
For development, I recommend setting environment variables with direnv.
By default, Cannery will always bind to all external IPv4 and IPv6 addresses in
dev and prod mode, respectively. If you would like to use different values,
they will need to be overridden in config/dev.exs and config/runtime.exs for
dev and prod modes, respectively.
MIX_ENV=dev
In dev mode, Cannery will listen for these environment variables at runtime.
HOST: External url to generate links with. Set this especially if you're behind a reverse proxy. Defaults tolocalhost. External URLs will always be generated withhttps://and port443.PORT: Internal port to bind to. Defaults to4000.DATABASE_URL: Controls the database url to connect to. Defaults toecto://postgres:postgres@localhost/cannery_dev.ECTO_IPV6: Controls if Ecto should use IPv6 to connect to PostgreSQL. Defaults tofalse.POOL_SIZE: Controls the pool size to use with PostgreSQL. Defaults to10.REGISTRATION: Controls if user sign-up should be invite only or set to public. Set topublicto enable public registration. Defaults toinvite.LOCALE: Sets a custom locale. Defaults toen_US.
MIX_ENV=test
In test mode (or in the Docker container), Cannery will listen for the same environment variables as dev mode, but also include the following at runtime:
TEST_DATABASE_URL: REPLACESDATABASE_URL. Controls the database url to connect to. Defaults toecto://postgres:postgres@localhost/cannery_test.MIX_TEST_PARTITION: Only used ifTEST_DATABASE_URLis not specified. Appended to the default database url if you would like to partition your test databases. Defaults to not set.
MIX_ENV=prod
In prod mode (or in the Docker container), Cannery will listen for the same environment variables as dev mode, but also include the following at runtime:
SECRET_KEY_BASE: Secret key base used to sign cookies. Must be generated withdocker run -it shibaobun/cannery mix phx.gen.secretand set for server to start.