From 994aa96a20fd52778f1b62ce807c36fb9de51226 Mon Sep 17 00:00:00 2001 From: shibao Date: Fri, 14 Apr 2023 20:32:47 -0400 Subject: [PATCH] simply assigns --- lib/memex_web/components/notes_table_component.ex | 8 ++------ .../components/pipelines_table_component.ex | 12 +++--------- 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/lib/memex_web/components/notes_table_component.ex b/lib/memex_web/components/notes_table_component.ex index 63be572..78ba7c7 100644 --- a/lib/memex_web/components/notes_table_component.ex +++ b/lib/memex_web/components/notes_table_component.ex @@ -88,9 +88,7 @@ defmodule MemexWeb.Components.NotesTableComponent do @spec get_value_for_key(atom(), Note.t(), additional_data :: map()) :: any() | {any(), Rendered.t()} - defp get_value_for_key(:slug, %{slug: slug}, _additional_data) do - assigns = %{slug: slug} - + defp get_value_for_key(:slug, %{slug: slug} = assigns, _additional_data) do slug_block = ~H""" <.link navigate={~p"/note/#{@slug}"} class="link"> <%= @slug %> @@ -100,9 +98,7 @@ defmodule MemexWeb.Components.NotesTableComponent do {slug, slug_block} end - defp get_value_for_key(:tags, %{tags: tags}, _additional_data) do - assigns = %{tags: tags} - + defp get_value_for_key(:tags, assigns, _additional_data) do ~H"""
<.link :for={tag <- @tags} patch={~p"/notes/#{tag}"} class="link"> diff --git a/lib/memex_web/components/pipelines_table_component.ex b/lib/memex_web/components/pipelines_table_component.ex index 1c50fe7..e35adcf 100644 --- a/lib/memex_web/components/pipelines_table_component.ex +++ b/lib/memex_web/components/pipelines_table_component.ex @@ -89,9 +89,7 @@ defmodule MemexWeb.Components.PipelinesTableComponent do @spec get_value_for_key(atom(), Pipeline.t(), additional_data :: map()) :: any() | {any(), Rendered.t()} - defp get_value_for_key(:slug, %{slug: slug}, _additional_data) do - assigns = %{slug: slug} - + defp get_value_for_key(:slug, %{slug: slug} = assigns, _additional_data) do slug_block = ~H""" <.link navigate={~p"/pipeline/#{@slug}"} class="link"> <%= @slug %> @@ -101,9 +99,7 @@ defmodule MemexWeb.Components.PipelinesTableComponent do {slug, slug_block} end - defp get_value_for_key(:description, %{description: description}, _additional_data) do - assigns = %{description: description} - + defp get_value_for_key(:description, %{description: description} = assigns, _additional_data) do description_block = ~H"""
<%= @description %> @@ -113,9 +109,7 @@ defmodule MemexWeb.Components.PipelinesTableComponent do {description, description_block} end - defp get_value_for_key(:tags, %{tags: tags}, _additional_data) do - assigns = %{tags: tags} - + defp get_value_for_key(:tags, assigns, _additional_data) do ~H"""
<.link :for={tag <- @tags} patch={~p"/pipelines/#{tag}"} class="link">