Shotgun Ammunition type field updates #40

New Issue

aaron_nad · 2023-04-10T16:31:05-04:00

aaron_nad commented

2023-04-10 16:31:05 -04:00

Hi, whilst looking over the new schema - which is amazing that its supported!
I might have missed asking for the muzzle velocity to be added initally

		lib/cannery/ammo/type.ex
		Line 81 in 81f21a02c4
	
				    field :muzzle_velocity, :integer

Can the Bullet Type field be ommitted - this is not required on shotgun cartridges (we have the shot type to cover the use of the cartirdge for geese, pidgeons, clay and foxes etc)

As always everything else is amazing as always and I really appreciate the time spent adding new features!

Hi, whilst looking over the new schema - which is amazing that its supported! I might have missed asking for the muzzle velocity to be added initally https://gitea.bubbletea.dev/shibao/cannery/src/commit/81f21a02c4dbf632b3cca576ea3a0dcbad835f26/lib/cannery/ammo/type.ex#L81 Can the Bullet Type field be ommitted - this is not required on shotgun cartridges (we have the shot type to cover the use of the cartirdge for geese, pidgeons, clay and foxes etc) As always everything else is amazing as always and I really appreciate the time spent adding new features!

shibao commented

2023-04-10 16:57:15 -04:00

based on recommendations, i've instead added DRAM equivalent as the replacement for a shotgun slug's muzzle velocity, since that seems to be the most widely used equivalent for measuring muzzle velocity with shotgun ammunition, and is printed on shotgun ammunition boxes at least here in the united states. You're free to simply enter muzzle velocity in the dram equivalent field in your instance, and I will add a note about choosing between DRAM equivalent or muzzle velocity units into #13.

For the bullet type showing for shotgun types, I think I may need to fix that in this ticket😄

based on recommendations, i've instead added DRAM equivalent as the replacement for a shotgun slug's muzzle velocity, since that seems to be the most widely used equivalent for measuring muzzle velocity with shotgun ammunition, and is printed on shotgun ammunition boxes at least here in the united states. You're free to simply enter muzzle velocity in the dram equivalent field in your instance, and I will add a note about choosing between DRAM equivalent or muzzle velocity units into #13. For the bullet type showing for shotgun types, I think I may need to fix that in this ticket😄

aaron_nad commented

2023-04-10 17:43:24 -04:00

Thanks for the speedy reply! Yep, no problemo, i'll do that. I was just reading up on DRAM conversions - its not widely used here in the UK and we still stick with the FPS for everything involved.

Im happy with this thank you

Thanks for the speedy reply! Yep, no problemo, i'll do that. I was just reading up on DRAM conversions - its not widely used here in the UK and we still stick with the FPS for everything involved. Im happy with this thank you

shibao commented

2023-04-10 20:05:00 -04:00

I'm curious, do they not print DRAM on shotgun ammo in the UK?