Translated using Weblate (Spanish)

Currently translated at 73.9% (34 of 46 strings)

Translation: cannery/prompts
Translate-URL: https://weblate.bubbletea.dev/projects/cannery/prompts/es/

.drone.yml

@@ -13,36 +13,28 @@ steps:
     mount:
       - _build
       - deps
-      - .npm
-      - .mix
+      - assets/node_modules/
 
 - name: test
-  image: elixir:1.14.1-alpine
+  image: elixir:1.13.4-alpine
   environment:
     TEST_DATABASE_URL: ecto://postgres:postgres@database/cannery_test
     HOST: testing.example.tld
-    MIX_HOME: /drone/src/.mix
-    MIX_ARCHIVES: /drone/src/.mix/archives
-    MIX_ENV: test
   commands:
-  - apk add --no-cache build-base npm git
-  - mix local.rebar --force --if-missing
-  - mix local.hex --force --if-missing
+  - apk add --no-cache build-base npm git python3
+  - mix local.rebar --force
+  - mix local.hex --force
   - mix deps.get
-  - npm set cache .npm
-  - npm --prefix ./assets ci --no-audit --prefer-offline
+  - mix deps.compile
+  - npm --prefix ./assets ci --progress=false --no-audit --loglevel=error
   - npm run --prefix ./assets deploy
   - mix do phx.digest, gettext.extract
-  - mix test.all
+  - mix test
 
 - name: build and publish stable
-  image: thegeeklab/drone-docker-buildx
-  privileged: true
+  image: plugins/docker
   settings:
     repo: shibaobun/cannery
-    purge: true
-    compress: true
-    platforms: linux/amd64,linux/arm/v7
     username:
       from_secret: docker_username
     password:
@@ -53,13 +45,9 @@ steps:
     - stable
 
 - name: build and publish tagged version
-  image: thegeeklab/drone-docker-buildx
-  privileged: true
+  image: plugins/docker
   settings:
     repo: shibaobun/cannery
-    purge: true
-    compress: true
-    platforms: linux/amd64,linux/arm/v7
     username:
       from_secret: docker_username
     password:
@@ -80,8 +68,7 @@ steps:
     mount:
       - _build
       - deps
-      - .npm
-      - .mix
+      - assets/node_modules/
 
 services:
 - name: database

.gitignore

@@ -25,7 +25,7 @@ cannery-*.tar
 # If NPM crashes, it generates a log, let's ignore it too.
 npm-debug.log
 
-# The directory NPM downloads your dependencies sources to.
+# Ignore assets that are produced by build tools.
 /assets/node_modules/
 
 # Since we are building assets from assets/,

.tool-versions

@@ -1,3 +1,3 @@
-elixir 1.14.1-otp-25
-erlang 25.1.2
-nodejs 18.9.1
+elixir 1.13.4-otp-24
+erlang 24.2
+nodejs 16.13.2

CHANGELOG.md

@@ -1,116 +1,3 @@
-# v0.9.0
-- Add length limits to all string fields
-- Add selectable ammo types
-- Improve onboarding experience slightly
-- Remove show used view from a container since it doesn't really make that much
-  sense
-
-# v0.8.6
-- Fix duplicate entries showing up
-- Show ammo packs under a type in a table by default
-- Only show historical ammo type information when displaying "Show used" in table
-- Only show historical ammo pack information when displaying "Show used" in table
-- Fix some values not being sorted in tables properly
-- Code quality improvements
-- Show link to ammo pack in ammo pack table while viewing ammo type
-
-# v0.8.5
-- Add link in readme to github mirror
-- Fix tables unable to sort on empty dates
-- Only show historical ammo type information when displaying "Show used"
-- Fix even more accessibility issues
-
-# v0.8.4
-- Improve accessibility
-- Code quality improvements
-- Fix dead link of example bullet abbreviations
-- Fix inaccurate error message when updating shot records
-- Fix tables not sorting dates correctly
-- Fix dates displaying incorrectly
-- Fix container table not displaying all fields
-- Fix textareas resizing when typing in them
-
-# v0.8.3
-- Improve some styles
-- Improve server log
-- Various minor improvements
-
-# v0.8.2
-- Fix bug with public registration
-- Improve templates
-- Improve invites, record usage
-- Fix padding on more pages when using chrome
-- Add oban metrics to server log and live dashboard
-
-# v0.8.1
-- Update dependencies
-- Show topbar on form submit/page refresh
-- Make loading/reconnection less intrusive
-- Add QR code for invite link
-
-# v0.8.0
-- Add search to catalog, ammo, container, tag and range index pages
-- Tweak urls for catalog, ammo, containers, tags and shot records
-- Fix bug with shot group chart not drawing lines between days correctly
-- Improve cards across app (make them line up with each other)
-- Update translations and add spanish!!! (thank you Brea and Hannah!)
-
-# v0.7.2
-- Code improvements
-
-# v0.7.1
-- Fix table component alignment and styling
-- Fix toggle button styling
-- Miscellanous code improvements
-- Improve container index table
-- Fix bug with ammo not updating after deleting shot group
-- Replace ammo "added on" with "purchased on"
-- Miscellaneous wording improvements
-- Update translations
-
-# v0.7.0
-- Add shading to table component
-- Fix chart to sum by day
-- Fix whitespace when copying invite url
-- Make ammo type show page also display ammo groups as table
-- Make container show page also display ammo groups as table
-- Display CPR for ammo packs
-- Add original count for ammo packs
-- Add ammo pack CPR and original count to json export
-
-# v0.6.0
-- Update translations
-- Display used-up date on used-up ammo
-- Make ammo index page a bit more compact
-- Make ammo index page filter used-up ammo
-- Make ammo catalog page include ammo count
-- Make ammo type show page a bit more compact
-- Make ammo type show page include container names for each ammo
-- Make ammo type show page filter used-up ammo
-- Make container index page optionally display a table
-- Make container show page a bit more compact
-- Make container show page filter used-up ammo
-- Forgot to add the logo as the favicon whoops
-- Add graph to range page
-- Add JSON export of data
-- Add ammo cloning
-- Add ammo type cloning
-- Add container cloning
-- Fix bug with moving ammo packs between containers
-- Add button to set rounds left to 0 when creating a shot group
-- Update project dependencies
-
-# v0.5.4
-- Rename "Ammo" tab to "Catalog", and "Manage" tab is now "Ammo"
-- Ammo groups are now just referred to as Ammo or "Packs"
-- URL paths now reflect new names
-- Add pack and round count to container information
-- Add cute logo >:3 Thank you [kalli](https://twitter.com/t0kkuro)!
-- Add note about deleting an ammo type deleting all ammo of that type as well
-- Prompt to create first ammo type before trying to create first ammo
-- Add note about creating unlimited invites
-- Update screenshot lol
-
 # v0.5.3
 - Update French translation: Thank you [duponin](https://udongein.xyz/users/duponin)!
 - Update German translation: Thank you [Kaia](https://shitposter.club/users/kaia)!

CONTRIBUTING.md

@@ -17,8 +17,8 @@ If you're multilingual, this project can use your translations! Visit
   functions as short as possible while keeping variable names descriptive! For
   instance, use inline `do:` blocks for short functions and make your aliases as
   short as possible without introducing ambiguity.
-  - I.e. since there's only one `AmmoGroup` in the app, please alias
-    `AmmoGroup.t()` instead of using `Cannery.Ammo.AmmoGroup.t()`
+  - I.e. since there's only one `Changeset` in the app, please alias
+    `Changeset.t(Type.t())` instead of using `Ecto.Changeset.t(Long.Type.t())`
 - Use pipelines when possible. If only calling a single method, a pipeline isn't
   strictly necessary but still encouraged for future modification.
 - Please add typespecs to your functions! Even your private functions may be
@@ -63,8 +63,7 @@ And as always, thank you!
   [`phx_gen_auth`](https://hexdocs.pm/phx_gen_auth/).
 - `Dockerfile` and example `docker-compose.yml`
 - Automatic migrations in `MIX_ENV=prod` or Docker image
-- JS linting with [standard.js](https://standardjs.com), HEEx linting with
-  [heex_formatter](https://github.com/feliperenan/heex_formatter)
+- JS linting with [standard.js](https://standardjs.com)
 
 ## Docs
 
@@ -110,7 +109,7 @@ In `dev` mode, Cannery will listen for these environment variables at runtime.
 - `POOL_SIZE`: Controls the pool size to use with PostgreSQL. Defaults to `10`.
 - `REGISTRATION`: Controls if user sign-up should be invite only or set to public. Set to `public` to enable public registration. Defaults to `invite`.
 - `LOCALE`: Sets a custom default locale. Defaults to `en_US`.
-  - Available options: `en_US`, `de`, `fr`, and `es`
+  - Available options: `en_US`, `de`, and `fr`
 
 ## `MIX_ENV=test`
 
@@ -144,5 +143,3 @@ Thank you so much for your contributions!
 - shibao (https://misskey.bubbletea.dev/@shibao)
 - kaia (https://shitposter.club/users/kaia)
 - duponin (https://udongein.xyz/users/duponin)
-- kalli (https://twitter.com/t0kkuro)
-- brea (https://refusal.biz/users/tarperfume)

Dockerfile

@@ -1,4 +1,4 @@
-FROM elixir:1.14.1-alpine AS build
+FROM elixir:1.13.4-alpine AS build
 
 # install build dependencies
 RUN apk add --no-cache build-base npm git python3
@@ -37,7 +37,7 @@ RUN mix do compile, release
 FROM alpine:latest AS app
 
 RUN apk upgrade --no-cache && \
-    apk add --no-cache bash openssl libssl1.1 libcrypto1.1 libgcc libstdc++ ncurses-libs
+    apk add --no-cache bash openssl libgcc libstdc++ ncurses-libs
 
 WORKDIR /app
 

README.md

@@ -1,6 +1,6 @@
 # Cannery
 
-![old screenshot](https://gitea.bubbletea.dev/shibao/cannery/raw/branch/stable/home.png)
+![screenshot](https://gitea.bubbletea.dev/shibao/cannery/raw/branch/stable/home.png)
 
 The self-hosted firearm tracker website.
 
@@ -64,7 +64,7 @@ You can use the following environment variables to configure Cannery in
 - `REGISTRATION`: Controls if user sign-up should be invite only or set to
   public. Set to `public` to enable public registration. Defaults to `invite`.
 - `LOCALE`: Sets a custom default locale. Defaults to `en_US`
-  - Available options: `en_US`, `de`, `fr` and `es`
+  - Available options: `en_US`, `de`, and `fr`
 - `SMTP_HOST`: The url for your SMTP email provider. Must be set
 - `SMTP_PORT`: The port for your SMTP relay. Defaults to `587`.
 - `SMTP_USERNAME`: The username for your SMTP relay. Must be set!
@@ -92,15 +92,6 @@ Cannery is licensed under AGPLv3 or later. A copy of the latest version of the
 license can be found at
 [LICENSE.md](https://gitea.bubbletea.dev/shibao/cannery/src/branch/stable/LICENSE.md).
 
-# Links
-
-- [Gitea](https://gitea.bubbletea.dev/shibao/cannery): Main repo, feature
-  requests and bug reports
-- [Github](https://github.com/shibaobun/cannery): Source code mirror, please
-  don't open pull requests to this repository
-- [Weblate](https://weblate.bubbletea.dev/engage/cannery): Contribute to
-  translations!
-
 ---
 
 [![Build

assets/css/app.scss

@@ -25,13 +25,12 @@ $fa-font-path: "@fortawesome/fontawesome-free/webfonts";
   100% { scale: 1.0; opacity: 1; }
 }
 
-// disconnect toast
-.phx-connected > #disconnect {
+.phx-connected > #disconnect, #loading {
   opacity: 0 !important;
   pointer-events: none;
 }
 
-.phx-error > #disconnect {
+.phx-loading:not(.phx-error) > #loading, .phx-error > #disconnect {
   opacity: 0.95 !important;
 }
 

assets/css/components.scss

@@ -25,6 +25,7 @@
   }
 
   .btn {
+    @apply inline-block break-words min-w-4;
     @apply focus:outline-none px-4 py-2 rounded-lg;
     @apply shadow-sm focus:shadow-lg;
     @apply transition-all duration-300 ease-in-out;
@@ -51,6 +52,7 @@
   }
 
   .link {
+    @apply inline-block break-all min-w-4;
     @apply hover:underline;
     @apply transition-colors duration-500 ease-in-out;
   }

assets/js/app.js

@@ -24,24 +24,29 @@ import 'phoenix_html'
 // Establish Phoenix Socket and LiveView configuration.
 import { Socket } from 'phoenix'
 import { LiveSocket } from 'phoenix_live_view'
-import topbar from 'topbar'
+import topbar from '../vendor/topbar'
 import MaintainAttrs from './maintain_attrs'
-import ShotLogChart from './shot_log_chart'
-import Date from './date'
-import DateTime from './datetime'
+import Alpine from 'alpinejs'
 
 const csrfToken = document.querySelector("meta[name='csrf-token']").getAttribute('content')
 const liveSocket = new LiveSocket('/live', Socket, {
+  dom: {
+    onBeforeElUpdated (from, to) {
+      if (from._x_dataStack) { window.Alpine.clone(from, to) }
+    }
+  },
   params: { _csrf_token: csrfToken },
-  hooks: { Date, DateTime, MaintainAttrs, ShotLogChart }
+  hooks: { MaintainAttrs }
 })
 
+// alpine.js
+window.Alpine = Alpine
+Alpine.start()
+
 // Show progress bar on live navigation and form submits
 topbar.config({ barColors: { 0: '#29d' }, shadowColor: 'rgba(0, 0, 0, .3)' })
 window.addEventListener('phx:page-loading-start', info => topbar.show())
 window.addEventListener('phx:page-loading-stop', info => topbar.hide())
-window.addEventListener('submit', info => topbar.show())
-window.addEventListener('beforeunload', info => topbar.show())
 
 // connect if there are any LiveViews on the page
 liveSocket.connect()
@@ -61,8 +66,3 @@ window.addEventListener('cannery:clipcopy', (event) => {
     window.alert('Sorry, your browser does not support clipboard copy.')
   }
 })
-
-// Set input value to 0
-window.addEventListener('cannery:set-zero', (event) => {
-  event.target.value = 0
-})

assets/js/date.js

@@ -1,11 +0,0 @@
-export default {
-  displayDate (el) {
-    const date =
-      Intl.DateTimeFormat([], { timeZone: 'Etc/UTC', dateStyle: 'short' })
-        .format(new Date(el.dateTime))
-
-    el.innerText = date
-  },
-  mounted () { this.displayDate(this.el) },
-  updated () { this.displayDate(this.el) }
-}

assets/js/datetime.js

@@ -1,11 +0,0 @@
-export default {
-  displayDateTime (el) {
-    const date =
-      Intl.DateTimeFormat([], { dateStyle: 'short', timeStyle: 'long' })
-        .format(new Date(el.dateTime))
-
-    el.innerText = date
-  },
-  mounted () { this.displayDateTime(this.el) },
-  updated () { this.displayDateTime(this.el) }
-}

assets/js/shot_log_chart.js

@@ -1,106 +0,0 @@
-import { Chart, Title, Tooltip, Legend, LineController, LineElement, PointElement, TimeScale, LinearScale } from 'chart.js'
-import 'chartjs-adapter-date-fns'
-Chart.register(Title, Tooltip, Legend, LineController, LineElement, PointElement, TimeScale, LinearScale)
-
-export default {
-  initalizeChart (el) {
-    const data = JSON.parse(el.dataset.chartData)
-
-    this.el.chart = new Chart(el, {
-      type: 'line',
-      data: {
-        datasets: [{
-          label: el.dataset.label,
-          data: data.map(({ date, count, label }) => ({
-            label,
-            x: date,
-            y: count
-          })),
-          backgroundColor: `${el.dataset.color}77`,
-          borderColor: el.dataset.color,
-          fill: true,
-          borderWidth: 3,
-          pointBorderWidth: 1
-        }]
-      },
-      options: {
-        elements: {
-          point: {
-            radius: 9,
-            hoverRadius: 12
-          }
-        },
-        plugins: {
-          legend: {
-            position: 'bottom',
-            labels: {
-              padding: 20
-            }
-          },
-          tooltip: {
-            displayColors: false,
-            callbacks: {
-              title: (contexts) => contexts.map(({ raw: { x } }) => Intl.DateTimeFormat([], { timeZone: 'Etc/UTC', dateStyle: 'short' }).format(new Date(x))),
-              label: ({ raw: { label } }) => label
-            }
-          }
-        },
-        scales: {
-          y: {
-            beginAtZero: true,
-            stacked: true,
-            grace: '15%',
-            ticks: {
-              padding: 15
-            }
-          },
-          x: {
-            type: 'time',
-            time: {
-              unit: 'day'
-            }
-          }
-        },
-        transitions: {
-          show: {
-            animations: {
-              x: {
-                from: 0
-              }
-            }
-          },
-          hide: {
-            animations: {
-              x: {
-                to: 0
-              }
-            }
-          }
-        }
-      }
-    })
-  },
-  updateChart (el) {
-    const data = JSON.parse(el.dataset.chartData)
-
-    this.el.chart.data = {
-      datasets: [{
-        label: el.dataset.label,
-        data: data.map(({ date, count, label }) => ({
-          label,
-          x: date,
-          y: count
-        })),
-        backgroundColor: `${el.dataset.color}77`,
-        borderColor: el.dataset.color,
-        fill: true,
-        borderWidth: 3,
-        pointBorderWidth: 1
-      }]
-    }
-
-    this.el.chart.update()
-  },
-  mounted () { this.initalizeChart(this.el) },
-  updated () { this.updateChart(this.el) }
-}

assets/package.json

@@ -2,10 +2,6 @@
   "repository": {},
   "description": " ",
   "license": "MIT",
-  "engines": {
-    "node": "v18.9.1",
-    "npm": "8.19.1"
-  },
   "scripts": {
     "deploy": "NODE_ENV=production webpack --mode production",
     "watch": "webpack --mode development --watch --watch-options-stdin",
@@ -13,37 +9,33 @@
     "test": "standard"
   },
   "dependencies": {
-    "@fortawesome/fontawesome-free": "^6.3.0",
-    "chart.js": "^4.2.1",
-    "chartjs-adapter-date-fns": "^3.0.0",
-    "date-fns": "^2.29.3",
+    "@fortawesome/fontawesome-free": "^6.1.1",
+    "alpinejs": "^3.10.2",
     "phoenix": "file:../deps/phoenix",
     "phoenix_html": "file:../deps/phoenix_html",
     "phoenix_live_view": "file:../deps/phoenix_live_view",
-    "topbar": "^2.0.1"
+    "topbar": "^1.0.1"
   },
   "devDependencies": {
-    "@babel/core": "^7.21.3",
-    "@babel/preset-env": "^7.20.2",
-    "autoprefixer": "^10.4.14",
-    "babel-loader": "^9.1.2",
-    "copy-webpack-plugin": "^11.0.0",
-    "css-loader": "^6.7.3",
-    "css-minimizer-webpack-plugin": "^4.2.2",
+    "@babel/core": "^7.17.10",
+    "@babel/preset-env": "^7.17.10",
+    "autoprefixer": "^10.4.7",
+    "babel-loader": "^8.2.5",
+    "copy-webpack-plugin": "^10.2.4",
+    "css-loader": "^6.7.1",
+    "css-minimizer-webpack-plugin": "^3.4.1",
     "file-loader": "^6.2.0",
-    "mini-css-extract-plugin": "^2.7.5",
-    "npm-check-updates": "^16.7.12",
-    "postcss": "^8.4.21",
-    "postcss-import": "^15.1.0",
-    "postcss-loader": "^7.1.0",
-    "postcss-preset-env": "^8.0.1",
-    "sass": "^1.59.3",
-    "sass-loader": "^13.2.1",
+    "mini-css-extract-plugin": "^2.6.0",
+    "postcss": "^8.4.13",
+    "postcss-import": "^14.1.0",
+    "postcss-loader": "^6.2.1",
+    "postcss-preset-env": "^7.5.0",
+    "sass-loader": "^12.6.0",
     "standard": "^17.0.0",
-    "tailwindcss": "^3.2.7",
-    "terser-webpack-plugin": "^5.3.7",
-    "webpack": "^5.76.2",
-    "webpack-cli": "^5.0.1",
-    "webpack-dev-server": "^4.13.1"
+    "tailwindcss": "^3.0.24",
+    "terser-webpack-plugin": "^5.3.1",
+    "webpack": "^5.72.0",
+    "webpack-cli": "^4.9.2",
+    "webpack-dev-server": "^4.9.0"
   }
 }

assets/vendor/topbar.js

@@ -0,0 +1,157 @@
+/**
+ * @license MIT
+ * topbar 1.0.0, 2021-01-06
+ * https://buunguyen.github.io/topbar
+ * Copyright (c) 2021 Buu Nguyen
+ */
+(function (window, document) {
+  "use strict";
+
+  // https://gist.github.com/paulirish/1579671
+  (function () {
+    var lastTime = 0;
+    var vendors = ["ms", "moz", "webkit", "o"];
+    for (var x = 0; x < vendors.length && !window.requestAnimationFrame; ++x) {
+      window.requestAnimationFrame =
+        window[vendors[x] + "RequestAnimationFrame"];
+      window.cancelAnimationFrame =
+        window[vendors[x] + "CancelAnimationFrame"] ||
+        window[vendors[x] + "CancelRequestAnimationFrame"];
+    }
+    if (!window.requestAnimationFrame)
+      window.requestAnimationFrame = function (callback, element) {
+        var currTime = new Date().getTime();
+        var timeToCall = Math.max(0, 16 - (currTime - lastTime));
+        var id = window.setTimeout(function () {
+          callback(currTime + timeToCall);
+        }, timeToCall);
+        lastTime = currTime + timeToCall;
+        return id;
+      };
+    if (!window.cancelAnimationFrame)
+      window.cancelAnimationFrame = function (id) {
+        clearTimeout(id);
+      };
+  })();
+
+  var canvas,
+    progressTimerId,
+    fadeTimerId,
+    currentProgress,
+    showing,
+    addEvent = function (elem, type, handler) {
+      if (elem.addEventListener) elem.addEventListener(type, handler, false);
+      else if (elem.attachEvent) elem.attachEvent("on" + type, handler);
+      else elem["on" + type] = handler;
+    },
+    options = {
+      autoRun: true,
+      barThickness: 3,
+      barColors: {
+        0: "rgba(26,  188, 156, .9)",
+        ".25": "rgba(52,  152, 219, .9)",
+        ".50": "rgba(241, 196, 15,  .9)",
+        ".75": "rgba(230, 126, 34,  .9)",
+        "1.0": "rgba(211, 84,  0,   .9)",
+      },
+      shadowBlur: 10,
+      shadowColor: "rgba(0,   0,   0,   .6)",
+      className: null,
+    },
+    repaint = function () {
+      canvas.width = window.innerWidth;
+      canvas.height = options.barThickness * 5; // need space for shadow
+
+      var ctx = canvas.getContext("2d");
+      ctx.shadowBlur = options.shadowBlur;
+      ctx.shadowColor = options.shadowColor;
+
+      var lineGradient = ctx.createLinearGradient(0, 0, canvas.width, 0);
+      for (var stop in options.barColors)
+        lineGradient.addColorStop(stop, options.barColors[stop]);
+      ctx.lineWidth = options.barThickness;
+      ctx.beginPath();
+      ctx.moveTo(0, options.barThickness / 2);
+      ctx.lineTo(
+        Math.ceil(currentProgress * canvas.width),
+        options.barThickness / 2
+      );
+      ctx.strokeStyle = lineGradient;
+      ctx.stroke();
+    },
+    createCanvas = function () {
+      canvas = document.createElement("canvas");
+      var style = canvas.style;
+      style.position = "fixed";
+      style.top = style.left = style.right = style.margin = style.padding = 0;
+      style.zIndex = 100001;
+      style.display = "none";
+      if (options.className) canvas.classList.add(options.className);
+      document.body.appendChild(canvas);
+      addEvent(window, "resize", repaint);
+    },
+    topbar = {
+      config: function (opts) {
+        for (var key in opts)
+          if (options.hasOwnProperty(key)) options[key] = opts[key];
+      },
+      show: function () {
+        if (showing) return;
+        showing = true;
+        if (fadeTimerId !== null) window.cancelAnimationFrame(fadeTimerId);
+        if (!canvas) createCanvas();
+        canvas.style.opacity = 1;
+        canvas.style.display = "block";
+        topbar.progress(0);
+        if (options.autoRun) {
+          (function loop() {
+            progressTimerId = window.requestAnimationFrame(loop);
+            topbar.progress(
+              "+" + 0.05 * Math.pow(1 - Math.sqrt(currentProgress), 2)
+            );
+          })();
+        }
+      },
+      progress: function (to) {
+        if (typeof to === "undefined") return currentProgress;
+        if (typeof to === "string") {
+          to =
+            (to.indexOf("+") >= 0 || to.indexOf("-") >= 0
+              ? currentProgress
+              : 0) + parseFloat(to);
+        }
+        currentProgress = to > 1 ? 1 : to;
+        repaint();
+        return currentProgress;
+      },
+      hide: function () {
+        if (!showing) return;
+        showing = false;
+        if (progressTimerId != null) {
+          window.cancelAnimationFrame(progressTimerId);
+          progressTimerId = null;
+        }
+        (function loop() {
+          if (topbar.progress("+.1") >= 1) {
+            canvas.style.opacity -= 0.05;
+            if (canvas.style.opacity <= 0.05) {
+              canvas.style.display = "none";
+              fadeTimerId = null;
+              return;
+            }
+          }
+          fadeTimerId = window.requestAnimationFrame(loop);
+        })();
+      },
+    };
+
+  if (typeof module === "object" && typeof module.exports === "object") {
+    module.exports = topbar;
+  } else if (typeof define === "function" && define.amd) {
+    define(function () {
+      return topbar;
+    });
+  } else {
+    this.topbar = topbar;
+  }
+}.call(this, window, document));

config/config.exs

@@ -11,8 +11,6 @@ config :cannery,
   ecto_repos: [Cannery.Repo],
   generators: [binary_id: true]
 
-config :cannery, Cannery.Accounts, registration: System.get_env("REGISTRATION", "invite")
-
 # Configures the endpoint
 config :cannery, CanneryWeb.Endpoint,
   url: [scheme: "https", host: System.get_env("HOST") || "localhost", port: "443"],
@@ -20,7 +18,8 @@ config :cannery, CanneryWeb.Endpoint,
   secret_key_base: "KH59P0iZixX5gP/u+zkxxG8vAAj6vgt0YqnwEB5JP5K+E567SsqkCz69uWShjE7I",
   render_errors: [view: CanneryWeb.ErrorView, accepts: ~w(html json), layout: false],
   pubsub_server: Cannery.PubSub,
-  live_view: [signing_salt: "zOLgd3lr"]
+  live_view: [signing_salt: "zOLgd3lr"],
+  registration: System.get_env("REGISTRATION") || "invite"
 
 config :cannery, Cannery.Application, automigrate: false
 

config/dev.exs

@@ -64,9 +64,8 @@ config :cannery, CanneryWeb.Endpoint,
     ]
   ]
 
-config :logger, :console,
-  format: "[$level] $message $metadata\n\n",
-  metadata: [:data]
+# Do not include metadata nor timestamps in development logs
+config :logger, :console, format: "[$level] $message\n"
 
 # Set a higher stacktrace during development. Avoid configuring such
 # in production as building large stacktraces may be expensive.

config/runtime.exs

@@ -15,18 +15,17 @@ end
 config :cannery, CanneryWeb.ViewHelpers, shibao_mode: System.get_env("SHIBAO_MODE") == "true"
 
 # Set default locale
-config :gettext, :default_locale, System.get_env("LOCALE", "en_US")
+config :gettext, :default_locale, System.get_env("LOCALE") || "en_US"
 
 maybe_ipv6 = if System.get_env("ECTO_IPV6") == "true", do: [:inet6], else: []
 
 database_url =
   if config_env() == :test do
-    System.get_env(
-      "TEST_DATABASE_URL",
+    System.get_env("TEST_DATABASE_URL") ||
       "ecto://postgres:postgres@localhost/cannery_test#{System.get_env("MIX_TEST_PARTITION")}"
-    )
   else
-    System.get_env("DATABASE_URL", "ecto://postgres:postgres@cannery-db/cannery")
+    System.get_env("DATABASE_URL") ||
+      "ecto://postgres:postgres@cannery-db/cannery"
   end
 
 host =
@@ -41,7 +40,7 @@ interface =
 config :cannery, Cannery.Repo,
   # ssl: true,
   url: database_url,
-  pool_size: String.to_integer(System.get_env("POOL_SIZE", "10")),
+  pool_size: String.to_integer(System.get_env("POOL_SIZE") || "10"),
   socket_options: maybe_ipv6
 
 config :cannery, CanneryWeb.Endpoint,
@@ -50,13 +49,10 @@ config :cannery, CanneryWeb.Endpoint,
     # See the documentation on https://hexdocs.pm/plug_cowboy/Plug.Cowboy.html
     # for details about using IPv6 vs IPv4 and loopback vs public addresses.
     ip: interface,
-    port: String.to_integer(System.get_env("PORT", "4000"))
+    port: String.to_integer(System.get_env("PORT") || "4000")
   ],
-  server: true
-
-if config_env() in [:dev, :prod] do
-  config :cannery, Cannery.Accounts, registration: System.get_env("REGISTRATION", "invite")
-end
+  server: true,
+  registration: System.get_env("REGISTRATION") || "invite"
 
 if config_env() == :prod do
   # The secret key base is used to sign/encrypt cookies and other secrets.
@@ -80,12 +76,12 @@ if config_env() == :prod do
   config :cannery, Cannery.Mailer,
     adapter: Swoosh.Adapters.SMTP,
     relay: System.get_env("SMTP_HOST") || raise("No SMTP_HOST set!"),
-    port: System.get_env("SMTP_PORT", "587"),
+    port: System.get_env("SMTP_PORT") || 587,
     username: System.get_env("SMTP_USERNAME") || raise("No SMTP_USERNAME set!"),
     password: System.get_env("SMTP_PASSWORD") || raise("No SMTP_PASSWORD set!"),
     ssl: System.get_env("SMTP_SSL") == "true",
-    email_from: System.get_env("EMAIL_FROM", "no-reply@#{System.get_env("HOST")}"),
-    email_name: System.get_env("EMAIL_NAME", "Cannery")
+    email_from: System.get_env("EMAIL_FROM") || "no-reply@#{System.get_env("HOST")}",
+    email_name: System.get_env("EMAIL_NAME") || "Cannery"
 
   # ## Using releases
   #

config/test.exs

@@ -22,9 +22,6 @@ config :cannery, CanneryWeb.Endpoint,
 # In test we don't send emails.
 config :cannery, Cannery.Mailer, adapter: Swoosh.Adapters.Test
 
-# Don't require invites for signups
-config :cannery, Cannery.Accounts, registration: "public"
-
 # Print only warnings and errors during test
 config :logger, level: :warn
 

lib/cannery/accounts.ex

@@ -5,7 +5,7 @@ defmodule Cannery.Accounts do
 
   import Ecto.Query, warn: false
   alias Cannery.{Mailer, Repo}
-  alias Cannery.Accounts.{Invite, Invites, User, UserToken}
+  alias Cannery.Accounts.{User, UserToken}
   alias Ecto.{Changeset, Multi}
   alias Oban.Job
 
@@ -23,24 +23,22 @@ defmodule Cannery.Accounts do
       nil
 
   """
-  @spec get_user_by_email(email :: String.t()) :: User.t() | nil
-  def get_user_by_email(email) when is_binary(email) do
-    Repo.get_by(User, email: email)
-  end
+  @spec get_user_by_email(String.t()) :: User.t() | nil
+  def get_user_by_email(email) when is_binary(email), do: Repo.get_by(User, email: email)
 
   @doc """
   Gets a user by email and password.
 
   ## Examples
 
-      iex> get_user_by_email_and_password("foo@example.com", "valid_password")
+      iex> get_user_by_email_and_password("foo@example.com", "correct_password")
       %User{}
 
       iex> get_user_by_email_and_password("foo@example.com", "invalid_password")
       nil
 
   """
-  @spec get_user_by_email_and_password(email :: String.t(), password :: String.t()) ::
+  @spec get_user_by_email_and_password(String.t(), String.t()) ::
           User.t() | nil
   def get_user_by_email_and_password(email, password)
       when is_binary(email) and is_binary(password) do
@@ -55,30 +53,28 @@ defmodule Cannery.Accounts do
 
   ## Examples
 
-      iex> get_user!(user_id)
-      user
+      iex> get_user!(123)
+      %User{}
 
-      iex> get_user!()
+      iex> get_user!(456)
       ** (Ecto.NoResultsError)
 
   """
-  @spec get_user!(User.id()) :: User.t()
-  def get_user!(id) do
-    Repo.get!(User, id)
-  end
+  @spec get_user!(User.t()) :: User.t()
+  def get_user!(id), do: Repo.get!(User, id)
 
   @doc """
   Returns all users grouped by role.
 
   ## Examples
 
-      iex> list_all_users_by_role(user1)
-      %{admin: [%User{role: :admin}], user: [%User{role: :user}]}
+      iex> list_users_by_role(%User{id: 123, role: :admin})
+      [admin: [%User{}], user: [%User{}, %User{}]]
 
   """
-  @spec list_all_users_by_role(User.t()) :: %{User.role() => [User.t()]}
+  @spec list_all_users_by_role(User.t()) :: %{String.t() => [User.t()]}
   def list_all_users_by_role(%User{role: :admin}) do
-    Repo.all(from u in User, order_by: u.email) |> Enum.group_by(fn %{role: role} -> role end)
+    Repo.all(from u in User, order_by: u.email) |> Enum.group_by(fn user -> user.role end)
   end
 
   @doc """
@@ -86,12 +82,13 @@ defmodule Cannery.Accounts do
 
   ## Examples
 
-      iex> list_users_by_role(:admin)
-      [%User{role: :admin}]
+      iex> list_users_by_role(%User{id: 123, role: :admin})
+      [%User{}]
 
   """
-  @spec list_users_by_role(:admin) :: [User.t()]
-  def list_users_by_role(:admin = role) do
+  @spec list_users_by_role(:admin | :user) :: [User.t()]
+  def list_users_by_role(role) do
+    role = role |> to_string()
     Repo.all(from u in User, where: u.role == ^role, order_by: u.email)
   end
 
@@ -102,38 +99,22 @@ defmodule Cannery.Accounts do
 
   ## Examples
 
-      iex> register_user(%{email: "foo@example.com", password: "valid_password"})
-      {:ok, %User{email: "foo@example.com"}}
+      iex> register_user(%{field: value})
+      {:ok, %User{}}
 
-      iex> register_user(%{email: "foo@example"})
+      iex> register_user(%{field: bad_value})
       {:error, %Changeset{}}
 
   """
-  @spec register_user(attrs :: map()) ::
-          {:ok, User.t()} | {:error, :invalid_token | User.changeset()}
-  @spec register_user(attrs :: map(), Invite.token() | nil) ::
-          {:ok, User.t()} | {:error, :invalid_token | User.changeset()}
-  def register_user(attrs, invite_token \\ nil) do
-    Multi.new()
-    |> Multi.one(:users_count, from(u in User, select: count(u.id), distinct: true))
-    |> Multi.run(:use_invite, fn _changes_so_far, _repo ->
-      if allow_registration?() and invite_token |> is_nil() do
-        {:ok, nil}
-      else
-        Invites.use_invite(invite_token)
-      end
-    end)
-    |> Multi.insert(:add_user, fn %{users_count: count, use_invite: invite} ->
-      # if no registered users, make first user an admin
-      role = if count == 0, do: :admin, else: :user
-      User.registration_changeset(attrs, invite) |> User.role_changeset(role)
-    end)
-    |> Repo.transaction()
-    |> case do
-      {:ok, %{add_user: user}} -> {:ok, user}
-      {:error, :use_invite, :invalid_token, _changes_so_far} -> {:error, :invalid_token}
-      {:error, :add_user, changeset, _changes_so_far} -> {:error, changeset}
-    end
+  @spec register_user(map()) :: {:ok, User.t()} | {:error, Changeset.t(User.new_user())}
+  def register_user(attrs) do
+    # if no registered users, make first user an admin
+    role =
+      if Repo.one!(from u in User, select: count(u.id), distinct: true) == 0,
+        do: "admin",
+        else: "user"
+
+    %User{} |> User.registration_changeset(attrs |> Map.put("role", role)) |> Repo.insert()
   end
 
   @doc """
@@ -141,18 +122,16 @@ defmodule Cannery.Accounts do
 
   ## Examples
 
-      iex> change_user_registration()
-      %Changeset{}
-
-      iex> change_user_registration(%{password: "hi"}
-      %Changeset{}
+      iex> change_user_registration(user)
+      %Changeset{data: %User{}}
 
   """
-  @spec change_user_registration() :: User.changeset()
-  @spec change_user_registration(attrs :: map()) :: User.changeset()
-  def change_user_registration(attrs \\ %{}) do
-    User.registration_changeset(attrs, nil, hash_password: false)
-  end
+  @spec change_user_registration(User.t() | User.new_user()) ::
+          Changeset.t(User.t() | User.new_user())
+  @spec change_user_registration(User.t() | User.new_user(), map()) ::
+          Changeset.t(User.t() | User.new_user())
+  def change_user_registration(user, attrs \\ %{}),
+    do: User.registration_changeset(user, attrs, hash_password: false)
 
   ## Settings
 
@@ -161,29 +140,24 @@ defmodule Cannery.Accounts do
 
   ## Examples
 
-      iex> change_user_email(%User{email: "foo@example.com"})
-      %Changeset{}
+      iex> change_user_email(user)
+      %Changeset{data: %User{}}
 
   """
-  @spec change_user_email(User.t()) :: User.changeset()
-  @spec change_user_email(User.t(), attrs :: map()) :: User.changeset()
-  def change_user_email(user, attrs \\ %{}) do
-    User.email_changeset(user, attrs)
-  end
+  @spec change_user_email(User.t(), map()) :: Changeset.t(User.t())
+  def change_user_email(user, attrs \\ %{}), do: User.email_changeset(user, attrs)
 
   @doc """
   Returns an `%Changeset{}` for changing the user role.
 
   ## Examples
 
-      iex> change_user_role(%User{}, :user)
-      %Changeset{}
+      iex> change_user_role(user)
+      %Changeset{data: %User{}}
 
   """
-  @spec change_user_role(User.t(), User.role()) :: User.changeset()
-  def change_user_role(user, role) do
-    User.role_changeset(user, role)
-  end
+  @spec change_user_role(User.t(), atom()) :: Changeset.t(User.t())
+  def change_user_role(user, role), do: User.role_changeset(user, role)
 
   @doc """
   Emulates that the email will change without actually changing
@@ -191,15 +165,15 @@ defmodule Cannery.Accounts do
 
   ## Examples
 
-      iex> apply_user_email(user, "valid_password", %{email: "new_email@account.com"})
+      iex> apply_user_email(user, "valid password", %{email: ...})
       {:ok, %User{}}
 
-      iex> apply_user_email(user, "invalid password", %{email: "new_email@account"})
+      iex> apply_user_email(user, "invalid password", %{email: ...})
       {:error, %Changeset{}}
 
   """
-  @spec apply_user_email(User.t(), email :: String.t(), attrs :: map()) ::
-          {:ok, User.t()} | {:error, User.changeset()}
+  @spec apply_user_email(User.t(), String.t(), map()) ::
+          {:ok, User.t()} | {:error, Changeset.t(User.t())}
   def apply_user_email(user, password, attrs) do
     user
     |> User.email_changeset(attrs)
@@ -213,7 +187,7 @@ defmodule Cannery.Accounts do
   If the token matches, the user email is updated and the token is deleted.
   The confirmed_at date is also updated to the current time.
   """
-  @spec update_user_email(User.t(), token :: String.t()) :: :ok | :error
+  @spec update_user_email(User.t(), String.t()) :: :ok | :error
   def update_user_email(user, token) do
     context = "change:#{user.email}"
 
@@ -226,7 +200,7 @@ defmodule Cannery.Accounts do
     end
   end
 
-  @spec user_email_multi(User.t(), email :: String.t(), context :: String.t()) :: Multi.t()
+  @spec user_email_multi(User.t(), String.t(), String.t()) :: Multi.t()
   defp user_email_multi(user, email, context) do
     changeset = user |> User.email_changeset(%{email: email}) |> User.confirm_changeset()
 
@@ -240,12 +214,11 @@ defmodule Cannery.Accounts do
 
   ## Examples
 
-      iex> deliver_update_email_instructions(user, "new_foo@example.com", fn _token -> "example url" end)
-      %Oban.Job{args: %{email: :update_email, user_id: ^user_id, attrs: %{url: "example url"}}}
+      iex> deliver_update_email_instructions(user, current_email, &Routes.user_update_email_url(conn, :edit, &1))
+      {:ok, %{to: ..., body: ...}}
 
   """
-  @spec deliver_update_email_instructions(User.t(), current_email :: String.t(), function) ::
-          Job.t()
+  @spec deliver_update_email_instructions(User.t(), String.t(), function) :: Job.t()
   def deliver_update_email_instructions(user, current_email, update_email_url_fun)
       when is_function(update_email_url_fun, 1) do
     {encoded_token, user_token} = UserToken.build_email_token(user, "change:#{current_email}")
@@ -258,32 +231,28 @@ defmodule Cannery.Accounts do
 
   ## Examples
 
-      iex> change_user_password(%User{})
-      %Changeset{}
+      iex> change_user_password(user)
+      %Changeset{data: %User{}}
 
   """
-  @spec change_user_password(User.t(), attrs :: map()) :: User.changeset()
-  def change_user_password(user, attrs \\ %{}) do
-    User.password_changeset(user, attrs, hash_password: false)
-  end
+  @spec change_user_password(User.t(), map()) :: Changeset.t(User.t())
+  def change_user_password(user, attrs \\ %{}),
+    do: User.password_changeset(user, attrs, hash_password: false)
 
   @doc """
   Updates the user password.
 
   ## Examples
 
-      iex> reset_user_password(user, %{
-      ...>   password: "new password",
-      ...>   password_confirmation: "new password"
-      ...> })
+      iex> update_user_password(user, "valid password", %{password: ...})
       {:ok, %User{}}
 
-      iex> update_user_password(user, "invalid password", %{password: "123"})
+      iex> update_user_password(user, "invalid password", %{password: ...})
       {:error, %Changeset{}}
 
   """
-  @spec update_user_password(User.t(), String.t(), attrs :: map()) ::
-          {:ok, User.t()} | {:error, User.changeset()}
+  @spec update_user_password(User.t(), String.t(), map()) ::
+          {:ok, User.t()} | {:error, Changeset.t(User.t())}
   def update_user_password(user, password, attrs) do
     changeset =
       user
@@ -301,54 +270,49 @@ defmodule Cannery.Accounts do
   end
 
   @doc """
-  Returns an `Ecto.Changeset.t()` for changing the user locale.
+  Returns an `%Changeset{}` for changing the user locale.
 
   ## Examples
 
-      iex> change_user_locale(%User{})
-      %Changeset{}
+      iex> change_user_locale(user)
+      %Changeset{data: %User{}}
 
   """
-  @spec change_user_locale(User.t()) :: User.changeset()
-  def change_user_locale(%{locale: locale} = user) do
-    User.locale_changeset(user, locale)
-  end
+  @spec change_user_locale(User.t()) :: Changeset.t(User.t())
+  def change_user_locale(%{locale: locale} = user), do: User.locale_changeset(user, locale)
 
   @doc """
   Updates the user locale.
 
   ## Examples
 
-      iex> update_user_locale(user, "en_US")
+      iex> update_user_locale(user, "valid locale")
       {:ok, %User{}}
 
+      iex> update_user_password(user, "invalid locale")
+      {:error, %Changeset{}}
+
   """
   @spec update_user_locale(User.t(), locale :: String.t()) ::
-          {:ok, User.t()} | {:error, User.changeset()}
-  def update_user_locale(user, locale) do
-    user |> User.locale_changeset(locale) |> Repo.update()
-  end
+          {:ok, User.t()} | {:error, Changeset.t(User.t())}
+  def update_user_locale(user, locale),
+    do: user |> User.locale_changeset(locale) |> Repo.update()
 
   @doc """
   Deletes a user. must be performed by an admin or the same user!
 
   ## Examples
 
-      iex> delete_user!(user, %User{id: 123, role: :admin})
+      iex> delete_user!(user_to_delete, %User{id: 123, role: :admin})
       %User{}
 
-      iex> delete_user!(user, user)
+      iex> delete_user!(%User{id: 123}, %User{id: 123})
       %User{}
 
   """
-  @spec delete_user!(user_to_delete :: User.t(), User.t()) :: User.t()
-  def delete_user!(user, %User{role: :admin}) do
-    user |> Repo.delete!()
-  end
-
-  def delete_user!(%User{id: user_id} = user, %User{id: user_id}) do
-    user |> Repo.delete!()
-  end
+  @spec delete_user!(User.t(), User.t()) :: User.t()
+  def delete_user!(user, %User{role: :admin}), do: user |> Repo.delete!()
+  def delete_user!(%User{id: user_id} = user, %User{id: user_id}), do: user |> Repo.delete!()
 
   ## Session
 
@@ -365,7 +329,7 @@ defmodule Cannery.Accounts do
   @doc """
   Gets the user with the given signed token.
   """
-  @spec get_user_by_session_token(token :: String.t()) :: User.t()
+  @spec get_user_by_session_token(String.t()) :: User.t()
   def get_user_by_session_token(token) do
     {:ok, query} = UserToken.verify_session_token_query(token)
     Repo.one(query)
@@ -374,9 +338,9 @@ defmodule Cannery.Accounts do
   @doc """
   Deletes the signed token with the given context.
   """
-  @spec delete_session_token(token :: String.t()) :: :ok
+  @spec delete_session_token(String.t()) :: :ok
   def delete_session_token(token) do
-    UserToken.token_and_context_query(token, "session") |> Repo.delete_all()
+    Repo.delete_all(UserToken.token_and_context_query(token, "session"))
     :ok
   end
 
@@ -385,53 +349,19 @@ defmodule Cannery.Accounts do
   """
   @spec allow_registration?() :: boolean()
   def allow_registration? do
-    registration_mode() == :public or list_users_by_role(:admin) |> Enum.empty?()
-  end
-
-  @doc """
-  Returns an atom representing the current configured registration mode
-  """
-  @spec registration_mode() :: :public | :invite_only
-  def registration_mode do
-    case Application.get_env(:cannery, Cannery.Accounts)[:registration] do
-      "public" -> :public
-      _other -> :invite_only
-    end
+    Application.get_env(:cannery, CanneryWeb.Endpoint)[:registration] == "public" or
+      list_users_by_role(:admin) |> Enum.empty?()
   end
 
   @doc """
   Checks if user is an admin
-
-  ## Examples
-
-      iex> is_admin?(%User{role: :admin})
-      true
-
-      iex> is_admin?(%User{})
-      false
-
   """
   @spec is_admin?(User.t()) :: boolean()
   def is_admin?(%User{id: user_id}) do
-    Repo.exists?(from u in User, where: u.id == ^user_id, where: u.role == :admin)
+    Repo.one(from u in User, where: u.id == ^user_id and u.role == :admin)
+    |> is_nil()
   end
 
-  @doc """
-  Checks to see if user has the admin role
-
-  ## Examples
-
-      iex> is_already_admin?(%User{role: :admin})
-      true
-
-      iex> is_already_admin?(%User{})
-      false
-
-  """
-  @spec is_already_admin?(User.t() | nil) :: boolean()
-  def is_already_admin?(%User{role: :admin}), do: true
-  def is_already_admin?(_invalid_user), do: false
-
   ## Confirmation
 
   @doc """
@@ -439,10 +369,10 @@ defmodule Cannery.Accounts do
 
   ## Examples
 
-      iex> deliver_user_confirmation_instructions(user, fn _token -> "example url" end)
-      %Oban.Job{args: %{email: :welcome, user_id: ^user_id, attrs: %{url: "example url"}}}
+      iex> deliver_user_confirmation_instructions(user, &Routes.user_confirmation_url(conn, :confirm, &1))
+      {:ok, %{to: ..., body: ...}}
 
-      iex> deliver_user_confirmation_instructions(user, fn _token -> "example url" end)
+      iex> deliver_user_confirmation_instructions(confirmed_user, &Routes.user_confirmation_url(conn, :confirm, &1))
       {:error, :already_confirmed}
 
   """
@@ -464,7 +394,7 @@ defmodule Cannery.Accounts do
   If the token matches, the user account is marked as confirmed
   and the token is deleted.
   """
-  @spec confirm_user(token :: String.t()) :: {:ok, User.t()} | :error
+  @spec confirm_user(String.t()) :: {:ok, User.t()} | atom()
   def confirm_user(token) do
     with {:ok, query} <- UserToken.verify_email_token_query(token, "confirm"),
          %User{} = user <- Repo.one(query),
@@ -489,8 +419,8 @@ defmodule Cannery.Accounts do
 
   ## Examples
 
-      iex> deliver_user_reset_password_instructions(user, fn _token -> "example url" end)
-      %Oban.Job{args: %{email: :reset_password, user_id: ^user_id, attrs: %{url: "example url"}}}
+      iex> deliver_user_reset_password_instructions(user, &Routes.user_reset_password_url(conn, :edit, &1))
+      {:ok, %{to: ..., body: ...}}
 
   """
   @spec deliver_user_reset_password_instructions(User.t(), function()) :: Job.t()
@@ -506,14 +436,14 @@ defmodule Cannery.Accounts do
 
   ## Examples
 
-      iex> get_user_by_reset_password_token(encoded_token)
+      iex> get_user_by_reset_password_token("validtoken")
       %User{}
 
       iex> get_user_by_reset_password_token("invalidtoken")
       nil
 
   """
-  @spec get_user_by_reset_password_token(token :: String.t()) :: User.t() | nil
+  @spec get_user_by_reset_password_token(String.t()) :: User.t() | nil
   def get_user_by_reset_password_token(token) do
     with {:ok, query} <- UserToken.verify_email_token_query(token, "reset_password"),
          %User{} = user <- Repo.one(query) do
@@ -528,18 +458,14 @@ defmodule Cannery.Accounts do
 
   ## Examples
 
-      iex> reset_user_password(user, %{
-      ...>   password: "new password",
-      ...>   password_confirmation: "new password"
-      ...> })
+      iex> reset_user_password(user, %{password: "new long password", password_confirmation: "new long password"})
       {:ok, %User{}}
 
       iex> reset_user_password(user, %{password: "valid", password_confirmation: "not the same"})
       {:error, %Changeset{}}
 
   """
-  @spec reset_user_password(User.t(), attrs :: map()) ::
-          {:ok, User.t()} | {:error, User.changeset()}
+  @spec reset_user_password(User.t(), map()) :: {:ok, User.t()} | {:error, Changeset.t(User.t())}
   def reset_user_password(user, attrs) do
     Multi.new()
     |> Multi.update(:user, User.password_changeset(user, attrs))

lib/cannery/accounts/email.ex

@@ -27,21 +27,21 @@ defmodule Cannery.Email do
   @spec generate_email(key :: String.t(), User.t(), attrs :: map()) :: t()
   def generate_email("welcome", user, %{"url" => url}) do
     user
-    |> base_email(dgettext("emails", "Confirm your Cannery account"))
+    |> base_email(dgettext("emails", "Confirm your %{name} account", name: "Cannery"))
     |> render_body("confirm_email.html", %{user: user, url: url})
     |> text_body(EmailView.render("confirm_email.txt", %{user: user, url: url}))
   end
 
   def generate_email("reset_password", user, %{"url" => url}) do
     user
-    |> base_email(dgettext("emails", "Reset your Cannery password"))
+    |> base_email(dgettext("emails", "Reset your %{name} password", name: "Cannery"))
     |> render_body("reset_password.html", %{user: user, url: url})
     |> text_body(EmailView.render("reset_password.txt", %{user: user, url: url}))
   end
 
   def generate_email("update_email", user, %{"url" => url}) do
     user
-    |> base_email(dgettext("emails", "Update your Cannery email"))
+    |> base_email(dgettext("emails", "Update your %{name} email", name: "Cannery"))
     |> render_body("update_email.html", %{user: user, url: url})
     |> text_body(EmailView.render("update_email.txt", %{user: user, url: url}))
   end

lib/cannery/accounts/invites.ex

@@ -1,208 +0,0 @@
-defmodule Cannery.Accounts.Invites do
-  @moduledoc """
-  The Invites context.
-  """
-
-  import Ecto.Query, warn: false
-  alias Ecto.Multi
-  alias Cannery.Accounts.{Invite, User}
-  alias Cannery.Repo
-
-  @invite_token_length 20
-
-  @doc """
-  Returns the list of invites.
-
-  ## Examples
-
-      iex> list_invites(%User{id: 123, role: :admin})
-      [%Invite{}, ...]
-
-  """
-  @spec list_invites(User.t()) :: [Invite.t()]
-  def list_invites(%User{role: :admin}) do
-    Repo.all(from i in Invite, order_by: i.name)
-  end
-
-  @doc """
-  Gets a single invite for a user
-
-  Raises `Ecto.NoResultsError` if the Invite does not exist.
-
-  ## Examples
-
-      iex> get_invite!(123, %User{id: 123, role: :admin})
-      %Invite{}
-
-      > get_invite!(456, %User{id: 123, role: :admin})
-      ** (Ecto.NoResultsError)
-
-  """
-  @spec get_invite!(Invite.id(), User.t()) :: Invite.t()
-  def get_invite!(id, %User{role: :admin}) do
-    Repo.get!(Invite, id)
-  end
-
-  @doc """
-  Returns if an invite token is still valid
-
-  ## Examples
-
-      iex> valid_invite_token?("valid_token")
-      %Invite{}
-
-      iex> valid_invite_token?("invalid_token")
-      nil
-  """
-  @spec valid_invite_token?(Invite.token() | nil) :: boolean()
-  def valid_invite_token?(token) when token in [nil, ""], do: false
-
-  def valid_invite_token?(token) do
-    Repo.exists?(
-      from i in Invite,
-        where: i.token == ^token,
-        where: i.disabled_at |> is_nil()
-    )
-  end
-
-  @doc """
-  Uses invite by decrementing uses_left, or marks invite invalid if it's been
-  completely used.
-  """
-  @spec use_invite(Invite.token()) :: {:ok, Invite.t()} | {:error, :invalid_token}
-  def use_invite(invite_token) do
-    Multi.new()
-    |> Multi.run(:invite, fn _changes_so_far, _repo ->
-      invite_token |> get_invite_by_token()
-    end)
-    |> Multi.update(:decrement_invite, fn %{invite: invite} ->
-      decrement_invite_changeset(invite)
-    end)
-    |> Repo.transaction()
-    |> case do
-      {:ok, %{decrement_invite: invite}} -> {:ok, invite}
-      {:error, :invite, :invalid_token, _changes_so_far} -> {:error, :invalid_token}
-    end
-  end
-
-  @spec get_invite_by_token(Invite.token() | nil) :: {:ok, Invite.t()} | {:error, :invalid_token}
-  defp get_invite_by_token(token) when token in [nil, ""], do: {:error, :invalid_token}
-
-  defp get_invite_by_token(token) do
-    Repo.one(
-      from i in Invite,
-        where: i.token == ^token,
-        where: i.disabled_at |> is_nil()
-    )
-    |> case do
-      nil -> {:error, :invalid_token}
-      invite -> {:ok, invite}
-    end
-  end
-
-  @spec get_use_count(Invite.t(), User.t()) :: non_neg_integer() | nil
-  def get_use_count(%Invite{id: invite_id} = invite, user) do
-    [invite] |> get_use_counts(user) |> Map.get(invite_id)
-  end
-
-  @spec get_use_counts([Invite.t()], User.t()) ::
-          %{optional(Invite.id()) => non_neg_integer()}
-  def get_use_counts(invites, %User{role: :admin}) do
-    invite_ids = invites |> Enum.map(fn %{id: invite_id} -> invite_id end)
-
-    Repo.all(
-      from u in User,
-        where: u.invite_id in ^invite_ids,
-        group_by: u.invite_id,
-        select: {u.invite_id, count(u.id)}
-    )
-    |> Map.new()
-  end
-
-  @spec decrement_invite_changeset(Invite.t()) :: Invite.changeset()
-  defp decrement_invite_changeset(%Invite{uses_left: nil} = invite) do
-    invite |> Invite.update_changeset(%{})
-  end
-
-  defp decrement_invite_changeset(%Invite{uses_left: 1} = invite) do
-    now = NaiveDateTime.utc_now() |> NaiveDateTime.truncate(:second)
-    invite |> Invite.update_changeset(%{uses_left: 0, disabled_at: now})
-  end
-
-  defp decrement_invite_changeset(%Invite{uses_left: uses_left} = invite) do
-    invite |> Invite.update_changeset(%{uses_left: uses_left - 1})
-  end
-
-  @doc """
-  Creates a invite.
-
-  ## Examples
-
-      iex> create_invite(%User{id: 123, role: :admin}, %{field: value})
-      {:ok, %Invite{}}
-
-      iex> create_invite(%User{id: 123, role: :admin}, %{field: bad_value})
-      {:error, %Changeset{}}
-
-  """
-  @spec create_invite(User.t(), attrs :: map()) ::
-          {:ok, Invite.t()} | {:error, Invite.changeset()}
-  def create_invite(%User{role: :admin} = user, attrs) do
-    token =
-      :crypto.strong_rand_bytes(@invite_token_length)
-      |> Base.url_encode64()
-      |> binary_part(0, @invite_token_length)
-
-    Invite.create_changeset(user, token, attrs) |> Repo.insert()
-  end
-
-  @doc """
-  Updates a invite.
-
-  ## Examples
-
-      iex> update_invite(invite, %{field: new_value}, %User{id: 123, role: :admin})
-      {:ok, %Invite{}}
-
-      iex> update_invite(invite, %{field: bad_value}, %User{id: 123, role: :admin})
-      {:error, %Changeset{}}
-
-  """
-  @spec update_invite(Invite.t(), attrs :: map(), User.t()) ::
-          {:ok, Invite.t()} | {:error, Invite.changeset()}
-  def update_invite(invite, attrs, %User{role: :admin}) do
-    invite |> Invite.update_changeset(attrs) |> Repo.update()
-  end
-
-  @doc """
-  Deletes a invite.
-
-  ## Examples
-
-      iex> delete_invite(invite, %User{id: 123, role: :admin})
-      {:ok, %Invite{}}
-
-      iex> delete_invite(invite, %User{id: 123, role: :admin})
-      {:error, %Changeset{}}
-
-  """
-  @spec delete_invite(Invite.t(), User.t()) ::
-          {:ok, Invite.t()} | {:error, Invite.changeset()}
-  def delete_invite(invite, %User{role: :admin}) do
-    invite |> Repo.delete()
-  end
-
-  @doc """
-  Deletes a invite.
-
-  ## Examples
-
-      iex> delete_invite(invite, %User{id: 123, role: :admin})
-      %Invite{}
-
-  """
-  @spec delete_invite!(Invite.t(), User.t()) :: Invite.t()
-  def delete_invite!(invite, %User{role: :admin}) do
-    invite |> Repo.delete!()
-  end
-end

lib/cannery/accounts/user.ex

@@ -1,24 +1,14 @@
 defmodule Cannery.Accounts.User do
   @moduledoc """
-  A Cannery user
+  A cannery user
   """
 
   use Ecto.Schema
   import Ecto.Changeset
   import CanneryWeb.Gettext
-  alias Ecto.{Association, Changeset, UUID}
-  alias Cannery.Accounts.{Invite, User}
+  alias Ecto.{Changeset, UUID}
+  alias Cannery.{Accounts.User, Invites.Invite}
 
-  @derive {Jason.Encoder,
-           only: [
-             :id,
-             :email,
-             :confirmed_at,
-             :role,
-             :locale,
-             :inserted_at,
-             :updated_at
-           ]}
   @derive {Inspect, except: [:password]}
   @primary_key {:id, :binary_id, autogenerate: true}
   @foreign_key_type :binary_id
@@ -30,9 +20,7 @@ defmodule Cannery.Accounts.User do
     field :role, Ecto.Enum, values: [:admin, :user], default: :user
     field :locale, :string
 
-    has_many :created_invites, Invite, foreign_key: :created_by_id
-
-    belongs_to :invite, Invite
+    has_many :invites, Invite, on_delete: :delete_all
 
     timestamps()
   end
@@ -43,18 +31,14 @@ defmodule Cannery.Accounts.User do
           password: String.t(),
           hashed_password: String.t(),
           confirmed_at: NaiveDateTime.t(),
-          role: role(),
+          role: atom(),
           locale: String.t() | nil,
-          created_invites: [Invite.t()] | Association.NotLoaded.t(),
-          invite: Invite.t() | nil | Association.NotLoaded.t(),
-          invite_id: Invite.id() | nil,
+          invites: [Invite.t()],
           inserted_at: NaiveDateTime.t(),
           updated_at: NaiveDateTime.t()
         }
   @type new_user :: %User{}
   @type id :: UUID.t()
-  @type changeset :: Changeset.t(t() | new_user())
-  @type role :: :admin | :user
 
   @doc """
   A user changeset for registration.
@@ -73,26 +57,26 @@ defmodule Cannery.Accounts.User do
       validations on a LiveView form), this option can be set to `false`.
       Defaults to `true`.
   """
-  @spec registration_changeset(attrs :: map(), Invite.t() | nil) :: changeset()
-  @spec registration_changeset(attrs :: map(), Invite.t() | nil, opts :: keyword()) :: changeset()
-  def registration_changeset(attrs, invite, opts \\ []) do
-    %User{}
-    |> cast(attrs, [:email, :password, :locale])
-    |> put_change(:invite_id, if(invite, do: invite.id))
-    |> validate_length(:locale, max: 255)
+  @spec registration_changeset(t() | new_user(), attrs :: map()) :: Changeset.t(t() | new_user())
+  @spec registration_changeset(t() | new_user(), attrs :: map(), opts :: keyword()) ::
+          Changeset.t(t() | new_user())
+  def registration_changeset(user, attrs, opts \\ []) do
+    user
+    |> cast(attrs, [:email, :password, :role, :locale])
     |> validate_email()
     |> validate_password(opts)
   end
 
   @doc """
   A user changeset for role.
+
   """
-  @spec role_changeset(t() | new_user() | changeset(), role()) :: changeset()
+  @spec role_changeset(t(), role :: atom()) :: Changeset.t(t())
   def role_changeset(user, role) do
-    user |> change(role: role)
+    user |> cast(%{"role" => role}, [:role])
   end
 
-  @spec validate_email(changeset()) :: changeset()
+  @spec validate_email(Changeset.t(t() | new_user())) :: Changeset.t(t() | new_user())
   defp validate_email(changeset) do
     changeset
     |> validate_required([:email])
@@ -104,8 +88,8 @@ defmodule Cannery.Accounts.User do
     |> unique_constraint(:email)
   end
 
-  @spec validate_password(changeset(), opts :: keyword()) ::
-          changeset()
+  @spec validate_password(Changeset.t(t() | new_user()), opts :: keyword()) ::
+          Changeset.t(t() | new_user())
   defp validate_password(changeset, opts) do
     changeset
     |> validate_required([:password])
@@ -116,7 +100,8 @@ defmodule Cannery.Accounts.User do
     |> maybe_hash_password(opts)
   end
 
-  @spec maybe_hash_password(changeset(), opts :: keyword()) :: changeset()
+  @spec maybe_hash_password(Changeset.t(t() | new_user()), opts :: keyword()) ::
+          Changeset.t(t() | new_user())
   defp maybe_hash_password(changeset, opts) do
     hash_password? = Keyword.get(opts, :hash_password, true)
     password = get_change(changeset, :password)
@@ -135,7 +120,7 @@ defmodule Cannery.Accounts.User do
 
   It requires the email to change otherwise an error is added.
   """
-  @spec email_changeset(t(), attrs :: map()) :: changeset()
+  @spec email_changeset(t(), attrs :: map()) :: Changeset.t(t())
   def email_changeset(user, attrs) do
     user
     |> cast(attrs, [:email])
@@ -158,8 +143,8 @@ defmodule Cannery.Accounts.User do
       validations on a LiveView form), this option can be set to `false`.
       Defaults to `true`.
   """
-  @spec password_changeset(t(), attrs :: map()) :: changeset()
-  @spec password_changeset(t(), attrs :: map(), opts :: keyword()) :: changeset()
+  @spec password_changeset(t(), attrs :: map()) :: Changeset.t(t())
+  @spec password_changeset(t(), attrs :: map(), opts :: keyword()) :: Changeset.t(t())
   def password_changeset(user, attrs, opts \\ []) do
     user
     |> cast(attrs, [:password])
@@ -170,7 +155,7 @@ defmodule Cannery.Accounts.User do
   @doc """
   Confirms the account by setting `confirmed_at`.
   """
-  @spec confirm_changeset(t() | changeset()) :: changeset()
+  @spec confirm_changeset(t() | Changeset.t(t())) :: Changeset.t(t())
   def confirm_changeset(user_or_changeset) do
     now = NaiveDateTime.utc_now() |> NaiveDateTime.truncate(:second)
     user_or_changeset |> change(confirmed_at: now)
@@ -196,7 +181,7 @@ defmodule Cannery.Accounts.User do
   @doc """
   Validates the current password otherwise adds an error to the changeset.
   """
-  @spec validate_current_password(changeset(), String.t()) :: changeset()
+  @spec validate_current_password(Changeset.t(t()), String.t()) :: Changeset.t(t())
   def validate_current_password(changeset, password) do
     if valid_password?(changeset.data, password),
       do: changeset,
@@ -206,11 +191,10 @@ defmodule Cannery.Accounts.User do
   @doc """
   A changeset for changing the user's locale
   """
-  @spec locale_changeset(t() | changeset(), locale :: String.t() | nil) :: changeset()
+  @spec locale_changeset(t() | Changeset.t(t()), locale :: String.t() | nil) :: Changeset.t(t())
   def locale_changeset(user_or_changeset, locale) do
     user_or_changeset
     |> cast(%{"locale" => locale}, [:locale])
-    |> validate_length(:locale, max: 255)
     |> validate_required(:locale)
   end
 end

lib/cannery/accounts/user_token.ex

@@ -1,12 +1,12 @@
 defmodule Cannery.Accounts.UserToken do
   @moduledoc """
-  Schema for a user's session token
+  Schema for serialized user session and authentication tokens
   """
 
   use Ecto.Schema
   import Ecto.Query
-  alias Cannery.Accounts.User
-  alias Ecto.{Association, UUID}
+  alias Ecto.{Query, UUID}
+  alias Cannery.{Accounts.User, Accounts.UserToken}
 
   @hash_algorithm :sha256
   @rand_size 32
@@ -30,27 +30,27 @@ defmodule Cannery.Accounts.UserToken do
     timestamps(updated_at: false)
   end
 
-  @type t :: %__MODULE__{
+  @type t :: %UserToken{
           id: id(),
-          token: token(),
+          token: String.t(),
           context: String.t(),
           sent_to: String.t(),
-          user: User.t() | Association.NotLoaded.t(),
-          user_id: User.id() | nil,
+          user: User.t(),
+          user_id: User.id(),
           inserted_at: NaiveDateTime.t()
         }
-  @type new_user_token :: %__MODULE__{}
+  @type new_token :: %UserToken{}
   @type id :: UUID.t()
-  @type token :: binary()
 
   @doc """
   Generates a token that will be stored in a signed place,
   such as session or cookie. As they are signed, those
   tokens do not need to be hashed.
   """
-  def build_session_token(user) do
+  @spec build_session_token(User.t()) :: {token :: String.t(), new_token()}
+  def build_session_token(%{id: user_id}) do
     token = :crypto.strong_rand_bytes(@rand_size)
-    {token, %__MODULE__{token: token, context: "session", user_id: user.id}}
+    {token, %UserToken{token: token, context: "session", user_id: user_id}}
   end
 
   @doc """
@@ -58,6 +58,7 @@ defmodule Cannery.Accounts.UserToken do
 
   The query returns the user found by the token.
   """
+  @spec verify_session_token_query(token :: String.t()) :: {:ok, Query.t()}
   def verify_session_token_query(token) do
     query =
       from token in token_and_context_query(token, "session"),
@@ -76,16 +77,19 @@ defmodule Cannery.Accounts.UserToken do
   The token is valid for a week as long as users don't change
   their email.
   """
+  @spec build_email_token(User.t(), context :: String.t()) :: {token :: String.t(), new_token()}
   def build_email_token(user, context) do
     build_hashed_token(user, context, user.email)
   end
 
+  @spec build_hashed_token(User.t(), String.t(), String.t()) ::
+          {String.t(), new_token()}
   defp build_hashed_token(user, context, sent_to) do
     token = :crypto.strong_rand_bytes(@rand_size)
     hashed_token = :crypto.hash(@hash_algorithm, token)
 
     {Base.url_encode64(token, padding: false),
-     %__MODULE__{
+     %UserToken{
        token: hashed_token,
        context: context,
        sent_to: sent_to,
@@ -98,6 +102,8 @@ defmodule Cannery.Accounts.UserToken do
 
   The query returns the user found by the token.
   """
+  @spec verify_email_token_query(token :: String.t(), context :: String.t()) ::
+          {:ok, Query.t()} | :error
   def verify_email_token_query(token, context) do
     case Base.url_decode64(token, padding: false) do
       {:ok, decoded_token} ->
@@ -117,6 +123,7 @@ defmodule Cannery.Accounts.UserToken do
     end
   end
 
+  @spec days_for_context(context :: <<_::56>>) :: non_neg_integer()
   defp days_for_context("confirm"), do: @confirm_validity_in_days
   defp days_for_context("reset_password"), do: @reset_password_validity_in_days
 
@@ -125,6 +132,8 @@ defmodule Cannery.Accounts.UserToken do
 
   The query returns the user token record.
   """
+  @spec verify_change_email_token_query(token :: String.t(), context :: String.t()) ::
+          {:ok, Query.t()} | :error
   def verify_change_email_token_query(token, context) do
     case Base.url_decode64(token, padding: false) do
       {:ok, decoded_token} ->
@@ -144,18 +153,21 @@ defmodule Cannery.Accounts.UserToken do
   @doc """
   Returns the given token with the given context.
   """
+  @spec token_and_context_query(token :: String.t(), context :: String.t()) :: Query.t()
   def token_and_context_query(token, context) do
-    from __MODULE__, where: [token: ^token, context: ^context]
+    from UserToken, where: [token: ^token, context: ^context]
   end
 
   @doc """
   Gets all tokens for the given user for the given contexts.
   """
-  def user_and_contexts_query(user, :all) do
-    from t in __MODULE__, where: t.user_id == ^user.id
+  @spec user_and_contexts_query(User.t(), contexts :: :all | nonempty_maybe_improper_list()) ::
+          Query.t()
+  def user_and_contexts_query(%{id: user_id}, :all) do
+    from t in UserToken, where: t.user_id == ^user_id
   end
 
-  def user_and_contexts_query(user, [_ | _] = contexts) do
-    from t in __MODULE__, where: t.user_id == ^user.id and t.context in ^contexts
+  def user_and_contexts_query(%{id: user_id}, [_ | _] = contexts) do
+    from t in UserToken, where: t.user_id == ^user_id and t.context in ^contexts
   end
 end

lib/cannery/activity_log.ex

@@ -4,104 +4,22 @@ defmodule Cannery.ActivityLog do
   """
 
   import Ecto.Query, warn: false
-  alias Cannery.Ammo.{AmmoGroup, AmmoType}
-  alias Cannery.{Accounts.User, ActivityLog.ShotGroup, Repo}
-  alias Ecto.{Multi, Queryable}
+  import CanneryWeb.Gettext
+  alias Cannery.{Accounts.User, ActivityLog.ShotGroup, Ammo, Ammo.AmmoGroup, Repo}
+  alias Ecto.{Changeset, Multi}
 
   @doc """
   Returns the list of shot_groups.
 
   ## Examples
 
-      iex> list_shot_groups(:all, %User{id: 123})
+      iex> list_shot_groups(%User{id: 123})
       [%ShotGroup{}, ...]
 
-      iex> list_shot_groups("cool", :all, %User{id: 123})
-      [%ShotGroup{notes: "My cool shot group"}, ...]
-
-      iex> list_shot_groups("cool", :rifle, %User{id: 123})
-      [%ShotGroup{notes: "Shot some rifle rounds"}, ...]
-
   """
-  @spec list_shot_groups(AmmoType.type() | :all, User.t()) :: [ShotGroup.t()]
-  @spec list_shot_groups(search :: nil | String.t(), AmmoType.type() | :all, User.t()) ::
-          [ShotGroup.t()]
-  def list_shot_groups(search \\ nil, type, %{id: user_id}) do
-    from(sg in ShotGroup,
-      as: :sg,
-      left_join: ag in AmmoGroup,
-      as: :ag,
-      on: sg.ammo_group_id == ag.id,
-      left_join: at in AmmoType,
-      as: :at,
-      on: ag.ammo_type_id == at.id,
-      where: sg.user_id == ^user_id,
-      distinct: sg.id
-    )
-    |> list_shot_groups_search(search)
-    |> list_shot_groups_filter_type(type)
-    |> Repo.all()
-  end
-
-  @spec list_shot_groups_search(Queryable.t(), search :: String.t() | nil) ::
-          Queryable.t()
-  defp list_shot_groups_search(query, search) when search in ["", nil], do: query
-
-  defp list_shot_groups_search(query, search) when search |> is_binary() do
-    trimmed_search = String.trim(search)
-
-    query
-    |> where(
-      [sg: sg, ag: ag, at: at],
-      fragment(
-        "? @@ websearch_to_tsquery('english', ?)",
-        sg.search,
-        ^trimmed_search
-      ) or
-        fragment(
-          "? @@ websearch_to_tsquery('english', ?)",
-          ag.search,
-          ^trimmed_search
-        ) or
-        fragment(
-          "? @@ websearch_to_tsquery('english', ?)",
-          at.search,
-          ^trimmed_search
-        )
-    )
-    |> order_by([sg: sg], {
-      :desc,
-      fragment(
-        "ts_rank_cd(?, websearch_to_tsquery('english', ?), 4)",
-        sg.search,
-        ^trimmed_search
-      )
-    })
-  end
-
-  @spec list_shot_groups_filter_type(Queryable.t(), AmmoType.type() | :all) ::
-          Queryable.t()
-  defp list_shot_groups_filter_type(query, :rifle),
-    do: query |> where([at: at], at.type == :rifle)
-
-  defp list_shot_groups_filter_type(query, :pistol),
-    do: query |> where([at: at], at.type == :pistol)
-
-  defp list_shot_groups_filter_type(query, :shotgun),
-    do: query |> where([at: at], at.type == :shotgun)
-
-  defp list_shot_groups_filter_type(query, _all), do: query
-
-  @spec list_shot_groups_for_ammo_group(AmmoGroup.t(), User.t()) :: [ShotGroup.t()]
-  def list_shot_groups_for_ammo_group(
-        %AmmoGroup{id: ammo_group_id, user_id: user_id},
-        %User{id: user_id}
-      ) do
-    Repo.all(
-      from sg in ShotGroup,
-        where: sg.ammo_group_id == ^ammo_group_id,
-        where: sg.user_id == ^user_id
-    )
+  @spec list_shot_groups(User.t()) :: [ShotGroup.t()]
+  def list_shot_groups(%User{id: user_id}) do
+    Repo.all(from(sg in ShotGroup, where: sg.user_id == ^user_id))
   end
 
   @doc """
@@ -141,37 +59,33 @@ defmodule Cannery.ActivityLog do
 
   """
   @spec create_shot_group(attrs :: map(), User.t(), AmmoGroup.t()) ::
-          {:ok, ShotGroup.t()} | {:error, ShotGroup.changeset() | nil}
-  def create_shot_group(attrs, user, ammo_group) do
-    Multi.new()
-    |> Multi.insert(
-      :create_shot_group,
-      %ShotGroup{} |> ShotGroup.create_changeset(user, ammo_group, attrs)
-    )
-    |> Multi.run(
-      :ammo_group,
-      fn _repo, %{create_shot_group: %{ammo_group_id: ammo_group_id, user_id: user_id}} ->
-        ammo_group =
-          Repo.one(
-            from ag in AmmoGroup,
-              where: ag.id == ^ammo_group_id,
-              where: ag.user_id == ^user_id
-          )
+          {:ok, ShotGroup.t()} | {:error, Changeset.t(ShotGroup.t()) | nil}
+  def create_shot_group(
+        attrs,
+        %User{id: user_id},
+        %AmmoGroup{id: ammo_group_id, count: ammo_group_count, user_id: user_id} = ammo_group
+      ) do
+    attrs = attrs |> Map.merge(%{"user_id" => user_id, "ammo_group_id" => ammo_group_id})
+    changeset = %ShotGroup{} |> ShotGroup.create_changeset(attrs)
+    shot_group_count = changeset |> Changeset.get_field(:count)
 
-        {:ok, ammo_group}
-      end
-    )
-    |> Multi.update(
-      :update_ammo_group,
-      fn %{create_shot_group: %{count: shot_group_count}, ammo_group: %{count: ammo_group_count}} ->
+    if shot_group_count > ammo_group_count do
+      error = dgettext("errors", "Count must be less than %{count}", count: ammo_group_count)
+      changeset = changeset |> Changeset.add_error(:count, error)
+      {:error, changeset}
+    else
+      Multi.new()
+      |> Multi.insert(:create_shot_group, changeset)
+      |> Multi.update(
+        :update_ammo_group,
         ammo_group |> AmmoGroup.range_changeset(%{"count" => ammo_group_count - shot_group_count})
+      )
+      |> Repo.transaction()
+      |> case do
+        {:ok, %{create_shot_group: shot_group}} -> {:ok, shot_group}
+        {:error, :create_shot_group, changeset, _changes_so_far} -> {:error, changeset}
+        {:error, _other_transaction, _value, _changes_so_far} -> {:error, nil}
       end
-    )
-    |> Repo.transaction()
-    |> case do
-      {:ok, %{create_shot_group: shot_group}} -> {:ok, shot_group}
-      {:error, :create_shot_group, changeset, _changes_so_far} -> {:error, changeset}
-      {:error, _other_transaction, _value, _changes_so_far} -> {:error, nil}
     end
   end
 
@@ -188,40 +102,44 @@ defmodule Cannery.ActivityLog do
 
   """
   @spec update_shot_group(ShotGroup.t(), attrs :: map(), User.t()) ::
-          {:ok, ShotGroup.t()} | {:error, ShotGroup.changeset() | nil}
+          {:ok, ShotGroup.t()} | {:error, Changeset.t(ShotGroup.t()) | nil}
   def update_shot_group(
-        %ShotGroup{count: count, user_id: user_id} = shot_group,
+        %ShotGroup{count: count, user_id: user_id, ammo_group_id: ammo_group_id} = shot_group,
         attrs,
         %User{id: user_id} = user
       ) do
-    Multi.new()
-    |> Multi.update(
-      :update_shot_group,
-      shot_group |> ShotGroup.update_changeset(user, attrs)
-    )
-    |> Multi.run(
-      :ammo_group,
-      fn repo, %{update_shot_group: %{ammo_group_id: ammo_group_id, user_id: user_id}} ->
-        {:ok,
-         repo.one(from ag in AmmoGroup, where: ag.id == ^ammo_group_id and ag.user_id == ^user_id)}
-      end
-    )
-    |> Multi.update(
-      :update_ammo_group,
-      fn %{
-           update_shot_group: %{count: new_count},
-           ammo_group: %{count: ammo_group_count} = ammo_group
-         } ->
-        shot_diff_to_add = new_count - count
-        new_ammo_group_count = ammo_group_count - shot_diff_to_add
-        ammo_group |> AmmoGroup.range_changeset(%{"count" => new_ammo_group_count})
-      end
-    )
-    |> Repo.transaction()
-    |> case do
-      {:ok, %{update_shot_group: shot_group}} -> {:ok, shot_group}
-      {:error, :update_shot_group, changeset, _changes_so_far} -> {:error, changeset}
-      {:error, _other_transaction, _value, _changes_so_far} -> {:error, nil}
+    %{count: ammo_group_count, user_id: ^user_id} =
+      ammo_group = ammo_group_id |> Ammo.get_ammo_group!(user)
+
+    changeset = shot_group |> ShotGroup.update_changeset(attrs)
+    new_shot_group_count = changeset |> Changeset.get_field(:count)
+    shot_diff_to_add = new_shot_group_count - count
+
+    cond do
+      shot_diff_to_add > ammo_group_count ->
+        error = dgettext("errors", "Count must be less than %{count}", count: ammo_group_count)
+        changeset = changeset |> Changeset.add_error(:count, error)
+        {:error, changeset}
+
+      new_shot_group_count <= 0 ->
+        error = dgettext("errors", "Count must be at least 1")
+        changeset = changeset |> Changeset.add_error(:count, error)
+        {:error, changeset}
+
+      true ->
+        Multi.new()
+        |> Multi.update(:update_shot_group, changeset)
+        |> Multi.update(
+          :update_ammo_group,
+          ammo_group
+          |> AmmoGroup.range_changeset(%{"count" => ammo_group_count - shot_diff_to_add})
+        )
+        |> Repo.transaction()
+        |> case do
+          {:ok, %{update_shot_group: shot_group}} -> {:ok, shot_group}
+          {:error, :update_shot_group, changeset, _changes_so_far} -> {:error, changeset}
+          {:error, _other_transaction, _value, _changes_so_far} -> {:error, nil}
+        end
     end
   end
 
@@ -238,29 +156,20 @@ defmodule Cannery.ActivityLog do
 
   """
   @spec delete_shot_group(ShotGroup.t(), User.t()) ::
-          {:ok, ShotGroup.t()} | {:error, ShotGroup.changeset()}
+          {:ok, ShotGroup.t()} | {:error, Changeset.t(ShotGroup.t())}
   def delete_shot_group(
-        %ShotGroup{user_id: user_id} = shot_group,
-        %User{id: user_id}
+        %ShotGroup{count: count, user_id: user_id, ammo_group_id: ammo_group_id} = shot_group,
+        %User{id: user_id} = user
       ) do
+    %{count: ammo_group_count, user_id: ^user_id} =
+      ammo_group = ammo_group_id |> Ammo.get_ammo_group!(user)
+
     Multi.new()
     |> Multi.delete(:delete_shot_group, shot_group)
-    |> Multi.run(
-      :ammo_group,
-      fn repo, %{delete_shot_group: %{ammo_group_id: ammo_group_id, user_id: user_id}} ->
-        {:ok,
-         repo.one(from ag in AmmoGroup, where: ag.id == ^ammo_group_id and ag.user_id == ^user_id)}
-      end
-    )
     |> Multi.update(
       :update_ammo_group,
-      fn %{
-           delete_shot_group: %{count: count},
-           ammo_group: %{count: ammo_group_count} = ammo_group
-         } ->
-        new_ammo_group_count = ammo_group_count + count
-        ammo_group |> AmmoGroup.range_changeset(%{"count" => new_ammo_group_count})
-      end
+      ammo_group
+      |> AmmoGroup.range_changeset(%{"count" => ammo_group_count + count})
     )
     |> Repo.transaction()
     |> case do
@@ -271,110 +180,19 @@ defmodule Cannery.ActivityLog do
   end
 
   @doc """
-  Returns the number of shot rounds for an ammo group
-  """
-  @spec get_used_count(AmmoGroup.t(), User.t()) :: non_neg_integer()
-  def get_used_count(%AmmoGroup{id: ammo_group_id} = ammo_group, user) do
-    [ammo_group]
-    |> get_used_counts(user)
-    |> Map.get(ammo_group_id, 0)
-  end
-
-  @doc """
-  Returns the number of shot rounds for multiple ammo groups
-  """
-  @spec get_used_counts([AmmoGroup.t()], User.t()) ::
-          %{optional(AmmoGroup.id()) => non_neg_integer()}
-  def get_used_counts(ammo_groups, %User{id: user_id}) do
-    ammo_group_ids =
-      ammo_groups
-      |> Enum.map(fn %{id: ammo_group_id} -> ammo_group_id end)
-
-    Repo.all(
-      from sg in ShotGroup,
-        where: sg.ammo_group_id in ^ammo_group_ids,
-        where: sg.user_id == ^user_id,
-        group_by: sg.ammo_group_id,
-        select: {sg.ammo_group_id, sum(sg.count)}
-    )
-    |> Map.new()
-  end
-
-  @doc """
-  Returns the last entered shot group date for an ammo group
-  """
-  @spec get_last_used_date(AmmoGroup.t(), User.t()) :: Date.t() | nil
-  def get_last_used_date(%AmmoGroup{id: ammo_group_id} = ammo_group, user) do
-    [ammo_group]
-    |> get_last_used_dates(user)
-    |> Map.get(ammo_group_id)
-  end
-
-  @doc """
-  Returns the last entered shot group date for an ammo group
-  """
-  @spec get_last_used_dates([AmmoGroup.t()], User.t()) :: %{optional(AmmoGroup.id()) => Date.t()}
-  def get_last_used_dates(ammo_groups, %User{id: user_id}) do
-    ammo_group_ids =
-      ammo_groups
-      |> Enum.map(fn %AmmoGroup{id: ammo_group_id, user_id: ^user_id} -> ammo_group_id end)
-
-    Repo.all(
-      from sg in ShotGroup,
-        where: sg.ammo_group_id in ^ammo_group_ids,
-        where: sg.user_id == ^user_id,
-        group_by: sg.ammo_group_id,
-        select: {sg.ammo_group_id, max(sg.date)}
-    )
-    |> Map.new()
-  end
-
-  @doc """
-  Gets the total number of rounds shot for an ammo type
-
-  Raises `Ecto.NoResultsError` if the Ammo type does not exist.
+  Returns an `%Ecto.Changeset{}` for tracking shot_group changes.
 
   ## Examples
 
-      iex> get_used_count_for_ammo_type(123, %User{id: 123})
-      35
-
-      iex> get_used_count_for_ammo_type(456, %User{id: 123})
-      ** (Ecto.NoResultsError)
+      iex> change_shot_group(shot_group)
+      %Ecto.Changeset{data: %ShotGroup{}}
 
   """
-  @spec get_used_count_for_ammo_type(AmmoType.t(), User.t()) :: non_neg_integer()
-  def get_used_count_for_ammo_type(%AmmoType{id: ammo_type_id} = ammo_type, user) do
-    [ammo_type]
-    |> get_used_count_for_ammo_types(user)
-    |> Map.get(ammo_type_id, 0)
-  end
-
-  @doc """
-  Gets the total number of rounds shot for multiple ammo types
-
-  ## Examples
-
-      iex> get_used_count_for_ammo_types(123, %User{id: 123})
-      35
-
-  """
-  @spec get_used_count_for_ammo_types([AmmoType.t()], User.t()) ::
-          %{optional(AmmoType.id()) => non_neg_integer()}
-  def get_used_count_for_ammo_types(ammo_types, %User{id: user_id}) do
-    ammo_type_ids =
-      ammo_types
-      |> Enum.map(fn %AmmoType{id: ammo_type_id, user_id: ^user_id} -> ammo_type_id end)
-
-    Repo.all(
-      from ag in AmmoGroup,
-        left_join: sg in ShotGroup,
-        on: ag.id == sg.ammo_group_id,
-        where: ag.ammo_type_id in ^ammo_type_ids,
-        where: not (sg.count |> is_nil()),
-        group_by: ag.ammo_type_id,
-        select: {ag.ammo_type_id, sum(sg.count)}
-    )
-    |> Map.new()
+  @spec change_shot_group(ShotGroup.t() | ShotGroup.new_shot_group()) ::
+          Changeset.t(ShotGroup.t() | ShotGroup.new_shot_group())
+  @spec change_shot_group(ShotGroup.t() | ShotGroup.new_shot_group(), attrs :: map()) ::
+          Changeset.t(ShotGroup.t() | ShotGroup.new_shot_group())
+  def change_shot_group(%ShotGroup{} = shot_group, attrs \\ %{}) do
+    shot_group |> ShotGroup.update_changeset(attrs)
   end
 end

lib/cannery/activity_log/shot_group.ex

@@ -4,19 +4,10 @@ defmodule Cannery.ActivityLog.ShotGroup do
   """
 
   use Ecto.Schema
-  import CanneryWeb.Gettext
   import Ecto.Changeset
-  alias Cannery.{Accounts.User, Ammo, Ammo.AmmoGroup}
+  alias Cannery.{Accounts.User, ActivityLog.ShotGroup, Ammo.AmmoGroup}
   alias Ecto.{Changeset, UUID}
 
-  @derive {Jason.Encoder,
-           only: [
-             :id,
-             :count,
-             :date,
-             :notes,
-             :ammo_group_id
-           ]}
   @primary_key {:id, :binary_id, autogenerate: true}
   @foreign_key_type :binary_id
   schema "shot_groups" do
@@ -24,106 +15,43 @@ defmodule Cannery.ActivityLog.ShotGroup do
     field :date, :date
     field :notes, :string
 
-    field :user_id, :binary_id
-    field :ammo_group_id, :binary_id
+    belongs_to :user, User
+    belongs_to :ammo_group, AmmoGroup
 
     timestamps()
   end
 
-  @type t :: %__MODULE__{
+  @type t :: %ShotGroup{
           id: id(),
           count: integer,
           notes: String.t() | nil,
           date: Date.t() | nil,
+          ammo_group: AmmoGroup.t() | nil,
           ammo_group_id: AmmoGroup.id(),
+          user: User.t() | nil,
           user_id: User.id(),
           inserted_at: NaiveDateTime.t(),
           updated_at: NaiveDateTime.t()
         }
-  @type new_shot_group :: %__MODULE__{}
+  @type new_shot_group :: %ShotGroup{}
   @type id :: UUID.t()
-  @type changeset :: Changeset.t(t() | new_shot_group())
 
   @doc false
-  @spec create_changeset(
-          new_shot_group(),
-          User.t() | any(),
-          AmmoGroup.t() | any(),
-          attrs :: map()
-        ) :: changeset()
-  def create_changeset(
-        shot_group,
-        %User{id: user_id},
-        %AmmoGroup{id: ammo_group_id, user_id: user_id} = ammo_group,
-        attrs
-      ) do
+  @spec create_changeset(new_shot_group(), attrs :: map()) :: Changeset.t(new_shot_group())
+  def create_changeset(shot_group, attrs) do
     shot_group
-    |> change(user_id: user_id)
-    |> change(ammo_group_id: ammo_group_id)
-    |> cast(attrs, [:count, :notes, :date])
-    |> validate_length(:notes, max: 255)
-    |> validate_create_shot_group_count(ammo_group)
-    |> validate_required([:date, :ammo_group_id, :user_id])
-  end
-
-  def create_changeset(shot_group, _invalid_user, _invalid_ammo_group, attrs) do
-    shot_group
-    |> cast(attrs, [:count, :notes, :date])
-    |> validate_length(:notes, max: 255)
-    |> validate_required([:ammo_group_id, :user_id])
-    |> add_error(:invalid, dgettext("errors", "Please select a valid user and ammo pack"))
-  end
-
-  defp validate_create_shot_group_count(changeset, %AmmoGroup{count: ammo_group_count}) do
-    case changeset |> Changeset.get_field(:count) do
-      nil ->
-        changeset |> Changeset.add_error(:ammo_left, dgettext("errors", "can't be blank"))
-
-      count when count > ammo_group_count ->
-        changeset
-        |> Changeset.add_error(:ammo_left, dgettext("errors", "Ammo left must be at least 0"))
-
-      count when count <= 0 ->
-        error =
-          dgettext("errors", "Ammo left can be at most %{count} rounds",
-            count: ammo_group_count - 1
-          )
-
-        changeset |> Changeset.add_error(:ammo_left, error)
-
-      _valid_count ->
-        changeset
-    end
-  end
-
-  @doc false
-  @spec update_changeset(t() | new_shot_group(), User.t(), attrs :: map()) :: changeset()
-  def update_changeset(%__MODULE__{} = shot_group, user, attrs) do
-    shot_group
-    |> cast(attrs, [:count, :notes, :date])
-    |> validate_length(:notes, max: 255)
+    |> cast(attrs, [:count, :notes, :date, :ammo_group_id, :user_id])
     |> validate_number(:count, greater_than: 0)
-    |> validate_required([:count, :date])
-    |> validate_update_shot_group_count(shot_group, user)
+    |> validate_required([:count, :ammo_group_id, :user_id])
   end
 
-  defp validate_update_shot_group_count(
-         changeset,
-         %__MODULE__{ammo_group_id: ammo_group_id, count: count},
-         user
-       ) do
-    %{count: ammo_group_count} = Ammo.get_ammo_group!(ammo_group_id, user)
-
-    new_shot_group_count = changeset |> Changeset.get_field(:count)
-    shot_diff_to_add = new_shot_group_count - count
-
-    if shot_diff_to_add > ammo_group_count do
-      error =
-        dgettext("errors", "Count can be at most %{count} shots", count: ammo_group_count + count)
-
-      changeset |> Changeset.add_error(:count, error)
-    else
-      changeset
-    end
+  @doc false
+  @spec update_changeset(t() | new_shot_group(), attrs :: map()) ::
+          Changeset.t(t() | new_shot_group())
+  def update_changeset(shot_group, attrs) do
+    shot_group
+    |> cast(attrs, [:count, :notes, :date])
+    |> validate_number(:count, greater_than: 0)
+    |> validate_required([:count])
   end
 end

lib/cannery/ammo/ammo_group.ex

@@ -7,22 +7,11 @@ defmodule Cannery.Ammo.AmmoGroup do
   """
 
   use Ecto.Schema
-  import CanneryWeb.Gettext
   import Ecto.Changeset
-  alias Cannery.Ammo.AmmoType
-  alias Cannery.{Accounts.User, Containers, Containers.Container}
+  alias Cannery.Ammo.{AmmoGroup, AmmoType}
+  alias Cannery.{Accounts.User, ActivityLog.ShotGroup, Containers.Container}
   alias Ecto.{Changeset, UUID}
 
-  @derive {Jason.Encoder,
-           only: [
-             :id,
-             :count,
-             :notes,
-             :price_paid,
-             :staged,
-             :ammo_type_id,
-             :container_id
-           ]}
   @primary_key {:id, :binary_id, autogenerate: true}
   @foreign_key_type :binary_id
   schema "ammo_groups" do
@@ -30,96 +19,62 @@ defmodule Cannery.Ammo.AmmoGroup do
     field :notes, :string
     field :price_paid, :float
     field :staged, :boolean, default: false
-    field :purchased_on, :date
 
     belongs_to :ammo_type, AmmoType
-    field :container_id, :binary_id
-    field :user_id, :binary_id
+    belongs_to :container, Container
+    belongs_to :user, User
+
+    has_many :shot_groups, ShotGroup
 
     timestamps()
   end
 
-  @type t :: %__MODULE__{
+  @type t :: %AmmoGroup{
           id: id(),
           count: integer,
           notes: String.t() | nil,
           price_paid: float() | nil,
           staged: boolean(),
-          purchased_on: Date.t(),
           ammo_type: AmmoType.t() | nil,
           ammo_type_id: AmmoType.id(),
+          container: Container.t() | nil,
           container_id: Container.id(),
+          user: User.t() | nil,
           user_id: User.id(),
           inserted_at: NaiveDateTime.t(),
           updated_at: NaiveDateTime.t()
         }
-  @type new_ammo_group :: %__MODULE__{}
+  @type new_ammo_group :: %AmmoGroup{}
   @type id :: UUID.t()
-  @type changeset :: Changeset.t(t() | new_ammo_group())
 
   @doc false
-  @spec create_changeset(
-          new_ammo_group(),
-          AmmoType.t() | nil,
-          Container.t() | nil,
-          User.t(),
-          attrs :: map()
-        ) :: changeset()
-  def create_changeset(
-        ammo_group,
-        %AmmoType{id: ammo_type_id},
-        %Container{id: container_id, user_id: user_id},
-        %User{id: user_id},
-        attrs
-      )
-      when is_binary(ammo_type_id) and is_binary(container_id) and is_binary(user_id) do
+  @spec create_changeset(new_ammo_group(), attrs :: map()) :: Changeset.t(new_ammo_group())
+  def create_changeset(ammo_group, attrs) do
     ammo_group
-    |> change(ammo_type_id: ammo_type_id)
-    |> change(user_id: user_id)
-    |> change(container_id: container_id)
-    |> cast(attrs, [:count, :price_paid, :notes, :staged, :purchased_on])
+    |> cast(attrs, [:count, :price_paid, :notes, :staged, :ammo_type_id, :container_id, :user_id])
     |> validate_number(:count, greater_than: 0)
-    |> validate_required([:count, :staged, :purchased_on, :ammo_type_id, :container_id, :user_id])
-  end
-
-  @doc """
-  Invalid changeset, used to prompt user to select ammo type and container
-  """
-  def create_changeset(ammo_group, _invalid_ammo_type, _invalid_container, _invalid_user, attrs) do
-    ammo_group
-    |> cast(attrs, [:ammo_type_id, :container_id])
-    |> validate_required([:ammo_type_id, :container_id])
-    |> add_error(:invalid, dgettext("errors", "Please select an ammo type and container"))
+    |> validate_required([:count, :staged, :ammo_type_id, :container_id, :user_id])
   end
 
   @doc false
-  @spec update_changeset(t() | new_ammo_group(), attrs :: map(), User.t()) :: changeset()
-  def update_changeset(ammo_group, attrs, user) do
+  @spec update_changeset(t() | new_ammo_group(), attrs :: map()) ::
+          Changeset.t(t() | new_ammo_group())
+  def update_changeset(ammo_group, attrs) do
     ammo_group
-    |> cast(attrs, [:count, :price_paid, :notes, :staged, :purchased_on, :container_id])
+    |> cast(attrs, [:count, :price_paid, :notes, :staged, :ammo_type_id, :container_id])
     |> validate_number(:count, greater_than_or_equal_to: 0)
-    |> validate_container_id(user)
-    |> validate_required([:count, :staged, :purchased_on, :container_id])
-  end
-
-  defp validate_container_id(changeset, user) do
-    container_id = changeset |> Changeset.get_field(:container_id)
-
-    if container_id do
-      Containers.get_container!(container_id, user)
-    end
-
-    changeset
+    |> validate_required([:count, :staged, :ammo_type_id, :container_id, :user_id])
   end
 
   @doc """
   This range changeset is used when "using up" ammo groups, and allows for
   updating the count to 0
   """
-  @spec range_changeset(t() | new_ammo_group(), attrs :: map()) :: changeset()
+  @spec range_changeset(t() | new_ammo_group(), attrs :: map()) ::
+          Changeset.t(t() | new_ammo_group())
   def range_changeset(ammo_group, attrs) do
     ammo_group
     |> cast(attrs, [:count, :staged])
-    |> validate_required([:count, :staged])
+    |> validate_required([:count, :staged, :ammo_type_id, :container_id, :user_id])
   end
 end

lib/cannery/ammo/ammo_type.ex

@@ -8,91 +8,48 @@ defmodule Cannery.Ammo.AmmoType do
   use Ecto.Schema
   import Ecto.Changeset
   alias Cannery.Accounts.User
-  alias Cannery.Ammo.AmmoGroup
+  alias Cannery.Ammo.{AmmoGroup, AmmoType}
   alias Ecto.{Changeset, UUID}
 
-  @derive {Jason.Encoder,
-           only: [
-             :id,
-             :name,
-             :desc,
-             :bullet_type,
-             :bullet_core,
-             :cartridge,
-             :caliber,
-             :case_material,
-             :jacket_type,
-             :muzzle_velocity,
-             :powder_type,
-             :powder_grains_per_charge,
-             :grains,
-             :pressure,
-             :primer_type,
-             :firing_type,
-             :tracer,
-             :incendiary,
-             :blank,
-             :corrosive,
-             :manufacturer,
-             :upc
-           ]}
   @primary_key {:id, :binary_id, autogenerate: true}
   @foreign_key_type :binary_id
   schema "ammo_types" do
     field :name, :string
     field :desc, :string
 
-    field :type, Ecto.Enum, values: [:rifle, :shotgun, :pistol]
-
-    # common fields
-    # https://shootersreference.com/reloadingdata/bullet_abbreviations/
+    # https://en.wikipedia.org/wiki/Bullet#Abbreviations
     field :bullet_type, :string
     field :bullet_core, :string
-    # also gauge for shotguns
+    field :cartridge, :string
     field :caliber, :string
     field :case_material, :string
+    field :jacket_type, :string
+    field :muzzle_velocity, :integer
     field :powder_type, :string
+    field :powder_grains_per_charge, :integer
     field :grains, :integer
     field :pressure, :string
     field :primer_type, :string
     field :firing_type, :string
-    field :manufacturer, :string
-    field :upc, :string
-
     field :tracer, :boolean, default: false
     field :incendiary, :boolean, default: false
     field :blank, :boolean, default: false
     field :corrosive, :boolean, default: false
 
-    # rifle/pistol fields
-    field :cartridge, :string
-    field :jacket_type, :string
-    field :powder_grains_per_charge, :integer
-    field :muzzle_velocity, :integer
+    field :manufacturer, :string
+    field :upc, :string
 
-    # shotgun fields
-    field :wadding, :string
-    field :shot_type, :string
-    field :shot_material, :string
-    field :shot_size, :string
-    field :unfired_length, :string
-    field :brass_height, :string
-    field :chamber_size, :string
-    field :load_grains, :integer
-    field :shot_charge_weight, :string
-    field :dram_equivalent, :string
+    belongs_to :user, User
 
-    field :user_id, :binary_id
     has_many :ammo_groups, AmmoGroup
 
     timestamps()
   end
 
-  @type t :: %__MODULE__{
+  @type t :: %AmmoType{
           id: id(),
           name: String.t(),
           desc: String.t() | nil,
-          type: type(),
           bullet_type: String.t() | nil,
           bullet_core: String.t() | nil,
           cartridge: String.t() | nil,
@@ -106,16 +63,6 @@ defmodule Cannery.Ammo.AmmoType do
           pressure: String.t() | nil,
           primer_type: String.t() | nil,
           firing_type: String.t() | nil,
-          wadding: String.t() | nil,
-          shot_type: String.t() | nil,
-          shot_material: String.t() | nil,
-          shot_size: String.t() | nil,
-          unfired_length: String.t() | nil,
-          brass_height: String.t() | nil,
-          chamber_size: String.t() | nil,
-          load_grains: integer() | nil,
-          shot_charge_weight: String.t() | nil,
-          dram_equivalent: String.t() | nil,
           tracer: boolean(),
           incendiary: boolean(),
           blank: boolean(),
@@ -123,21 +70,19 @@ defmodule Cannery.Ammo.AmmoType do
           manufacturer: String.t() | nil,
           upc: String.t() | nil,
           user_id: User.id(),
+          user: User.t() | nil,
           ammo_groups: [AmmoGroup.t()] | nil,
           inserted_at: NaiveDateTime.t(),
           updated_at: NaiveDateTime.t()
         }
-  @type new_ammo_type :: %__MODULE__{}
+  @type new_ammo_type :: %AmmoType{}
   @type id :: UUID.t()
-  @type changeset :: Changeset.t(t() | new_ammo_type())
-  @type type :: :rifle | :shotgun | :pistol | nil
 
   @spec changeset_fields() :: [atom()]
   defp changeset_fields,
     do: [
       :name,
       :desc,
-      :type,
       :bullet_type,
       :bullet_core,
       :cartridge,
@@ -151,16 +96,6 @@ defmodule Cannery.Ammo.AmmoType do
       :pressure,
       :primer_type,
       :firing_type,
-      :wadding,
-      :shot_type,
-      :shot_material,
-      :shot_size,
-      :unfired_length,
-      :brass_height,
-      :chamber_size,
-      :load_grains,
-      :shot_charge_weight,
-      :dram_equivalent,
       :tracer,
       :incendiary,
       :blank,
@@ -169,55 +104,20 @@ defmodule Cannery.Ammo.AmmoType do
       :upc
     ]
 
-  @spec string_fields() :: [atom()]
-  defp string_fields,
-    do: [
-      :name,
-      :bullet_type,
-      :bullet_core,
-      :cartridge,
-      :caliber,
-      :case_material,
-      :jacket_type,
-      :powder_type,
-      :pressure,
-      :primer_type,
-      :firing_type,
-      :wadding,
-      :shot_type,
-      :shot_material,
-      :shot_size,
-      :unfired_length,
-      :brass_height,
-      :chamber_size,
-      :shot_charge_weight,
-      :dram_equivalent,
-      :manufacturer,
-      :upc
-    ]
-
   @doc false
-  @spec create_changeset(new_ammo_type(), User.t(), attrs :: map()) :: changeset()
-  def create_changeset(ammo_type, %User{id: user_id}, attrs) do
-    changeset =
-      ammo_type
-      |> change(user_id: user_id)
-      |> cast(attrs, changeset_fields())
-
-    string_fields()
-    |> Enum.reduce(changeset, fn field, acc -> acc |> validate_length(field, max: 255) end)
+  @spec create_changeset(new_ammo_type(), attrs :: map()) :: Changeset.t(new_ammo_type())
+  def create_changeset(ammo_type, attrs) do
+    ammo_type
+    |> cast(attrs, [:user_id | changeset_fields()])
     |> validate_required([:name, :user_id])
   end
 
   @doc false
-  @spec update_changeset(t() | new_ammo_type(), attrs :: map()) :: changeset()
+  @spec update_changeset(t() | new_ammo_type(), attrs :: map()) ::
+          Changeset.t(t() | new_ammo_type())
   def update_changeset(ammo_type, attrs) do
-    changeset =
-      ammo_type
-      |> cast(attrs, changeset_fields())
-
-    string_fields()
-    |> Enum.reduce(changeset, fn field, acc -> acc |> validate_length(field, max: 255) end)
-    |> validate_required(:name)
+    ammo_type
+    |> cast(attrs, changeset_fields())
+    |> validate_required([:name, :user_id])
   end
 end

lib/cannery/application.ex

@@ -4,7 +4,6 @@ defmodule Cannery.Application do
   @moduledoc false
 
   use Application
-  alias Cannery.Logger
 
   @impl true
   def start(_type, _args) do
@@ -18,24 +17,16 @@ defmodule Cannery.Application do
       # Start the Endpoint (http/https)
       CanneryWeb.Endpoint,
       # Add Oban
-      {Oban, oban_config()},
-      Cannery.Repo.Migrator
+      {Oban, oban_config()}
       # Start a worker by calling: Cannery.Worker.start_link(arg)
       # {Cannery.Worker, arg}
     ]
 
-    # Oban events logging https://hexdocs.pm/oban/Oban.html#module-reporting-errors
-    :ok =
-      :telemetry.attach_many(
-        "oban-logger",
-        [
-          [:oban, :job, :exception],
-          [:oban, :job, :start],
-          [:oban, :job, :stop]
-        ],
-        &Logger.handle_event/4,
-        []
-      )
+    # Automatically migrate on start in prod
+    children =
+      if Application.get_env(:cannery, Cannery.Application, automigrate: false)[:automigrate],
+        do: children ++ [Cannery.Repo.Migrator],
+        else: children
 
     # See https://hexdocs.pm/elixir/Supervisor.html
     # for other strategies and supported options

lib/cannery/comparable_date.ex

@@ -1,12 +0,0 @@
-defmodule Cannery.ComparableDate do
-  @moduledoc """
-  A custom `Date` module that provides a `compare/2` function that is comparable
-  with nil values
-  """
-
-  @spec compare(Date.t() | any(), Date.t() | any()) :: :lt | :gt | :eq
-  def compare(%Date{} = date_1, %Date{} = date_2), do: Date.compare(date_1, date_2)
-  def compare(%Date{}, _date_2), do: :lt
-  def compare(_date_1, %Date{}), do: :gt
-  def compare(_date_1, _date_2), do: :eq
-end

lib/cannery/comparable_datetime.ex

@@ -1,15 +0,0 @@
-defmodule Cannery.ComparableDateTime do
-  @moduledoc """
-  A custom `DateTime` module that provides a `compare/2` function that is
-  comparable with nil values
-  """
-
-  @spec compare(DateTime.t() | any(), DateTime.t() | any()) :: :lt | :gt | :eq
-  def compare(%DateTime{} = datetime_1, %DateTime{} = datetime_2) do
-    DateTime.compare(datetime_1, datetime_2)
-  end
-
-  def compare(%DateTime{}, _datetime_2), do: :lt
-  def compare(_datetime_1, %DateTime{}), do: :gt
-  def compare(_datetime_1, _datetime_2), do: :eq
-end

lib/cannery/containers.ex

@@ -5,12 +5,10 @@ defmodule Cannery.Containers do
 
   import CanneryWeb.Gettext
   import Ecto.Query, warn: false
-  alias Cannery.{Accounts.User, Ammo.AmmoGroup, Repo}
-  alias Cannery.Containers.{Container, ContainerTag, Tag}
+  alias Cannery.{Accounts.User, Ammo.AmmoGroup, Repo, Tags.Tag}
+  alias Cannery.Containers.{Container, ContainerTag}
   alias Ecto.Changeset
 
-  @container_preloads [:tags]
-
   @doc """
   Returns the list of containers.
 
@@ -19,80 +17,23 @@ defmodule Cannery.Containers do
       iex> list_containers(%User{id: 123})
       [%Container{}, ...]
 
-      iex> list_containers("cool", %User{id: 123})
-      [%Container{name: "my cool container"}, ...]
-
   """
   @spec list_containers(User.t()) :: [Container.t()]
-  @spec list_containers(search :: nil | String.t(), User.t()) :: [Container.t()]
-  def list_containers(search \\ nil, %User{id: user_id}) do
-    from(c in Container,
-      as: :c,
-      left_join: t in assoc(c, :tags),
-      as: :t,
-      where: c.user_id == ^user_id,
-      order_by: c.name,
-      distinct: c.id,
-      preload: ^@container_preloads
-    )
-    |> list_containers_search(search)
-    |> Repo.all()
-  end
-
-  defp list_containers_search(query, nil), do: query
-  defp list_containers_search(query, ""), do: query
-
-  defp list_containers_search(query, search) do
-    trimmed_search = String.trim(search)
-
-    query
-    |> where(
-      [c: c, t: t],
-      fragment(
-        "? @@ websearch_to_tsquery('english', ?)",
-        c.search,
-        ^trimmed_search
-      ) or
-        fragment(
-          "? @@ websearch_to_tsquery('english', ?)",
-          t.search,
-          ^trimmed_search
-        )
-    )
-    |> order_by(
-      [c: c],
-      desc:
-        fragment(
-          "ts_rank_cd(?, websearch_to_tsquery('english', ?), 4)",
-          c.search,
-          ^trimmed_search
-        )
-    )
-  end
-
-  @doc """
-  Returns a count of containers.
-
-  ## Examples
-
-      iex> get_containers_count!(%User{id: 123})
-      3
-
-  """
-  @spec get_containers_count!(User.t()) :: integer()
-  def get_containers_count!(%User{id: user_id}) do
-    Repo.one(
+  def list_containers(%User{id: user_id}) do
+    Repo.all(
       from c in Container,
+        left_join: t in assoc(c, :tags),
+        left_join: ag in assoc(c, :ammo_groups),
         where: c.user_id == ^user_id,
-        select: count(c.id),
-        distinct: true
+        order_by: c.name,
+        preload: [tags: t, ammo_groups: ag]
     )
   end
 
   @doc """
   Gets a single container.
 
-  Raises `KeyError` if the Container does not exist.
+  Raises `Ecto.NoResultsError` if the Container does not exist.
 
   ## Examples
 
@@ -100,37 +41,20 @@ defmodule Cannery.Containers do
       %Container{}
 
       iex> get_container!(456, %User{id: 123})
-      ** (KeyError)
+      ** (Ecto.NoResultsError)
 
   """
   @spec get_container!(Container.id(), User.t()) :: Container.t()
-  def get_container!(id, user) do
-    [id]
-    |> get_containers(user)
-    |> Map.fetch!(id)
-  end
-
-  @doc """
-  Gets multiple containers.
-
-
-  ## Examples
-
-      iex> get_containers([123], %User{id: 123})
-      %{123 => %Container{}}
-
-  """
-  @spec get_containers([Container.id()], User.t()) :: %{optional(Container.id()) => Container.t()}
-  def get_containers(ids, %User{id: user_id}) do
-    Repo.all(
+  def get_container!(id, %User{id: user_id}) do
+    Repo.one!(
       from c in Container,
+        left_join: t in assoc(c, :tags),
+        left_join: ag in assoc(c, :ammo_groups),
         where: c.user_id == ^user_id,
-        where: c.id in ^ids,
+        where: c.id == ^id,
         order_by: c.name,
-        preload: ^@container_preloads,
-        select: {c.id, c}
+        preload: [tags: t, ammo_groups: ag]
     )
-    |> Map.new()
   end
 
   @doc """
@@ -146,21 +70,10 @@ defmodule Cannery.Containers do
 
   """
   @spec create_container(attrs :: map(), User.t()) ::
-          {:ok, Container.t()} | {:error, Container.changeset()}
-  def create_container(attrs, %User{} = user) do
-    %Container{}
-    |> Container.create_changeset(user, attrs)
-    |> Repo.insert()
-    |> case do
-      {:ok, container} -> {:ok, container |> preload_container()}
-      {:error, changeset} -> {:error, changeset}
-    end
-  end
-
-  @spec preload_container(Container.t()) :: Container.t()
-  @spec preload_container([Container.t()]) :: [Container.t()]
-  def preload_container(container) do
-    container |> Repo.preload(@container_preloads)
+          {:ok, Container.t()} | {:error, Changeset.t(Container.new_container())}
+  def create_container(attrs, %User{id: user_id}) do
+    attrs = attrs |> Map.put("user_id", user_id)
+    %Container{} |> Container.create_changeset(attrs) |> Repo.insert()
   end
 
   @doc """
@@ -176,15 +89,9 @@ defmodule Cannery.Containers do
 
   """
   @spec update_container(Container.t(), User.t(), attrs :: map()) ::
-          {:ok, Container.t()} | {:error, Container.changeset()}
+          {:ok, Container.t()} | {:error, Changeset.t(Container.t())}
   def update_container(%Container{user_id: user_id} = container, %User{id: user_id}, attrs) do
-    container
-    |> Container.update_changeset(attrs)
-    |> Repo.update()
-    |> case do
-      {:ok, container} -> {:ok, container |> preload_container()}
-      {:error, changeset} -> {:error, changeset}
-    end
+    container |> Container.update_changeset(attrs) |> Repo.update()
   end
 
   @doc """
@@ -200,7 +107,7 @@ defmodule Cannery.Containers do
 
   """
   @spec delete_container(Container.t(), User.t()) ::
-          {:ok, Container.t()} | {:error, Container.changeset()}
+          {:ok, Container.t()} | {:error, Changeset.t(Container.t())}
   def delete_container(%Container{user_id: user_id} = container, %User{id: user_id}) do
     Repo.one(
       from ag in AmmoGroup,
@@ -209,18 +116,13 @@ defmodule Cannery.Containers do
     )
     |> case do
       0 ->
-        container
-        |> Repo.delete()
-        |> case do
-          {:ok, container} -> {:ok, container |> preload_container()}
-          {:error, changeset} -> {:error, changeset}
-        end
+        container |> Repo.delete()
 
       _amount ->
         error = dgettext("errors", "Container must be empty before deleting")
 
         container
-        |> Container.update_changeset(%{})
+        |> change_container()
         |> Changeset.add_error(:ammo_groups, error)
         |> Changeset.apply_action(:delete)
     end
@@ -241,6 +143,25 @@ defmodule Cannery.Containers do
     container
   end
 
+  @doc """
+  Returns an `%Changeset{}` for tracking container changes.
+
+  ## Examples
+
+      iex> change_container(container)
+      %Changeset{data: %Container{}}
+
+      iex> change_container(%Changeset{})
+      %Changeset{data: %Container{}}
+
+  """
+  @spec change_container(Container.t() | Container.new_container()) ::
+          Changeset.t(Container.t() | Container.new_container())
+  @spec change_container(Container.t() | Container.new_container(), attrs :: map()) ::
+          Changeset.t(Container.t() | Container.new_container())
+  def change_container(container, attrs \\ %{}),
+    do: container |> Container.update_changeset(attrs)
+
   @doc """
   Adds a tag to a container
 
@@ -252,12 +173,12 @@ defmodule Cannery.Containers do
   """
   @spec add_tag!(Container.t(), Tag.t(), User.t()) :: ContainerTag.t()
   def add_tag!(
-        %Container{user_id: user_id} = container,
-        %Tag{user_id: user_id} = tag,
+        %Container{id: container_id, user_id: user_id},
+        %Tag{id: tag_id, user_id: user_id},
         %User{id: user_id}
       ) do
     %ContainerTag{}
-    |> ContainerTag.create_changeset(tag, container)
+    |> ContainerTag.changeset(%{"container_id" => container_id, "tag_id" => tag_id})
     |> Repo.insert!()
   end
 
@@ -270,175 +191,32 @@ defmodule Cannery.Containers do
       %Container{}
 
   """
-  @spec remove_tag!(Container.t(), Tag.t(), User.t()) :: {non_neg_integer(), [ContainerTag.t()]}
+  @spec remove_tag!(Container.t(), Tag.t(), User.t()) :: non_neg_integer()
   def remove_tag!(
         %Container{id: container_id, user_id: user_id},
         %Tag{id: tag_id, user_id: user_id},
         %User{id: user_id}
       ) do
-    {count, results} =
+    {count, _} =
       Repo.delete_all(
         from ct in ContainerTag,
           where: ct.container_id == ^container_id,
-          where: ct.tag_id == ^tag_id,
-          select: ct
+          where: ct.tag_id == ^tag_id
       )
 
-    if count == 0, do: raise("could not delete container tag"), else: {count, results}
-  end
-
-  # Container Tags
-
-  @doc """
-  Returns the list of tags.
-
-  ## Examples
-
-      iex> list_tags(%User{id: 123})
-      [%Tag{}, ...]
-
-      iex> list_tags("cool", %User{id: 123})
-      [%Tag{name: "my cool tag"}, ...]
-
-  """
-  @spec list_tags(User.t()) :: [Tag.t()]
-  @spec list_tags(search :: nil | String.t(), User.t()) :: [Tag.t()]
-  def list_tags(search \\ nil, user)
-
-  def list_tags(search, %{id: user_id}) when search |> is_nil() or search == "",
-    do: Repo.all(from t in Tag, where: t.user_id == ^user_id, order_by: t.name)
-
-  def list_tags(search, %{id: user_id}) when search |> is_binary() do
-    trimmed_search = String.trim(search)
-
-    Repo.all(
-      from t in Tag,
-        where: t.user_id == ^user_id,
-        where:
-          fragment(
-            "? @@ websearch_to_tsquery('english', ?)",
-            t.search,
-            ^trimmed_search
-          ),
-        order_by: {
-          :desc,
-          fragment(
-            "ts_rank_cd(?, websearch_to_tsquery('english', ?), 4)",
-            t.search,
-            ^trimmed_search
-          )
-        }
-    )
+    if count == 0, do: raise("could not delete container tag"), else: count
   end
 
   @doc """
-  Gets a single tag.
-
-  ## Examples
-
-      iex> get_tag(123, %User{id: 123})
-      {:ok, %Tag{}}
-
-      iex> get_tag(456, %User{id: 123})
-      {:error, :not_found}
-
+  Returns number of rounds in container. If data is already preloaded, then
+  there will be no db hit.
   """
-  @spec get_tag(Tag.id(), User.t()) :: {:ok, Tag.t()} | {:error, :not_found}
-  def get_tag(id, %User{id: user_id}) do
-    Repo.one(from t in Tag, where: t.id == ^id and t.user_id == ^user_id)
-    |> case do
-      nil -> {:error, :not_found}
-      tag -> {:ok, tag}
-    end
-  end
-
-  @doc """
-  Gets a single tag.
-
-  Raises `Ecto.NoResultsError` if the Tag does not exist.
-
-  ## Examples
-
-      iex> get_tag!(123, %User{id: 123})
-      %Tag{}
-
-      iex> get_tag!(456, %User{id: 123})
-      ** (Ecto.NoResultsError)
-
-  """
-  @spec get_tag!(Tag.id(), User.t()) :: Tag.t()
-  def get_tag!(id, %User{id: user_id}) do
-    Repo.one!(
-      from t in Tag,
-        where: t.id == ^id,
-        where: t.user_id == ^user_id
-    )
-  end
-
-  @doc """
-  Creates a tag.
-
-  ## Examples
-
-      iex> create_tag(%{field: value}, %User{id: 123})
-      {:ok, %Tag{}}
-
-      iex> create_tag(%{field: bad_value}, %User{id: 123})
-      {:error, %Changeset{}}
-
-  """
-  @spec create_tag(attrs :: map(), User.t()) ::
-          {:ok, Tag.t()} | {:error, Tag.changeset()}
-  def create_tag(attrs, %User{} = user) do
-    %Tag{} |> Tag.create_changeset(user, attrs) |> Repo.insert()
-  end
-
-  @doc """
-  Updates a tag.
-
-  ## Examples
-
-      iex> update_tag(tag, %{field: new_value}, %User{id: 123})
-      {:ok, %Tag{}}
-
-      iex> update_tag(tag, %{field: bad_value}, %User{id: 123})
-      {:error, %Changeset{}}
-
-  """
-  @spec update_tag(Tag.t(), attrs :: map(), User.t()) ::
-          {:ok, Tag.t()} | {:error, Tag.changeset()}
-  def update_tag(%Tag{user_id: user_id} = tag, attrs, %User{id: user_id}) do
-    tag |> Tag.update_changeset(attrs) |> Repo.update()
-  end
-
-  @doc """
-  Deletes a tag.
-
-  ## Examples
-
-      iex> delete_tag(tag, %User{id: 123})
-      {:ok, %Tag{}}
-
-      iex> delete_tag(tag, %User{id: 123})
-      {:error, %Changeset{}}
-
-  """
-  @spec delete_tag(Tag.t(), User.t()) :: {:ok, Tag.t()} | {:error, Tag.changeset()}
-  def delete_tag(%Tag{user_id: user_id} = tag, %User{id: user_id}) do
-    tag |> Repo.delete()
-  end
-
-  @doc """
-  Deletes a tag.
-
-  ## Examples
-
-      iex> delete_tag!(tag, %User{id: 123})
-      %Tag{}
-
-  """
-  @spec delete_tag!(Tag.t(), User.t()) :: Tag.t()
-  def delete_tag!(%Tag{user_id: user_id} = tag, %User{id: user_id}) do
-    tag |> Repo.delete!()
+  @spec get_container_rounds!(Container.t()) :: non_neg_integer()
+  def get_container_rounds!(%Container{} = container) do
+    container
+    |> Repo.preload(:ammo_groups)
+    |> Map.fetch!(:ammo_groups)
+    |> Enum.map(fn %{count: count} -> count end)
+    |> Enum.sum()
   end
 end

lib/cannery/containers/container.ex

@@ -6,17 +6,9 @@ defmodule Cannery.Containers.Container do
   use Ecto.Schema
   import Ecto.Changeset
   alias Ecto.{Changeset, UUID}
-  alias Cannery.{Accounts.User, Containers.ContainerTag, Containers.Tag}
+  alias Cannery.Containers.{Container, ContainerTag}
+  alias Cannery.{Accounts.User, Ammo.AmmoGroup, Tags.Tag}
 
-  @derive {Jason.Encoder,
-           only: [
-             :id,
-             :name,
-             :desc,
-             :location,
-             :type,
-             :tags
-           ]}
   @primary_key {:id, :binary_id, autogenerate: true}
   @foreign_key_type :binary_id
   schema "containers" do
@@ -25,46 +17,44 @@ defmodule Cannery.Containers.Container do
     field :location, :string
     field :type, :string
 
-    field :user_id, :binary_id
+    belongs_to :user, User
 
+    has_many :ammo_groups, AmmoGroup
     many_to_many :tags, Tag, join_through: ContainerTag
 
     timestamps()
   end
 
-  @type t :: %__MODULE__{
+  @type t :: %Container{
           id: id(),
           name: String.t(),
           desc: String.t(),
           location: String.t(),
           type: String.t(),
+          user: User.t(),
           user_id: User.id(),
+          ammo_groups: [AmmoGroup.t()] | nil,
           tags: [Tag.t()] | nil,
           inserted_at: NaiveDateTime.t(),
           updated_at: NaiveDateTime.t()
         }
-  @type new_container :: %__MODULE__{}
+  @type new_container :: %Container{}
   @type id :: UUID.t()
-  @type changeset :: Changeset.t(t() | new_container())
 
   @doc false
-  @spec create_changeset(new_container(), User.t(), attrs :: map()) :: changeset()
-  def create_changeset(container, %User{id: user_id}, attrs) do
+  @spec create_changeset(new_container(), attrs :: map()) :: Changeset.t(new_container())
+  def create_changeset(container, attrs) do
     container
-    |> change(user_id: user_id)
-    |> cast(attrs, [:name, :desc, :type, :location])
-    |> validate_length(:name, max: 255)
-    |> validate_length(:type, max: 255)
+    |> cast(attrs, [:name, :desc, :type, :location, :user_id])
     |> validate_required([:name, :type, :user_id])
   end
 
   @doc false
-  @spec update_changeset(t() | new_container(), attrs :: map()) :: changeset()
+  @spec update_changeset(t() | new_container(), attrs :: map()) ::
+          Changeset.t(t() | new_container())
   def update_changeset(container, attrs) do
     container
     |> cast(attrs, [:name, :desc, :type, :location])
-    |> validate_length(:name, max: 255)
-    |> validate_length(:type, max: 255)
-    |> validate_required([:name, :type])
+    |> validate_required([:name, :type, :user_id])
   end
 end

lib/cannery/containers/container_tag.ex

@@ -1,12 +1,12 @@
 defmodule Cannery.Containers.ContainerTag do
   @moduledoc """
   Thru-table struct for associating Cannery.Containers.Container and
-  Cannery.Containers.Tag.
+  Cannery.Tags.Tag.
   """
 
   use Ecto.Schema
   import Ecto.Changeset
-  alias Cannery.Containers.{Container, Tag}
+  alias Cannery.{Containers.Container, Containers.ContainerTag, Tags.Tag}
   alias Ecto.{Changeset, UUID}
 
   @primary_key {:id, :binary_id, autogenerate: true}
@@ -18,7 +18,7 @@ defmodule Cannery.Containers.ContainerTag do
     timestamps()
   end
 
-  @type t :: %__MODULE__{
+  @type t :: %ContainerTag{
           id: id(),
           container: Container.t(),
           container_id: Container.id(),
@@ -27,20 +27,14 @@ defmodule Cannery.Containers.ContainerTag do
           inserted_at: NaiveDateTime.t(),
           updated_at: NaiveDateTime.t()
         }
-  @type new_container_tag :: %__MODULE__{}
+  @type new_container_tag :: %ContainerTag{}
   @type id :: UUID.t()
-  @type changeset :: Changeset.t(t() | new_container_tag())
 
   @doc false
-  @spec create_changeset(new_container_tag(), Tag.t(), Container.t()) :: changeset()
-  def create_changeset(
-        container_tag,
-        %Tag{id: tag_id, user_id: user_id},
-        %Container{id: container_id, user_id: user_id}
-      ) do
+  @spec changeset(new_container_tag(), attrs :: map()) :: Changeset.t(new_container_tag())
+  def changeset(container_tag, attrs) do
     container_tag
-    |> change(tag_id: tag_id)
-    |> change(container_id: container_id)
+    |> cast(attrs, [:tag_id, :container_id])
     |> validate_required([:tag_id, :container_id])
   end
 end

lib/cannery/containers/tag.ex

@@ -1,66 +0,0 @@
-defmodule Cannery.Containers.Tag do
-  @moduledoc """
-  Tags are added to containers to help organize, and can include custom-defined
-  text and bg colors.
-  """
-
-  use Ecto.Schema
-  import Ecto.Changeset
-  alias Cannery.Accounts.User
-  alias Ecto.{Changeset, UUID}
-
-  @derive {Jason.Encoder,
-           only: [
-             :id,
-             :name,
-             :bg_color,
-             :text_color
-           ]}
-  @primary_key {:id, :binary_id, autogenerate: true}
-  @foreign_key_type :binary_id
-  schema "tags" do
-    field :name, :string
-    field :bg_color, :string
-    field :text_color, :string
-
-    field :user_id, :binary_id
-
-    timestamps()
-  end
-
-  @type t :: %__MODULE__{
-          id: id(),
-          name: String.t(),
-          bg_color: String.t(),
-          text_color: String.t(),
-          user_id: User.id(),
-          inserted_at: NaiveDateTime.t(),
-          updated_at: NaiveDateTime.t()
-        }
-  @type new_tag() :: %__MODULE__{}
-  @type id() :: UUID.t()
-  @type changeset() :: Changeset.t(t() | new_tag())
-
-  @doc false
-  @spec create_changeset(new_tag(), User.t(), attrs :: map()) :: changeset()
-  def create_changeset(tag, %User{id: user_id}, attrs) do
-    tag
-    |> change(user_id: user_id)
-    |> cast(attrs, [:name, :bg_color, :text_color])
-    |> validate_length(:name, max: 255)
-    |> validate_length(:bg_color, max: 12)
-    |> validate_length(:text_color, max: 12)
-    |> validate_required([:name, :bg_color, :text_color, :user_id])
-  end
-
-  @doc false
-  @spec update_changeset(t() | new_tag(), attrs :: map()) :: changeset()
-  def update_changeset(tag, attrs) do
-    tag
-    |> cast(attrs, [:name, :bg_color, :text_color])
-    |> validate_length(:name, max: 255)
-    |> validate_length(:bg_color, max: 12)
-    |> validate_length(:text_color, max: 12)
-    |> validate_required([:name, :bg_color, :text_color])
-  end
-end

lib/cannery/invites.ex

@@ -0,0 +1,173 @@
+defmodule Cannery.Invites do
+  @moduledoc """
+  The Invites context.
+  """
+
+  import Ecto.Query, warn: false
+  alias Cannery.{Accounts.User, Invites.Invite, Repo}
+  alias Ecto.Changeset
+
+  @invite_token_length 20
+
+  @doc """
+  Returns the list of invites.
+
+  ## Examples
+
+      iex> list_invites(%User{id: 123, role: :admin})
+      [%Invite{}, ...]
+
+  """
+  @spec list_invites(User.t()) :: [Invite.t()]
+  def list_invites(%User{role: :admin}) do
+    Repo.all(from i in Invite, order_by: i.name)
+  end
+
+  @doc """
+  Gets a single invite.
+
+  Raises `Ecto.NoResultsError` if the Invite does not exist.
+
+  ## Examples
+
+      iex> get_invite!(123, %User{id: 123, role: :admin})
+      %Invite{}
+
+      iex> get_invite!(456, %User{id: 123, role: :admin})
+      ** (Ecto.NoResultsError)
+
+  """
+  @spec get_invite!(Invite.id(), User.t()) :: Invite.t()
+  def get_invite!(id, %User{role: :admin}) do
+    Repo.get!(Invite, id)
+  end
+
+  @doc """
+  Returns a valid invite or nil based on the attempted token
+
+  ## Examples
+
+      iex> get_invite_by_token("valid_token")
+      %Invite{}
+
+      iex> get_invite_by_token("invalid_token")
+      nil
+  """
+  @spec get_invite_by_token(token :: String.t() | nil) :: Invite.t() | nil
+  def get_invite_by_token(nil), do: nil
+  def get_invite_by_token(""), do: nil
+
+  def get_invite_by_token(token) do
+    Repo.one(
+      from(i in Invite,
+        where: i.token == ^token and i.disabled_at |> is_nil()
+      )
+    )
+  end
+
+  @doc """
+  Uses invite by decrementing uses_left, or marks invite invalid if it's been
+  completely used.
+  """
+  @spec use_invite!(Invite.t()) :: Invite.t()
+  def use_invite!(%Invite{uses_left: nil} = invite), do: invite
+
+  def use_invite!(%Invite{uses_left: uses_left} = invite) do
+    new_uses_left = uses_left - 1
+
+    attrs =
+      if new_uses_left <= 0 do
+        now = NaiveDateTime.utc_now() |> NaiveDateTime.truncate(:second)
+        %{"uses_left" => 0, "disabled_at" => now}
+      else
+        %{"uses_left" => new_uses_left}
+      end
+
+    invite |> Invite.update_changeset(attrs) |> Repo.update!()
+  end
+
+  @doc """
+  Creates a invite.
+
+  ## Examples
+
+      iex> create_invite(%User{id: 123, role: :admin}, %{field: value})
+      {:ok, %Invite{}}
+
+      iex> create_invite(%User{id: 123, role: :admin}, %{field: bad_value})
+      {:error, %Changeset{}}
+
+  """
+  @spec create_invite(User.t(), attrs :: map()) ::
+          {:ok, Invite.t()} | {:error, Changeset.t(Invite.new_invite())}
+  def create_invite(%User{id: user_id, role: :admin}, attrs) do
+    token =
+      :crypto.strong_rand_bytes(@invite_token_length)
+      |> Base.url_encode64()
+      |> binary_part(0, @invite_token_length)
+
+    attrs = attrs |> Map.merge(%{"user_id" => user_id, "token" => token})
+
+    %Invite{} |> Invite.create_changeset(attrs) |> Repo.insert()
+  end
+
+  @doc """
+  Updates a invite.
+
+  ## Examples
+
+      iex> update_invite(invite, %{field: new_value}, %User{id: 123, role: :admin})
+      {:ok, %Invite{}}
+
+      iex> update_invite(invite, %{field: bad_value}, %User{id: 123, role: :admin})
+      {:error, %Changeset{}}
+
+  """
+  @spec update_invite(Invite.t(), attrs :: map(), User.t()) ::
+          {:ok, Invite.t()} | {:error, Changeset.t(Invite.t())}
+  def update_invite(invite, attrs, %User{role: :admin}),
+    do: invite |> Invite.update_changeset(attrs) |> Repo.update()
+
+  @doc """
+  Deletes a invite.
+
+  ## Examples
+
+      iex> delete_invite(invite, %User{id: 123, role: :admin})
+      {:ok, %Invite{}}
+
+      iex> delete_invite(invite, %User{id: 123, role: :admin})
+      {:error, %Changeset{}}
+
+  """
+  @spec delete_invite(Invite.t(), User.t()) ::
+          {:ok, Invite.t()} | {:error, Changeset.t(Invite.t())}
+  def delete_invite(invite, %User{role: :admin}), do: invite |> Repo.delete()
+
+  @doc """
+  Deletes a invite.
+
+  ## Examples
+
+      iex> delete_invite(invite, %User{id: 123, role: :admin})
+      %Invite{}
+
+  """
+  @spec delete_invite!(Invite.t(), User.t()) :: Invite.t()
+  def delete_invite!(invite, %User{role: :admin}), do: invite |> Repo.delete!()
+
+  @doc """
+  Returns an `%Changeset{}` for tracking invite changes.
+
+  ## Examples
+
+      iex> change_invite(invite)
+      %Changeset{data: %Invite{}}
+
+  """
+  @spec change_invite(Invite.t() | Invite.new_invite()) ::
+          Changeset.t(Invite.t() | Invite.new_invite())
+  @spec change_invite(Invite.t() | Invite.new_invite(), attrs :: map()) ::
+          Changeset.t(Invite.t() | Invite.new_invite())
+  def change_invite(invite, attrs \\ %{}), do: invite |> Invite.update_changeset(attrs)
+end

lib/cannery/invites/invite.ex

@@ -1,4 +1,4 @@
-defmodule Cannery.Accounts.Invite do
+defmodule Cannery.Invites.Invite do
   @moduledoc """
   An invite, created by an admin to allow someone to join their instance. An
   invite can be enabled or disabled, and can have an optional number of uses if
@@ -7,8 +7,8 @@ defmodule Cannery.Accounts.Invite do
 
   use Ecto.Schema
   import Ecto.Changeset
-  alias Cannery.Accounts.User
-  alias Ecto.{Association, Changeset, UUID}
+  alias Ecto.{Changeset, UUID}
+  alias Cannery.{Accounts.User, Invites.Invite}
 
   @primary_key {:id, :binary_id, autogenerate: true}
   @foreign_key_type :binary_id
@@ -18,48 +18,40 @@ defmodule Cannery.Accounts.Invite do
     field :uses_left, :integer, default: nil
     field :disabled_at, :naive_datetime
 
-    belongs_to :created_by, User
-
-    has_many :users, User
+    belongs_to :user, User
 
     timestamps()
   end
 
-  @type t :: %__MODULE__{
+  @type t :: %Invite{
           id: id(),
           name: String.t(),
-          token: token(),
+          token: String.t(),
           uses_left: integer() | nil,
           disabled_at: NaiveDateTime.t(),
-          created_by: User.t() | nil | Association.NotLoaded.t(),
-          created_by_id: User.id() | nil,
-          users: [User.t()] | Association.NotLoaded.t(),
+          user: User.t(),
+          user_id: User.id(),
           inserted_at: NaiveDateTime.t(),
           updated_at: NaiveDateTime.t()
         }
-  @type new_invite :: %__MODULE__{}
+  @type new_invite :: %Invite{}
   @type id :: UUID.t()
-  @type changeset :: Changeset.t(t() | new_invite())
-  @type token :: String.t()
 
   @doc false
-  @spec create_changeset(User.t(), token(), attrs :: map()) :: changeset()
-  def create_changeset(%User{id: user_id}, token, attrs) do
-    %__MODULE__{}
-    |> change(token: token, created_by_id: user_id)
-    |> cast(attrs, [:name, :uses_left, :disabled_at])
-    |> validate_length(:name, max: 255)
+  @spec create_changeset(new_invite(), attrs :: map()) :: Changeset.t(new_invite())
+  def create_changeset(invite, attrs) do
+    invite
+    |> cast(attrs, [:name, :token, :uses_left, :disabled_at, :user_id])
+    |> validate_required([:name, :token, :user_id])
     |> validate_number(:uses_left, greater_than_or_equal_to: 0)
-    |> validate_required([:name, :token, :created_by_id])
   end
 
   @doc false
-  @spec update_changeset(t() | new_invite(), attrs :: map()) :: changeset()
+  @spec update_changeset(t() | new_invite(), attrs :: map()) :: Changeset.t(t() | new_invite())
   def update_changeset(invite, attrs) do
     invite
     |> cast(attrs, [:name, :uses_left, :disabled_at])
-    |> validate_length(:name, max: 255)
+    |> validate_required([:name, :token, :user_id])
     |> validate_number(:uses_left, greater_than_or_equal_to: 0)
-    |> validate_required([:name])
   end
 end

lib/cannery/logger.ex

@@ -1,63 +0,0 @@
-defmodule Cannery.Logger do
-  @moduledoc """
-  Custom logger for telemetry events
-
-  Oban implementation taken from
-  https://hexdocs.pm/oban/Oban.html#module-reporting-errors
-  """
-
-  require Logger
-
-  def handle_event([:oban, :job, :exception], measure, %{stacktrace: stacktrace} = meta, _config) do
-    data =
-      get_oban_job_data(meta, measure)
-      |> Map.put(:stacktrace, Exception.format_stacktrace(stacktrace))
-      |> pretty_encode()
-
-    Logger.error(meta.reason, data: data)
-  end
-
-  def handle_event([:oban, :job, :start], measure, meta, _config) do
-    data = get_oban_job_data(meta, measure) |> pretty_encode()
-    Logger.info("Started oban job", data: data)
-  end
-
-  def handle_event([:oban, :job, :stop], measure, meta, _config) do
-    data = get_oban_job_data(meta, measure) |> pretty_encode()
-    Logger.info("Finished oban job", data: data)
-  end
-
-  def handle_event([:oban, :job, unhandled_event], measure, meta, _config) do
-    data =
-      get_oban_job_data(meta, measure)
-      |> Map.put(:event, unhandled_event)
-      |> pretty_encode()
-
-    Logger.warning("Unhandled oban job event", data: data)
-  end
-
-  def handle_event(unhandled_event, measure, meta, config) do
-    data =
-      pretty_encode(%{
-        event: unhandled_event,
-        meta: meta,
-        measurements: measure,
-        config: config
-      })
-
-    Logger.warning("Unhandled telemetry event", data: data)
-  end
-
-  defp get_oban_job_data(%{job: job}, measure) do
-    %{
-      job: job |> Map.take([:id, :args, :meta, :queue, :worker]),
-      measurements: measure
-    }
-  end
-
-  defp pretty_encode(data) do
-    data
-    |> Jason.encode!()
-    |> Jason.Formatter.pretty_print()
-  end
-end

lib/cannery/release.ex

@@ -9,9 +9,7 @@ defmodule Cannery.Release do
 
   def rollback(repo, version) do
     load_app()
-
-    {:ok, _fun_return, _apps} =
-      Ecto.Migrator.with_repo(repo, &Ecto.Migrator.run(&1, :down, to: version))
+    {:ok, _fun, _opts} = Ecto.Migrator.with_repo(repo, &Ecto.Migrator.run(&1, :down, to: version))
   end
 
   defp load_app do
@@ -22,8 +20,7 @@ defmodule Cannery.Release do
     load_app()
 
     for repo <- Application.fetch_env!(@app, :ecto_repos) do
-      {:ok, _fun_return, _apps} =
-        Ecto.Migrator.with_repo(repo, &Ecto.Migrator.run(&1, :up, all: true))
+      {:ok, _fun, _opts} = Ecto.Migrator.with_repo(repo, &Ecto.Migrator.run(&1, :up, all: true))
     end
   end
 end

lib/cannery/repo/migrator.ex

@@ -1,6 +1,6 @@
 defmodule Cannery.Repo.Migrator do
   @moduledoc """
-  Genserver to automatically perform all migration on app start
+  Genserver to automatically run migrations in prod env
   """
 
   use GenServer
@@ -11,15 +11,12 @@ defmodule Cannery.Repo.Migrator do
   end
 
   def init(_opts) do
-    {:ok, if(automigrate_enabled?(), do: migrate!())}
+    migrate!()
+    {:ok, nil}
   end
 
   def migrate! do
     path = Application.app_dir(:cannery, "priv/repo/migrations")
     Ecto.Migrator.run(Cannery.Repo, path, :up, all: true)
   end
-
-  defp automigrate_enabled? do
-    Application.get_env(:cannery, Cannery.Application, automigrate: false)[:automigrate]
-  end
 end

lib/cannery/tags.ex

@@ -0,0 +1,151 @@
+defmodule Cannery.Tags do
+  @moduledoc """
+  The Tags context.
+  """
+
+  import Ecto.Query, warn: false
+  import CanneryWeb.Gettext
+  alias Cannery.{Accounts.User, Repo, Tags.Tag}
+  alias Ecto.Changeset
+
+  @doc """
+  Returns the list of tags.
+
+  ## Examples
+
+      iex> list_tags(%User{id: 123})
+      [%Tag{}, ...]
+
+  """
+  @spec list_tags(User.t()) :: [Tag.t()]
+  def list_tags(%{id: user_id}),
+    do: Repo.all(from t in Tag, where: t.user_id == ^user_id, order_by: t.name)
+
+  @doc """
+  Gets a single tag.
+
+  ## Examples
+
+      iex> get_tag(123, %User{id: 123})
+      {:ok, %Tag{}}
+
+      iex> get_tag(456, %User{id: 123})
+      {:error, "tag not found"}
+
+  """
+  @spec get_tag(Tag.id(), User.t()) :: {:ok, Tag.t()} | {:error, String.t()}
+  def get_tag(id, %User{id: user_id}) do
+    Repo.one(from t in Tag, where: t.id == ^id and t.user_id == ^user_id)
+    |> case do
+      nil -> {:error, dgettext("errors", "Tag not found")}
+      tag -> {:ok, tag}
+    end
+  end
+
+  @doc """
+  Gets a single tag.
+
+  Raises `Ecto.NoResultsError` if the Tag does not exist.
+
+  ## Examples
+
+      iex> get_tag!(123, %User{id: 123})
+      %Tag{}
+
+      iex> get_tag!(456, %User{id: 123})
+      ** (Ecto.NoResultsError)
+
+  """
+  @spec get_tag!(Tag.id(), User.t()) :: Tag.t()
+  def get_tag!(id, %User{id: user_id}),
+    do: Repo.one!(from t in Tag, where: t.id == ^id and t.user_id == ^user_id)
+
+  @doc """
+  Creates a tag.
+
+  ## Examples
+
+      iex> create_tag(%{field: value}, %User{id: 123})
+      {:ok, %Tag{}}
+
+      iex> create_tag(%{field: bad_value}, %User{id: 123})
+      {:error, %Changeset{}}
+
+  """
+  @spec create_tag(attrs :: map(), User.t()) ::
+          {:ok, Tag.t()} | {:error, Changeset.t(Tag.new_tag())}
+  def create_tag(attrs, %User{id: user_id}),
+    do: %Tag{} |> Tag.create_changeset(attrs |> Map.put("user_id", user_id)) |> Repo.insert()
+
+  @doc """
+  Updates a tag.
+
+  ## Examples
+
+      iex> update_tag(tag, %{field: new_value}, %User{id: 123})
+      {:ok, %Tag{}}
+
+      iex> update_tag(tag, %{field: bad_value}, %User{id: 123})
+      {:error, %Changeset{}}
+
+  """
+  @spec update_tag(Tag.t(), attrs :: map(), User.t()) ::
+          {:ok, Tag.t()} | {:error, Changeset.t(Tag.t())}
+  def update_tag(%Tag{user_id: user_id} = tag, attrs, %User{id: user_id}),
+    do: tag |> Tag.update_changeset(attrs) |> Repo.update()
+
+  @doc """
+  Deletes a tag.
+
+  ## Examples
+
+      iex> delete_tag(tag, %User{id: 123})
+      {:ok, %Tag{}}
+
+      iex> delete_tag(tag, %User{id: 123})
+      {:error, %Changeset{}}
+
+  """
+  @spec delete_tag(Tag.t(), User.t()) :: {:ok, Tag.t()} | {:error, Changeset.t(Tag.t())}
+  def delete_tag(%Tag{user_id: user_id} = tag, %User{id: user_id}), do: tag |> Repo.delete()
+
+  @doc """
+  Deletes a tag.
+
+  ## Examples
+
+      iex> delete_tag!(tag, %User{id: 123})
+      %Tag{}
+
+  """
+  @spec delete_tag!(Tag.t(), User.t()) :: Tag.t()
+  def delete_tag!(%Tag{user_id: user_id} = tag, %User{id: user_id}), do: tag |> Repo.delete!()
+
+  @doc """
+  Returns an `%Changeset{}` for tracking tag changes.
+
+  ## Examples
+
+      iex> change_tag(tag)
+      %Changeset{data: %Tag{}}
+
+  """
+  @spec change_tag(Tag.t() | Tag.new_tag()) :: Changeset.t(Tag.t() | Tag.new_tag())
+  @spec change_tag(Tag.t() | Tag.new_tag(), attrs :: map()) ::
+          Changeset.t(Tag.t() | Tag.new_tag())
+  def change_tag(tag, attrs \\ %{}), do: Tag.update_changeset(tag, attrs)
+
+  @doc """
+  Get a random tag bg_color in `#ffffff` hex format
+
+  ## Examples
+
+      iex> random_color()
+      "#cc0066"
+  """
+  @spec random_bg_color() :: <<_::7>>
+  def random_bg_color do
+    ["#cc0066", "#ff6699", "#6666ff", "#0066cc", "#00cc66", "#669900", "#ff9900", "#996633"]
+    |> Enum.random()
+  end
+end

lib/cannery/tags/tag.ex

@@ -0,0 +1,52 @@
+defmodule Cannery.Tags.Tag do
+  @moduledoc """
+  Tags are added to containers to help organize, and can include custom-defined
+  text and bg colors.
+  """
+
+  use Ecto.Schema
+  import Ecto.Changeset
+  alias Ecto.{Changeset, UUID}
+  alias Cannery.{Accounts.User, Tags.Tag}
+
+  @primary_key {:id, :binary_id, autogenerate: true}
+  @foreign_key_type :binary_id
+  schema "tags" do
+    field :name, :string
+    field :bg_color, :string
+    field :text_color, :string
+
+    belongs_to :user, User
+
+    timestamps()
+  end
+
+  @type t :: %Tag{
+          id: id(),
+          name: String.t(),
+          bg_color: String.t(),
+          text_color: String.t(),
+          user: User.t() | nil,
+          user_id: User.id(),
+          inserted_at: NaiveDateTime.t(),
+          updated_at: NaiveDateTime.t()
+        }
+  @type new_tag() :: %Tag{}
+  @type id() :: UUID.t()
+
+  @doc false
+  @spec create_changeset(new_tag(), attrs :: map()) :: Changeset.t(new_tag())
+  def create_changeset(tag, attrs) do
+    tag
+    |> cast(attrs, [:name, :bg_color, :text_color, :user_id])
+    |> validate_required([:name, :bg_color, :text_color, :user_id])
+  end
+
+  @doc false
+  @spec update_changeset(t() | new_tag(), attrs :: map()) :: Changeset.t(t() | new_tag())
+  def update_changeset(tag, attrs) do
+    tag
+    |> cast(attrs, [:name, :bg_color, :text_color])
+    |> validate_required([:name, :bg_color, :text_color, :user_id])
+  end
+end

lib/cannery_web.ex

@@ -44,7 +44,8 @@ defmodule CanneryWeb do
 
   def live_view do
     quote do
-      use Phoenix.LiveView, layout: {CanneryWeb.LayoutView, :live}
+      use Phoenix.LiveView,
+        layout: {CanneryWeb.LayoutView, "live.html"}
 
       on_mount CanneryWeb.InitAssigns
       unquote(view_helpers())
@@ -71,14 +72,16 @@ defmodule CanneryWeb do
     quote do
       use Phoenix.Router
 
-      import Phoenix.{Controller, LiveView.Router}
       # credo:disable-for-next-line Credo.Check.Consistency.MultiAliasImportRequireUse
       import Plug.Conn
+      import Phoenix.Controller
+      import Phoenix.LiveView.Router
     end
   end
 
   def channel do
     quote do
+      # credo:disable-for-next-line Credo.Check.Consistency.MultiAliasImportRequireUse
       use Phoenix.Channel
       # credo:disable-for-next-line Credo.Check.Consistency.MultiAliasImportRequireUse
       import CanneryWeb.Gettext
@@ -92,11 +95,15 @@ defmodule CanneryWeb do
       use Phoenix.HTML
 
       # Import LiveView and .heex helpers (live_render, live_patch, <.form>, etc)
-      # Import basic rendering functionality (render, render_layout, etc)
-      import CanneryWeb.{ErrorHelpers, Gettext, CoreComponents, ViewHelpers}
-      import Phoenix.{Component, View}
+      # credo:disable-for-next-line Credo.Check.Consistency.MultiAliasImportRequireUse
+      import Phoenix.LiveView.Helpers
 
-      alias CanneryWeb.Endpoint
+      # Import basic rendering functionality (render, render_layout, etc)
+      # credo:disable-for-next-line Credo.Check.Consistency.MultiAliasImportRequireUse
+      import Phoenix.View
+
+      # credo:disable-for-next-line Credo.Check.Consistency.MultiAliasImportRequireUse
+      import CanneryWeb.{ErrorHelpers, Gettext, LiveHelpers, ViewHelpers}
       alias CanneryWeb.Router.Helpers, as: Routes
     end
   end

lib/cannery_web/components/add_shot_group_component.ex

@@ -5,8 +5,7 @@ defmodule CanneryWeb.Components.AddShotGroupComponent do
 
   use CanneryWeb, :live_component
   alias Cannery.{Accounts.User, ActivityLog, ActivityLog.ShotGroup, Ammo.AmmoGroup}
-  alias Ecto.Changeset
-  alias Phoenix.LiveView.{JS, Socket}
+  alias Phoenix.LiveView.Socket
 
   @impl true
   @spec update(
@@ -17,10 +16,9 @@ defmodule CanneryWeb.Components.AddShotGroupComponent do
           },
           Socket.t()
         ) :: {:ok, Socket.t()}
-  def update(%{ammo_group: ammo_group, current_user: current_user} = assigns, socket) do
+  def update(%{ammo_group: _ammo_group, current_user: _current_user} = assigns, socket) do
     changeset =
-      %ShotGroup{date: Date.utc_today()}
-      |> ShotGroup.create_changeset(current_user, ammo_group, %{})
+      %ShotGroup{date: NaiveDateTime.utc_now(), count: 1} |> ActivityLog.change_shot_group()
 
     {:ok, socket |> assign(assigns) |> assign(:changeset, changeset)}
   end
@@ -29,17 +27,22 @@ defmodule CanneryWeb.Components.AddShotGroupComponent do
   def handle_event(
         "validate",
         %{"shot_group" => shot_group_params},
-        %{assigns: %{ammo_group: ammo_group, current_user: current_user}} = socket
+        %{
+          assigns: %{
+            ammo_group: %AmmoGroup{id: ammo_group_id} = ammo_group,
+            current_user: %User{id: user_id}
+          }
+        } = socket
       ) do
-    params = shot_group_params |> process_params(ammo_group)
-
-    changeset = %ShotGroup{} |> ShotGroup.create_changeset(current_user, ammo_group, params)
+    shot_group_params =
+      shot_group_params
+      |> process_params(ammo_group)
+      |> Map.merge(%{"ammo_group_id" => ammo_group_id, "user_id" => user_id})
 
     changeset =
-      case changeset |> Changeset.apply_action(:validate) do
-        {:ok, _data} -> changeset
-        {:error, changeset} -> changeset
-      end
+      %ShotGroup{}
+      |> ActivityLog.change_shot_group(shot_group_params)
+      |> Map.put(:action, :validate)
 
     {:noreply, socket |> assign(:changeset, changeset)}
   end
@@ -48,19 +51,24 @@ defmodule CanneryWeb.Components.AddShotGroupComponent do
         "save",
         %{"shot_group" => shot_group_params},
         %{
-          assigns: %{ammo_group: ammo_group, current_user: current_user, return_to: return_to}
+          assigns: %{
+            ammo_group: %{id: ammo_group_id} = ammo_group,
+            current_user: %{id: user_id} = current_user,
+            return_to: return_to
+          }
         } = socket
       ) do
     socket =
       shot_group_params
       |> process_params(ammo_group)
+      |> Map.merge(%{"ammo_group_id" => ammo_group_id, "user_id" => user_id})
       |> ActivityLog.create_shot_group(current_user, ammo_group)
       |> case do
         {:ok, _shot_group} ->
           prompt = dgettext("prompts", "Shots recorded successfully")
-          socket |> put_flash(:info, prompt) |> push_navigate(to: return_to)
+          socket |> put_flash(:info, prompt) |> push_redirect(to: return_to)
 
-        {:error, %Changeset{} = changeset} ->
+        {:error, %Ecto.Changeset{} = changeset} ->
           socket |> assign(changeset: changeset)
       end
 
@@ -69,14 +77,14 @@ defmodule CanneryWeb.Components.AddShotGroupComponent do
 
   # calculate count from shots left
   defp process_params(params, %AmmoGroup{count: count}) do
-    shot_group_count =
-      if params |> Map.get("ammo_left", "") == "" do
-        nil
+    new_count =
+      if params |> Map.get("ammo_left", "0") == "" do
+        "0"
       else
-        new_count = params |> Map.get("ammo_left") |> String.to_integer()
-        count - new_count
+        params |> Map.get("ammo_left", "0")
       end
+      |> String.to_integer()
 
-    params |> Map.put("count", shot_group_count)
+    params |> Map.put("count", count - new_count)
   end
 end

lib/cannery_web/components/add_shot_group_component.html.heex

@@ -4,7 +4,7 @@
   </h2>
 
   <.form
-    :let={f}
+    let={f}
     for={@changeset}
     id="shot-group-form"
     class="flex flex-col space-y-4 sm:space-y-0 sm:grid sm:grid-cols-3 sm:gap-4 justify-center items-center"
@@ -12,41 +12,30 @@
     phx-change="validate"
     phx-submit="save"
   >
-    <div
-      :if={@changeset.action && not @changeset.valid?()}
-      class="invalid-feedback col-span-3 text-center"
-    >
-      <%= changeset_errors(@changeset) %>
-    </div>
+    <%= if @changeset.action && not @changeset.valid? do %>
+      <div class="invalid-feedback col-span-3 text-center">
+        <%= changeset_errors(@changeset) %>
+      </div>
+    <% end %>
 
     <%= label(f, :ammo_left, gettext("Rounds left"), class: "title text-lg text-primary-600") %>
     <%= number_input(f, :ammo_left,
       min: 0,
       max: @ammo_group.count - 1,
-      placeholder: gettext("Rounds left"),
-      class: "input input-primary"
+      placeholder: 0,
+      class: "input input-primary col-span-2"
     ) %>
-    <button
-      type="button"
-      class="mx-2 my-1 text-sm btn btn-primary"
-      phx-click={JS.dispatch("cannery:set-zero", to: "#shot-group-form_ammo_left")}
-    >
-      <%= gettext("Used up!") %>
-    </button>
     <%= error_tag(f, :ammo_left, "col-span-3") %>
 
     <%= label(f, :notes, gettext("Notes"), class: "title text-lg text-primary-600") %>
     <%= textarea(f, :notes,
-      id: "add-shot-group-form-notes",
       class: "input input-primary col-span-2",
-      maxlength: 255,
-      placeholder: gettext("Really great weather"),
-      phx_hook: "MaintainAttrs",
-      phx_update: "ignore"
+      placeholder: "Really great weather",
+      phx_hook: "MaintainAttrs"
     ) %>
     <%= error_tag(f, :notes, "col-span-3") %>
 
-    <%= label(f, :date, gettext("Date"), class: "title text-lg text-primary-600") %>
+    <%= label(f, :date, gettext("Date (UTC)"), class: "title text-lg text-primary-600") %>
     <%= date_input(f, :date,
       class: "input input-primary col-span-2",
       phx_update: "ignore",

lib/cannery_web/components/ammo_group_card.ex

@@ -0,0 +1,63 @@
+defmodule CanneryWeb.Components.AmmoGroupCard do
+  @moduledoc """
+  Display card for an ammo group
+  """
+
+  use CanneryWeb, :component
+  alias Cannery.Repo
+  alias CanneryWeb.Endpoint
+
+  def ammo_group_card(assigns) do
+    assigns = assigns |> assign(:ammo_group, assigns.ammo_group |> Repo.preload(:ammo_type))
+
+    ~H"""
+    <div
+      id={"ammo_group-#{@ammo_group.id}"}
+      class="mx-4 my-2 px-8 py-4 flex flex-col justify-center items-center
+            border border-gray-400 rounded-lg shadow-lg hover:shadow-md
+            transition-all duration-300 ease-in-out"
+    >
+      <%= live_redirect to: Routes.ammo_group_show_path(Endpoint, :show, @ammo_group),
+                    class: "mb-2 link" do %>
+        <h1 class="title text-xl title-primary-500">
+          <%= @ammo_group.ammo_type.name %>
+        </h1>
+      <% end %>
+
+      <div class="flex flex-col justify-center items-center">
+        <span class="rounded-lg title text-lg">
+          <%= gettext("Count:") %>
+          <%= @ammo_group.count %>
+        </span>
+
+        <%= if @ammo_group.notes do %>
+          <span class="rounded-lg title text-lg">
+            <%= gettext("Notes:") %>
+            <%= @ammo_group.notes %>
+          </span>
+        <% end %>
+
+        <span class="rounded-lg title text-lg">
+          <%= gettext("Added on:") %>
+          <%= @ammo_group.inserted_at |> display_datetime() %>
+        </span>
+
+        <%= if @ammo_group.price_paid do %>
+          <span class="rounded-lg title text-lg">
+            <%= gettext("Price paid:") %>
+            <%= gettext("$%{amount}",
+              amount: @ammo_group.price_paid |> :erlang.float_to_binary(decimals: 2)
+            ) %>
+          </span>
+        <% end %>
+      </div>
+
+      <%= if assigns |> Map.has_key?(:inner_block) do %>
+        <div class="mt-4 flex space-x-4 justify-center items-center">
+          <%= render_slot(@inner_block) %>
+        </div>
+      <% end %>
+    </div>
+    """
+  end
+end

lib/cannery_web/components/ammo_group_table_component.ex

@@ -1,257 +0,0 @@
-defmodule CanneryWeb.Components.AmmoGroupTableComponent do
-  @moduledoc """
-  A component that displays a list of ammo groups
-  """
-  use CanneryWeb, :live_component
-  alias Cannery.{Accounts.User, Ammo.AmmoGroup, ComparableDate}
-  alias Cannery.{ActivityLog, Ammo, Containers}
-  alias CanneryWeb.Components.TableComponent
-  alias Ecto.UUID
-  alias Phoenix.LiveView.{Rendered, Socket}
-
-  @impl true
-  @spec update(
-          %{
-            required(:id) => UUID.t(),
-            required(:current_user) => User.t(),
-            required(:ammo_groups) => [AmmoGroup.t()],
-            required(:show_used) => boolean(),
-            optional(:ammo_type) => Rendered.t(),
-            optional(:range) => Rendered.t(),
-            optional(:container) => Rendered.t(),
-            optional(:actions) => Rendered.t(),
-            optional(any()) => any()
-          },
-          Socket.t()
-        ) :: {:ok, Socket.t()}
-  def update(
-        %{id: _id, ammo_groups: _ammo_group, current_user: _current_user, show_used: _show_used} =
-          assigns,
-        socket
-      ) do
-    socket =
-      socket
-      |> assign(assigns)
-      |> assign_new(:ammo_type, fn -> [] end)
-      |> assign_new(:range, fn -> [] end)
-      |> assign_new(:container, fn -> [] end)
-      |> assign_new(:actions, fn -> [] end)
-      |> display_ammo_groups()
-
-    {:ok, socket}
-  end
-
-  defp display_ammo_groups(
-         %{
-           assigns: %{
-             ammo_groups: ammo_groups,
-             current_user: current_user,
-             ammo_type: ammo_type,
-             range: range,
-             container: container,
-             actions: actions,
-             show_used: show_used
-           }
-         } = socket
-       ) do
-    columns =
-      []
-      |> TableComponent.maybe_compose_columns(
-        %{label: gettext("Actions"), key: :actions, sortable: false},
-        actions != []
-      )
-      |> TableComponent.maybe_compose_columns(%{
-        label: gettext("Last used on"),
-        key: :used_up_on,
-        type: ComparableDate
-      })
-      |> TableComponent.maybe_compose_columns(%{
-        label: gettext("Purchased on"),
-        key: :purchased_on,
-        type: ComparableDate
-      })
-      |> TableComponent.maybe_compose_columns(
-        %{label: gettext("Container"), key: :container},
-        container != []
-      )
-      |> TableComponent.maybe_compose_columns(
-        %{label: gettext("Range"), key: :range},
-        range != []
-      )
-      |> TableComponent.maybe_compose_columns(%{label: gettext("CPR"), key: :cpr})
-      |> TableComponent.maybe_compose_columns(%{label: gettext("Price paid"), key: :price_paid})
-      |> TableComponent.maybe_compose_columns(
-        %{label: gettext("% left"), key: :remaining},
-        show_used
-      )
-      |> TableComponent.maybe_compose_columns(
-        %{label: gettext("Original Count"), key: :original_count},
-        show_used
-      )
-      |> TableComponent.maybe_compose_columns(%{
-        label: if(show_used, do: gettext("Current Count"), else: gettext("Count")),
-        key: :count
-      })
-      |> TableComponent.maybe_compose_columns(
-        %{label: gettext("Ammo type"), key: :ammo_type},
-        ammo_type != []
-      )
-
-    containers =
-      ammo_groups
-      |> Enum.map(fn %{container_id: container_id} -> container_id end)
-      |> Containers.get_containers(current_user)
-
-    extra_data = %{
-      current_user: current_user,
-      ammo_type: ammo_type,
-      columns: columns,
-      container: container,
-      containers: containers,
-      original_counts: Ammo.get_original_counts(ammo_groups, current_user),
-      cprs: Ammo.get_cprs(ammo_groups, current_user),
-      last_used_dates: ActivityLog.get_last_used_dates(ammo_groups, current_user),
-      percentages_remaining: Ammo.get_percentages_remaining(ammo_groups, current_user),
-      actions: actions,
-      range: range
-    }
-
-    rows =
-      ammo_groups
-      |> Enum.map(fn ammo_group ->
-        ammo_group |> get_row_data_for_ammo_group(extra_data)
-      end)
-
-    socket |> assign(columns: columns, rows: rows)
-  end
-
-  @impl true
-  def render(assigns) do
-    ~H"""
-    <div id={@id} class="w-full">
-      <.live_component module={TableComponent} id={"table-#{@id}"} columns={@columns} rows={@rows} />
-    </div>
-    """
-  end
-
-  @spec get_row_data_for_ammo_group(AmmoGroup.t(), additional_data :: map()) :: map()
-  defp get_row_data_for_ammo_group(ammo_group, %{columns: columns} = additional_data) do
-    columns
-    |> Map.new(fn %{key: key} ->
-      {key, get_value_for_key(key, ammo_group, additional_data)}
-    end)
-  end
-
-  @spec get_value_for_key(atom(), AmmoGroup.t(), additional_data :: map()) ::
-          any() | {any(), Rendered.t()}
-  defp get_value_for_key(
-         :ammo_type,
-         %{ammo_type: %{name: ammo_type_name} = ammo_type},
-         %{ammo_type: ammo_type_block}
-       ) do
-    assigns = %{ammo_type: ammo_type, ammo_type_block: ammo_type_block}
-
-    {ammo_type_name,
-     ~H"""
-     <%= render_slot(@ammo_type_block, @ammo_type) %>
-     """}
-  end
-
-  defp get_value_for_key(:price_paid, %{price_paid: nil}, _additional_data),
-    do: {0, gettext("No cost information")}
-
-  defp get_value_for_key(:price_paid, %{price_paid: price_paid}, _additional_data),
-    do: {price_paid, gettext("$%{amount}", amount: display_currency(price_paid))}
-
-  defp get_value_for_key(:purchased_on, %{purchased_on: purchased_on} = assigns, _additional_data) do
-    {purchased_on,
-     ~H"""
-     <.date id={"#{@id}-purchased-on"} date={@purchased_on} />
-     """}
-  end
-
-  defp get_value_for_key(:used_up_on, %{id: ammo_group_id}, %{last_used_dates: last_used_dates}) do
-    last_used_date = last_used_dates |> Map.get(ammo_group_id)
-    assigns = %{id: ammo_group_id, last_used_date: last_used_date}
-
-    {last_used_date,
-     ~H"""
-     <%= if @last_used_date do %>
-       <.date id={"#{@id}-last-used-date"} date={@last_used_date} />
-     <% else %>
-       <%= gettext("Never used") %>
-     <% end %>
-     """}
-  end
-
-  defp get_value_for_key(:range, %{staged: staged} = ammo_group, %{range: range}) do
-    assigns = %{range: range, ammo_group: ammo_group}
-
-    {staged,
-     ~H"""
-     <%= render_slot(@range, @ammo_group) %>
-     """}
-  end
-
-  defp get_value_for_key(
-         :remaining,
-         %{id: ammo_group_id},
-         %{percentages_remaining: percentages_remaining}
-       ) do
-    percentage = Map.fetch!(percentages_remaining, ammo_group_id)
-    {percentage, gettext("%{percentage}%", percentage: percentage)}
-  end
-
-  defp get_value_for_key(:actions, ammo_group, %{actions: actions}) do
-    assigns = %{actions: actions, ammo_group: ammo_group}
-
-    ~H"""
-    <%= render_slot(@actions, @ammo_group) %>
-    """
-  end
-
-  defp get_value_for_key(:container, %{container: nil}, _additional_data), do: {nil, nil}
-
-  defp get_value_for_key(
-         :container,
-         %{container_id: container_id} = ammo_group,
-         %{container: container_block, containers: containers}
-       ) do
-    container = %{name: container_name} = Map.fetch!(containers, container_id)
-
-    assigns = %{
-      container: container,
-      container_block: container_block,
-      ammo_group: ammo_group
-    }
-
-    {container_name,
-     ~H"""
-     <%= render_slot(@container_block, {@ammo_group, @container}) %>
-     """}
-  end
-
-  defp get_value_for_key(
-         :original_count,
-         %{id: ammo_group_id},
-         %{original_counts: original_counts}
-       ) do
-    Map.fetch!(original_counts, ammo_group_id)
-  end
-
-  defp get_value_for_key(:cpr, %{price_paid: nil}, _additional_data),
-    do: {0, gettext("No cost information")}
-
-  defp get_value_for_key(:cpr, %{id: ammo_group_id}, %{cprs: cprs}) do
-    amount = Map.fetch!(cprs, ammo_group_id)
-    {amount, gettext("$%{amount}", amount: display_currency(amount))}
-  end
-
-  defp get_value_for_key(:count, %{count: count}, _additional_data),
-    do: if(count == 0, do: {0, gettext("Empty")}, else: count)
-
-  defp get_value_for_key(key, ammo_group, _additional_data), do: ammo_group |> Map.get(key)
-
-  @spec display_currency(float()) :: String.t()
-  defp display_currency(float), do: :erlang.float_to_binary(float, decimals: 2)
-end

lib/cannery_web/components/ammo_type_table_component.ex

@@ -1,290 +0,0 @@
-defmodule CanneryWeb.Components.AmmoTypeTableComponent do
-  @moduledoc """
-  A component that displays a list of ammo type
-  """
-  use CanneryWeb, :live_component
-  alias Cannery.{Accounts.User, ActivityLog, Ammo, Ammo.AmmoType}
-  alias CanneryWeb.Components.TableComponent
-  alias Ecto.UUID
-  alias Phoenix.LiveView.{Rendered, Socket}
-
-  @impl true
-  @spec update(
-          %{
-            required(:id) => UUID.t(),
-            required(:current_user) => User.t(),
-            optional(:type) => AmmoType.type() | nil,
-            optional(:show_used) => boolean(),
-            optional(:ammo_types) => [AmmoType.t()],
-            optional(:actions) => Rendered.t(),
-            optional(any()) => any()
-          },
-          Socket.t()
-        ) :: {:ok, Socket.t()}
-  def update(%{id: _id, ammo_types: _ammo_types, current_user: _current_user} = assigns, socket) do
-    socket =
-      socket
-      |> assign(assigns)
-      |> assign_new(:show_used, fn -> false end)
-      |> assign_new(:type, fn -> :all end)
-      |> assign_new(:actions, fn -> [] end)
-      |> display_ammo_types()
-
-    {:ok, socket}
-  end
-
-  defp display_ammo_types(
-         %{
-           assigns: %{
-             ammo_types: ammo_types,
-             current_user: current_user,
-             show_used: show_used,
-             type: type,
-             actions: actions
-           }
-         } = socket
-       ) do
-    filtered_columns =
-      [
-        %{label: gettext("Cartridge"), key: :cartridge, type: :string},
-        %{
-          label: if(type == :shotgun, do: gettext("Gauge"), else: gettext("Caliber")),
-          key: :caliber,
-          type: :string
-        },
-        %{label: gettext("Unfired shell length"), key: :unfired_length, type: :string},
-        %{label: gettext("Brass height"), key: :brass_height, type: :string},
-        %{label: gettext("Chamber size"), key: :chamber_size, type: :string},
-        %{label: gettext("Chamber size"), key: :chamber_size, type: :string},
-        %{label: gettext("Grains"), key: :grains, type: :string},
-        %{label: gettext("Bullet type"), key: :bullet_type, type: :string},
-        %{
-          label: if(type == :shotgun, do: gettext("Slug core"), else: gettext("Bullet core")),
-          key: :bullet_core,
-          type: :string
-        },
-        %{label: gettext("Jacket type"), key: :jacket_type, type: :string},
-        %{label: gettext("Case material"), key: :case_material, type: :string},
-        %{label: gettext("Wadding"), key: :wadding, type: :string},
-        %{label: gettext("Shot type"), key: :shot_type, type: :string},
-        %{label: gettext("Shot material"), key: :shot_material, type: :string},
-        %{label: gettext("Shot size"), key: :shot_size, type: :string},
-        %{label: gettext("Load grains"), key: :load_grains, type: :string},
-        %{label: gettext("Shot charge weight"), key: :shot_charge_weight, type: :string},
-        %{label: gettext("Powder type"), key: :powder_type, type: :string},
-        %{
-          label: gettext("Powder grains per charge"),
-          key: :powder_grains_per_charge,
-          type: :string
-        },
-        %{label: gettext("Pressure"), key: :pressure, type: :string},
-        %{label: gettext("Dram equivalent"), key: :dram_equivalent, type: :string},
-        %{label: gettext("Muzzle velocity"), key: :muzzle_velocity, type: :string},
-        %{label: gettext("Primer type"), key: :primer_type, type: :string},
-        %{label: gettext("Firing type"), key: :firing_type, type: :string},
-        %{label: gettext("Tracer"), key: :tracer, type: :atom},
-        %{label: gettext("Incendiary"), key: :incendiary, type: :atom},
-        %{label: gettext("Blank"), key: :blank, type: :atom},
-        %{label: gettext("Corrosive"), key: :corrosive, type: :atom},
-        %{label: gettext("Manufacturer"), key: :manufacturer, type: :string}
-      ]
-      |> Enum.filter(fn %{key: key, type: type} ->
-        # remove columns if all values match defaults
-        default_value = if type == :atom, do: false, else: nil
-
-        ammo_types
-        |> Enum.any?(fn ammo_type -> Map.get(ammo_type, key, default_value) != default_value end)
-      end)
-
-    columns =
-      [%{label: gettext("Actions"), key: "actions", type: :actions, sortable: false}]
-      |> TableComponent.maybe_compose_columns(%{
-        label: gettext("Average CPR"),
-        key: :avg_price_paid,
-        type: :avg_price_paid
-      })
-      |> TableComponent.maybe_compose_columns(
-        %{
-          label: gettext("Total ever packs"),
-          key: :historical_pack_count,
-          type: :historical_pack_count
-        },
-        show_used
-      )
-      |> TableComponent.maybe_compose_columns(
-        %{
-          label: gettext("Used packs"),
-          key: :used_pack_count,
-          type: :used_pack_count
-        },
-        show_used
-      )
-      |> TableComponent.maybe_compose_columns(%{
-        label: gettext("Packs"),
-        key: :ammo_count,
-        type: :ammo_count
-      })
-      |> TableComponent.maybe_compose_columns(
-        %{
-          label: gettext("Total ever rounds"),
-          key: :historical_round_count,
-          type: :historical_round_count
-        },
-        show_used
-      )
-      |> TableComponent.maybe_compose_columns(
-        %{
-          label: gettext("Used rounds"),
-          key: :used_round_count,
-          type: :used_round_count
-        },
-        show_used
-      )
-      |> TableComponent.maybe_compose_columns(%{
-        label: gettext("Rounds"),
-        key: :round_count,
-        type: :round_count
-      })
-      |> TableComponent.maybe_compose_columns(filtered_columns)
-      |> TableComponent.maybe_compose_columns(
-        %{label: gettext("Type"), key: :type, type: :atom},
-        type in [:all, nil]
-      )
-      |> TableComponent.maybe_compose_columns(%{label: gettext("Name"), key: :name, type: :name})
-
-    round_counts = ammo_types |> Ammo.get_round_count_for_ammo_types(current_user)
-    packs_count = ammo_types |> Ammo.get_ammo_groups_count_for_types(current_user)
-    average_costs = ammo_types |> Ammo.get_average_cost_for_ammo_types(current_user)
-
-    [used_counts, historical_round_counts, historical_pack_counts, used_pack_counts] =
-      if show_used do
-        [
-          ammo_types |> ActivityLog.get_used_count_for_ammo_types(current_user),
-          ammo_types |> Ammo.get_historical_count_for_ammo_types(current_user),
-          ammo_types |> Ammo.get_ammo_groups_count_for_types(current_user, true),
-          ammo_types |> Ammo.get_used_ammo_groups_count_for_types(current_user)
-        ]
-      else
-        [nil, nil, nil, nil]
-      end
-
-    extra_data = %{
-      actions: actions,
-      current_user: current_user,
-      used_counts: used_counts,
-      round_counts: round_counts,
-      historical_round_counts: historical_round_counts,
-      packs_count: packs_count,
-      used_pack_counts: used_pack_counts,
-      historical_pack_counts: historical_pack_counts,
-      average_costs: average_costs
-    }
-
-    rows =
-      ammo_types
-      |> Enum.map(fn ammo_type ->
-        ammo_type |> get_ammo_type_values(columns, extra_data)
-      end)
-
-    socket |> assign(columns: columns, rows: rows)
-  end
-
-  @impl true
-  def render(assigns) do
-    ~H"""
-    <div id={@id} class="w-full">
-      <.live_component module={TableComponent} id={"table-#{@id}"} columns={@columns} rows={@rows} />
-    </div>
-    """
-  end
-
-  defp get_ammo_type_values(ammo_type, columns, extra_data) do
-    columns
-    |> Map.new(fn %{key: key, type: type} ->
-      {key, get_ammo_type_value(type, key, ammo_type, extra_data)}
-    end)
-  end
-
-  defp get_ammo_type_value(:atom, key, ammo_type, _other_data),
-    do: ammo_type |> Map.get(key) |> humanize()
-
-  defp get_ammo_type_value(:round_count, _key, %{id: ammo_type_id}, %{round_counts: round_counts}),
-    do: Map.get(round_counts, ammo_type_id, 0)
-
-  defp get_ammo_type_value(
-         :historical_round_count,
-         _key,
-         %{id: ammo_type_id},
-         %{historical_round_counts: historical_round_counts}
-       ) do
-    Map.get(historical_round_counts, ammo_type_id, 0)
-  end
-
-  defp get_ammo_type_value(
-         :used_round_count,
-         _key,
-         %{id: ammo_type_id},
-         %{used_counts: used_counts}
-       ) do
-    Map.get(used_counts, ammo_type_id, 0)
-  end
-
-  defp get_ammo_type_value(
-         :historical_pack_count,
-         _key,
-         %{id: ammo_type_id},
-         %{historical_pack_counts: historical_pack_counts}
-       ) do
-    Map.get(historical_pack_counts, ammo_type_id, 0)
-  end
-
-  defp get_ammo_type_value(
-         :used_pack_count,
-         _key,
-         %{id: ammo_type_id},
-         %{used_pack_counts: used_pack_counts}
-       ) do
-    Map.get(used_pack_counts, ammo_type_id, 0)
-  end
-
-  defp get_ammo_type_value(:ammo_count, _key, %{id: ammo_type_id}, %{packs_count: packs_count}),
-    do: Map.get(packs_count, ammo_type_id)
-
-  defp get_ammo_type_value(
-         :avg_price_paid,
-         _key,
-         %{id: ammo_type_id},
-         %{average_costs: average_costs}
-       ) do
-    case Map.get(average_costs, ammo_type_id) do
-      nil -> {0, gettext("No cost information")}
-      count -> {count, gettext("$%{amount}", amount: display_currency(count))}
-    end
-  end
-
-  defp get_ammo_type_value(:name, _key, %{name: ammo_type_name} = ammo_type, _other_data) do
-    assigns = %{ammo_type: ammo_type}
-
-    {ammo_type_name,
-     ~H"""
-     <.link navigate={Routes.ammo_type_show_path(Endpoint, :show, @ammo_type)} class="link">
-       <%= @ammo_type.name %>
-     </.link>
-     """}
-  end
-
-  defp get_ammo_type_value(:actions, _key, ammo_type, %{actions: actions}) do
-    assigns = %{actions: actions, ammo_type: ammo_type}
-
-    ~H"""
-    <%= render_slot(@actions, @ammo_type) %>
-    """
-  end
-
-  defp get_ammo_type_value(nil, _key, _ammo_type, _other_data), do: nil
-
-  defp get_ammo_type_value(_other, key, ammo_type, _other_data), do: ammo_type |> Map.get(key)
-
-  @spec display_currency(float()) :: String.t()
-  defp display_currency(float), do: :erlang.float_to_binary(float, decimals: 2)
-end

lib/cannery_web/components/container_card.ex

@@ -0,0 +1,76 @@
+defmodule CanneryWeb.Components.ContainerCard do
+  @moduledoc """
+  Display card for a container
+  """
+
+  use CanneryWeb, :component
+  import CanneryWeb.Components.TagCard
+  alias Cannery.{Containers, Repo}
+  alias CanneryWeb.Endpoint
+
+  def container_card(%{container: container} = assigns) do
+    assigns = assigns |> Map.put(:container, container |> Repo.preload([:tags, :ammo_groups]))
+
+    ~H"""
+    <div
+      id={"container-#{@container.id}"}
+      class="overflow-hidden max-w-full mx-4 my-2 px-8 py-4 flex flex-col justify-center items-center space-y-4
+        border border-gray-400 rounded-lg shadow-lg hover:shadow-md
+        transition-all duration-300 ease-in-out"
+    >
+      <div class="max-w-full mb-4 flex flex-col justify-center items-center space-y-2">
+        <%= live_redirect to: Routes.container_show_path(Endpoint, :show, @container),
+                      class: "link" do %>
+          <h1 class="px-4 py-2 rounded-lg title text-xl">
+            <%= @container.name %>
+          </h1>
+        <% end %>
+
+        <%= if @container.desc do %>
+          <span class="rounded-lg title text-lg">
+            <%= gettext("Description:") %>
+            <%= @container.desc %>
+          </span>
+        <% end %>
+
+        <span class="rounded-lg title text-lg">
+          <%= gettext("Type:") %>
+          <%= @container.type %>
+        </span>
+
+        <%= if @container.location do %>
+          <span class="rounded-lg title text-lg">
+            <%= gettext("Location:") %>
+            <%= @container.location %>
+          </span>
+        <% end %>
+
+        <%= if @container.ammo_groups do %>
+          <span class="rounded-lg title text-lg">
+            <%= gettext("Rounds:") %>
+            <%= @container |> Containers.get_container_rounds!() %>
+          </span>
+        <% end %>
+
+        <div class="flex flex-wrap justify-center items-center">
+          <%= unless @container.tags |> Enum.empty?() do %>
+            <%= for tag <- @container.tags do %>
+              <.simple_tag_card tag={tag} />
+            <% end %>
+          <% end %>
+
+          <%= if assigns |> Map.has_key?(:tag_actions) do %>
+            <%= render_slot(@tag_actions) %>
+          <% end %>
+        </div>
+      </div>
+
+      <%= if assigns |> Map.has_key?(:inner_block) do %>
+        <div class="flex space-x-4 justify-center items-center">
+          <%= render_slot(@inner_block) %>
+        </div>
+      <% end %>
+    </div>
+    """
+  end
+end

lib/cannery_web/components/container_table_component.ex

@@ -1,161 +0,0 @@
-defmodule CanneryWeb.Components.ContainerTableComponent do
-  @moduledoc """
-  A component that displays a list of containers
-  """
-  use CanneryWeb, :live_component
-  alias Cannery.{Accounts.User, Ammo, Containers.Container}
-  alias Ecto.UUID
-  alias Phoenix.LiveView.{Rendered, Socket}
-
-  @impl true
-  @spec update(
-          %{
-            required(:id) => UUID.t(),
-            required(:current_user) => User.t(),
-            optional(:containers) => [Container.t()],
-            optional(:tag_actions) => Rendered.t(),
-            optional(:actions) => Rendered.t(),
-            optional(any()) => any()
-          },
-          Socket.t()
-        ) :: {:ok, Socket.t()}
-  def update(%{id: _id, containers: _containers, current_user: _current_user} = assigns, socket) do
-    socket =
-      socket
-      |> assign(assigns)
-      |> assign_new(:tag_actions, fn -> [] end)
-      |> assign_new(:actions, fn -> [] end)
-      |> display_containers()
-
-    {:ok, socket}
-  end
-
-  defp display_containers(
-         %{
-           assigns: %{
-             containers: containers,
-             current_user: current_user,
-             tag_actions: tag_actions,
-             actions: actions
-           }
-         } = socket
-       ) do
-    columns =
-      [
-        %{label: gettext("Name"), key: :name, type: :string},
-        %{label: gettext("Description"), key: :desc, type: :string},
-        %{label: gettext("Location"), key: :location, type: :string},
-        %{label: gettext("Type"), key: :type, type: :string}
-      ]
-      |> Enum.filter(fn %{key: key, type: type} ->
-        # remove columns if all values match defaults
-        default_value =
-          case type do
-            :boolean -> false
-            _other_type -> nil
-          end
-
-        containers
-        |> Enum.any?(fn container ->
-          type in [:tags, :actions] or not (container |> Map.get(key) == default_value)
-        end)
-      end)
-      |> Enum.concat([
-        %{label: gettext("Packs"), key: :packs, type: :integer},
-        %{label: gettext("Rounds"), key: :rounds, type: :integer},
-        %{label: gettext("Tags"), key: :tags, type: :tags},
-        %{label: gettext("Actions"), key: :actions, sortable: false, type: :actions}
-      ])
-
-    extra_data = %{
-      current_user: current_user,
-      tag_actions: tag_actions,
-      actions: actions,
-      pack_count: Ammo.get_ammo_groups_count_for_containers(containers, current_user),
-      round_count: Ammo.get_round_count_for_containers(containers, current_user)
-    }
-
-    rows =
-      containers
-      |> Enum.map(fn container ->
-        container |> get_row_data_for_container(columns, extra_data)
-      end)
-
-    socket
-    |> assign(
-      columns: columns,
-      rows: rows
-    )
-  end
-
-  @impl true
-  def render(assigns) do
-    ~H"""
-    <div id={@id} class="w-full">
-      <.live_component
-        module={CanneryWeb.Components.TableComponent}
-        id={"table-#{@id}"}
-        columns={@columns}
-        rows={@rows}
-      />
-    </div>
-    """
-  end
-
-  @spec get_row_data_for_container(Container.t(), columns :: [map()], extra_data :: map) :: map()
-  defp get_row_data_for_container(container, columns, extra_data) do
-    columns
-    |> Map.new(fn %{key: key} -> {key, get_value_for_key(key, container, extra_data)} end)
-  end
-
-  @spec get_value_for_key(atom(), Container.t(), extra_data :: map) :: any()
-  defp get_value_for_key(:name, %{id: id, name: container_name}, _extra_data) do
-    assigns = %{id: id, container_name: container_name}
-
-    {container_name,
-     ~H"""
-     <div class="flex flex-wrap justify-center items-center">
-       <.link navigate={Routes.container_show_path(Endpoint, :show, @id)} class="link">
-         <%= @container_name %>
-       </.link>
-     </div>
-     """}
-  end
-
-  defp get_value_for_key(:packs, %{id: container_id}, %{pack_count: pack_count}) do
-    pack_count |> Map.get(container_id, 0)
-  end
-
-  defp get_value_for_key(:rounds, %{id: container_id}, %{round_count: round_count}) do
-    round_count |> Map.get(container_id, 0)
-  end
-
-  defp get_value_for_key(:tags, container, %{tag_actions: tag_actions}) do
-    assigns = %{tag_actions: tag_actions, container: container}
-
-    tag_names =
-      container.tags
-      |> Enum.map(fn %{name: name} -> name end)
-      |> Enum.sort()
-      |> Enum.join(" ")
-
-    {tag_names,
-     ~H"""
-     <div class="flex flex-wrap justify-center items-center">
-       <.simple_tag_card :for={tag <- @container.tags} :if={@container.tags} tag={tag} />
-
-       <%= render_slot(@tag_actions, @container) %>
-     </div>
-     """}
-  end
-
-  defp get_value_for_key(:actions, container, %{actions: actions}) do
-    assigns = %{actions: actions, container: container}
-
-    ~H"""
-    <%= render_slot(@actions, @container) %>
-    """
-  end
-
-  defp get_value_for_key(key, container, _extra_data), do: container |> Map.get(key)
-end

lib/cannery_web/components/core_components.ex

@@ -1,149 +0,0 @@
-defmodule CanneryWeb.CoreComponents do
-  @moduledoc """
-  Provides core UI components.
-  """
-  use Phoenix.Component
-  import CanneryWeb.{Gettext, ViewHelpers}
-  alias Cannery.{Accounts, Accounts.Invite, Accounts.User}
-  alias Cannery.{Ammo, Ammo.AmmoGroup}
-  alias Cannery.{Containers.Container, Containers.Tag}
-  alias CanneryWeb.{Endpoint, HomeLive}
-  alias CanneryWeb.Router.Helpers, as: Routes
-  alias Phoenix.LiveView.{JS, Rendered}
-
-  embed_templates "core_components/*"
-
-  attr :title_content, :string, default: nil
-  attr :current_user, User, default: nil
-
-  def topbar(assigns)
-
-  attr :return_to, :string, required: true
-  slot(:inner_block)
-
-  @doc """
-  Renders a live component inside a modal.
-
-  The rendered modal receives a `:return_to` option to properly update
-  the URL when the modal is closed.
-
-  ## Examples
-
-      <.modal return_to={Routes.<%= schema.singular %>_index_path(Endpoint, :index)}>
-        <.live_component
-          module={<%= inspect context.web_module %>.<%= inspect Module.concat(schema.web_namespace, schema.alias) %>Live.FormComponent}
-          id={@<%= schema.singular %>.id || :new}
-          title={@page_title}
-          action={@live_action}
-          return_to={Routes.<%= schema.singular %>_index_path(Endpoint, :index)}
-          <%= schema.singular %>: @<%= schema.singular %>
-        />
-      </.modal>
-  """
-  def modal(assigns)
-
-  defp hide_modal(js \\ %JS{}) do
-    js
-    |> JS.hide(to: "#modal", transition: "fade-out")
-    |> JS.hide(to: "#modal-bg", transition: "fade-out")
-    |> JS.hide(to: "#modal-content", transition: "fade-out-scale")
-  end
-
-  attr :action, :string, required: true
-  attr :value, :boolean, required: true
-  attr :id, :string, default: nil
-  slot(:inner_block)
-
-  @doc """
-  A toggle button element that can be directed to a liveview or a
-  live_component's `handle_event/3`.
-
-  ## Examples
-
-  <.toggle_button action="my_liveview_action" value={@some_value}>
-    <span>Toggle me!</span>
-  </.toggle_button>
-  <.toggle_button action="my_live_component_action" target={@myself} value={@some_value}>
-    <span>Whatever you want</span>
-  </.toggle_button>
-  """
-  def toggle_button(assigns)
-
-  attr :container, Container, required: true
-  attr :current_user, User, required: true
-  slot(:tag_actions)
-  slot(:inner_block)
-
-  @spec container_card(assigns :: map()) :: Rendered.t()
-  def container_card(assigns)
-
-  attr :tag, Tag, required: true
-  slot(:inner_block, required: true)
-
-  def tag_card(assigns)
-
-  attr :tag, Tag, required: true
-
-  def simple_tag_card(assigns)
-
-  attr :ammo_group, AmmoGroup, required: true
-  attr :current_user, User, required: true
-  attr :original_count, :integer, default: nil
-  attr :cpr, :integer, default: nil
-  attr :last_used_date, Date, default: nil
-  attr :container, Container, default: nil
-  slot(:inner_block)
-
-  def ammo_group_card(assigns)
-
-  @spec display_currency(float()) :: String.t()
-  defp display_currency(float), do: :erlang.float_to_binary(float, decimals: 2)
-
-  attr :user, User, required: true
-  slot(:inner_block, required: true)
-
-  def user_card(assigns)
-
-  attr :invite, Invite, required: true
-  attr :use_count, :integer, default: nil
-  attr :current_user, User, required: true
-  slot(:inner_block)
-  slot(:code_actions)
-
-  def invite_card(assigns)
-
-  attr :content, :string, required: true
-  attr :filename, :string, default: "qrcode", doc: "filename without .png extension"
-  attr :image_class, :string, default: "w-64 h-max"
-  attr :width, :integer, default: 384, doc: "width of png to generate"
-
-  @doc """
-  Creates a downloadable QR Code element
-  """
-  def qr_code(assigns)
-
-  attr :id, :string, required: true
-  attr :date, :any, required: true, doc: "A `Date` struct or nil"
-
-  @doc """
-  Phoenix.Component for a <date> element that renders the Date in the user's
-  local timezone
-  """
-  def date(assigns)
-
-  attr :id, :string, required: true
-  attr :datetime, :any, required: true, doc: "A `DateTime` struct or nil"
-
-  @doc """
-  Phoenix.Component for a <time> element that renders the naivedatetime in the
-  user's local timezone
-  """
-  def datetime(assigns)
-
-  @spec cast_datetime(NaiveDateTime.t() | nil) :: String.t()
-  defp cast_datetime(%NaiveDateTime{} = datetime) do
-    datetime |> DateTime.from_naive!("Etc/UTC") |> DateTime.to_iso8601(:extended)
-  end
-
-  defp cast_datetime(_datetime), do: ""
-end

lib/cannery_web/components/core_components/ammo_group_card.html.heex

@@ -1,65 +0,0 @@
-<div
-  id={"ammo_group-#{@ammo_group.id}"}
-  class="mx-4 my-2 px-8 py-4
-    flex flex-col justify-center items-center
-    border border-gray-400 rounded-lg shadow-lg hover:shadow-md
-    transition-all duration-300 ease-in-out"
->
-  <.link navigate={Routes.ammo_group_show_path(Endpoint, :show, @ammo_group)} class="mb-2 link">
-    <h1 class="title text-xl title-primary-500">
-      <%= @ammo_group.ammo_type.name %>
-    </h1>
-  </.link>
-
-  <div class="flex flex-col justify-center items-center">
-    <span class="rounded-lg title text-lg">
-      <%= gettext("Count:") %>
-      <%= if @ammo_group.count == 0, do: gettext("Empty"), else: @ammo_group.count %>
-    </span>
-
-    <span
-      :if={@original_count && @original_count != @ammo_group.count}
-      class="rounded-lg title text-lg"
-    >
-      <%= gettext("Original Count:") %>
-      <%= @original_count %>
-    </span>
-
-    <span :if={@ammo_group.notes} class="rounded-lg title text-lg">
-      <%= gettext("Notes:") %>
-      <%= @ammo_group.notes %>
-    </span>
-
-    <span :if={@ammo_group.purchased_on} class="rounded-lg title text-lg">
-      <%= gettext("Purchased on:") %>
-      <.date id={"#{@ammo_group.id}-purchased-on"} date={@ammo_group.purchased_on} />
-    </span>
-
-    <span :if={@last_used_date} class="rounded-lg title text-lg">
-      <%= gettext("Last used on:") %>
-      <.date id={"#{@ammo_group.id}-last-used-on"} date={@last_used_date} />
-    </span>
-
-    <span :if={@ammo_group.price_paid} class="rounded-lg title text-lg">
-      <%= gettext("Price paid:") %>
-      <%= gettext("$%{amount}", amount: display_currency(@ammo_group.price_paid)) %>
-    </span>
-
-    <span :if={@cpr} class="rounded-lg title text-lg">
-      <%= gettext("CPR:") %>
-      <%= gettext("$%{amount}", amount: display_currency(@cpr)) %>
-    </span>
-
-    <span :if={@container} class="rounded-lg title text-lg">
-      <%= gettext("Container:") %>
-
-      <.link navigate={Routes.container_show_path(Endpoint, :show, @container)} class="link">
-        <%= @container.name %>
-      </.link>
-    </span>
-  </div>
-
-  <div :if={@inner_block} class="mt-4 flex space-x-4 justify-center items-center">
-    <%= render_slot(@inner_block) %>
-  </div>
-</div>

lib/cannery_web/components/core_components/container_card.html.heex

@@ -1,58 +0,0 @@
-<div
-  id={"container-#{@container.id}"}
-  class="overflow-hidden max-w-full mx-4 mb-4 px-8 py-4
-    flex flex-col justify-around items-center space-y-4
-    border border-gray-400 rounded-lg shadow-lg hover:shadow-md
-    transition-all duration-300 ease-in-out"
->
-  <.link navigate={Routes.container_show_path(Endpoint, :show, @container)} class="link">
-    <h1 class="px-4 py-2 rounded-lg title text-xl">
-      <%= @container.name %>
-    </h1>
-  </.link>
-
-  <div class="flex flex-col justify-center items-center space-y-2">
-    <span :if={@container.desc} class="rounded-lg title text-lg">
-      <%= gettext("Description:") %>
-      <%= @container.desc %>
-    </span>
-
-    <span class="rounded-lg title text-lg">
-      <%= gettext("Type:") %>
-      <%= @container.type %>
-    </span>
-
-    <span :if={@container.location} class="rounded-lg title text-lg">
-      <%= gettext("Location:") %>
-      <%= @container.location %>
-    </span>
-
-    <%= if @container |> Ammo.get_ammo_groups_count_for_container!(@current_user) != 0 do %>
-      <span class="rounded-lg title text-lg">
-        <%= gettext("Packs:") %>
-        <%= @container |> Ammo.get_ammo_groups_count_for_container!(@current_user) %>
-      </span>
-
-      <span class="rounded-lg title text-lg">
-        <%= gettext("Rounds:") %>
-        <%= @container |> Ammo.get_round_count_for_container!(@current_user) %>
-      </span>
-    <% end %>
-
-    <div
-      :if={@tag_actions || @container.tags != []}
-      class="flex flex-wrap justify-center items-center"
-    >
-      <.simple_tag_card :for={tag <- @container.tags} tag={tag} />
-
-      <%= if @tag_actions, do: render_slot(@tag_actions) %>
-    </div>
-  </div>
-
-  <div
-    :if={assigns |> Map.has_key?(:inner_block)}
-    class="flex space-x-4 justify-center items-center"
-  >
-    <%= render_slot(@inner_block) %>
-  </div>
-</div>

lib/cannery_web/components/core_components/date.html.heex

@@ -1,3 +0,0 @@
-<time :if={@date} id={@id} datetime={Date.to_iso8601(@date, :extended)} phx-hook="Date">
-  <%= Date.to_iso8601(@date, :extended) %>
-</time>

lib/cannery_web/components/core_components/datetime.html.heex

@@ -1,3 +0,0 @@
-<time :if={@datetime} id={@id} datetime={cast_datetime(@datetime)} phx-hook="DateTime">
-  <%= cast_datetime(@datetime) %>
-</time>

lib/cannery_web/components/core_components/invite_card.html.heex

@@ -1,46 +0,0 @@
-<div class="mx-4 my-2 px-8 py-4 flex flex-col justify-center items-center space-y-4
-  border border-gray-400 rounded-lg shadow-lg hover:shadow-md
-  transition-all duration-300 ease-in-out">
-  <h1 class="title text-xl">
-    <%= @invite.name %>
-  </h1>
-
-  <%= if @invite.disabled_at |> is_nil() do %>
-    <h2 class="title text-md">
-      <%= if @invite.uses_left do %>
-        <%= gettext(
-          "Uses Left: %{uses_left_count}",
-          uses_left_count: @invite.uses_left
-        ) %>
-      <% else %>
-        <%= gettext("Uses Left: Unlimited") %>
-      <% end %>
-    </h2>
-  <% else %>
-    <h2 class="title text-md">
-      <%= gettext("Invite Disabled") %>
-    </h2>
-  <% end %>
-
-  <.qr_code
-    content={Routes.user_registration_url(Endpoint, :new, invite: @invite.token)}
-    filename={@invite.name}
-  />
-
-  <h2 :if={@use_count && @use_count != 0} class="title text-md">
-    <%= gettext("Uses: %{uses_count}", uses_count: @use_count) %>
-  </h2>
-
-  <div class="flex flex-row flex-wrap justify-center items-center">
-    <code
-      id={"code-#{@invite.id}"}
-      class="mx-2 my-1 text-xs px-4 py-2 rounded-lg text-center break-all text-gray-100 bg-primary-800"
-      phx-no-format
-    ><%= Routes.user_registration_url(Endpoint, :new, invite: @invite.token) %></code>
-    <%= if @code_actions, do: render_slot(@code_actions) %>
-  </div>
-
-  <div :if={@inner_block} class="flex space-x-4 justify-center items-center">
-    <%= render_slot(@inner_block) %>
-  </div>
-</div>

lib/cannery_web/components/core_components/modal.html.heex

@@ -1,44 +0,0 @@
-<.link
-  patch={@return_to}
-  id="modal-bg"
-  class="fade-in fixed z-10 left-0 top-0
-    w-full h-full overflow-hidden
-    p-8 flex flex-col justify-center items-center cursor-auto"
-  style="background-color: rgba(0,0,0,0.4);"
-  phx-remove={hide_modal()}
-  aria-label={gettext("Close modal")}
->
-  <span class="hidden"></span>
-</.link>
-
-<div
-  id="modal"
-  class="fixed z-10 left-0 top-0 pointer-events-none
-    w-full h-full overflow-hidden
-    p-4 sm:p-8 flex flex-col justify-center items-center"
->
-  <div
-    id="modal-content"
-    class="fade-in-scale w-full max-w-3xl relative
-      pointer-events-auto overflow-hidden
-      px-8 py-4 sm:py-8
-      flex flex-col justify-start items-center
-      bg-white border-2 rounded-lg"
-  >
-    <.link
-      patch={@return_to}
-      id="close"
-      class="absolute top-8 right-10
-        text-gray-500 hover:text-gray-800
-        transition-all duration-500 ease-in-out"
-      phx-remove={hide_modal()}
-      aria-label={gettext("Close modal")}
-    >
-      <i class="fa-fw fa-lg fas fa-times"></i>
-    </.link>
-
-    <div class="overflow-x-hidden overflow-y-auto w-full p-8 flex flex-col space-y-4 justify-start items-center">
-      <%= render_slot(@inner_block) %>
-    </div>
-  </div>
-</div>

lib/cannery_web/components/core_components/qr_code.html.heex

@@ -1,3 +0,0 @@
-<a href={qr_code_image(@content)} download={@filename <> ".png"}>
-  <img class={@image_class} alt={@filename} src={qr_code_image(@content)} />
-</a>

lib/cannery_web/components/core_components/simple_tag_card.html.heex

@@ -1,6 +0,0 @@
-<h1
-  class="inline-block break-all mx-2 my-1 px-4 py-2 rounded-lg title text-xl"
-  style={"color: #{@tag.text_color}; background-color: #{@tag.bg_color}"}
->
-  <%= @tag.name %>
-</h1>

lib/cannery_web/components/core_components/tag_card.html.heex

@@ -1,9 +0,0 @@
-<div
-  id={"tag-#{@tag.id}"}
-  class="mx-4 mb-4 px-8 py-4 space-x-4 flex justify-center items-center
-    border border-gray-400 rounded-lg shadow-lg hover:shadow-md
-    transition-all duration-300 ease-in-out"
->
-  <.simple_tag_card tag={@tag} />
-  <%= render_slot(@inner_block) %>
-</div>

lib/cannery_web/components/core_components/toggle_button.html.heex

@@ -1,30 +0,0 @@
-<label for={@id || @action} class="relative inline-flex items-center cursor-pointer">
-  <input
-    id={@id || @action}
-    type="checkbox"
-    value={@value}
-    checked={@value}
-    class="sr-only peer"
-    aria-labelledby={"#{@id || @action}-label"}
-    {
-      if assigns |> Map.has_key?(:target),
-        do: %{"phx-click": @action, "phx-value-value": @value, "phx-target": @target},
-        else: %{"phx-click": @action, "phx-value-value": @value}
-    }
-  />
-  <div class="w-11 h-6 bg-gray-300 rounded-full peer
-    peer-focus:ring-4 peer-focus:ring-teal-300 dark:peer-focus:ring-teal-800
-    peer-checked:bg-gray-600
-    peer-checked:after:translate-x-full peer-checked:after:border-white
-    after:content-[''] after:absolute after:top-1 after:left-[2px] after:bg-white after:border-gray-300
-    after:border after:rounded-full after:h-5 after:w-5
-    after:transition-all after:duration-250 after:ease-in-out
-    transition-colors duration-250 ease-in-out">
-  </div>
-  <span
-    id={"#{@id || @action}-label"}
-    class="ml-3 text-sm font-medium text-gray-900 dark:text-gray-300 whitespace-nowrap"
-  >
-    <%= render_slot(@inner_block) %>
-  </span>
-</label>

lib/cannery_web/components/core_components/topbar.html.heex

@@ -1,130 +0,0 @@
-<nav role="navigation" class="mb-8 px-8 py-4 w-full bg-primary-500">
-  <div class="flex flex-col sm:flex-row justify-between items-center">
-    <div class="mb-4 sm:mb-0 sm:mr-8 flex flex-row justify-start items-center space-x-2">
-      <.link
-        navigate={Routes.live_path(Endpoint, HomeLive)}
-        class="inline mx-2 my-1 leading-5 text-xl text-white"
-      >
-        <img
-          src={Routes.static_path(Endpoint, "/images/cannery.svg")}
-          alt={gettext("Cannery logo")}
-          class="inline-block h-8 mx-1"
-        />
-        <h1 class="inline hover:underline">Cannery</h1>
-      </.link>
-
-      <%= if @title_content do %>
-        <span class="mx-2 my-1">
-          |
-        </span>
-        <%= @title_content %>
-      <% end %>
-    </div>
-
-    <hr class="mb-2 sm:hidden hr-light" />
-
-    <ul class="flex flex-row flex-wrap justify-center items-center
-      text-lg text-white text-ellipsis">
-      <%= if @current_user do %>
-        <li class="mx-2 my-1">
-          <.link
-            navigate={Routes.tag_index_path(Endpoint, :index)}
-            class="text-white hover:underline"
-          >
-            <%= gettext("Tags") %>
-          </.link>
-        </li>
-        <li class="mx-2 my-1">
-          <.link
-            navigate={Routes.container_index_path(Endpoint, :index)}
-            class="text-white hover:underline"
-          >
-            <%= gettext("Containers") %>
-          </.link>
-        </li>
-        <li class="mx-2 my-1">
-          <.link
-            navigate={Routes.ammo_type_index_path(Endpoint, :index)}
-            class="text-white hover:underline"
-          >
-            <%= gettext("Catalog") %>
-          </.link>
-        </li>
-        <li class="mx-2 my-1">
-          <.link
-            navigate={Routes.ammo_group_index_path(Endpoint, :index)}
-            class="text-white hover:underline"
-          >
-            <%= gettext("Ammo") %>
-          </.link>
-        </li>
-        <li class="mx-2 my-1">
-          <.link
-            navigate={Routes.range_index_path(Endpoint, :index)}
-            class="text-white hover:underline"
-          >
-            <%= gettext("Range") %>
-          </.link>
-        </li>
-        <li :if={@current_user |> Accounts.is_already_admin?()} class="mx-2 my-1">
-          <.link
-            navigate={Routes.invite_index_path(Endpoint, :index)}
-            class="text-white hover:underline"
-          >
-            <%= gettext("Invites") %>
-          </.link>
-        </li>
-        <li class="mx-2 my-1">
-          <.link
-            href={Routes.user_settings_path(Endpoint, :edit)}
-            class="text-white hover:underline truncate"
-          >
-            <%= @current_user.email %>
-          </.link>
-        </li>
-        <li class="mx-2 my-1">
-          <.link
-            href={Routes.user_session_path(Endpoint, :delete)}
-            method="delete"
-            data-confirm={dgettext("prompts", "Are you sure you want to log out?")}
-            aria-label={gettext("Log out")}
-          >
-            <i class="fas fa-sign-out-alt"></i>
-          </.link>
-        </li>
-        <li
-          :if={
-            @current_user |> Accounts.is_already_admin?() and
-              function_exported?(Routes, :live_dashboard_path, 2)
-          }
-          class="mx-2 my-1"
-        >
-          <.link
-            navigate={Routes.live_dashboard_path(Endpoint, :home)}
-            class="text-white hover:underline"
-            aria-label={gettext("Live Dashboard")}
-          >
-            <i class="fas fa-gauge"></i>
-          </.link>
-        </li>
-      <% else %>
-        <li :if={Accounts.allow_registration?()} class="mx-2 my-1">
-          <.link
-            href={Routes.user_registration_path(Endpoint, :new)}
-            class="text-white hover:underline truncate"
-          >
-            <%= dgettext("actions", "Register") %>
-          </.link>
-        </li>
-        <li class="mx-2 my-1">
-          <.link
-            href={Routes.user_session_path(Endpoint, :new)}
-            class="text-white hover:underline truncate"
-          >
-            <%= dgettext("actions", "Log in") %>
-          </.link>
-        </li>
-      <% end %>
-    </ul>
-  </div>
-</nav>

lib/cannery_web/components/core_components/user_card.html.heex

@@ -1,36 +0,0 @@
-<div
-  id={"user-#{@user.id}"}
-  class="mx-4 my-2 px-8 py-4 flex flex-col justify-center items-center text-center
-    border border-gray-400 rounded-lg shadow-lg hover:shadow-md
-    transition-all duration-300 ease-in-out"
->
-  <h1 class="px-4 py-2 rounded-lg title text-xl break-all">
-    <%= @user.email %>
-  </h1>
-
-  <h3 class="px-4 py-2 rounded-lg title text-lg">
-    <p>
-      <%= if @user.confirmed_at do %>
-        <%= gettext(
-          "User was confirmed at%{confirmed_datetime}",
-          confirmed_datetime: ""
-        ) %>
-        <.datetime id={"#{@user.id}-confirmed-at"} datetime={@user.confirmed_at} />
-      <% else %>
-        <%= gettext("Email unconfirmed") %>
-      <% end %>
-    </p>
-
-    <p>
-      <%= gettext(
-        "User registered on%{registered_datetime}",
-        registered_datetime: ""
-      ) %>
-      <.datetime id={"#{@user.id}-inserted-at"} datetime={@user.inserted_at} />
-    </p>
-  </h3>
-
-  <div :if={@inner_block} class="px-4 py-2 flex space-x-4 justify-center items-center">
-    <%= render_slot(@inner_block) %>
-  </div>
-</div>

lib/cannery_web/components/invite_card.ex

@@ -0,0 +1,50 @@
+defmodule CanneryWeb.Components.InviteCard do
+  @moduledoc """
+  Display card for an invite
+  """
+
+  use CanneryWeb, :component
+  alias CanneryWeb.Endpoint
+
+  def invite_card(assigns) do
+    ~H"""
+    <div class="mx-4 my-2 px-8 py-4 flex flex-col justify-center items-center space-y-4
+      border border-gray-400 rounded-lg shadow-lg hover:shadow-md
+      transition-all duration-300 ease-in-out">
+      <h1 class="title text-xl">
+        <%= @invite.name %>
+      </h1>
+
+      <%= if @invite.disabled_at |> is_nil() do %>
+        <h2 class="title text-md">
+          <%= gettext("Uses Left:") %>
+          <%= @invite.uses_left || "Unlimited" %>
+        </h2>
+      <% else %>
+        <h2 class="title text-md">
+          <%= gettext("Invite Disabled") %>
+        </h2>
+      <% end %>
+
+      <div class="flex flex-row flex-wrap justify-center items-center">
+        <code
+          id={"code-#{@invite.id}"}
+          class="mx-2 my-1 text-xs px-4 py-2 rounded-lg text-center break-all text-gray-100 bg-primary-800"
+        >
+          <%= Routes.user_registration_url(Endpoint, :new, invite: @invite.token) %>
+        </code>
+
+        <%= if @code_actions do %>
+          <%= render_slot(@code_actions) %>
+        <% end %>
+      </div>
+
+      <%= if @inner_block do %>
+        <div class="flex space-x-4 justify-center items-center">
+          <%= render_slot(@inner_block) %>
+        </div>
+      <% end %>
+    </div>
+    """
+  end
+end

lib/cannery_web/components/move_ammo_group_component.ex

@@ -6,7 +6,6 @@ defmodule CanneryWeb.Components.MoveAmmoGroupComponent do
   use CanneryWeb, :live_component
   alias Cannery.{Accounts.User, Ammo, Ammo.AmmoGroup, Containers, Containers.Container}
   alias CanneryWeb.Endpoint
-  alias Ecto.Changeset
   alias Phoenix.LiveView.Socket
 
   @impl true
@@ -23,7 +22,7 @@ defmodule CanneryWeb.Components.MoveAmmoGroupComponent do
           assigns,
         socket
       ) do
-    changeset = ammo_group |> AmmoGroup.update_changeset(%{}, current_user)
+    changeset = Ammo.change_ammo_group(ammo_group)
 
     containers =
       Containers.list_containers(current_user)
@@ -52,9 +51,10 @@ defmodule CanneryWeb.Components.MoveAmmoGroupComponent do
       |> case do
         {:ok, _ammo_group} ->
           prompt = dgettext("prompts", "Ammo moved to %{name} successfully", name: container_name)
-          socket |> put_flash(:info, prompt) |> push_navigate(to: return_to)
 
-        {:error, %Changeset{} = changeset} ->
+          socket |> put_flash(:info, prompt) |> push_redirect(to: return_to)
+
+        {:error, %Ecto.Changeset{} = changeset} ->
           socket |> assign(changeset: changeset)
       end
 
@@ -64,10 +64,10 @@ defmodule CanneryWeb.Components.MoveAmmoGroupComponent do
   @impl true
   def render(%{containers: containers} = assigns) do
     columns = [
-      %{label: gettext("Container"), key: :name},
-      %{label: gettext("Type"), key: :type},
-      %{label: gettext("Location"), key: :location},
-      %{label: gettext("Actions"), key: :actions, sortable: false}
+      %{label: gettext("Container"), key: "name"},
+      %{label: gettext("Type"), key: "type"},
+      %{label: gettext("Location"), key: "location"},
+      %{label: nil, key: "actions", sortable: false}
     ]
 
     rows = containers |> get_rows_for_containers(assigns, columns)
@@ -77,7 +77,7 @@ defmodule CanneryWeb.Components.MoveAmmoGroupComponent do
     ~H"""
     <div class="w-full flex flex-col space-y-8 justify-center items-center">
       <h2 class="mb-8 text-center title text-xl text-primary-600">
-        <%= dgettext("actions", "Move ammo") %>
+        <%= gettext("Move ammo") %>
       </h2>
 
       <%= if @containers |> Enum.empty?() do %>
@@ -86,9 +86,10 @@ defmodule CanneryWeb.Components.MoveAmmoGroupComponent do
           <%= display_emoji("😔") %>
         </h2>
 
-        <.link navigate={Routes.container_index_path(Endpoint, :new)} class="btn btn-primary">
-          <%= dgettext("actions", "Add another container!") %>
-        </.link>
+        <%= live_patch(dgettext("actions", "Add another container!"),
+          to: Routes.container_index_path(Endpoint, :new),
+          class: "btn btn-primary"
+        ) %>
       <% else %>
         <.live_component
           module={CanneryWeb.Components.TableComponent}
@@ -106,12 +107,12 @@ defmodule CanneryWeb.Components.MoveAmmoGroupComponent do
     containers
     |> Enum.map(fn container ->
       columns
-      |> Map.new(fn %{key: key} -> {key, get_row_value_by_key(key, container, assigns)} end)
+      |> Enum.into(%{}, fn %{key: key} -> {key, get_row_value_by_key(key, container, assigns)} end)
     end)
   end
 
-  @spec get_row_value_by_key(atom(), Container.t(), map()) :: any()
-  defp get_row_value_by_key(:actions, container, assigns) do
+  @spec get_row_value_by_key(String.t(), Container.t(), map()) :: any()
+  defp get_row_value_by_key("actions", container, assigns) do
     assigns = assigns |> Map.put(:container, container)
 
     ~H"""
@@ -121,7 +122,7 @@ defmodule CanneryWeb.Components.MoveAmmoGroupComponent do
         class="btn btn-primary"
         phx-click="move"
         phx-target={@myself}
-        phx-value-container_id={@container.id}
+        phx-value-container_id={container.id}
       >
         <%= dgettext("actions", "Select") %>
       </button>
@@ -129,5 +130,6 @@ defmodule CanneryWeb.Components.MoveAmmoGroupComponent do
     """
   end
 
-  defp get_row_value_by_key(key, container, _assigns), do: container |> Map.get(key)
+  defp get_row_value_by_key(key, container, _assigns),
+    do: container |> Map.get(key |> String.to_existing_atom())
 end

lib/cannery_web/components/shot_group_table_component.ex

@@ -1,120 +0,0 @@
-defmodule CanneryWeb.Components.ShotGroupTableComponent do
-  @moduledoc """
-  A component that displays a list of shot groups
-  """
-  use CanneryWeb, :live_component
-  alias Cannery.{Accounts.User, ActivityLog.ShotGroup, Ammo, ComparableDate}
-  alias Ecto.UUID
-  alias Phoenix.LiveView.{Rendered, Socket}
-
-  @impl true
-  @spec update(
-          %{
-            required(:id) => UUID.t(),
-            required(:current_user) => User.t(),
-            optional(:shot_groups) => [ShotGroup.t()],
-            optional(:actions) => Rendered.t(),
-            optional(any()) => any()
-          },
-          Socket.t()
-        ) :: {:ok, Socket.t()}
-  def update(%{id: _id, shot_groups: _shot_groups, current_user: _current_user} = assigns, socket) do
-    socket =
-      socket
-      |> assign(assigns)
-      |> assign_new(:actions, fn -> [] end)
-      |> display_shot_groups()
-
-    {:ok, socket}
-  end
-
-  defp display_shot_groups(
-         %{
-           assigns: %{
-             shot_groups: shot_groups,
-             current_user: current_user,
-             actions: actions
-           }
-         } = socket
-       ) do
-    columns = [
-      %{label: gettext("Ammo"), key: :name},
-      %{label: gettext("Rounds shot"), key: :count},
-      %{label: gettext("Notes"), key: :notes},
-      %{label: gettext("Date"), key: :date, type: ComparableDate},
-      %{label: gettext("Actions"), key: :actions, sortable: false}
-    ]
-
-    ammo_groups =
-      shot_groups
-      |> Enum.map(fn %{ammo_group_id: ammo_group_id} -> ammo_group_id end)
-      |> Ammo.get_ammo_groups(current_user)
-
-    extra_data = %{current_user: current_user, actions: actions, ammo_groups: ammo_groups}
-
-    rows =
-      shot_groups
-      |> Enum.map(fn shot_group ->
-        shot_group |> get_row_data_for_shot_group(columns, extra_data)
-      end)
-
-    socket
-    |> assign(
-      columns: columns,
-      rows: rows
-    )
-  end
-
-  @impl true
-  def render(assigns) do
-    ~H"""
-    <div id={@id} class="w-full">
-      <.live_component
-        module={CanneryWeb.Components.TableComponent}
-        id={"table-#{@id}"}
-        columns={@columns}
-        rows={@rows}
-        initial_key={:date}
-        initial_sort_mode={:desc}
-      />
-    </div>
-    """
-  end
-
-  @spec get_row_data_for_shot_group(ShotGroup.t(), columns :: [map()], extra_data :: map()) ::
-          map()
-  defp get_row_data_for_shot_group(shot_group, columns, extra_data) do
-    columns
-    |> Map.new(fn %{key: key} ->
-      {key, get_row_value(key, shot_group, extra_data)}
-    end)
-  end
-
-  defp get_row_value(:name, %{ammo_group_id: ammo_group_id}, %{ammo_groups: ammo_groups}) do
-    assigns = %{ammo_group: ammo_group = Map.fetch!(ammo_groups, ammo_group_id)}
-
-    {ammo_group.ammo_type.name,
-     ~H"""
-     <.link navigate={Routes.ammo_group_show_path(Endpoint, :show, @ammo_group)} class="link">
-       <%= @ammo_group.ammo_type.name %>
-     </.link>
-     """}
-  end
-
-  defp get_row_value(:date, %{date: date} = assigns, _extra_data) do
-    {date,
-     ~H"""
-     <.date id={"#{@id}-date"} date={@date} />
-     """}
-  end
-
-  defp get_row_value(:actions, shot_group, %{actions: actions}) do
-    assigns = %{actions: actions, shot_group: shot_group}
-
-    ~H"""
-    <%= render_slot(@actions, @shot_group) %>
-    """
-  end
-
-  defp get_row_value(key, shot_group, _extra_data), do: shot_group |> Map.get(key)
-end

lib/cannery_web/components/table_component.ex

@@ -6,7 +6,7 @@ defmodule CanneryWeb.Components.TableComponent do
     - `:columns`: An array of maps containing the following keys
       - `:label`: A gettext'd or otherwise user-facing string label for the
         column. Can be nil
-      - `:key`: An atom key used for sorting
+      - `:key`: A string key used for sorting
       - `:class`: Extra classes to be applied to the column element, if desired.
         Optional
       - `:sortable`: If false, will prevent the user from sorting with it.
@@ -21,7 +21,6 @@ defmodule CanneryWeb.Components.TableComponent do
 
   use CanneryWeb, :live_component
   alias Phoenix.LiveView.Socket
-  require Integer
 
   @impl true
   @spec update(
@@ -29,53 +28,26 @@ defmodule CanneryWeb.Components.TableComponent do
             required(:columns) =>
               list(%{
                 required(:label) => String.t() | nil,
-                required(:key) => atom() | nil,
+                required(:key) => String.t() | nil,
                 optional(:class) => String.t(),
-                optional(:row_class) => String.t(),
-                optional(:alternate_row_class) => String.t(),
-                optional(:sortable) => false,
-                optional(:type) => module()
+                optional(:sortable) => false
               }),
             required(:rows) =>
               list(%{
-                (key :: atom()) => any() | {custom_sort_value :: String.t(), value :: any()}
+                (key :: String.t()) => any() | {custom_sort_value :: String.t(), value :: any()}
               }),
-            optional(:inital_key) => atom(),
-            optional(:initial_sort_mode) => atom(),
             optional(any()) => any()
           },
           Socket.t()
         ) :: {:ok, Socket.t()}
   def update(%{columns: columns, rows: rows} = assigns, socket) do
-    initial_key =
-      if assigns |> Map.has_key?(:initial_key) do
-        assigns.initial_key
-      else
-        columns |> List.first(%{}) |> Map.get(:key)
-      end
-
-    initial_sort_mode =
-      if assigns |> Map.has_key?(:initial_sort_mode) do
-        assigns.initial_sort_mode
-      else
-        :asc
-      end
-
-    type = columns |> Enum.find(%{}, fn %{key: key} -> key == initial_key end) |> Map.get(:type)
-    rows = rows |> sort_by_custom_sort_value_or_value(initial_key, initial_sort_mode, type)
+    initial_key = columns |> List.first() |> Map.get(:key)
+    rows = rows |> Enum.sort_by(fn row -> row |> Map.get(initial_key) end, :asc)
 
     socket =
       socket
       |> assign(assigns)
-      |> assign(
-        columns: columns,
-        rows: rows,
-        key: initial_key,
-        last_sort_key: initial_key,
-        sort_mode: initial_sort_mode
-      )
-      |> assign_new(:row_class, fn -> "bg-white" end)
-      |> assign_new(:alternate_row_class, fn -> "bg-gray-200" end)
+      |> assign(columns: columns, rows: rows, last_sort_key: initial_key, sort_mode: :asc)
 
     {:ok, socket}
   end
@@ -84,46 +56,23 @@ defmodule CanneryWeb.Components.TableComponent do
   def handle_event(
         "sort_by",
         %{"sort-key" => key},
-        %{
-          assigns: %{
-            columns: columns,
-            rows: rows,
-            last_sort_key: last_sort_key,
-            sort_mode: sort_mode
-          }
-        } = socket
+        %{assigns: %{rows: rows, last_sort_key: key, sort_mode: sort_mode}} = socket
       ) do
-    key = key |> String.to_existing_atom()
-
-    sort_mode =
-      case {key, sort_mode} do
-        {^last_sort_key, :asc} -> :desc
-        {^last_sort_key, :desc} -> :asc
-        {_new_sort_key, _last_sort_mode} -> :asc
-      end
-
-    type =
-      columns |> Enum.find(%{}, fn %{key: column_key} -> column_key == key end) |> Map.get(:type)
-
-    rows = rows |> sort_by_custom_sort_value_or_value(key, sort_mode, type)
-    {:noreply, socket |> assign(last_sort_key: key, sort_mode: sort_mode, rows: rows)}
+    sort_mode = if sort_mode == :asc, do: :desc, else: :asc
+    rows = rows |> sort_by_custom_sort_value_or_value(key, sort_mode)
+    {:noreply, socket |> assign(sort_mode: sort_mode, rows: rows)}
   end
 
-  defp sort_by_custom_sort_value_or_value(rows, key, sort_mode, type)
-       when type in [Date, DateTime] do
-    rows
-    |> Enum.sort_by(
-      fn row ->
-        case row |> Map.get(key) do
-          {custom_sort_key, _value} -> custom_sort_key
-          value -> value
-        end
-      end,
-      {sort_mode, type}
-    )
+  def handle_event(
+        "sort_by",
+        %{"sort-key" => key},
+        %{assigns: %{rows: rows}} = socket
+      ) do
+    rows = rows |> sort_by_custom_sort_value_or_value(key, :asc)
+    {:noreply, socket |> assign(last_sort_key: key, sort_mode: :asc, rows: rows)}
   end
 
-  defp sort_by_custom_sort_value_or_value(rows, key, sort_mode, _type) do
+  defp sort_by_custom_sort_value_or_value(rows, key, sort_mode) do
     rows
     |> Enum.sort_by(
       fn row ->
@@ -135,25 +84,4 @@ defmodule CanneryWeb.Components.TableComponent do
       sort_mode
     )
   end
-
-  @doc """
-  Conditionally composes elements into the columns list, supports maps and
-  lists. Works tail to front in order for efficiency
-
-      iex> []
-      ...> |> maybe_compose_columns(%{label: "Column 3"}, true)
-      ...> |> maybe_compose_columns(%{label: "Column 2"}, false)
-      ...> |> maybe_compose_columns(%{label: "Column 1"})
-      [%{label: "Column 1"}, %{label: "Column 3"}]
-
-  """
-  @spec maybe_compose_columns(list(), element_to_add :: list() | map()) :: list()
-  @spec maybe_compose_columns(list(), element_to_add :: list() | map(), boolean()) :: list()
-  def maybe_compose_columns(columns, element_or_elements, add? \\ true)
-
-  def maybe_compose_columns(columns, elements, true) when is_list(elements),
-    do: Enum.concat(elements, columns)
-
-  def maybe_compose_columns(columns, element, true) when is_map(element), do: [element | columns]
-  def maybe_compose_columns(columns, _element_or_elements, false), do: columns
 end

lib/cannery_web/components/table_component.html.heex

@@ -1,32 +1,31 @@
-<div id={@id} class="w-full overflow-x-auto border border-gray-600 rounded-lg shadow-lg bg-white">
+<div class="w-full overflow-x-auto border border-gray-600 rounded-lg shadow-lg bg-black">
   <table class="min-w-full table-auto text-center bg-white">
     <thead class="border-b border-primary-600">
       <tr>
         <%= for %{key: key, label: label} = column <- @columns do %>
           <%= if column |> Map.get(:sortable, true) do %>
-            <th class={["p-2", column[:class]]}>
+            <th class={"p-2 #{column[:class]}"}>
               <span
-                class="cursor-pointer flex justify-center items-center space-x-2"
+                class="cursor-pointer"
                 phx-click="sort_by"
                 phx-value-sort-key={key}
                 phx-target={@myself}
               >
-                <i class="w-0 float-right fas fa-sm fa-chevron-up opacity-0"></i>
-                <span class={if @last_sort_key == key, do: "underline"}><%= label %></span>
+                <span class="underline"><%= label %></span>
                 <%= if @last_sort_key == key do %>
                   <%= case @sort_mode do %>
                     <% :asc -> %>
-                      <i class="w-0 float-right fas fa-sm fa-chevron-down"></i>
+                      <i class="fas fa-sm fa-chevron-down"></i>
                     <% :desc -> %>
-                      <i class="w-0 float-right fas fa-sm fa-chevron-up"></i>
+                      <i class="fas fa-sm fa-chevron-up"></i>
                   <% end %>
                 <% else %>
-                  <i class="w-0 float-right fas fa-sm fa-chevron-up opacity-0"></i>
+                  <i class="fas fa-sm fa-chevron-up opacity-0"></i>
                 <% end %>
               </span>
             </th>
           <% else %>
-            <th class={["p-2 cursor-not-allowed", column[:class]]}>
+            <th class={"p-2 #{column[:class]}"}>
               <%= label %>
             </th>
           <% end %>
@@ -34,19 +33,20 @@
       </tr>
     </thead>
     <tbody>
-      <tr
-        :for={{values, i} <- @rows |> Enum.with_index()}
-        class={if i |> Integer.is_even(), do: @row_class, else: @alternate_row_class}
-      >
-        <td :for={%{key: key} = value <- @columns} class={["p-2", value[:class]]}>
-          <%= case values |> Map.get(key) do %>
-            <% {_custom_sort_value, value} -> %>
-              <%= value %>
-            <% value -> %>
-              <%= value %>
+      <%= for values <- @rows do %>
+        <tr>
+          <%= for %{key: key} = value <- @columns do %>
+            <td class={"p-2 #{value[:class]}"}>
+              <%= case values |> Map.get(key) do %>
+                <% {_custom_sort_value, value} -> %>
+                  <%= value %>
+                <% value -> %>
+                  <%= value %>
+              <% end %>
+            </td>
           <% end %>
-        </td>
-      </tr>
+        </tr>
+      <% end %>
     </tbody>
   </table>
 </div>

lib/cannery_web/components/tag_card.ex

@@ -0,0 +1,32 @@
+defmodule CanneryWeb.Components.TagCard do
+  @moduledoc """
+  Display card for a tag
+  """
+
+  use CanneryWeb, :component
+
+  def tag_card(assigns) do
+    ~H"""
+    <div
+      id={"tag-#{@tag.id}"}
+      class="mx-4 my-2 px-8 py-4 space-x-4 flex justify-center items-center
+          border border-gray-400 rounded-lg shadow-lg hover:shadow-md
+          transition-all duration-300 ease-in-out"
+    >
+      <.simple_tag_card tag={@tag} />
+      <%= render_slot(@inner_block) %>
+    </div>
+    """
+  end
+
+  def simple_tag_card(assigns) do
+    ~H"""
+    <h1
+      class="inline-block break-all mx-2 my-1 px-4 py-2 rounded-lg title text-xl"
+      style={"color: #{@tag.text_color}; background-color: #{@tag.bg_color}"}
+    >
+      <%= @tag.name %>
+    </h1>
+    """
+  end
+end

lib/cannery_web/components/topbar.ex

@@ -0,0 +1,117 @@
+defmodule CanneryWeb.Components.Topbar do
+  @moduledoc """
+  Component that renders a topbar with user functions/links
+  """
+
+  use CanneryWeb, :component
+
+  alias Cannery.Accounts
+  alias CanneryWeb.{Endpoint, HomeLive}
+
+  def topbar(assigns) do
+    assigns =
+      %{results: [], title_content: nil, flash: nil, current_user: nil} |> Map.merge(assigns)
+
+    ~H"""
+    <nav role="navigation" class="mb-8 px-8 py-4 w-full bg-primary-400">
+      <div class="flex flex-col sm:flex-row justify-between items-center">
+        <div class="mb-4 sm:mb-0 sm:mr-8 flex flex-row justify-start items-center space-x-2">
+          <%= live_redirect("Cannery",
+            to: Routes.live_path(Endpoint, HomeLive),
+            class: "mx-2 my-1 leading-5 text-xl text-white hover:underline"
+          ) %>
+
+          <%= if @title_content do %>
+            <span class="mx-2 my-1">
+              |
+            </span>
+            <%= @title_content %>
+          <% end %>
+        </div>
+
+        <hr class="mb-2 sm:hidden hr-light" />
+
+        <ul class="flex flex-row flex-wrap justify-center items-center
+          text-lg text-white text-ellipsis">
+          <%= if @current_user do %>
+            <li class="mx-2 my-1">
+              <%= live_redirect(gettext("Tags"),
+                to: Routes.tag_index_path(Endpoint, :index),
+                class: "text-primary-600 text-white hover:underline"
+              ) %>
+            </li>
+            <li class="mx-2 my-1">
+              <%= live_redirect(gettext("Containers"),
+                to: Routes.container_index_path(Endpoint, :index),
+                class: "text-primary-600 text-white hover:underline"
+              ) %>
+            </li>
+            <li class="mx-2 my-1">
+              <%= live_redirect(gettext("Ammo"),
+                to: Routes.ammo_type_index_path(Endpoint, :index),
+                class: "text-primary-600 text-white hover:underline"
+              ) %>
+            </li>
+            <li class="mx-2 my-1">
+              <%= live_redirect(gettext("Manage"),
+                to: Routes.ammo_group_index_path(Endpoint, :index),
+                class: "text-primary-600 text-white hover:underline"
+              ) %>
+            </li>
+            <li class="mx-2 my-1">
+              <%= live_redirect(gettext("Range"),
+                to: Routes.range_index_path(Endpoint, :index),
+                class: "text-primary-600 text-white hover:underline"
+              ) %>
+            </li>
+            <%= if @current_user.role == :admin do %>
+              <li class="mx-2 my-1">
+                <%= live_redirect(gettext("Invites"),
+                  to: Routes.invite_index_path(Endpoint, :index),
+                  class: "text-primary-600 text-white hover:underline"
+                ) %>
+              </li>
+            <% end %>
+            <li class="mx-2 my-1">
+              <%= live_redirect(@current_user.email,
+                to: Routes.user_settings_path(Endpoint, :edit),
+                class: "text-primary-600 text-white hover:underline truncate"
+              ) %>
+            </li>
+            <li class="mx-2 my-1">
+              <%= link to: Routes.user_session_path(Endpoint, :delete),
+                   method: :delete,
+                   data: [confirm: dgettext("prompts", "Are you sure you want to log out?")] do %>
+                <i class="fas fa-sign-out-alt"></i>
+              <% end %>
+            </li>
+            <%= if @current_user.role == :admin and function_exported?(Routes, :live_dashboard_path, 2) do %>
+              <li class="mx-2 my-1">
+                <%= live_redirect to: Routes.live_dashboard_path(Endpoint, :home),
+                  class: "text-primary-600 text-white hover:underline" do %>
+                  <i class="fas fa-gauge"></i>
+                <% end %>
+              </li>
+            <% end %>
+          <% else %>
+            <%= if Accounts.allow_registration?() do %>
+              <li class="mx-2 my-1">
+                <%= live_redirect(dgettext("actions", "Register"),
+                  to: Routes.user_registration_path(Endpoint, :new),
+                  class: "text-primary-600 text-white hover:underline truncate"
+                ) %>
+              </li>
+            <% end %>
+            <li class="mx-2 my-1">
+              <%= live_redirect(dgettext("actions", "Log in"),
+                to: Routes.user_session_path(Endpoint, :new),
+                class: "text-primary-600 text-white hover:underline truncate"
+              ) %>
+            </li>
+          <% end %>
+        </ul>
+      </div>
+    </nav>
+    """
+  end
+end

lib/cannery_web/components/user_card.ex

@@ -0,0 +1,43 @@
+defmodule CanneryWeb.Components.UserCard do
+  @moduledoc """
+  Display card for a user
+  """
+
+  use CanneryWeb, :component
+
+  def user_card(assigns) do
+    ~H"""
+    <div
+      id={"user-#{@user.id}"}
+      class="mx-4 my-2 px-8 py-4 flex flex-col justify-center items-center text-center
+          border border-gray-400 rounded-lg shadow-lg hover:shadow-md
+          transition-all duration-300 ease-in-out"
+    >
+      <h1 class="px-4 py-2 rounded-lg title text-xl break-all">
+        <%= @user.email %>
+      </h1>
+
+      <h3 class="px-4 py-2 rounded-lg title text-lg">
+        <p>
+          <%= if @user.confirmed_at |> is_nil() do %>
+            Email unconfirmed
+          <% else %>
+            User was confirmed at <%= @user.confirmed_at |> display_datetime() %>
+          <% end %>
+        </p>
+
+        <p>
+          <%= gettext("User registered on") %>
+          <%= @user.inserted_at |> display_datetime() %>
+        </p>
+      </h3>
+
+      <%= if @inner_block do %>
+        <div class="px-4 py-2 flex space-x-4 justify-center items-center">
+          <%= render_slot(@inner_block) %>
+        </div>
+      <% end %>
+    </div>
+    """
+  end
+end

lib/cannery_web/controllers/export_controller.ex

@@ -1,76 +0,0 @@
-defmodule CanneryWeb.ExportController do
-  use CanneryWeb, :controller
-  alias Cannery.{ActivityLog, Ammo, Containers}
-
-  def export(%{assigns: %{current_user: current_user}} = conn, %{"mode" => "json"}) do
-    ammo_types = Ammo.list_ammo_types(current_user, :all)
-    used_counts = ammo_types |> ActivityLog.get_used_count_for_ammo_types(current_user)
-    round_counts = ammo_types |> Ammo.get_round_count_for_ammo_types(current_user)
-    ammo_group_counts = ammo_types |> Ammo.get_ammo_groups_count_for_types(current_user)
-
-    total_ammo_group_counts =
-      ammo_types |> Ammo.get_ammo_groups_count_for_types(current_user, true)
-
-    average_costs = ammo_types |> Ammo.get_average_cost_for_ammo_types(current_user)
-
-    ammo_types =
-      ammo_types
-      |> Enum.map(fn %{id: ammo_type_id} = ammo_type ->
-        ammo_type
-        |> Jason.encode!()
-        |> Jason.decode!()
-        |> Map.merge(%{
-          "average_cost" => Map.get(average_costs, ammo_type_id),
-          "round_count" => Map.get(round_counts, ammo_type_id, 0),
-          "used_count" => Map.get(used_counts, ammo_type_id, 0),
-          "ammo_group_count" => Map.get(ammo_group_counts, ammo_type_id, 0),
-          "total_ammo_group_count" => Map.get(total_ammo_group_counts, ammo_type_id, 0)
-        })
-      end)
-
-    ammo_groups = Ammo.list_ammo_groups(nil, :all, current_user, true)
-    used_counts = ammo_groups |> ActivityLog.get_used_counts(current_user)
-    original_counts = ammo_groups |> Ammo.get_original_counts(current_user)
-    cprs = ammo_groups |> Ammo.get_cprs(current_user)
-    percentages_remaining = ammo_groups |> Ammo.get_percentages_remaining(current_user)
-
-    ammo_groups =
-      ammo_groups
-      |> Enum.map(fn %{id: ammo_group_id} = ammo_group ->
-        ammo_group
-        |> Jason.encode!()
-        |> Jason.decode!()
-        |> Map.merge(%{
-          "used_count" => Map.get(used_counts, ammo_group_id),
-          "percentage_remaining" => Map.fetch!(percentages_remaining, ammo_group_id),
-          "original_count" => Map.get(original_counts, ammo_group_id),
-          "cpr" => Map.get(cprs, ammo_group_id)
-        })
-      end)
-
-    shot_groups = ActivityLog.list_shot_groups(:all, current_user)
-
-    containers =
-      Containers.list_containers(current_user)
-      |> Enum.map(fn container ->
-        ammo_group_count = container |> Ammo.get_ammo_groups_count_for_container!(current_user)
-        round_count = container |> Ammo.get_round_count_for_container!(current_user)
-
-        container
-        |> Jason.encode!()
-        |> Jason.decode!()
-        |> Map.merge(%{
-          "ammo_group_count" => ammo_group_count,
-          "round_count" => round_count
-        })
-      end)
-
-    json(conn, %{
-      user: current_user,
-      ammo_types: ammo_types,
-      ammo_groups: ammo_groups,
-      shot_groups: shot_groups,
-      containers: containers
-    })
-  end
-end

lib/cannery_web/controllers/home_controller.ex

@@ -1,8 +1,4 @@
 defmodule CanneryWeb.HomeController do
-  @moduledoc """
-  Controller for home page
-  """
-
   use CanneryWeb, :controller
 
   def index(conn, _params) do

lib/cannery_web/controllers/user_registration_controller.ex

@@ -1,13 +1,15 @@
 defmodule CanneryWeb.UserRegistrationController do
   use CanneryWeb, :controller
   import CanneryWeb.Gettext
-  alias Cannery.{Accounts, Accounts.Invites}
+  alias Cannery.{Accounts, Invites}
+  alias Cannery.Accounts.User
   alias CanneryWeb.{Endpoint, HomeLive}
-  alias Ecto.Changeset
 
   def new(conn, %{"invite" => invite_token}) do
-    if Invites.valid_invite_token?(invite_token) do
-      conn |> render_new(invite_token)
+    invite = Invites.get_invite_by_token(invite_token)
+
+    if invite do
+      conn |> render_new(invite)
     else
       conn
       |> put_flash(:error, dgettext("errors", "Sorry, this invite was not found or expired"))
@@ -26,17 +28,19 @@ defmodule CanneryWeb.UserRegistrationController do
   end
 
   # renders new user registration page
-  defp render_new(conn, invite_token \\ nil) do
+  defp render_new(conn, invite \\ nil) do
     render(conn, "new.html",
-      changeset: Accounts.change_user_registration(),
-      invite_token: invite_token,
+      changeset: Accounts.change_user_registration(%User{}),
+      invite: invite,
       page_title: gettext("Register")
     )
   end
 
   def create(conn, %{"user" => %{"invite_token" => invite_token}} = attrs) do
-    if Invites.valid_invite_token?(invite_token) do
-      conn |> create_user(attrs, invite_token)
+    invite = Invites.get_invite_by_token(invite_token)
+
+    if invite do
+      conn |> create_user(attrs, invite)
     else
       conn
       |> put_flash(:error, dgettext("errors", "Sorry, this invite was not found or expired"))
@@ -54,9 +58,13 @@ defmodule CanneryWeb.UserRegistrationController do
     end
   end
 
-  defp create_user(conn, %{"user" => user_params}, invite_token \\ nil) do
-    case Accounts.register_user(user_params, invite_token) do
+  defp create_user(conn, %{"user" => user_params}, invite \\ nil) do
+    case Accounts.register_user(user_params) do
       {:ok, user} ->
+        unless invite |> is_nil() do
+          invite |> Invites.use_invite!()
+        end
+
         Accounts.deliver_user_confirmation_instructions(
           user,
           &Routes.user_confirmation_url(conn, :confirm, &1)
@@ -66,13 +74,8 @@ defmodule CanneryWeb.UserRegistrationController do
         |> put_flash(:info, dgettext("prompts", "Please check your email to verify your account"))
         |> redirect(to: Routes.user_session_path(Endpoint, :new))
 
-      {:error, :invalid_token} ->
-        conn
-        |> put_flash(:error, dgettext("errors", "Sorry, this invite was not found or expired"))
-        |> redirect(to: Routes.live_path(Endpoint, HomeLive))
-
-      {:error, %Changeset{} = changeset} ->
-        conn |> render("new.html", changeset: changeset, invite_token: invite_token)
+      {:error, %Ecto.Changeset{} = changeset} ->
+        conn |> render("new.html", changeset: changeset, invite: invite)
     end
   end
 end

lib/cannery_web/live/ammo_group_live/form_component.ex

@@ -21,30 +21,38 @@ defmodule CanneryWeb.AmmoGroupLive.FormComponent do
   end
 
   @spec update(Socket.t()) :: {:ok, Socket.t()}
-  def update(%{assigns: %{current_user: current_user}} = socket) do
-    %{assigns: %{ammo_types: ammo_types, containers: containers}} =
-      socket =
+  def update(%{assigns: %{ammo_group: ammo_group, current_user: current_user}} = socket) do
+    socket =
       socket
       |> assign(:ammo_group_create_limit, @ammo_group_create_limit)
-      |> assign(:ammo_types, Ammo.list_ammo_types(current_user, :all))
+      |> assign(:changeset, Ammo.change_ammo_group(ammo_group))
+      |> assign(:ammo_types, Ammo.list_ammo_types(current_user))
       |> assign_new(:containers, fn -> Containers.list_containers(current_user) end)
 
-    params =
-      if ammo_types |> List.first() |> is_nil(),
-        do: %{},
-        else: %{} |> Map.put("ammo_type_id", ammo_types |> List.first() |> Map.get(:id))
-
-    params =
-      if containers |> List.first() |> is_nil(),
-        do: params,
-        else: params |> Map.put("container_id", containers |> List.first() |> Map.get(:id))
-
-    {:ok, socket |> assign_changeset(params)}
+    {:ok, socket}
   end
 
   @impl true
-  def handle_event("validate", %{"ammo_group" => ammo_group_params}, socket) do
-    {:noreply, socket |> assign_changeset(ammo_group_params, :validate)}
+  def handle_event(
+        "validate",
+        %{"ammo_group" => ammo_group_params},
+        %{assigns: %{action: action, ammo_group: ammo_group}} = socket
+      ) do
+    changeset_action =
+      case action do
+        :new -> :insert
+        :edit -> :update
+      end
+
+    changeset = ammo_group |> Ammo.change_ammo_group(ammo_group_params)
+
+    changeset =
+      case changeset |> Changeset.apply_action(changeset_action) do
+        {:ok, _data} -> changeset
+        {:error, changeset} -> changeset
+      end
+
+    {:noreply, socket |> assign(:changeset, changeset)}
   end
 
   def handle_event(
@@ -56,7 +64,6 @@ defmodule CanneryWeb.AmmoGroupLive.FormComponent do
   end
 
   # HTML Helpers
-
   @spec container_options([Container.t()]) :: [{String.t(), Container.id()}]
   defp container_options(containers) do
     containers |> Enum.map(fn %{id: id, name: name} -> {name, id} end)
@@ -69,51 +76,6 @@ defmodule CanneryWeb.AmmoGroupLive.FormComponent do
 
   # Save Helpers
 
-  defp assign_changeset(
-         %{assigns: %{action: action, ammo_group: ammo_group, current_user: user}} = socket,
-         ammo_group_params,
-         changeset_action \\ nil
-       ) do
-    default_action =
-      case action do
-        create when create in [:new, :clone] -> :insert
-        :edit -> :update
-      end
-
-    changeset =
-      case default_action do
-        :insert ->
-          ammo_type = maybe_get_ammo_type(ammo_group_params, user)
-          container = maybe_get_container(ammo_group_params, user)
-          ammo_group |> AmmoGroup.create_changeset(ammo_type, container, user, ammo_group_params)
-
-        :update ->
-          ammo_group |> AmmoGroup.update_changeset(ammo_group_params, user)
-      end
-
-    changeset =
-      case changeset |> Changeset.apply_action(changeset_action || default_action) do
-        {:ok, _data} -> changeset
-        {:error, changeset} -> changeset
-      end
-
-    socket |> assign(:changeset, changeset)
-  end
-
-  defp maybe_get_container(%{"container_id" => container_id}, user)
-       when is_binary(container_id) do
-    container_id |> Containers.get_container!(user)
-  end
-
-  defp maybe_get_container(_params_not_found, _user), do: nil
-
-  defp maybe_get_ammo_type(%{"ammo_type_id" => ammo_type_id}, user)
-       when is_binary(ammo_type_id) do
-    ammo_type_id |> Ammo.get_ammo_type!(user)
-  end
-
-  defp maybe_get_ammo_type(_params_not_found, _user), do: nil
-
   defp save_ammo_group(
          %{assigns: %{ammo_group: ammo_group, current_user: current_user, return_to: return_to}} =
            socket,
@@ -123,8 +85,8 @@ defmodule CanneryWeb.AmmoGroupLive.FormComponent do
     socket =
       case Ammo.update_ammo_group(ammo_group, ammo_group_params, current_user) do
         {:ok, _ammo_group} ->
-          prompt = dgettext("prompts", "Ammo updated successfully")
-          socket |> put_flash(:info, prompt) |> push_navigate(to: return_to)
+          prompt = dgettext("prompts", "Ammo group updated successfully")
+          socket |> put_flash(:info, prompt) |> push_redirect(to: return_to)
 
         {:error, %Changeset{} = changeset} ->
           socket |> assign(:changeset, changeset)
@@ -135,10 +97,9 @@ defmodule CanneryWeb.AmmoGroupLive.FormComponent do
 
   defp save_ammo_group(
          %{assigns: %{changeset: changeset}} = socket,
-         action,
+         :new,
          %{"multiplier" => multiplier_str} = ammo_group_params
-       )
-       when action in [:new, :clone] do
+       ) do
     socket =
       case multiplier_str |> Integer.parse() do
         {multiplier, _remainder}
@@ -154,26 +115,27 @@ defmodule CanneryWeb.AmmoGroupLive.FormComponent do
               multiplier: multiplier
             )
 
-          save_multiplier_error(socket, changeset, error_msg)
+          {:error, changeset} =
+            changeset
+            |> Changeset.add_error(:multiplier, error_msg)
+            |> Changeset.apply_action(:insert)
+
+          socket |> assign(:changeset, changeset)
 
         :error ->
           error_msg = dgettext("errors", "Could not parse number of copies")
-          save_multiplier_error(socket, changeset, error_msg)
+
+          {:error, changeset} =
+            changeset
+            |> Changeset.add_error(:multiplier, error_msg)
+            |> Changeset.apply_action(:insert)
+
+          socket |> assign(:changeset, changeset)
       end
 
     {:noreply, socket}
   end
 
-  @spec save_multiplier_error(Socket.t(), Changeset.t(), String.t()) :: Socket.t()
-  defp save_multiplier_error(socket, changeset, error_msg) do
-    {:error, changeset} =
-      changeset
-      |> Changeset.add_error(:multiplier, error_msg)
-      |> Changeset.apply_action(:insert)
-
-    socket |> assign(:changeset, changeset)
-  end
-
   defp create_multiple(
          %{assigns: %{current_user: current_user, return_to: return_to}} = socket,
          ammo_group_params,
@@ -184,12 +146,12 @@ defmodule CanneryWeb.AmmoGroupLive.FormComponent do
         prompt =
           dngettext(
             "prompts",
-            "Ammo added successfully",
-            "Ammo added successfully",
+            "Ammo group created successfully",
+            "Ammo groups created successfully",
             count
           )
 
-        socket |> put_flash(:info, prompt) |> push_navigate(to: return_to)
+        socket |> put_flash(:info, prompt) |> push_redirect(to: return_to)
 
       {:error, %Changeset{} = changeset} ->
         socket |> assign(changeset: changeset)

lib/cannery_web/live/ammo_group_live/form_component.html.heex

@@ -4,7 +4,7 @@
   </h2>
 
   <.form
-    :let={f}
+    let={f}
     for={@changeset}
     id="ammo_group-form"
     phx-target={@myself}
@@ -12,12 +12,11 @@
     phx-submit="save"
     class="flex flex-col space-y-4 sm:space-y-0 sm:grid sm:grid-cols-3 sm:gap-4 justify-center items-center"
   >
-    <div
-      :if={@changeset.action && not @changeset.valid?()}
-      class="invalid-feedback col-span-3 text-center"
-    >
-      <%= changeset_errors(@changeset) %>
-    </div>
+    <%= if @changeset.action && not @changeset.valid? do %>
+      <div class="invalid-feedback col-span-3 text-center">
+        <%= changeset_errors(@changeset) %>
+      </div>
+    <% end %>
 
     <%= label(f, :ammo_type_id, gettext("Ammo type"), class: "title text-lg text-primary-600") %>
     <%= select(f, :ammo_type_id, ammo_type_options(@ammo_types),
@@ -39,20 +38,10 @@
     ) %>
     <%= error_tag(f, :price_paid, "col-span-3 text-center") %>
 
-    <%= label(f, :purchased_on, gettext("Purchased on"), class: "title text-lg text-primary-600") %>
-    <%= date_input(f, :purchased_on,
-      class: "input input-primary col-span-2",
-      phx_update: "ignore",
-      value: @changeset |> Changeset.get_field(:purchased_on) || Date.utc_today()
-    ) %>
-    <%= error_tag(f, :purchased_on, "col-span-3 text-center") %>
-
     <%= label(f, :notes, gettext("Notes"), class: "title text-lg text-primary-600") %>
     <%= textarea(f, :notes,
-      id: "ammo-group-form-notes",
       class: "text-center col-span-2 input input-primary",
-      phx_hook: "MaintainAttrs",
-      phx_update: "ignore"
+      phx_hook: "MaintainAttrs"
     ) %>
     <%= error_tag(f, :notes, "col-span-3 text-center") %>
 
@@ -63,7 +52,7 @@
     <%= error_tag(f, :container_id, "col-span-3 text-center") %>
 
     <%= case @action do %>
-      <% action when action in [:new, :clone] -> %>
+      <% :new -> %>
         <hr class="hr col-span-3" />
 
         <%= label(f, :multiplier, gettext("Copies"), class: "title text-lg text-primary-600") %>

lib/cannery_web/live/ammo_group_live/index.ex

@@ -4,20 +4,17 @@ defmodule CanneryWeb.AmmoGroupLive.Index do
   """
 
   use CanneryWeb, :live_view
-  alias Cannery.{Ammo, Ammo.AmmoGroup, Containers}
+  alias Cannery.{Ammo, Ammo.AmmoGroup, Containers, Repo}
+  alias CanneryWeb.Endpoint
 
   @impl true
-  def mount(%{"search" => search}, _session, socket) do
-    {:ok, socket |> assign(type: :all, show_used: false, search: search) |> display_ammo_groups()}
-  end
-
   def mount(_params, _session, socket) do
-    {:ok, socket |> assign(type: :all, show_used: false, search: nil) |> display_ammo_groups()}
+    {:ok, socket |> display_ammo_groups()}
   end
 
   @impl true
   def handle_params(params, _url, %{assigns: %{live_action: live_action}} = socket) do
-    {:noreply, apply_action(socket, live_action, params) |> display_ammo_groups()}
+    {:noreply, apply_action(socket, live_action, params)}
   end
 
   defp apply_action(
@@ -26,71 +23,42 @@ defmodule CanneryWeb.AmmoGroupLive.Index do
          %{"id" => id}
        ) do
     socket
-    |> assign(
-      page_title: gettext("Record shots"),
-      ammo_group: Ammo.get_ammo_group!(id, current_user)
-    )
+    |> assign(:page_title, gettext("Record shots"))
+    |> assign(:ammo_group, Ammo.get_ammo_group!(id, current_user))
   end
 
   defp apply_action(%{assigns: %{current_user: current_user}} = socket, :move, %{"id" => id}) do
     socket
-    |> assign(
-      page_title: gettext("Move ammo"),
-      ammo_group: Ammo.get_ammo_group!(id, current_user)
-    )
+    |> assign(:page_title, gettext("Move Ammo group"))
+    |> assign(:ammo_group, Ammo.get_ammo_group!(id, current_user))
   end
 
   defp apply_action(%{assigns: %{current_user: current_user}} = socket, :edit, %{"id" => id}) do
     socket
-    |> assign(
-      page_title: gettext("Edit ammo"),
-      ammo_group: Ammo.get_ammo_group!(id, current_user)
-    )
-  end
-
-  defp apply_action(%{assigns: %{current_user: current_user}} = socket, :clone, %{"id" => id}) do
-    socket
-    |> assign(
-      page_title: dgettext("actions", "Add Ammo"),
-      ammo_group: %{Ammo.get_ammo_group!(id, current_user) | id: nil}
-    )
+    |> assign(:page_title, gettext("Edit Ammo group"))
+    |> assign(:ammo_group, Ammo.get_ammo_group!(id, current_user))
   end
 
   defp apply_action(socket, :new, _params) do
     socket
-    |> assign(
-      page_title: dgettext("actions", "Add Ammo"),
-      ammo_group: %AmmoGroup{}
-    )
+    |> assign(:page_title, dgettext("actions", "Add Ammo"))
+    |> assign(:ammo_group, %AmmoGroup{})
   end
 
   defp apply_action(socket, :index, _params) do
-    socket
-    |> assign(
-      page_title: gettext("Ammo"),
-      search: nil,
-      ammo_group: nil
-    )
-  end
-
-  defp apply_action(socket, :search, %{"search" => search}) do
-    socket
-    |> assign(
-      page_title: gettext("Ammo"),
-      search: search,
-      ammo_group: nil
-    )
+    socket |> assign(:page_title, gettext("Ammo groups")) |> assign(:ammo_group, nil)
   end
 
   @impl true
   def handle_event("delete", %{"id" => id}, %{assigns: %{current_user: current_user}} = socket) do
     Ammo.get_ammo_group!(id, current_user) |> Ammo.delete_ammo_group!(current_user)
 
-    prompt = dgettext("prompts", "Ammo deleted succesfully")
+    prompt = dgettext("prompts", "Ammo group deleted succesfully")
 
     {:noreply, socket |> put_flash(:info, prompt) |> display_ammo_groups()}
   end
 
+  @impl true
   def handle_event(
         "toggle_staged",
         %{"ammo_group_id" => id},
@@ -104,60 +72,133 @@ defmodule CanneryWeb.AmmoGroupLive.Index do
     {:noreply, socket |> display_ammo_groups()}
   end
 
-  def handle_event("toggle_show_used", _params, %{assigns: %{show_used: show_used}} = socket) do
-    {:noreply, socket |> assign(:show_used, !show_used) |> display_ammo_groups()}
-  end
+  defp display_ammo_groups(%{assigns: %{current_user: current_user}} = socket) do
+    ammo_groups = Ammo.list_ammo_groups(current_user) |> Repo.preload([:ammo_type, :container])
+    containers = Containers.list_containers(current_user)
 
-  def handle_event("search", %{"search" => %{"search_term" => ""}}, socket) do
-    {:noreply, socket |> push_patch(to: Routes.ammo_group_index_path(Endpoint, :index))}
-  end
+    columns = [
+      %{label: gettext("Ammo type"), key: "ammo_type"},
+      %{label: gettext("Count"), key: "count"},
+      %{label: gettext("Price paid"), key: "price_paid"},
+      %{label: gettext("% left"), key: "remaining"},
+      %{label: gettext("Range"), key: "range"},
+      %{label: gettext("Container"), key: "container"},
+      %{label: gettext("Added on"), key: "added_on"},
+      %{label: nil, key: "actions", sortable: false}
+    ]
 
-  def handle_event("search", %{"search" => %{"search_term" => search_term}}, socket) do
-    socket =
-      socket |> push_patch(to: Routes.ammo_group_index_path(Endpoint, :search, search_term))
-
-    {:noreply, socket}
-  end
-
-  def handle_event("change_type", %{"ammo_type" => %{"type" => "rifle"}}, socket) do
-    {:noreply, socket |> assign(:type, :rifle) |> display_ammo_groups()}
-  end
-
-  def handle_event("change_type", %{"ammo_type" => %{"type" => "shotgun"}}, socket) do
-    {:noreply, socket |> assign(:type, :shotgun) |> display_ammo_groups()}
-  end
-
-  def handle_event("change_type", %{"ammo_type" => %{"type" => "pistol"}}, socket) do
-    {:noreply, socket |> assign(:type, :pistol) |> display_ammo_groups()}
-  end
-
-  def handle_event("change_type", %{"ammo_type" => %{"type" => _all}}, socket) do
-    {:noreply, socket |> assign(:type, :all) |> display_ammo_groups()}
-  end
-
-  defp display_ammo_groups(
-         %{
-           assigns: %{
-             type: type,
-             search: search,
-             current_user: current_user,
-             show_used: show_used
-           }
-         } = socket
-       ) do
-    # get total number of ammo groups to determine whether to display onboarding
-    # prompts
-    ammo_groups_count = Ammo.get_ammo_groups_count!(current_user, true)
-    ammo_groups = Ammo.list_ammo_groups(search, type, current_user, show_used)
-    ammo_types_count = Ammo.get_ammo_types_count!(current_user)
-    containers_count = Containers.get_containers_count!(current_user)
+    rows =
+      ammo_groups
+      |> Enum.map(fn ammo_group -> ammo_group |> get_row_data_for_ammo_group(columns) end)
 
     socket
-    |> assign(
-      ammo_groups: ammo_groups,
-      ammo_types_count: ammo_types_count,
-      containers_count: containers_count,
-      ammo_groups_count: ammo_groups_count
-    )
+    |> assign(ammo_groups: ammo_groups, containers: containers, columns: columns, rows: rows)
   end
+
+  @spec get_row_data_for_ammo_group(AmmoGroup.t(), [map()]) :: [map()]
+  defp get_row_data_for_ammo_group(ammo_group, columns) do
+    ammo_group = ammo_group |> Repo.preload([:ammo_type, :container])
+
+    columns
+    |> Enum.into(%{}, fn %{key: key} -> {key, get_value_for_key(key, ammo_group)} end)
+  end
+
+  @spec get_value_for_key(String.t(), AmmoGroup.t()) :: any()
+  defp get_value_for_key("ammo_type", %{ammo_type: ammo_type}) do
+    {ammo_type.name,
+     live_patch(ammo_type.name,
+       to: Routes.ammo_type_show_path(Endpoint, :show, ammo_type),
+       class: "link"
+     )}
+  end
+
+  defp get_value_for_key("price_paid", %{price_paid: nil}), do: {"a", nil}
+
+  defp get_value_for_key("price_paid", %{price_paid: price_paid}),
+    do: gettext("$%{amount}", amount: price_paid |> :erlang.float_to_binary(decimals: 2))
+
+  defp get_value_for_key("added_on", %{inserted_at: inserted_at}) do
+    assigns = %{inserted_at: inserted_at}
+
+    {inserted_at,
+     ~H"""
+     <%= @inserted_at |> display_datetime() %>
+     """}
+  end
+
+  defp get_value_for_key("range", %{staged: staged} = ammo_group) do
+    assigns = %{ammo_group: ammo_group}
+
+    {staged,
+     ~H"""
+     <div class="min-w-20 py-2 px-4 h-full flex flex-col justify-center items-center">
+       <button
+         type="button"
+         class="mx-2 my-1 btn btn-primary"
+         phx-click="toggle_staged"
+         phx-value-ammo_group_id={ammo_group.id}
+       >
+         <%= if ammo_group.staged, do: gettext("Unstage"), else: gettext("Stage") %>
+       </button>
+
+       <%= live_patch(dgettext("actions", "Record shots"),
+         to: Routes.ammo_group_index_path(Endpoint, :add_shot_group, ammo_group),
+         class: "mx-2 my-1 btn btn-primary"
+       ) %>
+     </div>
+     """}
+  end
+
+  defp get_value_for_key("remaining", ammo_group),
+    do: "#{ammo_group |> Ammo.get_percentage_remaining()}%"
+
+  defp get_value_for_key("actions", ammo_group) do
+    assigns = %{ammo_group: ammo_group}
+
+    ~H"""
+    <div class="py-2 px-4 h-full space-x-4 flex justify-center items-center">
+      <%= live_redirect to: Routes.ammo_group_show_path(Endpoint, :show, ammo_group),
+                    class: "text-primary-600 link",
+                    data: [qa: "view-#{ammo_group.id}"] do %>
+        <i class="fa-fw fa-lg fas fa-eye"></i>
+      <% end %>
+
+      <%= live_patch to: Routes.ammo_group_index_path(Endpoint, :edit, ammo_group),
+                  class: "text-primary-600 link",
+                  data: [qa: "edit-#{ammo_group.id}"] do %>
+        <i class="fa-fw fa-lg fas fa-edit"></i>
+      <% end %>
+
+      <%= link to: "#",
+            class: "text-primary-600 link",
+            phx_click: "delete",
+            phx_value_id: ammo_group.id,
+            data: [
+              confirm: dgettext("prompts", "Are you sure you want to delete this ammo?"),
+              qa: "delete-#{ammo_group.id}"
+            ] do %>
+        <i class="fa-fw fa-lg fas fa-trash"></i>
+      <% end %>
+    </div>
+    """
+  end
+
+  defp get_value_for_key("container", %{container: nil}), do: {nil, nil}
+
+  defp get_value_for_key("container", %{container: %{name: container_name}} = ammo_group) do
+    assigns = %{ammo_group: ammo_group}
+
+    {container_name,
+     ~H"""
+     <div class="min-w-20 py-2 px-4 h-full space-x-4 flex justify-center items-center">
+       <%= live_patch(@ammo_group.container.name,
+         to: Routes.ammo_group_index_path(Endpoint, :move, @ammo_group),
+         class: "btn btn-primary"
+       ) %>
+     </div>
+     """}
+  end
+
+  defp get_value_for_key(key, ammo_group),
+    do: ammo_group |> Map.get(key |> String.to_existing_atom())
 end

lib/cannery_web/live/ammo_group_live/index.html.heex

@@ -3,207 +3,60 @@
     <%= gettext("Ammo") %>
   </h1>
 
-  <%= cond do %>
-    <% @containers_count == 0 -> %>
+  <%= if @ammo_groups |> Enum.empty?() do %>
+    <h2 class="title text-xl text-primary-600">
+      <%= gettext("No Ammo") %>
+      <%= display_emoji("😔") %>
+    </h2>
+
+    <%= if @containers |> Enum.empty?() do %>
       <div class="flex justify-center items-center">
         <h2 class="m-2 title text-md text-primary-600">
           <%= dgettext("prompts", "You'll need to") %>
         </h2>
 
-        <.link navigate={Routes.container_index_path(Endpoint, :new)} class="btn btn-primary">
-          <%= dgettext("actions", "add a container first") %>
-        </.link>
+        <%= live_patch(dgettext("actions", "add a container first"),
+          to: Routes.container_index_path(Endpoint, :new),
+          class: "btn btn-primary"
+        ) %>
       </div>
-    <% @ammo_types_count == 0 -> %>
+    <% else %>
+      <%= live_patch(dgettext("actions", "Add your first box!"),
+        to: Routes.ammo_group_index_path(Endpoint, :new),
+        class: "btn btn-primary"
+      ) %>
+    <% end %>
+  <% else %>
+    <%= if @containers |> Enum.empty?() do %>
       <div class="flex justify-center items-center">
         <h2 class="m-2 title text-md text-primary-600">
           <%= dgettext("prompts", "You'll need to") %>
         </h2>
 
-        <.link navigate={Routes.ammo_type_index_path(Endpoint, :new)} class="btn btn-primary">
-          <%= dgettext("actions", "add an ammo type first") %>
-        </.link>
+        <%= live_patch(dgettext("actions", "add a container first"),
+          to: Routes.container_index_path(Endpoint, :new),
+          class: "btn btn-primary"
+        ) %>
       </div>
-    <% @ammo_groups_count == 0 -> %>
-      <h2 class="title text-xl text-primary-600">
-        <%= gettext("No ammo") %>
-        <%= display_emoji("😔") %>
-      </h2>
+    <% else %>
+      <%= live_patch(dgettext("actions", "New Ammo group"),
+        to: Routes.ammo_group_index_path(Endpoint, :new),
+        class: "btn btn-primary"
+      ) %>
+    <% end %>
 
-      <.link patch={Routes.ammo_group_index_path(Endpoint, :new)} class="btn btn-primary">
-        <%= dgettext("actions", "Add your first box!") %>
-      </.link>
-    <% true -> %>
-      <.link patch={Routes.ammo_group_index_path(Endpoint, :new)} class="btn btn-primary">
-        <%= dgettext("actions", "Add Ammo") %>
-      </.link>
-
-      <div class="w-full flex flex-col sm:flex-row justify-center items-center space-y-4 sm:space-y-0 sm:space-x-4 max-w-2xl">
-        <.form
-          :let={f}
-          for={%{}}
-          as={:ammo_type}
-          phx-change="change_type"
-          phx-submit="change_type"
-          class="flex items-center"
-        >
-          <%= label(f, :type, gettext("Type"), class: "title text-primary-600 text-lg text-center") %>
-
-          <%= select(
-            f,
-            :type,
-            [
-              {gettext("All"), :all},
-              {gettext("Rifle"), :rifle},
-              {gettext("Shotgun"), :shotgun},
-              {gettext("Pistol"), :pistol}
-            ],
-            class: "mx-2 my-1 min-w-md input input-primary",
-            value: @type
-          ) %>
-        </.form>
-
-        <.form
-          :let={f}
-          for={%{}}
-          as={:search}
-          phx-change="search"
-          phx-submit="search"
-          class="grow flex items-center"
-        >
-          <%= text_input(f, :search_term,
-            class: "grow input input-primary",
-            value: @search,
-            role: "search",
-            phx_debounce: 300,
-            placeholder: gettext("Search ammo")
-          ) %>
-        </.form>
-
-        <.toggle_button action="toggle_show_used" value={@show_used}>
-          <span class="title text-lg text-primary-600">
-            <%= gettext("Show used") %>
-          </span>
-        </.toggle_button>
-      </div>
-
-      <%= if @ammo_groups |> Enum.empty?() do %>
-        <h2 class="title text-xl text-primary-600">
-          <%= gettext("No Ammo") %>
-          <%= display_emoji("😔") %>
-        </h2>
-      <% else %>
-        <.live_component
-          module={CanneryWeb.Components.AmmoGroupTableComponent}
-          id="ammo-group-index-table"
-          ammo_groups={@ammo_groups}
-          current_user={@current_user}
-          show_used={@show_used}
-        >
-          <:ammo_type :let={%{name: ammo_type_name} = ammo_type}>
-            <.link navigate={Routes.ammo_type_show_path(Endpoint, :show, ammo_type)} class="link">
-              <%= ammo_type_name %>
-            </.link>
-          </:ammo_type>
-          <:range :let={ammo_group}>
-            <div class="min-w-20 py-2 px-4 h-full flex flew-wrap justify-center items-center">
-              <button
-                type="button"
-                class="mx-2 my-1 text-sm btn btn-primary"
-                phx-click="toggle_staged"
-                phx-value-ammo_group_id={ammo_group.id}
-              >
-                <%= if ammo_group.staged,
-                  do: dgettext("actions", "Unstage"),
-                  else: dgettext("actions", "Stage") %>
-              </button>
-
-              <.link
-                patch={Routes.ammo_group_index_path(Endpoint, :add_shot_group, ammo_group)}
-                class="mx-2 my-1 text-sm btn btn-primary"
-              >
-                <%= dgettext("actions", "Record shots") %>
-              </.link>
-            </div>
-          </:range>
-          <:container :let={{ammo_group, %{name: container_name} = container}}>
-            <div class="min-w-20 py-2 px-4 h-full flex flew-wrap justify-center items-center">
-              <.link
-                navigate={Routes.container_show_path(Endpoint, :show, container)}
-                class="mx-2 my-1 link"
-              >
-                <%= container_name %>
-              </.link>
-
-              <.link
-                patch={Routes.ammo_group_index_path(Endpoint, :move, ammo_group)}
-                class="mx-2 my-1 text-sm btn btn-primary"
-              >
-                <%= dgettext("actions", "Move ammo") %>
-              </.link>
-            </div>
-          </:container>
-          <:actions :let={%{count: ammo_group_count} = ammo_group}>
-            <div class="py-2 px-4 h-full space-x-4 flex justify-center items-center">
-              <.link
-                navigate={Routes.ammo_group_show_path(Endpoint, :show, ammo_group)}
-                class="text-primary-600 link"
-                aria-label={
-                  dgettext("actions", "View ammo group of %{ammo_group_count} bullets",
-                    ammo_group_count: ammo_group_count
-                  )
-                }
-              >
-                <i class="fa-fw fa-lg fas fa-eye"></i>
-              </.link>
-
-              <.link
-                patch={Routes.ammo_group_index_path(Endpoint, :edit, ammo_group)}
-                class="text-primary-600 link"
-                aria-label={
-                  dgettext("actions", "Edit ammo group of %{ammo_group_count} bullets",
-                    ammo_group_count: ammo_group_count
-                  )
-                }
-              >
-                <i class="fa-fw fa-lg fas fa-edit"></i>
-              </.link>
-
-              <.link
-                patch={Routes.ammo_group_index_path(Endpoint, :clone, ammo_group)}
-                class="text-primary-600 link"
-                aria-label={
-                  dgettext("actions", "Clone ammo group of %{ammo_group_count} bullets",
-                    ammo_group_count: ammo_group_count
-                  )
-                }
-              >
-                <i class="fa-fw fa-lg fas fa-copy"></i>
-              </.link>
-
-              <.link
-                href="#"
-                class="text-primary-600 link"
-                phx-click="delete"
-                phx-value-id={ammo_group.id}
-                data-confirm={dgettext("prompts", "Are you sure you want to delete this ammo?")}
-                aria-label={
-                  dgettext("actions", "Delete ammo group of %{ammo_group_count} bullets",
-                    ammo_group_count: ammo_group_count
-                  )
-                }
-              >
-                <i class="fa-fw fa-lg fas fa-trash"></i>
-              </.link>
-            </div>
-          </:actions>
-        </.live_component>
-      <% end %>
+    <.live_component
+      module={CanneryWeb.Components.TableComponent}
+      id="ammo_groups_index_table"
+      action={@live_action}
+      columns={@columns}
+      rows={@rows}
+    />
   <% end %>
 </div>
 
-<%= case @live_action do %>
-  <% create when create in [:new, :edit, :clone] -> %>
+<%= cond do %>
+  <% @live_action in [:new, :edit] -> %>
     <.modal return_to={Routes.ammo_group_index_path(Endpoint, :index)}>
       <.live_component
         module={CanneryWeb.AmmoGroupLive.FormComponent}
@@ -213,9 +66,10 @@
         ammo_group={@ammo_group}
         return_to={Routes.ammo_group_index_path(Endpoint, :index)}
         current_user={@current_user}
+        containers={@containers}
       />
     </.modal>
-  <% :add_shot_group -> %>
+  <% @live_action == :add_shot_group -> %>
     <.modal return_to={Routes.ammo_group_index_path(Endpoint, :index)}>
       <.live_component
         module={CanneryWeb.Components.AddShotGroupComponent}
@@ -227,7 +81,7 @@
         current_user={@current_user}
       />
     </.modal>
-  <% :move -> %>
+  <% @live_action == :move -> %>
     <.modal return_to={Routes.ammo_group_index_path(Endpoint, :index)}>
       <.live_component
         module={CanneryWeb.Components.MoveAmmoGroupComponent}
@@ -239,5 +93,6 @@
         current_user={@current_user}
       />
     </.modal>
-  <% _ -> %>
+  <% true -> %>
+    <%= nil %>
 <% end %>

lib/cannery_web/live/ammo_group_live/show.ex

@@ -4,9 +4,8 @@ defmodule CanneryWeb.AmmoGroupLive.Show do
   """
 
   use CanneryWeb, :live_view
-  alias Cannery.{ActivityLog, ActivityLog.ShotGroup}
-  alias Cannery.{Ammo, Ammo.AmmoGroup}
-  alias Cannery.{ComparableDate, Containers}
+  import CanneryWeb.Components.ContainerCard
+  alias Cannery.{ActivityLog, ActivityLog.ShotGroup, Ammo, Ammo.AmmoGroup, Repo}
   alias CanneryWeb.Endpoint
   alias Phoenix.LiveView.Socket
 
@@ -29,20 +28,16 @@ defmodule CanneryWeb.AmmoGroupLive.Show do
     {:noreply, socket}
   end
 
+  @impl true
   def handle_params(%{"id" => id}, _url, %{assigns: %{live_action: live_action}} = socket) do
-    socket =
-      socket
-      |> assign(page_title: page_title(live_action))
-      |> display_ammo_group(id)
-
-    {:noreply, socket}
+    {:noreply, socket |> assign(page_title: page_title(live_action)) |> display_ammo_group(id)}
   end
 
   defp page_title(:add_shot_group), do: gettext("Record Shots")
   defp page_title(:edit_shot_group), do: gettext("Edit Shot Records")
-  defp page_title(:move), do: gettext("Move Ammo")
-  defp page_title(:show), do: gettext("Show Ammo")
-  defp page_title(:edit), do: gettext("Edit Ammo")
+  defp page_title(:move), do: gettext("Move Ammo group")
+  defp page_title(:show), do: gettext("Show Ammo group")
+  defp page_title(:edit), do: gettext("Edit Ammo group")
 
   @impl true
   def handle_event(
@@ -52,12 +47,13 @@ defmodule CanneryWeb.AmmoGroupLive.Show do
       ) do
     ammo_group |> Ammo.delete_ammo_group!(current_user)
 
-    prompt = dgettext("prompts", "Ammo deleted succesfully")
+    prompt = dgettext("prompts", "Ammo group deleted succesfully")
     redirect_to = Routes.ammo_group_index_path(socket, :index)
 
-    {:noreply, socket |> put_flash(:info, prompt) |> push_navigate(to: redirect_to)}
+    {:noreply, socket |> put_flash(:info, prompt) |> push_redirect(to: redirect_to)}
   end
 
+  @impl true
   def handle_event(
         "toggle_staged",
         _params,
@@ -69,107 +65,78 @@ defmodule CanneryWeb.AmmoGroupLive.Show do
     {:noreply, socket |> display_ammo_group(ammo_group)}
   end
 
+  @impl true
   def handle_event(
         "delete_shot_group",
         %{"id" => id},
-        %{assigns: %{ammo_group: %{id: ammo_group_id}, current_user: current_user}} = socket
+        %{assigns: %{ammo_group: ammo_group, current_user: current_user}} = socket
       ) do
     {:ok, _} =
       ActivityLog.get_shot_group!(id, current_user)
       |> ActivityLog.delete_shot_group(current_user)
 
     prompt = dgettext("prompts", "Shot records deleted succesfully")
-    {:noreply, socket |> put_flash(:info, prompt) |> display_ammo_group(ammo_group_id)}
+    {:noreply, socket |> put_flash(:info, prompt) |> display_ammo_group(ammo_group)}
   end
 
   @spec display_ammo_group(Socket.t(), AmmoGroup.t() | AmmoGroup.id()) :: Socket.t()
-  defp display_ammo_group(
-         %{assigns: %{current_user: current_user}} = socket,
-         %AmmoGroup{container_id: container_id} = ammo_group
-       ) do
+  defp display_ammo_group(socket, %AmmoGroup{} = ammo_group) do
+    ammo_group = ammo_group |> Repo.preload([:container, :ammo_type, :shot_groups], force: true)
+
     columns = [
-      %{label: gettext("Rounds shot"), key: :count},
-      %{label: gettext("Notes"), key: :notes},
-      %{label: gettext("Date"), key: :date, type: ComparableDate},
-      %{label: gettext("Actions"), key: :actions, sortable: false}
+      %{label: gettext("Rounds shot"), key: "count"},
+      %{label: gettext("Notes"), key: "notes"},
+      %{label: gettext("Date"), key: "date"},
+      %{label: nil, key: "actions", sortable: false}
     ]
 
-    shot_groups = ActivityLog.list_shot_groups_for_ammo_group(ammo_group, current_user)
-
     rows =
-      shot_groups
+      ammo_group.shot_groups
       |> Enum.map(fn shot_group ->
         ammo_group |> get_table_row_for_shot_group(shot_group, columns)
       end)
 
-    socket
-    |> assign(
-      ammo_group: ammo_group,
-      original_count: Ammo.get_original_count(ammo_group, current_user),
-      percentage_remaining: Ammo.get_percentage_remaining(ammo_group, current_user),
-      container: container_id && Containers.get_container!(container_id, current_user),
-      shot_groups: shot_groups,
-      columns: columns,
-      rows: rows
-    )
+    socket |> assign(ammo_group: ammo_group, columns: columns, rows: rows)
   end
 
   defp display_ammo_group(%{assigns: %{current_user: current_user}} = socket, id),
     do: display_ammo_group(socket, Ammo.get_ammo_group!(id, current_user))
 
-  @spec display_currency(float()) :: String.t()
-  defp display_currency(float), do: :erlang.float_to_binary(float, decimals: 2)
-
-  @spec get_table_row_for_shot_group(AmmoGroup.t(), ShotGroup.t(), [map()]) :: map()
-  defp get_table_row_for_shot_group(ammo_group, %{id: id, date: date} = shot_group, columns) do
+  @spec get_table_row_for_shot_group(AmmoGroup.t(), ShotGroup.t(), [map()]) :: [map()]
+  defp get_table_row_for_shot_group(ammo_group, %{date: date} = shot_group, columns) do
     assigns = %{ammo_group: ammo_group, shot_group: shot_group}
 
     columns
-    |> Map.new(fn %{key: key} ->
+    |> Enum.into(%{}, fn %{key: key} ->
       value =
         case key do
-          :date ->
-            assigns = %{id: id, date: date}
+          "date" ->
+            {date, date |> display_date()}
 
-            {date,
-             ~H"""
-             <.date id={"#{@id}-date"} date={@date} />
-             """}
-
-          :actions ->
+          "actions" ->
             ~H"""
             <div class="px-4 py-2 space-x-4 flex justify-center items-center">
-              <.link
-                patch={Routes.ammo_group_show_path(Endpoint, :edit_shot_group, @ammo_group, @shot_group)}
-                class="text-primary-600 link"
-                aria-label={
-                  dgettext("actions", "Edit shot group of %{shot_group_count} shots",
-                    shot_group_count: @shot_group.count
-                  )
-                }
-              >
+              <%= live_patch to: Routes.ammo_group_show_path(Endpoint, :edit_shot_group, @ammo_group, shot_group),
+                          class: "text-primary-600 link",
+                          data: [qa: "edit-#{shot_group.id}"] do %>
                 <i class="fa-fw fa-lg fas fa-edit"></i>
-              </.link>
+              <% end %>
 
-              <.link
-                href="#"
-                class="text-primary-600 link"
-                phx-click="delete_shot_group"
-                phx-value-id={@shot_group.id}
-                data-confirm={dgettext("prompts", "Are you sure you want to delete this shot record?")}
-                aria-label={
-                  dgettext("actions", "Delete shot record of %{shot_group_count} shots",
-                    shot_group_count: @shot_group.count
-                  )
-                }
-              >
+              <%= link to: "#",
+                    class: "text-primary-600 link",
+                    phx_click: "delete_shot_group",
+                    phx_value_id: shot_group.id,
+                    data: [
+                      confirm: dgettext("prompts", "Are you sure you want to delete this shot record?"),
+                      qa: "delete-#{shot_group.id}"
+                    ] do %>
                 <i class="fa-fw fa-lg fas fa-trash"></i>
-              </.link>
+              <% end %>
             </div>
             """
 
           key ->
-            shot_group |> Map.get(key)
+            shot_group |> Map.get(key |> String.to_existing_atom())
         end
 
       {key, value}

lib/cannery_web/live/ammo_group_live/show.html.heex

@@ -11,12 +11,12 @@
 
     <span class="rounded-lg title text-lg">
       <%= gettext("Original count:") %>
-      <%= @original_count %>
+      <%= @ammo_group.count + Ammo.get_used_count(@ammo_group) %>
     </span>
 
     <span class="rounded-lg title text-lg">
       <%= gettext("Percentage left:") %>
-      <%= gettext("%{percentage}%", percentage: @percentage_remaining) %>
+      <%= "#{@ammo_group |> Ammo.get_percentage_remaining()}%" %>
     </span>
 
     <%= if @ammo_group.notes do %>
@@ -27,20 +27,24 @@
     <% end %>
 
     <span class="rounded-lg title text-lg">
-      <%= gettext("Purchased on:") %>
-      <.date id={"#{@ammo_group.id}-purchased-on"} date={@ammo_group.purchased_on} />
+      <%= gettext("Added on:") %>
+      <%= @ammo_group.inserted_at |> display_datetime() %>
     </span>
 
     <%= if @ammo_group.price_paid do %>
       <span class="rounded-lg title text-lg">
         <%= gettext("Original cost:") %>
-        <%= gettext("$%{amount}", amount: display_currency(@ammo_group.price_paid)) %>
+        <%= gettext("$%{amount}",
+          amount: @ammo_group.price_paid |> :erlang.float_to_binary(decimals: 2)
+        ) %>
       </span>
 
       <span class="rounded-lg title text-lg">
         <%= gettext("Current value:") %>
         <%= gettext("$%{amount}",
-          amount: display_currency(@ammo_group.price_paid * @percentage_remaining / 100)
+          amount:
+            (@ammo_group.price_paid * Ammo.get_percentage_remaining(@ammo_group) / 100)
+            |> :erlang.float_to_binary(decimals: 2)
         ) %>
       </span>
     <% end %>
@@ -48,78 +52,64 @@
 
   <div class="flex flex-col justify-center items-center">
     <div class="flex flex-wrap justify-center items-center text-primary-600">
-      <.link
-        navigate={Routes.ammo_type_show_path(Endpoint, :show, @ammo_group.ammo_type)}
-        class="mx-4 my-2 btn btn-primary"
-      >
-        <%= dgettext("actions", "View in Catalog") %>
-      </.link>
+      <%= live_patch(dgettext("actions", "Ammo Details"),
+        to: Routes.ammo_type_show_path(Endpoint, :show, @ammo_group.ammo_type),
+        class: "mx-4 my-2 btn btn-primary",
+        data: [qa: "details"]
+      ) %>
 
-      <.link
-        patch={Routes.ammo_group_show_path(Endpoint, :edit, @ammo_group)}
-        class="mx-4 my-2 text-primary-600 link"
-        aria-label={
-          dgettext("actions", "Edit ammo group of %{ammo_group_count} bullets",
-            ammo_group_count: @ammo_group.count
-          )
-        }
-      >
+      <%= live_patch to: Routes.ammo_group_show_path(Endpoint, :edit, @ammo_group),
+                 class: "mx-4 my-2 text-primary-600 link",
+                 data: [qa: "edit"] do %>
         <i class="fa-fw fa-lg fas fa-edit"></i>
-      </.link>
+      <% end %>
 
-      <.link
-        href="#"
-        class="mx-4 my-2 text-primary-600 link"
-        phx-click="delete"
-        data-confirm={dgettext("prompts", "Are you sure you want to delete this ammo?")}
-        aria-label={
-          dgettext("actions", "Delete ammo group of %{ammo_group_count} bullets",
-            ammo_group_count: @ammo_group.count
-          )
-        }
-      >
+      <%= link to: "#",
+           class: "mx-4 my-2 text-primary-600 link",
+           phx_click: "delete",
+           data: [
+             confirm: dgettext("prompts", "Are you sure you want to delete this ammo?"),
+             qa: "delete"
+           ] do %>
         <i class="fa-fw fa-lg fas fa-trash"></i>
-      </.link>
+      <% end %>
     </div>
 
     <div class="flex flex-wrap justify-center items-center text-primary-600">
       <button type="button" class="mx-4 my-2 btn btn-primary" phx-click="toggle_staged">
         <%= if @ammo_group.staged,
-          do: dgettext("actions", "Unstage from range"),
-          else: dgettext("actions", "Stage for range") %>
+          do: gettext("Unstage from range"),
+          else: gettext("Stage for range") %>
       </button>
 
-      <.link
-        patch={Routes.ammo_group_show_path(Endpoint, :move, @ammo_group)}
-        class="btn btn-primary"
-      >
-        <%= dgettext("actions", "Move ammo") %>
-      </.link>
+      <%= live_patch(dgettext("actions", "Move containers"),
+        to: Routes.ammo_group_show_path(Endpoint, :move, @ammo_group),
+        class: "btn btn-primary",
+        data: [qa: "move"]
+      ) %>
 
-      <.link
-        patch={Routes.ammo_group_show_path(Endpoint, :add_shot_group, @ammo_group)}
-        class="mx-4 my-2 btn btn-primary"
-      >
-        <%= dgettext("actions", "Record shots") %>
-      </.link>
+      <%= live_patch(dgettext("actions", "Record shots"),
+        to: Routes.ammo_group_show_path(Endpoint, :add_shot_group, @ammo_group),
+        class: "mx-4 my-2 btn btn-primary"
+      ) %>
     </div>
   </div>
 
   <hr class="mb-4 w-full" />
 
   <div>
-    <%= if @container do %>
+    <%= if @ammo_group.container do %>
       <h1 class="mb-4 px-4 py-2 text-center rounded-lg title text-xl">
         <%= gettext("Stored in") %>
       </h1>
 
-      <.container_card container={@container} current_user={@current_user} />
+      <.container_card container={@ammo_group.container} />
     <% else %>
-      <%= gettext("This ammo is not in a container") %>
+      <%= gettext("This ammo group is not in a container") %>
     <% end %>
   </div>
 
-  <%= unless @shot_groups |> Enum.empty?() do %>
+  <%= unless @ammo_group.shot_groups |> Enum.empty?() do %>
     <hr class="mb-4 w-full" />
 
     <h1 class="mb-4 px-4 py-2 text-center rounded-lg title text-xl">

lib/cannery_web/live/ammo_type_live/form_component.ex

@@ -13,13 +13,17 @@ defmodule CanneryWeb.AmmoTypeLive.FormComponent do
           %{:ammo_type => AmmoType.t(), :current_user => User.t(), optional(any) => any},
           Socket.t()
         ) :: {:ok, Socket.t()}
-  def update(%{current_user: _current_user} = assigns, socket) do
-    {:ok, socket |> assign(assigns) |> assign_changeset(%{})}
+  def update(%{ammo_type: ammo_type, current_user: _current_user} = assigns, socket) do
+    {:ok, socket |> assign(assigns) |> assign(:changeset, Ammo.change_ammo_type(ammo_type))}
   end
 
   @impl true
-  def handle_event("validate", %{"ammo_type" => ammo_type_params}, socket) do
-    {:noreply, socket |> assign_changeset(ammo_type_params)}
+  def handle_event(
+        "validate",
+        %{"ammo_type" => ammo_type_params},
+        %{assigns: %{ammo_type: ammo_type}} = socket
+      ) do
+    {:noreply, socket |> assign(:changeset, ammo_type |> Ammo.change_ammo_type(ammo_type_params))}
   end
 
   def handle_event(
@@ -30,34 +34,6 @@ defmodule CanneryWeb.AmmoTypeLive.FormComponent do
     save_ammo_type(socket, action, ammo_type_params)
   end
 
-  defp assign_changeset(
-         %{assigns: %{action: action, ammo_type: ammo_type, current_user: user}} = socket,
-         ammo_type_params
-       ) do
-    changeset_action =
-      case action do
-        create when create in [:new, :clone] -> :insert
-        :edit -> :update
-      end
-
-    changeset =
-      case action do
-        create when create in [:new, :clone] ->
-          ammo_type |> AmmoType.create_changeset(user, ammo_type_params)
-
-        :edit ->
-          ammo_type |> AmmoType.update_changeset(ammo_type_params)
-      end
-
-    changeset =
-      case changeset |> Changeset.apply_action(changeset_action) do
-        {:ok, _data} -> changeset
-        {:error, changeset} -> changeset
-      end
-
-    socket |> assign(changeset: changeset)
-  end
-
   defp save_ammo_type(
          %{assigns: %{ammo_type: ammo_type, current_user: current_user, return_to: return_to}} =
            socket,
@@ -68,7 +44,7 @@ defmodule CanneryWeb.AmmoTypeLive.FormComponent do
       case Ammo.update_ammo_type(ammo_type, ammo_type_params, current_user) do
         {:ok, %{name: ammo_type_name}} ->
           prompt = dgettext("prompts", "%{name} updated successfully", name: ammo_type_name)
-          socket |> put_flash(:info, prompt) |> push_navigate(to: return_to)
+          socket |> put_flash(:info, prompt) |> push_redirect(to: return_to)
 
         {:error, %Changeset{} = changeset} ->
           socket |> assign(:changeset, changeset)
@@ -79,15 +55,14 @@ defmodule CanneryWeb.AmmoTypeLive.FormComponent do
 
   defp save_ammo_type(
          %{assigns: %{current_user: current_user, return_to: return_to}} = socket,
-         action,
+         :new,
          ammo_type_params
-       )
-       when action in [:new, :clone] do
+       ) do
     socket =
       case Ammo.create_ammo_type(ammo_type_params, current_user) do
         {:ok, %{name: ammo_type_name}} ->
           prompt = dgettext("prompts", "%{name} created successfully", name: ammo_type_name)
-          socket |> put_flash(:info, prompt) |> push_navigate(to: return_to)
+          socket |> put_flash(:info, prompt) |> push_redirect(to: return_to)
 
         {:error, %Changeset{} = changeset} ->
           socket |> assign(changeset: changeset)

lib/cannery_web/live/ammo_type_live/form_component.html.heex

@@ -3,7 +3,7 @@
     <%= @title %>
   </h2>
   <.form
-    :let={f}
+    let={f}
     for={@changeset}
     id="ammo_type-form"
     phx-target={@myself}
@@ -11,103 +11,94 @@
     phx-submit="save"
     class="flex flex-col space-y-4 sm:space-y-0 sm:grid sm:grid-cols-3 sm:gap-4 justify-center items-center"
   >
-    <div
-      :if={@changeset.action && not @changeset.valid?()}
-      class="invalid-feedback col-span-3 text-center"
-    >
-      <%= dgettext("errors", "Oops, something went wrong! Please check the errors below.") %>
-    </div>
-
-    <%= label(f, :type, gettext("Type"), class: "title text-lg text-primary-600") %>
-    <%= select(
-      f,
-      :type,
-      [{gettext("Rifle"), :rifle}, {gettext("Shotgun"), :shotgun}, {gettext("Pistol"), :pistol}],
-      class: "text-center col-span-2 input input-primary",
-      maxlength: 255
-    ) %>
-    <%= error_tag(f, :type, "col-span-3 text-center") %>
+    <%= if @changeset.action && not @changeset.valid? do %>
+      <div class="invalid-feedback col-span-3 text-center">
+        <%= changeset_errors(@changeset) %>
+      </div>
+    <% end %>
 
     <%= label(f, :name, gettext("Name"), class: "title text-lg text-primary-600") %>
-    <%= text_input(f, :name,
-      class: "text-center col-span-2 input input-primary",
-      maxlength: 255
-    ) %>
+    <%= text_input(f, :name, class: "text-center col-span-2 input input-primary") %>
     <%= error_tag(f, :name, "col-span-3 text-center") %>
 
     <%= label(f, :desc, gettext("Description"), class: "title text-lg text-primary-600") %>
     <%= textarea(f, :desc,
-      id: "ammo-type-form-desc",
       class: "text-center col-span-2 input input-primary",
-      phx_hook: "MaintainAttrs",
-      phx_update: "ignore"
+      phx_hook: "MaintainAttrs"
     ) %>
     <%= error_tag(f, :desc, "col-span-3 text-center") %>
 
-    <h2 class="text-center title text-lg text-primary-600 col-span-3">
-      <%= gettext("Dimensions") %>
-    </h2>
-
-    <%= if Changeset.get_field(@changeset, :type) in [:rifle, :pistol] do %>
-      <%= label(f, :cartridge, gettext("Cartridge"), class: "title text-lg text-primary-600") %>
-      <%= text_input(f, :cartridge,
-        class: "text-center col-span-2 input input-primary",
-        maxlength: 255,
-        placeholder: gettext("5.56x46mm NATO")
-      ) %>
-      <%= error_tag(f, :cartridge, "col-span-3 text-center") %>
-    <% else %>
-      <%= hidden_input(f, :cartridge, value: nil) %>
-    <% end %>
-
-    <%= label(
-      f,
-      :caliber,
-      if(Changeset.get_field(@changeset, :type) == :shotgun,
-        do: gettext("Gauge"),
-        else: gettext("Caliber")
-      ),
-      class: "title text-lg text-primary-600"
+    <a
+      href="https://en.wikipedia.org/wiki/Bullet#Abbreviations"
+      class="col-span-3 text-center link title text-md text-primary-600"
+    >
+      <%= gettext("Example bullet type abbreviations") %>
+    </a>
+    <%= label(f, :bullet_type, gettext("Bullet type"), class: "title text-lg text-primary-600") %>
+    <%= text_input(f, :bullet_type,
+      class: "text-center col-span-2 input input-primary",
+      placeholder: gettext("FMJ")
     ) %>
+    <%= error_tag(f, :bullet_type, "col-span-3 text-center") %>
+
+    <%= label(f, :bullet_core, gettext("Bullet core"), class: "title text-lg text-primary-600") %>
+    <%= text_input(f, :bullet_core,
+      class: "text-center col-span-2 input input-primary",
+      placeholder: gettext("Steel")
+    ) %>
+    <%= error_tag(f, :bullet_core, "col-span-3 text-center") %>
+
+    <%= label(f, :cartridge, gettext("Cartridge"), class: "title text-lg text-primary-600") %>
+    <%= text_input(f, :cartridge,
+      class: "text-center col-span-2 input input-primary",
+      placeholder: "5.56x46mm NATO"
+    ) %>
+    <%= error_tag(f, :cartridge, "col-span-3 text-center") %>
+
+    <%= label(f, :caliber, gettext("Caliber"), class: "title text-lg text-primary-600") %>
     <%= text_input(f, :caliber,
       class: "text-center col-span-2 input input-primary",
-      maxlength: 255,
-      placeholder: gettext(".223")
+      placeholder: ".223"
     ) %>
     <%= error_tag(f, :caliber, "col-span-3 text-center") %>
 
-    <%= if Changeset.get_field(@changeset, :type) == :shotgun do %>
-      <%= label(f, :unfired_length, gettext("Unfired shell length"),
-        class: "title text-lg text-primary-600"
-      ) %>
-      <%= text_input(f, :unfired_length,
-        class: "text-center col-span-2 input input-primary",
-        maxlength: 255
-      ) %>
-      <%= error_tag(f, :unfired_length, "col-span-3 text-center") %>
+    <%= label(f, :case_material, gettext("Case material"), class: "title text-lg text-primary-600") %>
+    <%= text_input(f, :case_material,
+      class: "text-center col-span-2 input input-primary",
+      placeholder: gettext("Brass")
+    ) %>
+    <%= error_tag(f, :case_material, "col-span-3 text-center") %>
 
-      <%= label(f, :brass_height, gettext("Brass height"), class: "title text-lg text-primary-600") %>
-      <%= text_input(f, :brass_height,
-        class: "text-center col-span-2 input input-primary",
-        maxlength: 255
-      ) %>
-      <%= error_tag(f, :brass_height, "col-span-3 text-center") %>
+    <%= label(f, :jacket_type, gettext("Jacket type"), class: "title text-lg text-primary-600") %>
+    <%= text_input(f, :jacket_type,
+      class: "text-center col-span-2 input input-primary",
+      placeholder: gettext("Bimetal")
+    ) %>
+    <%= error_tag(f, :case_material, "col-span-3 text-center") %>
 
-      <%= label(f, :chamber_size, gettext("Chamber size"), class: "title text-lg text-primary-600") %>
-      <%= text_input(f, :chamber_size,
-        class: "text-center col-span-2 input input-primary",
-        maxlength: 255
-      ) %>
-      <%= error_tag(f, :chamber_size, "col-span-3 text-center") %>
-    <% else %>
-      <%= hidden_input(f, :unfired_length, value: nil) %>
-      <%= hidden_input(f, :brass_height, value: nil) %>
-      <%= hidden_input(f, :chamber_size, value: nil) %>
-    <% end %>
+    <%= label(f, :muzzle_velocity, gettext("Muzzle velocity"),
+      class: "title text-lg text-primary-600"
+    ) %>
+    <%= number_input(f, :muzzle_velocity,
+      step: "1",
+      class: "text-center col-span-2 input input-primary",
+      min: 1
+    ) %>
+    <%= error_tag(f, :muzzle_velocity, "col-span-3 text-center") %>
 
-    <h2 class="text-center title text-lg text-primary-600 col-span-3">
-      <%= gettext("Projectile") %>
-    </h2>
+    <%= label(f, :powder_type, gettext("Powder type"), class: "title text-lg text-primary-600") %>
+    <%= text_input(f, :powder_type, class: "text-center col-span-2 input input-primary") %>
+    <%= error_tag(f, :powder_type, "col-span-3 text-center") %>
+
+    <%= label(f, :powder_grains_per_charge, gettext("Powder grains per charge"),
+      class: "title text-lg text-primary-600"
+    ) %>
+    <%= number_input(f, :powder_grains_per_charge,
+      step: "1",
+      class: "text-center col-span-2 input input-primary",
+      min: 1
+    ) %>
+    <%= error_tag(f, :powder_grains_per_charge, "col-span-3 text-center") %>
 
     <%= label(f, :grains, gettext("Grains"), class: "title text-lg text-primary-600") %>
     <%= number_input(f, :grains,
@@ -117,202 +108,27 @@
     ) %>
     <%= error_tag(f, :grains, "col-span-3 text-center") %>
 
-    <%= label f, :bullet_type, class: "flex title text-lg text-primary-600 space-x-2" do %>
-      <p><%= gettext("Bullet type") %></p>
-
-      <.link
-        href="https://shootersreference.com/reloadingdata/bullet_abbreviations/"
-        class="link"
-        target="_blank"
-        rel="noopener noreferrer"
-      >
-        <i class="fas fa-md fa-external-link-alt"></i>
-      </.link>
-    <% end %>
-    <%= text_input(f, :bullet_type,
-      class: "text-center col-span-2 input input-primary",
-      maxlength: 255,
-      placeholder: gettext("FMJ")
-    ) %>
-    <%= error_tag(f, :bullet_type, "col-span-3 text-center") %>
-
-    <%= label(
-      f,
-      :bullet_core,
-      if(Changeset.get_field(@changeset, :type) == :shotgun,
-        do: gettext("Slug core"),
-        else: gettext("Bullet core")
-      ),
-      class: "title text-lg text-primary-600"
-    ) %>
-    <%= text_input(f, :bullet_core,
-      class: "text-center col-span-2 input input-primary",
-      maxlength: 255,
-      placeholder: gettext("Steel")
-    ) %>
-    <%= error_tag(f, :bullet_core, "col-span-3 text-center") %>
-
-    <%= if Changeset.get_field(@changeset, :type) in [:rifle, :pistol] do %>
-      <%= label(f, :jacket_type, gettext("Jacket type"), class: "title text-lg text-primary-600") %>
-      <%= text_input(f, :jacket_type,
-        class: "text-center col-span-2 input input-primary",
-        maxlength: 255,
-        placeholder: gettext("Bimetal")
-      ) %>
-      <%= error_tag(f, :jacket_type, "col-span-3 text-center") %>
-    <% else %>
-      <%= hidden_input(f, :jacket_type, value: nil) %>
-    <% end %>
-
-    <%= label(f, :case_material, gettext("Case material"), class: "title text-lg text-primary-600") %>
-    <%= text_input(f, :case_material,
-      class: "text-center col-span-2 input input-primary",
-      maxlength: 255,
-      placeholder: gettext("Brass")
-    ) %>
-    <%= error_tag(f, :case_material, "col-span-3 text-center") %>
-
-    <%= if Changeset.get_field(@changeset, :type) == :shotgun do %>
-      <%= label(f, :wadding, gettext("Wadding"), class: "title text-lg text-primary-600") %>
-      <%= text_input(f, :wadding,
-        class: "text-center col-span-2 input input-primary",
-        maxlength: 255
-      ) %>
-      <%= error_tag(f, :wadding, "col-span-3 text-center") %>
-
-      <%= label(f, :shot_type, gettext("Shot type"), class: "title text-lg text-primary-600") %>
-      <%= text_input(f, :shot_type,
-        class: "text-center col-span-2 input input-primary",
-        maxlength: 255,
-        placeholder: gettext("Target, bird, buck, etc")
-      ) %>
-      <%= error_tag(f, :shot_type, "col-span-3 text-center") %>
-
-      <%= label(f, :shot_material, gettext("Shot material"),
-        class: "title text-lg text-primary-600"
-      ) %>
-      <%= text_input(f, :shot_material,
-        class: "text-center col-span-2 input input-primary",
-        maxlength: 255
-      ) %>
-      <%= error_tag(f, :shot_material, "col-span-3 text-center") %>
-
-      <%= label(f, :shot_size, gettext("Shot size"), class: "title text-lg text-primary-600") %>
-      <%= text_input(f, :shot_size,
-        class: "text-center col-span-2 input input-primary",
-        maxlength: 255
-      ) %>
-      <%= error_tag(f, :shot_size, "col-span-3 text-center") %>
-
-      <%= label(f, :load_grains, gettext("Load grains"), class: "title text-lg text-primary-600") %>
-      <%= number_input(f, :load_grains,
-        step: "1",
-        class: "text-center col-span-2 input input-primary",
-        min: 1
-      ) %>
-      <%= error_tag(f, :load_grains, "col-span-3 text-center") %>
-
-      <%= label(f, :shot_charge_weight, gettext("Shot charge weight"),
-        class: "title text-lg text-primary-600"
-      ) %>
-      <%= text_input(f, :shot_charge_weight,
-        class: "text-center col-span-2 input input-primary",
-        maxlength: 255
-      ) %>
-      <%= error_tag(f, :shot_charge_weight, "col-span-3 text-center") %>
-    <% else %>
-      <%= hidden_input(f, :wadding, value: nil) %>
-      <%= hidden_input(f, :shot_type, value: nil) %>
-      <%= hidden_input(f, :shot_material, value: nil) %>
-      <%= hidden_input(f, :shot_size, value: nil) %>
-      <%= hidden_input(f, :load_grains, value: nil) %>
-      <%= hidden_input(f, :shot_charge_weight, value: nil) %>
-    <% end %>
-
-    <h2 class="text-center title text-lg text-primary-600 col-span-3">
-      <%= gettext("Powder") %>
-    </h2>
-
-    <%= label(f, :powder_type, gettext("Powder type"), class: "title text-lg text-primary-600") %>
-    <%= text_input(f, :powder_type,
-      class: "text-center col-span-2 input input-primary",
-      maxlength: 255
-    ) %>
-    <%= error_tag(f, :powder_type, "col-span-3 text-center") %>
-
-    <%= if Changeset.get_field(@changeset, :type) in [:rifle, :pistol] do %>
-      <%= label(f, :powder_grains_per_charge, gettext("Powder grains per charge"),
-        class: "title text-lg text-primary-600"
-      ) %>
-      <%= number_input(f, :powder_grains_per_charge,
-        step: "1",
-        class: "text-center col-span-2 input input-primary",
-        min: 1
-      ) %>
-      <%= error_tag(f, :powder_grains_per_charge, "col-span-3 text-center") %>
-    <% else %>
-      <%= hidden_input(f, :powder_grains_per_charge, value: nil) %>
-    <% end %>
-
     <%= label(f, :pressure, gettext("Pressure"), class: "title text-lg text-primary-600") %>
     <%= text_input(f, :pressure,
       class: "text-center col-span-2 input input-primary",
-      maxlength: 255,
-      placeholder: gettext("+P")
+      placeholder: "+P"
     ) %>
     <%= error_tag(f, :pressure, "col-span-3 text-center") %>
 
-    <%= if Changeset.get_field(@changeset, :type) == :shotgun do %>
-      <%= label(f, :dram_equivalent, gettext("Dram equivalent"),
-        class: "title text-lg text-primary-600"
-      ) %>
-      <%= text_input(f, :dram_equivalent,
-        class: "text-center col-span-2 input input-primary",
-        maxlength: 255
-      ) %>
-      <%= error_tag(f, :dram_equivalent, "col-span-3 text-center") %>
-    <% else %>
-      <%= hidden_input(f, :dram_equivalent, value: nil) %>
-    <% end %>
-
-    <%= if Changeset.get_field(@changeset, :type) in [:rifle, :pistol] do %>
-      <%= label(f, :muzzle_velocity, gettext("Muzzle velocity"),
-        class: "title text-lg text-primary-600"
-      ) %>
-      <%= number_input(f, :muzzle_velocity,
-        step: "1",
-        class: "text-center col-span-2 input input-primary",
-        min: 1
-      ) %>
-      <%= error_tag(f, :muzzle_velocity, "col-span-3 text-center") %>
-    <% else %>
-      <%= hidden_input(f, :muzzle_velocity, value: nil) %>
-    <% end %>
-
-    <h2 class="text-center title text-lg text-primary-600 col-span-3">
-      <%= gettext("Primer") %>
-    </h2>
-
     <%= label(f, :primer_type, gettext("Primer type"), class: "title text-lg text-primary-600") %>
     <%= text_input(f, :primer_type,
       class: "text-center col-span-2 input input-primary",
-      maxlength: 255,
-      placeholder: gettext("Boxer")
+      placeholder: "Boxer"
     ) %>
     <%= error_tag(f, :primer_type, "col-span-3 text-center") %>
 
     <%= label(f, :firing_type, gettext("Firing type"), class: "title text-lg text-primary-600") %>
     <%= text_input(f, :firing_type,
       class: "text-center col-span-2 input input-primary",
-      maxlength: 255,
-      placeholder: gettext("Centerfire")
+      placeholder: "Centerfire"
     ) %>
     <%= error_tag(f, :firing_type, "col-span-3 text-center") %>
 
-    <h2 class="text-center title text-lg text-primary-600 col-span-3">
-      <%= gettext("Attributes") %>
-    </h2>
-
     <%= label(f, :tracer, gettext("Tracer"), class: "title text-lg text-primary-600") %>
     <%= checkbox(f, :tracer, class: "text-center col-span-2 checkbox") %>
     <%= error_tag(f, :tracer, "col-span-3 text-center") %>
@@ -329,22 +145,12 @@
     <%= checkbox(f, :corrosive, class: "text-center col-span-2 checkbox") %>
     <%= error_tag(f, :corrosive, "col-span-3 text-center") %>
 
-    <h2 class="text-center title text-lg text-primary-600 col-span-3">
-      <%= gettext("Manufacturer") %>
-    </h2>
-
     <%= label(f, :manufacturer, gettext("Manufacturer"), class: "title text-lg text-primary-600") %>
-    <%= text_input(f, :manufacturer,
-      class: "text-center col-span-2 input input-primary",
-      maxlength: 255
-    ) %>
+    <%= text_input(f, :manufacturer, class: "text-center col-span-2 input input-primary") %>
     <%= error_tag(f, :manufacturer, "col-span-3 text-center") %>
 
     <%= label(f, :upc, gettext("UPC"), class: "title text-lg text-primary-600") %>
-    <%= text_input(f, :upc,
-      class: "text-center col-span-2 input input-primary",
-      maxlength: 255
-    ) %>
+    <%= text_input(f, :upc, class: "text-center col-span-2 input input-primary") %>
     <%= error_tag(f, :upc, "col-span-3 text-center") %>
 
     <%= submit(dgettext("actions", "Save"),

lib/cannery_web/live/ammo_type_live/index.ex

@@ -4,15 +4,13 @@ defmodule CanneryWeb.AmmoTypeLive.Index do
   """
 
   use CanneryWeb, :live_view
+
   alias Cannery.{Ammo, Ammo.AmmoType}
+  alias CanneryWeb.Endpoint
 
   @impl true
-  def mount(%{"search" => search}, _session, socket) do
-    {:ok, socket |> assign(type: :all, show_used: false, search: search) |> list_ammo_types()}
-  end
-
   def mount(_params, _session, socket) do
-    {:ok, socket |> assign(type: :all, show_used: false, search: nil) |> list_ammo_types()}
+    {:ok, socket |> list_ammo_types()}
   end
 
   @impl true
@@ -21,94 +19,135 @@ defmodule CanneryWeb.AmmoTypeLive.Index do
   end
 
   defp apply_action(%{assigns: %{current_user: current_user}} = socket, :edit, %{"id" => id}) do
-    %{name: ammo_type_name} = ammo_type = Ammo.get_ammo_type!(id, current_user)
-
     socket
-    |> assign(
-      page_title: gettext("Edit %{ammo_type_name}", ammo_type_name: ammo_type_name),
-      ammo_type: ammo_type
-    )
-  end
-
-  defp apply_action(%{assigns: %{current_user: current_user}} = socket, :clone, %{"id" => id}) do
-    socket
-    |> assign(
-      page_title: gettext("New Ammo type"),
-      ammo_type: %{Ammo.get_ammo_type!(id, current_user) | id: nil}
-    )
+    |> assign(:page_title, gettext("Edit Ammo type"))
+    |> assign(:ammo_type, Ammo.get_ammo_type!(id, current_user))
   end
 
   defp apply_action(socket, :new, _params) do
     socket
-    |> assign(
-      page_title: gettext("New Ammo type"),
-      ammo_type: %AmmoType{}
-    )
+    |> assign(:page_title, gettext("New Ammo type"))
+    |> assign(:ammo_type, %AmmoType{})
   end
 
   defp apply_action(socket, :index, _params) do
-    socket
-    |> assign(
-      page_title: gettext("Catalog"),
-      search: nil,
-      ammo_type: nil
-    )
-    |> list_ammo_types()
-  end
-
-  defp apply_action(socket, :search, %{"search" => search}) do
-    socket
-    |> assign(
-      page_title: gettext("Catalog"),
-      search: search,
-      ammo_type: nil
-    )
-    |> list_ammo_types()
+    socket |> assign(:page_title, gettext("Ammo types")) |> assign(:ammo_type, nil)
   end
 
   @impl true
   def handle_event("delete", %{"id" => id}, %{assigns: %{current_user: current_user}} = socket) do
     %{name: name} = Ammo.get_ammo_type!(id, current_user) |> Ammo.delete_ammo_type!(current_user)
+
     prompt = dgettext("prompts", "%{name} deleted succesfully", name: name)
+
     {:noreply, socket |> put_flash(:info, prompt) |> list_ammo_types()}
   end
 
-  def handle_event("toggle_show_used", _params, %{assigns: %{show_used: show_used}} = socket) do
-    {:noreply, socket |> assign(:show_used, !show_used) |> list_ammo_types()}
+  defp list_ammo_types(%{assigns: %{current_user: current_user}} = socket) do
+    ammo_types = Ammo.list_ammo_types(current_user)
+
+    columns =
+      [
+        %{label: gettext("Name"), key: "name", type: :string},
+        %{label: gettext("Bullet type"), key: "bullet_type", type: :string},
+        %{label: gettext("Bullet core"), key: "bullet_core", type: :string},
+        %{label: gettext("Cartridge"), key: "cartridge", type: :string},
+        %{label: gettext("Caliber"), key: "caliber", type: :string},
+        %{label: gettext("Case material"), key: "case_material", type: :string},
+        %{label: gettext("Jacket type"), key: "jacket_type", type: :string},
+        %{label: gettext("Muzzle velocity"), key: "muzzle_velocity", type: :string},
+        %{label: gettext("Powder type"), key: "powder_type", type: :string},
+        %{
+          label: gettext("Powder grains per charge"),
+          key: "powder_grains_per_charge",
+          type: :string
+        },
+        %{label: gettext("Grains"), key: "grains", type: :string},
+        %{label: gettext("Pressure"), key: "pressure", type: :string},
+        %{label: gettext("Primer type"), key: "primer_type", type: :string},
+        %{label: gettext("Firing type"), key: "firing_type", type: :string},
+        %{label: gettext("Tracer"), key: "tracer", type: :boolean},
+        %{label: gettext("Incendiary"), key: "incendiary", type: :boolean},
+        %{label: gettext("Blank"), key: "blank", type: :boolean},
+        %{label: gettext("Corrosive"), key: "corrosive", type: :boolean},
+        %{label: gettext("Manufacturer"), key: "manufacturer", type: :string},
+        %{label: gettext("UPC"), key: "upc", type: :string}
+      ]
+      |> Enum.filter(fn %{key: key, type: type} ->
+        # remove columns if all values match defaults
+        default_value = if type == :boolean, do: false, else: nil
+
+        ammo_types
+        |> Enum.any?(fn ammo_type ->
+          not (ammo_type |> Map.get(key |> String.to_existing_atom()) == default_value)
+        end)
+      end)
+      |> Kernel.++([
+        %{label: gettext("Total # of rounds"), key: "round_count", type: :round_count},
+        %{label: gettext("Average Price paid"), key: "avg_price_paid", type: :avg_price_paid},
+        %{label: nil, key: "actions", type: :actions, sortable: false}
+      ])
+
+    rows =
+      ammo_types
+      |> Enum.map(fn ammo_type -> ammo_type |> get_ammo_type_values(columns, current_user) end)
+
+    socket |> assign(columns: columns, rows: rows)
   end
 
-  def handle_event("search", %{"search" => %{"search_term" => ""}}, socket) do
-    {:noreply, socket |> push_patch(to: Routes.ammo_type_index_path(Endpoint, :index))}
+  defp get_ammo_type_values(ammo_type, columns, current_user) do
+    columns
+    |> Enum.into(%{}, fn %{key: key, type: type} ->
+      {key, get_ammo_type_value(type, key, ammo_type, current_user)}
+    end)
   end
 
-  def handle_event("search", %{"search" => %{"search_term" => search_term}}, socket) do
-    search_path = Routes.ammo_type_index_path(Endpoint, :search, search_term)
-    {:noreply, socket |> push_patch(to: search_path)}
+  defp get_ammo_type_value(:boolean, key, ammo_type, _current_user),
+    do: ammo_type |> Map.get(key |> String.to_existing_atom()) |> humanize()
+
+  defp get_ammo_type_value(:round_count, _key, ammo_type, current_user),
+    do: ammo_type |> Ammo.get_round_count_for_ammo_type(current_user)
+
+  defp get_ammo_type_value(:avg_price_paid, _key, ammo_type, current_user) do
+    case ammo_type |> Ammo.get_average_cost_for_ammo_type!(current_user) do
+      nil -> gettext("No cost information")
+      count -> gettext("$%{amount}", amount: count |> :erlang.float_to_binary(decimals: 2))
+    end
   end
 
-  def handle_event("change_type", %{"ammo_type" => %{"type" => "rifle"}}, socket) do
-    {:noreply, socket |> assign(:type, :rifle) |> list_ammo_types()}
+  defp get_ammo_type_value(:actions, _key, ammo_type, _current_user) do
+    assigns = %{ammo_type: ammo_type}
+
+    ~H"""
+    <div class="px-4 py-2 space-x-4 flex justify-center items-center">
+      <%= live_redirect to: Routes.ammo_type_show_path(Endpoint, :show, ammo_type),
+                    class: "text-primary-600 link",
+                    data: [qa: "view-#{ammo_type.id}"] do %>
+        <i class="fa-fw fa-lg fas fa-eye"></i>
+      <% end %>
+
+      <%= live_patch to: Routes.ammo_type_index_path(Endpoint, :edit, ammo_type),
+                  class: "text-primary-600 link",
+                  data: [qa: "edit-#{ammo_type.id}"] do %>
+        <i class="fa-fw fa-lg fas fa-edit"></i>
+      <% end %>
+
+      <%= link to: "#",
+            class: "text-primary-600 link",
+            phx_click: "delete",
+            phx_value_id: ammo_type.id,
+            data: [
+              confirm: dgettext("prompts", "Are you sure you want to delete this ammo?"),
+              qa: "delete-#{ammo_type.id}"
+            ] do %>
+        <i class="fa-lg fas fa-trash"></i>
+      <% end %>
+    </div>
+    """
   end
 
-  def handle_event("change_type", %{"ammo_type" => %{"type" => "shotgun"}}, socket) do
-    {:noreply, socket |> assign(:type, :shotgun) |> list_ammo_types()}
-  end
+  defp get_ammo_type_value(nil, _key, _ammo_type, _current_user), do: nil
 
-  def handle_event("change_type", %{"ammo_type" => %{"type" => "pistol"}}, socket) do
-    {:noreply, socket |> assign(:type, :pistol) |> list_ammo_types()}
-  end
-
-  def handle_event("change_type", %{"ammo_type" => %{"type" => _all}}, socket) do
-    {:noreply, socket |> assign(:type, :all) |> list_ammo_types()}
-  end
-
-  defp list_ammo_types(
-         %{assigns: %{type: type, search: search, current_user: current_user}} = socket
-       ) do
-    socket
-    |> assign(
-      ammo_types: Ammo.list_ammo_types(search, current_user, type),
-      ammo_types_count: Ammo.get_ammo_types_count!(current_user)
-    )
-  end
+  defp get_ammo_type_value(_other, key, ammo_type, _current_user),
+    do: ammo_type |> Map.get(key |> String.to_existing_atom())
 end

lib/cannery_web/live/ammo_type_live/index.html.heex

@@ -1,155 +1,45 @@
 <div class="flex flex-col space-y-8 justify-center items-center">
   <h1 class="title text-2xl title-primary-500">
-    <%= gettext("Catalog") %>
+    <%= gettext("Ammo Types") %>
   </h1>
 
-  <%= if @ammo_types_count == 0 do %>
+  <%= if @rows |> Enum.empty?() do %>
     <h2 class="title text-xl text-primary-600">
-      <%= gettext("No Ammo types") %>
+      <%= gettext("No Ammo Types") %>
       <%= display_emoji("😔") %>
     </h2>
 
-    <.link patch={Routes.ammo_type_index_path(Endpoint, :new)} class="btn btn-primary">
-      <%= dgettext("actions", "Add your first type!") %>
-    </.link>
+    <%= live_patch(dgettext("actions", "Add your first type!"),
+      to: Routes.ammo_type_index_path(Endpoint, :new),
+      class: "btn btn-primary"
+    ) %>
   <% else %>
-    <.link patch={Routes.ammo_type_index_path(Endpoint, :new)} class="btn btn-primary">
-      <%= dgettext("actions", "New Ammo type") %>
-    </.link>
+    <%= live_patch(dgettext("actions", "New Ammo type"),
+      to: Routes.ammo_type_index_path(Endpoint, :new),
+      class: "btn btn-primary"
+    ) %>
 
-    <div class="w-full flex flex-col sm:flex-row justify-center items-center space-y-4 sm:space-y-0 sm:space-x-4 max-w-2xl">
-      <.form
-        :let={f}
-        for={%{}}
-        as={:ammo_type}
-        phx-change="change_type"
-        phx-submit="change_type"
-        class="flex items-center"
-      >
-        <%= label(f, :type, gettext("Type"), class: "title text-primary-600 text-lg text-center") %>
-
-        <%= select(
-          f,
-          :type,
-          [
-            {gettext("All"), :all},
-            {gettext("Rifle"), :rifle},
-            {gettext("Shotgun"), :shotgun},
-            {gettext("Pistol"), :pistol}
-          ],
-          class: "mx-2 my-1 min-w-md input input-primary",
-          value: @type
-        ) %>
-      </.form>
-
-      <.form
-        :let={f}
-        for={%{}}
-        as={:search}
-        phx-change="search"
-        phx-submit="search"
-        class="grow flex items-center"
-      >
-        <%= text_input(f, :search_term,
-          class: "grow input input-primary",
-          value: @search,
-          role: "search",
-          phx_debounce: 300,
-          placeholder: gettext("Search catalog")
-        ) %>
-      </.form>
-
-      <.toggle_button action="toggle_show_used" value={@show_used}>
-        <span class="title text-lg text-primary-600">
-          <%= gettext("Show used") %>
-        </span>
-      </.toggle_button>
-    </div>
-
-    <%= if @ammo_types |> Enum.empty?() do %>
-      <h2 class="title text-xl text-primary-600">
-        <%= gettext("No Ammo types") %>
-        <%= display_emoji("😔") %>
-      </h2>
-    <% else %>
-      <.live_component
-        module={CanneryWeb.Components.AmmoTypeTableComponent}
-        id="ammo_types_index_table"
-        action={@live_action}
-        ammo_types={@ammo_types}
-        current_user={@current_user}
-        show_used={@show_used}
-        type={@type}
-      >
-        <:actions :let={ammo_type}>
-          <div class="px-4 py-2 space-x-4 flex justify-center items-center">
-            <.link
-              navigate={Routes.ammo_type_show_path(Endpoint, :show, ammo_type)}
-              class="text-primary-600 link"
-              aria-label={
-                dgettext("actions", "View %{ammo_type_name}", ammo_type_name: ammo_type.name)
-              }
-            >
-              <i class="fa-fw fa-lg fas fa-eye"></i>
-            </.link>
-
-            <.link
-              patch={Routes.ammo_type_index_path(Endpoint, :edit, ammo_type)}
-              class="text-primary-600 link"
-              aria-label={
-                dgettext("actions", "Edit %{ammo_type_name}", ammo_type_name: ammo_type.name)
-              }
-            >
-              <i class="fa-fw fa-lg fas fa-edit"></i>
-            </.link>
-
-            <.link
-              patch={Routes.ammo_type_index_path(Endpoint, :clone, ammo_type)}
-              class="text-primary-600 link"
-              aria-label={
-                dgettext("actions", "Clone %{ammo_type_name}", ammo_type_name: ammo_type.name)
-              }
-            >
-              <i class="fa-fw fa-lg fas fa-copy"></i>
-            </.link>
-
-            <.link
-              href="#"
-              class="text-primary-600 link"
-              phx-click="delete"
-              phx-value-id={ammo_type.id}
-              data-confirm={
-                dgettext(
-                  "prompts",
-                  "Are you sure you want to delete %{name}? This will delete all %{name} type ammo as well!",
-                  name: ammo_type.name
-                )
-              }
-              aria-label={
-                dgettext("actions", "Delete %{ammo_type_name}", ammo_type_name: ammo_type.name)
-              }
-            >
-              <i class="fa-lg fas fa-trash"></i>
-            </.link>
-          </div>
-        </:actions>
-      </.live_component>
-    <% end %>
+    <.live_component
+      module={CanneryWeb.Components.TableComponent}
+      id="ammo_types_index_table"
+      action={@live_action}
+      columns={@columns}
+      rows={@rows}
+    />
   <% end %>
 </div>
 
-<.modal
-  :if={@live_action in [:new, :edit, :clone]}
-  return_to={Routes.ammo_type_index_path(Endpoint, :index)}
->
-  <.live_component
-    module={CanneryWeb.AmmoTypeLive.FormComponent}
-    id={@ammo_type.id || :new}
-    title={@page_title}
-    action={@live_action}
-    ammo_type={@ammo_type}
-    return_to={Routes.ammo_type_index_path(Endpoint, :index)}
-    current_user={@current_user}
-    }
-  />
-</.modal>
+<%= if @live_action in [:new, :edit] do %>
+  <.modal return_to={Routes.ammo_type_index_path(Endpoint, :index)}>
+    <.live_component
+      module={CanneryWeb.AmmoTypeLive.FormComponent}
+      id={@ammo_type.id || :new}
+      title={@page_title}
+      action={@live_action}
+      ammo_type={@ammo_type}
+      return_to={Routes.ammo_type_index_path(Endpoint, :index)}
+      current_user={@current_user}
+      }
+    />
+  </.modal>
+<% end %>

lib/cannery_web/live/ammo_type_live/show.ex

@@ -4,16 +4,27 @@ defmodule CanneryWeb.AmmoTypeLive.Show do
   """
 
   use CanneryWeb, :live_view
-  alias Cannery.{ActivityLog, Ammo, Ammo.AmmoType, Containers}
+  import CanneryWeb.Components.AmmoGroupCard
+  alias Cannery.Ammo
   alias CanneryWeb.Endpoint
 
   @impl true
-  def mount(_params, _session, socket),
-    do: {:ok, socket |> assign(show_used: false, view_table: true)}
+  def mount(_params, _session, socket), do: {:ok, socket}
 
   @impl true
-  def handle_params(%{"id" => id}, _params, socket) do
-    {:noreply, socket |> display_ammo_type(id)}
+  def handle_params(%{"id" => id}, _params, %{assigns: %{current_user: current_user}} = socket) do
+    ammo_type = Ammo.get_ammo_type!(id, current_user)
+
+    socket =
+      socket
+      |> assign(
+        page_title: page_title(socket.assigns.live_action),
+        ammo_type: ammo_type,
+        ammo_groups: ammo_type |> Ammo.list_ammo_groups_for_type(current_user),
+        avg_cost_per_round: ammo_type |> Ammo.get_average_cost_for_ammo_type!(current_user)
+      )
+
+    {:noreply, socket}
   end
 
   @impl true
@@ -27,137 +38,9 @@ defmodule CanneryWeb.AmmoTypeLive.Show do
     prompt = dgettext("prompts", "%{name} deleted succesfully", name: ammo_type_name)
     redirect_to = Routes.ammo_type_index_path(socket, :index)
 
-    {:noreply, socket |> put_flash(:info, prompt) |> push_navigate(to: redirect_to)}
+    {:noreply, socket |> put_flash(:info, prompt) |> push_redirect(to: redirect_to)}
   end
 
-  def handle_event("toggle_show_used", _params, %{assigns: %{show_used: show_used}} = socket) do
-    {:noreply, socket |> assign(:show_used, !show_used) |> display_ammo_type()}
-  end
-
-  def handle_event("toggle_table", _params, %{assigns: %{view_table: view_table}} = socket) do
-    {:noreply, socket |> assign(:view_table, !view_table)}
-  end
-
-  defp display_ammo_type(
-         %{assigns: %{live_action: live_action, current_user: current_user, show_used: show_used}} =
-           socket,
-         %AmmoType{name: ammo_type_name} = ammo_type
-       ) do
-    custom_fields? =
-      fields_to_display(ammo_type)
-      |> Enum.any?(fn %{key: field, type: type} ->
-        default_value =
-          case type do
-            :boolean -> false
-            _other_type -> nil
-          end
-
-        ammo_type |> Map.get(field) != default_value
-      end)
-
-    ammo_groups = ammo_type |> Ammo.list_ammo_groups_for_type(current_user, show_used)
-
-    [
-      original_counts,
-      used_packs_count,
-      historical_packs_count,
-      used_rounds,
-      historical_round_count
-    ] =
-      if show_used do
-        [
-          ammo_groups |> Ammo.get_original_counts(current_user),
-          ammo_type |> Ammo.get_used_ammo_groups_count_for_type(current_user),
-          ammo_type |> Ammo.get_ammo_groups_count_for_type(current_user, true),
-          ammo_type |> ActivityLog.get_used_count_for_ammo_type(current_user),
-          ammo_type |> Ammo.get_historical_count_for_ammo_type(current_user)
-        ]
-      else
-        [nil, nil, nil, nil, nil]
-      end
-
-    page_title =
-      case live_action do
-        :show -> ammo_type_name
-        :edit -> gettext("Edit %{ammo_type_name}", ammo_type_name: ammo_type_name)
-      end
-
-    containers =
-      ammo_groups
-      |> Enum.map(fn %{container_id: container_id} -> container_id end)
-      |> Containers.get_containers(current_user)
-
-    socket
-    |> assign(
-      page_title: page_title,
-      ammo_type: ammo_type,
-      ammo_groups: ammo_groups,
-      containers: containers,
-      cprs: ammo_groups |> Ammo.get_cprs(current_user),
-      last_used_dates: ammo_groups |> ActivityLog.get_last_used_dates(current_user),
-      avg_cost_per_round: ammo_type |> Ammo.get_average_cost_for_ammo_type(current_user),
-      rounds: ammo_type |> Ammo.get_round_count_for_ammo_type(current_user),
-      original_counts: original_counts,
-      used_rounds: used_rounds,
-      historical_round_count: historical_round_count,
-      packs_count: ammo_type |> Ammo.get_ammo_groups_count_for_type(current_user),
-      used_packs_count: used_packs_count,
-      historical_packs_count: historical_packs_count,
-      fields_to_display: fields_to_display(ammo_type),
-      custom_fields?: custom_fields?
-    )
-  end
-
-  defp display_ammo_type(%{assigns: %{current_user: current_user}} = socket, ammo_type_id) do
-    socket |> display_ammo_type(Ammo.get_ammo_type!(ammo_type_id, current_user))
-  end
-
-  defp display_ammo_type(%{assigns: %{ammo_type: ammo_type}} = socket) do
-    socket |> display_ammo_type(ammo_type)
-  end
-
-  defp fields_to_display(%AmmoType{type: type}) do
-    [
-      %{label: gettext("Cartridge:"), key: :cartridge, type: :string},
-      %{
-        label: if(type == :shotgun, do: gettext("Gauge:"), else: gettext("Caliber:")),
-        key: :caliber,
-        type: :string
-      },
-      %{label: gettext("Unfired length:"), key: :unfired_length, type: :string},
-      %{label: gettext("Brass height:"), key: :brass_height, type: :string},
-      %{label: gettext("Chamber size:"), key: :chamber_size, type: :string},
-      %{label: gettext("Grains:"), key: :grains, type: :string},
-      %{label: gettext("Bullet type:"), key: :bullet_type, type: :string},
-      %{label: gettext("Bullet core:"), key: :bullet_core, type: :string},
-      %{label: gettext("Jacket type:"), key: :jacket_type, type: :string},
-      %{label: gettext("Case material:"), key: :case_material, type: :string},
-      %{label: gettext("Wadding:"), key: :wadding, type: :string},
-      %{label: gettext("Shot type:"), key: :shot_type, type: :string},
-      %{label: gettext("Shot material:"), key: :shot_material, type: :string},
-      %{label: gettext("Shot size:"), key: :shot_size, type: :string},
-      %{label: gettext("Load grains:"), key: :load_grains, type: :string},
-      %{label: gettext("Shot charge weight:"), key: :shot_charge_weight, type: :string},
-      %{label: gettext("Powder type:"), key: :powder_type, type: :string},
-      %{
-        label: gettext("Powder grains per charge:"),
-        key: :powder_grains_per_charge,
-        type: :string
-      },
-      %{label: gettext("Pressure:"), key: :pressure, type: :string},
-      %{label: gettext("Dram equivalent:"), key: :dram_equivalent, type: :string},
-      %{label: gettext("Muzzle velocity:"), key: :muzzle_velocity, type: :string},
-      %{label: gettext("Primer type:"), key: :primer_type, type: :string},
-      %{label: gettext("Firing type:"), key: :firing_type, type: :string},
-      %{label: gettext("Tracer:"), key: :tracer, type: :boolean},
-      %{label: gettext("Incendiary:"), key: :incendiary, type: :boolean},
-      %{label: gettext("Blank:"), key: :blank, type: :boolean},
-      %{label: gettext("Corrosive:"), key: :corrosive, type: :boolean},
-      %{label: gettext("Manufacturer:"), key: :manufacturer, type: :string},
-      %{label: gettext("UPC:"), key: :upc, type: :string}
-    ]
-  end
-
-  @spec display_currency(float()) :: String.t()
-  defp display_currency(float), do: :erlang.float_to_binary(float, decimals: 2)
+  defp page_title(:show), do: gettext("Show Ammo type")
+  defp page_title(:edit), do: gettext("Edit Ammo type")
 end

lib/cannery_web/live/ammo_type_live/show.html.heex

@@ -1,155 +1,109 @@
-<div class="space-y-4 flex flex-col justify-center items-center">
+<div class="mx-auto px-4 sm:px-8 space-y-4 max-w-3xl
+  flex flex-col justify-center items-center">
   <h1 class="title text-2xl title-primary-500">
     <%= @ammo_type.name %>
   </h1>
 
-  <span
-    :if={@ammo_type.desc}
-    class="max-w-2xl w-full px-8 py-4 rounded-lg
+  <%= if @ammo_type.desc do %>
+    <span class="max-w-2xl w-full px-8 py-4 rounded-lg
       text-center title text-lg
-      border border-primary-600"
-  >
-    <%= @ammo_type.desc %>
-  </span>
+      border border-primary-600">
+      <%= @ammo_type.desc %>
+    </span>
+  <% end %>
 
   <div class="flex space-x-4 justify-center items-center text-primary-600">
-    <.link
-      patch={Routes.ammo_type_show_path(Endpoint, :edit, @ammo_type)}
-      class="text-primary-600 link"
-      aria-label={dgettext("actions", "Edit %{ammo_type_name}", ammo_type_name: @ammo_type.name)}
-    >
+    <%= live_patch to: Routes.ammo_type_show_path(Endpoint, :edit, @ammo_type),
+               class: "text-primary-600 link",
+               data: [qa: "edit"] do %>
       <i class="fa-fw fa-lg fas fa-edit"></i>
-    </.link>
+    <% end %>
 
-    <.link
-      href="#"
-      class="text-primary-600 link"
-      phx-click="delete"
-      data-confirm={
-        dgettext(
-          "prompts",
-          "Are you sure you want to delete %{name}? This will delete all %{name} type ammo as well!",
-          name: @ammo_type.name
-        )
-      }
-      aria-label={
-        dgettext("actions", "Delete %{ammo_type_name}", ammo_type_name: @ammo_type.name)
-      }
-    >
+    <%= link to: "#",
+         class: "text-primary-600 link",
+         phx_click: "delete",
+         data: [
+           confirm:
+             dgettext("prompts", "Are you sure you want to delete %{name}?", name: @ammo_type.name),
+           qa: "delete"
+         ] do %>
       <i class="fa-fw fa-lg fas fa-trash"></i>
-    </.link>
+    <% end %>
   </div>
 
   <hr class="hr" />
 
-  <%= if @ammo_type.type || @custom_fields? do %>
-    <div class="grid sm:grid-cols-2 gap-4 text-center justify-center items-center">
-      <h3 class="title text-lg">
-        <%= gettext("Type") %>
-      </h3>
-
-      <span class="text-primary-600">
-        <%= case @ammo_type.type do %>
-          <% :shotgun -> %>
-            <%= gettext("Shotgun") %>
-          <% :rifle -> %>
-            <%= gettext("Rifle") %>
-          <% :pistol -> %>
-            <%= gettext("Pistol") %>
-          <% _ -> %>
-            <%= gettext("None specified") %>
-        <% end %>
-      </span>
-
-      <%= for %{label: label, key: key, type: type} <- @fields_to_display do %>
-        <%= if @ammo_type |> Map.get(key) do %>
-          <h3 class="title text-lg">
-            <%= label %>
-          </h3>
-
-          <span class="text-primary-600">
-            <%= case type do %>
-              <% :boolean -> %>
-                <%= @ammo_type |> Map.get(key) |> humanize() %>
-              <% _ -> %>
-                <%= @ammo_type |> Map.get(key) %>
-            <% end %>
-          </span>
-        <% end %>
-      <% end %>
-    </div>
-
-    <hr class="hr" />
-  <% end %>
-
   <div class="grid sm:grid-cols-2 gap-4 text-center justify-center items-center">
-    <h3 class="title text-lg">
-      <%= gettext("Rounds:") %>
-    </h3>
+    <%= for {field_name, field, type} <- [
+          {gettext("Bullet type"), :bullet_type, :string},
+          {gettext("Bullet core"), :bullet_core, :string},
+          {gettext("Cartridge"), :cartridge, :string},
+          {gettext("Caliber"), :caliber, :string},
+          {gettext("Case material"), :case_material, :string},
+          {gettext("Jacket type"), :jacket_type, :string},
+          {gettext("Muzzle velocity"), :muzzle_velocity, :string},
+          {gettext("Powder type"), :powder_type, :string},
+          {gettext("Powder grains per charge"), :powder_grains_per_charge, :string},
+          {gettext("Grains"), :grains, :string},
+          {gettext("Pressure"), :pressure, :string},
+          {gettext("Primer type"), :primer_type, :string},
+          {gettext("Firing type"), :firing_type, :string},
+          {gettext("Tracer"), :tracer, :boolean},
+          {gettext("Incendiary"), :incendiary, :boolean},
+          {gettext("Blank"), :blank, :boolean},
+          {gettext("Corrosive"), :corrosive, :boolean},
+          {gettext("Manufacturer"), :manufacturer, :string},
+          {gettext("UPC"), :upc, :string}
+        ] do %>
+      <%= if @ammo_type |> Map.get(field) do %>
+        <h3 class="title text-lg">
+          <%= field_name %>:
+        </h3>
 
-    <span class="text-primary-600">
-      <%= @rounds %>
-    </span>
-
-    <%= if @show_used do %>
-      <h3 class="title text-lg">
-        <%= gettext("Used rounds:") %>
-      </h3>
-
-      <span class="text-primary-600">
-        <%= @used_rounds %>
-      </span>
-
-      <h3 class="title text-lg">
-        <%= gettext("Total ever rounds:") %>
-      </h3>
-
-      <span class="text-primary-600">
-        <%= @historical_round_count %>
-      </span>
+        <span class="text-primary-600">
+          <%= case type do %>
+            <% :boolean -> %>
+              <%= @ammo_type |> Map.get(field) |> humanize() %>
+            <% _ -> %>
+              <%= @ammo_type |> Map.get(field) %>
+          <% end %>
+        </span>
+      <% end %>
     <% end %>
 
     <h3 class="title text-lg">
-      <%= gettext("Packs:") %>
+      <%= gettext("Current # of rounds:") %>
     </h3>
 
     <span class="text-primary-600">
-      <%= @packs_count %>
+      <%= @ammo_type |> Ammo.get_round_count_for_ammo_type(@current_user) %>
     </span>
 
-    <%= if @show_used do %>
-      <h3 class="title text-lg">
-        <%= gettext("Used packs:") %>
-      </h3>
+    <h3 class="title text-lg">
+      <%= gettext("Total rounds shot:") %>
+    </h3>
 
-      <span class="text-primary-600">
-        <%= @used_packs_count %>
-      </span>
-
-      <h3 class="title text-lg">
-        <%= gettext("Total ever packs:") %>
-      </h3>
-
-      <span class="text-primary-600">
-        <%= @historical_packs_count %>
-      </span>
-    <% end %>
+    <span class="text-primary-600">
+      <%= @ammo_type |> Ammo.get_used_count_for_ammo_type(@current_user) %>
+    </span>
 
     <h3 class="title text-lg">
       <%= gettext("Added on:") %>
     </h3>
 
     <span class="text-primary-600">
-      <.datetime id={"#{@ammo_type.id}-inserted-at"} datetime={@ammo_type.inserted_at} />
+      <%= @ammo_type.inserted_at |> display_datetime() %>
     </span>
 
     <%= if @avg_cost_per_round do %>
       <h3 class="title text-lg">
-        <%= gettext("Average CPR") %>:
+        <%= gettext("Average Price paid") %>:
       </h3>
 
       <span class="text-primary-600">
-        <%= gettext("$%{amount}", amount: display_currency(@avg_cost_per_round)) %>
+        <%= gettext("$%{amount}",
+          amount: @avg_cost_per_round |> :erlang.float_to_binary(decimals: 2)
+        ) %>
       </span>
     <% else %>
       <h3 class="mx-8 my-4 title text-lg text-primary-600 col-span-2">
@@ -160,87 +114,32 @@
 
   <hr class="hr" />
 
-  <div class="flex justify-center items-center space-x-4">
-    <.toggle_button action="toggle_show_used" value={@show_used}>
-      <span class="title text-lg text-primary-600">
-        <%= gettext("Show used") %>
-      </span>
-    </.toggle_button>
-
-    <.toggle_button action="toggle_table" value={@view_table}>
-      <span class="title text-lg text-primary-600">
-        <%= gettext("View as table") %>
-      </span>
-    </.toggle_button>
-  </div>
-
-  <div class="w-full p-4">
+  <div>
     <%= if @ammo_groups |> Enum.empty?() do %>
-      <h2 class="px-4 title text-lg text-primary-600">
+      <h2 class="mx-8 my-4 title text-lg text-primary-600">
         <%= gettext("No ammo for this type") %>
         <%= display_emoji("😔") %>
       </h2>
     <% else %>
-      <%= if @view_table do %>
-        <.live_component
-          module={CanneryWeb.Components.AmmoGroupTableComponent}
-          id="ammo-type-show-table"
-          ammo_groups={@ammo_groups}
-          current_user={@current_user}
-          show_used={@show_used}
-        >
-          <:container :let={{_ammo_group, %{name: container_name} = container}}>
-            <.link
-              navigate={Routes.container_show_path(Endpoint, :show, container)}
-              class="mx-2 my-1 link"
-            >
-              <%= container_name %>
-            </.link>
-          </:container>
-          <:actions :let={%{count: ammo_group_count} = ammo_group}>
-            <div class="py-2 px-4 h-full space-x-4 flex justify-center items-center">
-              <.link
-                navigate={Routes.ammo_group_show_path(Endpoint, :show, ammo_group)}
-                class="text-primary-600 link"
-                aria-label={
-                  dgettext("actions", "View ammo group of %{ammo_group_count} bullets",
-                    ammo_group_count: ammo_group_count
-                  )
-                }
-              >
-                <i class="fa-fw fa-lg fas fa-eye"></i>
-              </.link>
-            </div>
-          </:actions>
-        </.live_component>
-      <% else %>
-        <div class="flex flex-wrap justify-center items-stretch">
-          <.ammo_group_card
-            :for={%{id: ammo_group_id, container_id: container_id} = ammo_group <- @ammo_groups}
-            ammo_group={ammo_group}
-            original_count={@original_counts && Map.fetch!(@original_counts, ammo_group_id)}
-            cpr={Map.get(@cprs, ammo_group_id)}
-            last_used_date={Map.get(@last_used_dates, ammo_group_id)}
-            current_user={@current_user}
-            container={Map.fetch!(@containers, container_id)}
-          />
-        </div>
-      <% end %>
+      <div class="flex flex-wrap justify-center items-center">
+        <%= for ammo_group <- @ammo_groups do %>
+          <.ammo_group_card ammo_group={ammo_group} />
+        <% end %>
+      </div>
     <% end %>
   </div>
 </div>
 
-<.modal
-  :if={@live_action == :edit}
-  return_to={Routes.ammo_type_show_path(Endpoint, :show, @ammo_type)}
->
-  <.live_component
-    module={CanneryWeb.AmmoTypeLive.FormComponent}
-    id={@ammo_type.id}
-    title={@page_title}
-    action={@live_action}
-    ammo_type={@ammo_type}
-    return_to={Routes.ammo_type_show_path(Endpoint, :show, @ammo_type)}
-    current_user={@current_user}
-  />
-</.modal>
+<%= if @live_action in [:edit] do %>
+  <.modal return_to={Routes.ammo_type_show_path(Endpoint, :show, @ammo_type)}>
+    <.live_component
+      module={CanneryWeb.AmmoTypeLive.FormComponent}
+      id={@ammo_type.id}
+      title={@page_title}
+      action={@live_action}
+      ammo_type={@ammo_type}
+      return_to={Routes.ammo_type_show_path(Endpoint, :show, @ammo_type)}
+      current_user={@current_user}
+    />
+  </.modal>
+<% end %>

lib/cannery_web/live/container_live/edit_tags_component.ex

@@ -4,41 +4,25 @@ defmodule CanneryWeb.ContainerLive.EditTagsComponent do
   """
 
   use CanneryWeb, :live_component
-  alias Cannery.{Accounts.User, Containers}
-  alias Cannery.Containers.{Container, Tag}
+  alias Cannery.{Accounts.User, Containers, Containers.Container, Repo, Tags, Tags.Tag}
   alias Phoenix.LiveView.Socket
 
   @impl true
   @spec update(
-          %{
-            :container => Container.t(),
-            :current_path => String.t(),
-            :current_user => User.t(),
-            optional(any) => any
-          },
+          %{:container => Container.t(), :current_user => User.t(), optional(any) => any},
           Socket.t()
         ) :: {:ok, Socket.t()}
-  def update(
-        %{container: _container, current_path: _current_path, current_user: current_user} =
-          assigns,
-        socket
-      ) do
-    tags = Containers.list_tags(current_user)
-    {:ok, socket |> assign(assigns) |> assign(:tags, tags)}
+  def update(%{container: container, current_user: current_user} = assigns, socket) do
+    tags = Tags.list_tags(current_user)
+    container = container |> Repo.preload(:tags)
+    {:ok, socket |> assign(assigns) |> assign(tags: tags, container: container)}
   end
 
   @impl true
   def handle_event(
         "save",
         %{"tag" => %{"tag_id" => tag_id}},
-        %{
-          assigns: %{
-            tags: tags,
-            container: container,
-            current_user: current_user,
-            current_path: current_path
-          }
-        } = socket
+        %{assigns: %{tags: tags, container: container, current_user: current_user}} = socket
       ) do
     socket =
       case tags |> Enum.find(fn %{id: id} -> tag_id == id end) do
@@ -48,24 +32,19 @@ defmodule CanneryWeb.ContainerLive.EditTagsComponent do
 
         %{name: tag_name} = tag ->
           _container_tag = Containers.add_tag!(container, tag, current_user)
+          container = container |> Repo.preload(:tags, force: true)
           prompt = dgettext("prompts", "%{name} added successfully", name: tag_name)
-          socket |> put_flash(:info, prompt) |> push_patch(to: current_path)
+          socket |> put_flash(:info, prompt) |> assign(container: container)
       end
 
     {:noreply, socket}
   end
 
+  @impl true
   def handle_event(
         "delete",
         %{"tag-id" => tag_id},
-        %{
-          assigns: %{
-            tags: tags,
-            container: container,
-            current_user: current_user,
-            current_path: current_path
-          }
-        } = socket
+        %{assigns: %{tags: tags, container: container, current_user: current_user}} = socket
       ) do
     socket =
       case tags |> Enum.find(fn %{id: id} -> tag_id == id end) do
@@ -75,8 +54,9 @@ defmodule CanneryWeb.ContainerLive.EditTagsComponent do
 
         %{name: tag_name} = tag ->
           _container_tag = Containers.remove_tag!(container, tag, current_user)
+          container = container |> Repo.preload(:tags, force: true)
           prompt = dgettext("prompts", "%{name} removed successfully", name: tag_name)
-          socket |> put_flash(:info, prompt) |> push_patch(to: current_path)
+          socket |> put_flash(:info, prompt) |> assign(container: container)
       end
 
     {:noreply, socket}

lib/cannery_web/live/container_live/edit_tags_component.html.heex

@@ -4,40 +4,41 @@
   </h2>
 
   <div class="flex flex-wrap justify-center items-center">
-    <.link
-      :for={tag <- @container.tags}
-      href="#"
-      class="mx-2 my-1 px-4 py-2 rounded-lg title text-xl"
-      style={"color: #{tag.text_color}; background-color: #{tag.bg_color}"}
-      phx-click="delete"
-      phx-value-tag-id={tag.id}
-      phx-target={@myself}
-      data-confirm={
-        dgettext(
-          "prompts",
-          "Are you sure you want to remove the %{tag_name} tag from %{container_name}?",
-          tag_name: tag.name,
-          container_name: @container.name
-        )
-      }
-    >
-      <%= tag.name %>
-      <i class="fa-fw fa-sm fas fa-trash"></i>
-    </.link>
+    <%= for tag <- @container.tags do %>
+      <%= link to: "#",
+            class: "mx-2 my-1 px-4 py-2 rounded-lg title text-xl",
+            style: "color: #{tag.text_color}; background-color: #{tag.bg_color}",
+            phx_click: "delete",
+            phx_value_tag_id: tag.id,
+            phx_target: @myself,
+            data: [
+              confirm:
+                dgettext(
+                  "prompts",
+                  "Are you sure you want to remove the %{tag_name} tag from %{container_name}?",
+                  tag_name: tag.name,
+                  container_name: @container.name
+                )
+            ] do %>
+        <%= tag.name %>
+        <i class="fa-fw fa-sm fas fa-trash"></i>
+      <% end %>
+    <% end %>
 
-    <h2 :if={@container.tags |> Enum.empty?()} class="title text-xl text-primary-600">
-      <%= gettext("No tags") %>
-      <%= display_emoji("😔") %>
-    </h2>
+    <%= if @container.tags |> Enum.empty?() do %>
+      <h2 class="title text-xl text-primary-600">
+        <%= gettext("No tags") %>
+        <%= display_emoji("😔") %>
+      </h2>
+    <% end %>
   </div>
 
   <%= unless tag_options(@tags, @container) |> Enum.empty?() do %>
     <hr class="hr" />
 
     <.form
-      :let={f}
-      for={%{}}
-      as={:tag}
+      let={f}
+      for={:tag}
       id="add-tag-to-container-form"
       class="flex flex-col space-y-4 sm:space-y-0 sm:grid sm:grid-cols-3 sm:gap-4 justify-center items-center"
       phx-target={@myself}

lib/cannery_web/live/container_live/form_component.ex

@@ -13,13 +13,18 @@ defmodule CanneryWeb.ContainerLive.FormComponent do
           %{:container => Container.t(), :current_user => User.t(), optional(any) => any},
           Socket.t()
         ) :: {:ok, Socket.t()}
-  def update(%{container: _container} = assigns, socket) do
-    {:ok, socket |> assign(assigns) |> assign_changeset(%{})}
+  def update(%{container: container} = assigns, socket) do
+    {:ok, socket |> assign(assigns) |> assign(:changeset, Containers.change_container(container))}
   end
 
   @impl true
-  def handle_event("validate", %{"container" => container_params}, socket) do
-    {:noreply, socket |> assign_changeset(container_params)}
+  def handle_event(
+        "validate",
+        %{"container" => container_params},
+        %{assigns: %{container: container}} = socket
+      ) do
+    changeset = container |> Containers.change_container(container_params)
+    {:noreply, socket |> assign(:changeset, changeset)}
   end
 
   def handle_event(
@@ -30,34 +35,6 @@ defmodule CanneryWeb.ContainerLive.FormComponent do
     save_container(socket, action, container_params)
   end
 
-  defp assign_changeset(
-         %{assigns: %{action: action, container: container, current_user: user}} = socket,
-         container_params
-       ) do
-    changeset_action =
-      case action do
-        create when create in [:new, :clone] -> :insert
-        :edit -> :update
-      end
-
-    changeset =
-      case action do
-        create when create in [:new, :clone] ->
-          container |> Container.create_changeset(user, container_params)
-
-        :edit ->
-          container |> Container.update_changeset(container_params)
-      end
-
-    changeset =
-      case changeset |> Changeset.apply_action(changeset_action) do
-        {:ok, _data} -> changeset
-        {:error, changeset} -> changeset
-      end
-
-    socket |> assign(:changeset, changeset)
-  end
-
   defp save_container(
          %{assigns: %{container: container, current_user: current_user, return_to: return_to}} =
            socket,
@@ -68,7 +45,7 @@ defmodule CanneryWeb.ContainerLive.FormComponent do
       case Containers.update_container(container, current_user, container_params) do
         {:ok, %{name: container_name}} ->
           prompt = dgettext("prompts", "%{name} updated successfully", name: container_name)
-          socket |> put_flash(:info, prompt) |> push_navigate(to: return_to)
+          socket |> put_flash(:info, prompt) |> push_redirect(to: return_to)
 
         {:error, %Changeset{} = changeset} ->
           socket |> assign(:changeset, changeset)
@@ -79,15 +56,14 @@ defmodule CanneryWeb.ContainerLive.FormComponent do
 
   defp save_container(
          %{assigns: %{current_user: current_user, return_to: return_to}} = socket,
-         action,
+         :new,
          container_params
-       )
-       when action in [:new, :clone] do
+       ) do
     socket =
       case Containers.create_container(container_params, current_user) do
         {:ok, %{name: container_name}} ->
           prompt = dgettext("prompts", "%{name} created successfully", name: container_name)
-          socket |> put_flash(:info, prompt) |> push_navigate(to: return_to)
+          socket |> put_flash(:info, prompt) |> push_redirect(to: return_to)
 
         {:error, %Changeset{} = changeset} ->
           socket |> assign(changeset: changeset)

lib/cannery_web/live/container_live/form_component.html.heex

@@ -3,7 +3,7 @@
     <%= @title %>
   </h2>
   <.form
-    :let={f}
+    let={f}
     for={@changeset}
     id="container-form"
     class="flex flex-col space-y-4 sm:space-y-0 sm:grid sm:grid-cols-3 sm:gap-4 justify-center items-center"
@@ -11,46 +11,39 @@
     phx-change="validate"
     phx-submit="save"
   >
-    <div
-      :if={@changeset.action && not @changeset.valid?()}
-      class="invalid-feedback col-span-3 text-center"
-    >
-      <%= changeset_errors(@changeset) %>
-    </div>
+    <%= if @changeset.action && not @changeset.valid? do %>
+      <div class="invalid-feedback col-span-3 text-center">
+        <%= changeset_errors(@changeset) %>
+      </div>
+    <% end %>
 
     <%= label(f, :name, gettext("Name"), class: "title text-lg text-primary-600") %>
     <%= text_input(f, :name,
       class: "input input-primary col-span-2",
-      placeholder: gettext("My cool ammo can"),
-      maxlength: 255
+      placeholder: gettext("My cool ammo can")
     ) %>
     <%= error_tag(f, :name, "col-span-3 text-center") %>
 
     <%= label(f, :desc, gettext("Description"), class: "title text-lg text-primary-600") %>
     <%= textarea(f, :desc,
-      id: "container-form-desc",
       class: "input input-primary col-span-2",
-      placeholder: gettext("Metal ammo can with the anime girl sticker"),
       phx_hook: "MaintainAttrs",
-      phx_update: "ignore"
+      placeholder: gettext("Metal ammo can with the anime girl sticker")
     ) %>
     <%= error_tag(f, :desc, "col-span-3 text-center") %>
 
     <%= label(f, :type, gettext("Type"), class: "title text-lg text-primary-600") %>
     <%= text_input(f, :type,
       class: "input input-primary col-span-2",
-      placeholder: gettext("Magazine, Clip, Ammo Box, etc"),
-      maxlength: 255
+      placeholder: gettext("Magazine, Clip, Ammo Box, etc")
     ) %>
     <%= error_tag(f, :type, "col-span-3 text-center") %>
 
     <%= label(f, :location, gettext("Location"), class: "title text-lg text-primary-600") %>
     <%= textarea(f, :location,
-      id: "container-form-location",
       class: "input input-primary col-span-2",
-      placeholder: gettext("On the bookshelf"),
       phx_hook: "MaintainAttrs",
-      phx_update: "ignore"
+      placeholder: gettext("On the bookshelf")
     ) %>
     <%= error_tag(f, :location, "col-span-3 text-center") %>
 

lib/cannery_web/live/container_live/index.ex

@@ -4,17 +4,13 @@ defmodule CanneryWeb.ContainerLive.Index do
   """
 
   use CanneryWeb, :live_view
-  alias Cannery.{Containers, Containers.Container}
+  import CanneryWeb.Components.ContainerCard
+  alias Cannery.{Containers, Containers.Container, Repo}
+  alias CanneryWeb.Endpoint
   alias Ecto.Changeset
 
   @impl true
-  def mount(%{"search" => search}, _session, socket) do
-    {:ok, socket |> assign(view_table: true, search: search) |> display_containers()}
-  end
-
-  def mount(_params, _session, socket) do
-    {:ok, socket |> assign(view_table: true, search: nil) |> display_containers()}
-  end
+  def mount(_params, _session, socket), do: {:ok, socket}
 
   @impl true
   def handle_params(params, _url, %{assigns: %{live_action: live_action}} = socket) do
@@ -22,7 +18,10 @@ defmodule CanneryWeb.ContainerLive.Index do
   end
 
   defp apply_action(%{assigns: %{current_user: current_user}} = socket, :edit, %{"id" => id}) do
-    %{name: container_name} = container = Containers.get_container!(id, current_user)
+    %{name: container_name} =
+      container =
+      Containers.get_container!(id, current_user)
+      |> Repo.preload([:tags, :ammo_groups], force: true)
 
     socket
     |> assign(page_title: gettext("Edit %{name}", name: container_name), container: container)
@@ -32,33 +31,17 @@ defmodule CanneryWeb.ContainerLive.Index do
     socket |> assign(:page_title, gettext("New Container")) |> assign(:container, %Container{})
   end
 
-  defp apply_action(%{assigns: %{current_user: current_user}} = socket, :clone, %{"id" => id}) do
-    container = Containers.get_container!(id, current_user)
-
-    socket
-    |> assign(page_title: gettext("New Container"), container: %{container | id: nil})
-  end
-
   defp apply_action(socket, :index, _params) do
     socket
-    |> assign(
-      page_title: gettext("Containers"),
-      container: nil,
-      search: nil
-    )
-  end
-
-  defp apply_action(socket, :search, %{"search" => search}) do
-    socket
-    |> assign(
-      page_title: gettext("Containers"),
-      container: nil,
-      search: search
-    )
+    |> assign(:page_title, gettext("Containers"))
+    |> assign(:container, nil)
+    |> display_containers()
   end
 
   defp apply_action(%{assigns: %{current_user: current_user}} = socket, :edit_tags, %{"id" => id}) do
-    %{name: container_name} = container = Containers.get_container!(id, current_user)
+    %{name: container_name} =
+      container =
+      Containers.get_container!(id, current_user) |> Repo.preload([:tags, :ammo_groups])
 
     page_title = gettext("Edit %{name} tags", name: container_name)
     socket |> assign(page_title: page_title, container: container)
@@ -100,20 +83,10 @@ defmodule CanneryWeb.ContainerLive.Index do
     {:noreply, socket}
   end
 
-  def handle_event("toggle_table", _params, %{assigns: %{view_table: view_table}} = socket) do
-    {:noreply, socket |> assign(:view_table, !view_table) |> display_containers()}
-  end
+  defp display_containers(%{assigns: %{current_user: current_user}} = socket) do
+    containers =
+      Containers.list_containers(current_user) |> Repo.preload([:tags, :ammo_groups], force: true)
 
-  def handle_event("search", %{"search" => %{"search_term" => ""}}, socket) do
-    {:noreply, socket |> push_patch(to: Routes.container_index_path(Endpoint, :index))}
-  end
-
-  def handle_event("search", %{"search" => %{"search_term" => search_term}}, socket) do
-    {:noreply,
-     socket |> push_patch(to: Routes.container_index_path(Endpoint, :search, search_term))}
-  end
-
-  defp display_containers(%{assigns: %{search: search, current_user: current_user}} = socket) do
-    socket |> assign(:containers, Containers.list_containers(search, current_user))
+    socket |> assign(containers: containers)
   end
 end

lib/cannery_web/live/container_live/index.html.heex

@@ -3,198 +3,79 @@
     <%= gettext("Containers") %>
   </h1>
 
-  <%= if @containers |> Enum.empty?() and @search |> is_nil() do %>
+  <%= if @containers |> Enum.empty?() do %>
     <h2 class="title text-xl text-primary-600">
       <%= gettext("No containers") %>
       <%= display_emoji("😔") %>
     </h2>
 
-    <.link patch={Routes.container_index_path(Endpoint, :new)} class="btn btn-primary">
-      <%= dgettext("actions", "Add your first container!") %>
-    </.link>
+    <%= live_patch(dgettext("actions", "Add your first container!"),
+      to: Routes.container_index_path(Endpoint, :new),
+      class: "btn btn-primary"
+    ) %>
   <% else %>
-    <.link patch={Routes.container_index_path(Endpoint, :new)} class="btn btn-primary">
-      <%= dgettext("actions", "New Container") %>
-    </.link>
-
-    <div class="w-full flex flex-col sm:flex-row justify-center items-center space-y-4 sm:space-y-0 sm:space-x-4 max-w-2xl">
-      <.form
-        :let={f}
-        for={%{}}
-        as={:search}
-        phx-change="search"
-        phx-submit="search"
-        class="grow flex items-center"
-      >
-        <%= text_input(f, :search_term,
-          class: "grow input input-primary",
-          value: @search,
-          role: "search",
-          phx_debounce: 300,
-          placeholder: gettext("Search containers")
-        ) %>
-      </.form>
-
-      <.toggle_button action="toggle_table" value={@view_table}>
-        <span class="title text-lg text-primary-600">
-          <%= gettext("View as table") %>
-        </span>
-      </.toggle_button>
-    </div>
-
-    <%= if @containers |> Enum.empty?() do %>
-      <h2 class="title text-xl text-primary-600">
-        <%= gettext("No containers") %>
-        <%= display_emoji("😔") %>
-      </h2>
-    <% else %>
-      <%= if @view_table do %>
-        <.live_component
-          module={CanneryWeb.Components.ContainerTableComponent}
-          id="containers_index_table"
-          action={@live_action}
-          containers={@containers}
-          current_user={@current_user}
-        >
-          <:tag_actions :let={container}>
-            <div class="mx-4 my-2">
-              <.link
-                patch={Routes.container_index_path(Endpoint, :edit_tags, container)}
-                class="text-primary-600 link"
-                aria-label={
-                  dgettext("actions", "Tag %{container_name}", container_name: container.name)
-                }
-              >
-                <i class="fa-fw fa-lg fas fa-tags"></i>
-              </.link>
-            </div>
-          </:tag_actions>
-          <:actions :let={container}>
-            <.link
-              patch={Routes.container_index_path(Endpoint, :edit, container)}
-              class="text-primary-600 link"
-              aria-label={
-                dgettext("actions", "Edit %{container_name}", container_name: container.name)
-              }
-            >
-              <i class="fa-fw fa-lg fas fa-edit"></i>
-            </.link>
-
-            <.link
-              patch={Routes.container_index_path(Endpoint, :clone, container)}
-              class="text-primary-600 link"
-              aria-label={
-                dgettext("actions", "Clone %{container_name}", container_name: container.name)
-              }
-            >
-              <i class="fa-fw fa-lg fas fa-copy"></i>
-            </.link>
-
-            <.link
-              href="#"
-              class="text-primary-600 link"
-              phx-click="delete"
-              phx-value-id={container.id}
-              data-confirm={
-                dgettext("prompts", "Are you sure you want to delete %{name}?",
-                  name: container.name
-                )
-              }
-              aria-label={
-                dgettext("actions", "Delete %{container_name}", container_name: container.name)
-              }
-            >
-              <i class="fa-fw fa-lg fas fa-trash"></i>
-            </.link>
-          </:actions>
-        </.live_component>
-      <% else %>
-        <div class="w-full flex flex-row flex-wrap justify-center items-stretch">
-          <.container_card
-            :for={container <- @containers}
-            container={container}
-            current_user={@current_user}
-          >
-            <:tag_actions>
-              <div class="mx-4 my-2">
-                <.link
-                  patch={Routes.container_index_path(Endpoint, :edit_tags, container)}
-                  class="text-primary-600 link"
-                  aria-label={
-                    dgettext("actions", "Tag %{container_name}", container_name: container.name)
-                  }
-                >
-                  <i class="fa-fw fa-lg fas fa-tags"></i>
-                </.link>
-              </div>
-            </:tag_actions>
-            <.link
-              patch={Routes.container_index_path(Endpoint, :edit, container)}
-              class="text-primary-600 link"
-              aria-label={
-                dgettext("actions", "Edit %{container_name}", container_name: container.name)
-              }
-            >
-              <i class="fa-fw fa-lg fas fa-edit"></i>
-            </.link>
-
-            <.link
-              patch={Routes.container_index_path(Endpoint, :clone, container)}
-              class="text-primary-600 link"
-              aria-label={
-                dgettext("actions", "Clone %{container_name}", container_name: container.name)
-              }
-            >
-              <i class="fa-fw fa-lg fas fa-copy"></i>
-            </.link>
-
-            <.link
-              href="#"
-              class="text-primary-600 link"
-              phx-click="delete"
-              phx-value-id={container.id}
-              data-confirm={
-                dgettext("prompts", "Are you sure you want to delete %{name}?",
-                  name: container.name
-                )
-              }
-              aria-label={
-                dgettext("actions", "Delete %{container_name}", container_name: container.name)
-              }
-            >
-              <i class="fa-fw fa-lg fas fa-trash"></i>
-            </.link>
-          </.container_card>
-        </div>
-      <% end %>
-    <% end %>
+    <%= live_patch(dgettext("actions", "New Container"),
+      to: Routes.container_index_path(Endpoint, :new),
+      class: "btn btn-primary"
+    ) %>
   <% end %>
+
+  <div class="max-w-full flex flex-row flex-wrap justify-center items-center">
+    <%= for container <- @containers do %>
+      <.container_card container={container}>
+        <:tag_actions>
+          <div class="mx-4 my-2">
+            <%= live_patch to: Routes.container_index_path(Endpoint, :edit_tags, container),
+              class: "text-primary-600 link" do %>
+              <i class="fa-fw fa-lg fas fa-tags"></i>
+            <% end %>
+          </div>
+        </:tag_actions>
+        <%= live_patch to: Routes.container_index_path(Endpoint, :edit, container),
+                   class: "text-primary-600 link",
+                   data: [qa: "edit-#{container.id}"] do %>
+          <i class="fa-fw fa-lg fas fa-edit"></i>
+        <% end %>
+
+        <%= link to: "#",
+             class: "text-primary-600 link",
+             phx_click: "delete",
+             phx_value_id: container.id,
+             data: [
+               confirm:
+                 dgettext("prompts", "Are you sure you want to delete %{name}?", name: container.name),
+               qa: "delete-#{container.id}"
+             ] do %>
+          <i class="fa-fw fa-lg fas fa-trash"></i>
+        <% end %>
+      </.container_card>
+    <% end %>
+  </div>
 </div>
 
-<%= case @live_action do %>
-  <% modifying when modifying in [:new, :edit, :clone] -> %>
-    <.modal return_to={Routes.container_index_path(Endpoint, :index)}>
-      <.live_component
-        module={CanneryWeb.ContainerLive.FormComponent}
-        id={@container.id || :new}
-        title={@page_title}
-        action={@live_action}
-        container={@container}
-        return_to={Routes.container_index_path(Endpoint, :index)}
-        current_user={@current_user}
-      />
-    </.modal>
-  <% :edit_tags -> %>
-    <.modal return_to={Routes.container_index_path(Endpoint, :index)}>
-      <.live_component
-        module={CanneryWeb.ContainerLive.EditTagsComponent}
-        id={@container.id}
-        title={@page_title}
-        action={@live_action}
-        container={@container}
-        current_path={Routes.container_index_path(Endpoint, :edit_tags, @container)}
-        current_user={@current_user}
-      />
-    </.modal>
-  <% _ -> %>
+<%= if @live_action in [:new, :edit] do %>
+  <.modal return_to={Routes.container_index_path(Endpoint, :index)}>
+    <.live_component
+      module={CanneryWeb.ContainerLive.FormComponent}
+      id={@container.id || :new}
+      title={@page_title}
+      action={@live_action}
+      container={@container}
+      return_to={Routes.container_index_path(Endpoint, :index)}
+      current_user={@current_user}
+    />
+  </.modal>
+<% end %>
+
+<%= if @live_action == :edit_tags do %>
+  <.modal return_to={Routes.container_index_path(Endpoint, :index)}>
+    <.live_component
+      module={CanneryWeb.ContainerLive.EditTagsComponent}
+      id={@container.id}
+      title={@page_title}
+      action={@live_action}
+      container={@container}
+      current_user={@current_user}
+    />
+  </.modal>
 <% end %>

lib/cannery_web/live/container_live/show.ex

@@ -4,23 +4,22 @@ defmodule CanneryWeb.ContainerLive.Show do
   """
 
   use CanneryWeb, :live_view
-  alias Cannery.{Accounts.User, ActivityLog, Ammo, Containers, Containers.Container}
+  import CanneryWeb.Components.{AmmoGroupCard, TagCard}
+  alias Cannery.{Accounts.User, Containers, Containers.Container, Repo, Tags}
   alias CanneryWeb.Endpoint
   alias Ecto.Changeset
   alias Phoenix.LiveView.Socket
 
   @impl true
-  def mount(_params, _session, socket),
-    do: {:ok, socket |> assign(type: :all, view_table: true)}
+  def mount(_params, _session, socket), do: {:ok, socket}
 
   @impl true
-  def handle_params(%{"id" => id}, _session, %{assigns: %{current_user: current_user}} = socket) do
-    socket =
-      socket
-      |> assign(view_table: true)
-      |> render_container(id, current_user)
-
-    {:noreply, socket}
+  def handle_params(
+        %{"id" => id},
+        _session,
+        %{assigns: %{current_user: current_user}} = socket
+      ) do
+    {:noreply, socket |> render_container(id, current_user)}
   end
 
   @impl true
@@ -30,7 +29,7 @@ defmodule CanneryWeb.ContainerLive.Show do
         %{assigns: %{container: container, current_user: current_user}} = socket
       ) do
     socket =
-      case Containers.get_tag(tag_id, current_user) do
+      case Tags.get_tag(tag_id, current_user) do
         {:ok, tag} ->
           _count = Containers.remove_tag!(container, tag, current_user)
 
@@ -40,15 +39,16 @@ defmodule CanneryWeb.ContainerLive.Show do
               container_name: container.name
             )
 
-          socket |> put_flash(:info, prompt) |> render_container()
+          socket |> put_flash(:info, prompt) |> render_container(container.id, current_user)
 
-        {:error, :not_found} ->
-          socket |> put_flash(:error, dgettext("errors", "Tag not found"))
+        {:error, error_string} ->
+          socket |> put_flash(:error, error_string)
       end
 
     {:noreply, socket}
   end
 
+  @impl true
   def handle_event(
         "delete_container",
         _params,
@@ -62,7 +62,7 @@ defmodule CanneryWeb.ContainerLive.Show do
 
           socket
           |> put_flash(:info, prompt)
-          |> push_navigate(to: Routes.container_index_path(socket, :index))
+          |> push_redirect(to: Routes.container_index_path(socket, :index))
 
         {:error, %{action: :delete, errors: [ammo_groups: _error], valid?: false} = changeset} ->
           ammo_groups_error = changeset |> changeset_errors(:ammo_groups) |> Enum.join(", ")
@@ -82,62 +82,20 @@ defmodule CanneryWeb.ContainerLive.Show do
     {:noreply, socket}
   end
 
-  def handle_event("toggle_table", _params, %{assigns: %{view_table: view_table}} = socket) do
-    {:noreply, socket |> assign(:view_table, !view_table) |> render_container()}
-  end
-
-  def handle_event("change_type", %{"ammo_type" => %{"type" => "rifle"}}, socket) do
-    {:noreply, socket |> assign(:type, :rifle) |> render_container()}
-  end
-
-  def handle_event("change_type", %{"ammo_type" => %{"type" => "shotgun"}}, socket) do
-    {:noreply, socket |> assign(:type, :shotgun) |> render_container()}
-  end
-
-  def handle_event("change_type", %{"ammo_type" => %{"type" => "pistol"}}, socket) do
-    {:noreply, socket |> assign(:type, :pistol) |> render_container()}
-  end
-
-  def handle_event("change_type", %{"ammo_type" => %{"type" => _all}}, socket) do
-    {:noreply, socket |> assign(:type, :all) |> render_container()}
-  end
-
   @spec render_container(Socket.t(), Container.id(), User.t()) :: Socket.t()
-  defp render_container(
-         %{assigns: %{type: type, live_action: live_action}} = socket,
-         id,
-         current_user
-       ) do
-    %{name: container_name} = container = Containers.get_container!(id, current_user)
-    ammo_groups = Ammo.list_ammo_groups_for_container(container, type, current_user)
-    original_counts = ammo_groups |> Ammo.get_original_counts(current_user)
-    cprs = ammo_groups |> Ammo.get_cprs(current_user)
-    last_used_dates = ammo_groups |> ActivityLog.get_last_used_dates(current_user)
+  defp render_container(%{assigns: %{live_action: live_action}} = socket, id, current_user) do
+    %{name: container_name} =
+      container =
+      Containers.get_container!(id, current_user)
+      |> Repo.preload([:ammo_groups, :tags], force: true)
 
     page_title =
       case live_action do
-        :show -> container_name
+        :show -> gettext("Show %{name}", name: container_name)
         :edit -> gettext("Edit %{name}", name: container_name)
         :edit_tags -> gettext("Edit %{name} tags", name: container_name)
       end
 
-    socket
-    |> assign(
-      container: container,
-      round_count: Ammo.get_round_count_for_container!(container, current_user),
-      ammo_groups_count: Ammo.get_ammo_groups_count_for_container!(container, current_user),
-      ammo_groups: ammo_groups,
-      original_counts: original_counts,
-      cprs: cprs,
-      last_used_dates: last_used_dates,
-      page_title: page_title
-    )
-  end
-
-  @spec render_container(Socket.t()) :: Socket.t()
-  defp render_container(
-         %{assigns: %{container: %{id: container_id}, current_user: current_user}} = socket
-       ) do
-    socket |> render_container(container_id, current_user)
+    socket |> assign(container: container, page_title: page_title)
   end
 end

lib/cannery_web/live/container_live/show.html.heex

@@ -1,55 +1,44 @@
-<div class="space-y-4 flex flex-col justify-center items-center">
+<div class="mx-auto space-y-4 max-w-3xl flex flex-col justify-center items-center">
   <h1 class="title text-2xl title-primary-500">
     <%= @container.name %>
   </h1>
 
-  <span :if={@container.desc} class="rounded-lg title text-lg">
-    <%= gettext("Description:") %>
-    <%= @container.desc %>
-  </span>
+  <%= if @container.desc do %>
+    <span class="rounded-lg title text-lg">
+      <%= gettext("Description:") %>
+      <%= @container.desc %>
+    </span>
+  <% end %>
 
   <span class="rounded-lg title text-lg">
     <%= gettext("Type:") %>
     <%= @container.type %>
   </span>
 
-  <span :if={@container.location} class="rounded-lg title text-lg">
-    <%= gettext("Location:") %>
-    <%= @container.location %>
-  </span>
-
-  <span class="rounded-lg title text-lg">
-    <%= gettext("Packs:") %>
-    <%= @ammo_groups_count %>
-  </span>
-
-  <span class="rounded-lg title text-lg">
-    <%= gettext("Rounds:") %>
-    <%= @round_count %>
-  </span>
+  <%= if @container.location do %>
+    <span class="rounded-lg title text-lg">
+      <%= gettext("Location:") %>
+      <%= @container.location %>
+    </span>
+  <% end %>
 
   <div class="flex space-x-4 justify-center items-center text-primary-600">
-    <.link
-      patch={Routes.container_show_path(Endpoint, :edit, @container)}
-      class="text-primary-600 link"
-      aria-label={dgettext("actions", "Edit %{container_name}", container_name: @container.name)}
-    >
+    <%= live_patch to: Routes.container_show_path(Endpoint, :edit, @container),
+               class: "text-primary-600 link",
+               data: [qa: "edit"] do %>
       <i class="fa-fw fa-lg fas fa-edit"></i>
-    </.link>
+    <% end %>
 
-    <.link
-      href="#"
-      class="text-primary-600 link"
-      phx-click="delete_container"
-      data-confirm={
-        dgettext("prompts", "Are you sure you want to delete %{name}?", name: @container.name)
-      }
-      aria-label={
-        dgettext("actions", "Delete %{container_name}", container_name: @container.name)
-      }
-    >
+    <%= link to: "#",
+         class: "text-primary-600 link",
+         phx_click: "delete_container",
+         data: [
+           confirm:
+             dgettext("prompts", "Are you sure you want to delete %{name}?", name: @container.name),
+           qa: "delete"
+         ] do %>
       <i class="fa-fw fa-lg fas fa-trash"></i>
-    </.link>
+    <% end %>
   </div>
 
   <hr class="mb-4 hr" />
@@ -61,123 +50,67 @@
         <%= display_emoji("😔") %>
       </h2>
 
-      <.link
-        patch={Routes.container_show_path(Endpoint, :edit_tags, @container)}
-        class="btn btn-primary"
-      >
-        <%= dgettext("actions", "Why not add one?") %>
-      </.link>
+      <%= live_patch(dgettext("actions", "Why not add one?"),
+        to: Routes.container_show_path(Endpoint, :edit_tags, @container),
+        class: "btn btn-primary"
+      ) %>
     </div>
   <% else %>
     <div class="flex flex-wrap justify-center items-center">
-      <.simple_tag_card :for={tag <- @container.tags} tag={tag} />
+      <%= for tag <- @container.tags do %>
+        <.simple_tag_card tag={tag} />
+      <% end %>
 
       <div class="mx-4 my-2">
-        <.link
-          patch={Routes.container_show_path(Endpoint, :edit_tags, @container)}
-          class="text-primary-600 link"
-        >
+        <%= live_patch to: Routes.container_show_path(Endpoint, :edit_tags, @container),
+          class: "text-primary-600 link" do %>
           <i class="fa-fw fa-lg fas fa-tags"></i>
-        </.link>
+        <% end %>
       </div>
     </div>
   <% end %>
 
   <hr class="mb-4 hr" />
 
-  <div class="flex justify-center items-center space-x-4">
-    <.form
-      :let={f}
-      for={%{}}
-      as={:ammo_type}
-      phx-change="change_type"
-      phx-submit="change_type"
-      class="flex items-center"
-    >
-      <%= label(f, :type, gettext("Type"), class: "title text-primary-600 text-lg text-center") %>
-
-      <%= select(
-        f,
-        :type,
-        [
-          {gettext("All"), :all},
-          {gettext("Rifle"), :rifle},
-          {gettext("Shotgun"), :shotgun},
-          {gettext("Pistol"), :pistol}
-        ],
-        class: "mx-2 my-1 min-w-md input input-primary",
-        value: @type
-      ) %>
-    </.form>
-
-    <.toggle_button action="toggle_table" value={@view_table}>
-      <span class="title text-lg text-primary-600">
-        <%= gettext("View as table") %>
-      </span>
-    </.toggle_button>
-  </div>
-
-  <div class="w-full p-4">
-    <%= if @ammo_groups |> Enum.empty?() do %>
-      <h2 class="mx-4 title text-lg text-primary-600 text-center">
-        <%= gettext("No ammo in this container") %>
+  <div>
+    <%= if @container.ammo_groups |> Enum.empty?() do %>
+      <h2 class="mx-8 my-4 title text-lg text-primary-600">
+        <%= gettext("No ammo groups in this container") %>
       </h2>
     <% else %>
-      <%= if @view_table do %>
-        <.live_component
-          module={CanneryWeb.Components.AmmoGroupTableComponent}
-          id="ammo-type-show-table"
-          ammo_groups={@ammo_groups}
-          current_user={@current_user}
-          show_used={false}
-        >
-          <:ammo_type :let={%{name: ammo_type_name} = ammo_type}>
-            <.link navigate={Routes.ammo_type_show_path(Endpoint, :show, ammo_type)} class="link">
-              <%= ammo_type_name %>
-            </.link>
-          </:ammo_type>
-        </.live_component>
-      <% else %>
-        <div class="flex flex-wrap justify-center items-stretch">
-          <.ammo_group_card
-            :for={%{id: ammo_group_id} = ammo_group <- @ammo_groups}
-            ammo_group={ammo_group}
-            original_count={Map.fetch!(@original_counts, ammo_group_id)}
-            cpr={Map.get(@cprs, ammo_group_id)}
-            last_used_date={Map.get(@last_used_dates, ammo_group_id)}
-            current_user={@current_user}
-          />
-        </div>
-      <% end %>
+      <div class="flex flex-wrap justify-center items-center">
+        <%= for ammo_group <- @container.ammo_groups do %>
+          <.ammo_group_card ammo_group={ammo_group} />
+        <% end %>
+      </div>
     <% end %>
   </div>
 </div>
 
-<%= case @live_action do %>
-  <% :edit -> %>
-    <.modal return_to={Routes.container_show_path(Endpoint, :show, @container)}>
-      <.live_component
-        module={CanneryWeb.ContainerLive.FormComponent}
-        id={@container.id}
-        title={@page_title}
-        action={@live_action}
-        container={@container}
-        return_to={Routes.container_show_path(Endpoint, :show, @container)}
-        current_user={@current_user}
-      />
-    </.modal>
-  <% :edit_tags -> %>
-    <.modal return_to={Routes.container_show_path(Endpoint, :show, @container)}>
-      <.live_component
-        module={CanneryWeb.ContainerLive.EditTagsComponent}
-        id={@container.id}
-        title={@page_title}
-        action={@live_action}
-        container={@container}
-        return_to={Routes.container_show_path(Endpoint, :show, @container)}
-        current_path={Routes.container_show_path(Endpoint, :edit_tags, @container)}
-        current_user={@current_user}
-      />
-    </.modal>
-  <% _ -> %>
+<%= if @live_action in [:edit] do %>
+  <.modal return_to={Routes.container_show_path(Endpoint, :show, @container)}>
+    <.live_component
+      module={CanneryWeb.ContainerLive.FormComponent}
+      id={@container.id}
+      title={@page_title}
+      action={@live_action}
+      container={@container}
+      return_to={Routes.container_show_path(Endpoint, :show, @container)}
+      current_user={@current_user}
+    />
+  </.modal>
+<% end %>
+
+<%= if @live_action == :edit_tags do %>
+  <.modal return_to={Routes.container_show_path(Endpoint, :show, @container)}>
+    <.live_component
+      module={CanneryWeb.ContainerLive.EditTagsComponent}
+      id={@container.id}
+      title={@page_title}
+      action={@live_action}
+      container={@container}
+      return_to={Routes.container_show_path(Endpoint, :show, @container)}
+      current_user={@current_user}
+    />
+  </.modal>
 <% end %>

lib/cannery_web/live/home_live.ex

@@ -5,13 +5,181 @@ defmodule CanneryWeb.HomeLive do
 
   use CanneryWeb, :live_view
   alias Cannery.Accounts
-  alias CanneryWeb.Endpoint
-
-  @version Mix.Project.config()[:version]
 
   @impl true
   def mount(_params, _session, socket) do
     admins = Accounts.list_users_by_role(:admin)
-    {:ok, socket |> assign(page_title: gettext("Home"), admins: admins, version: @version)}
+    socket = socket |> assign(page_title: "Home", query: "", results: %{}, admins: admins)
+    {:ok, socket}
+  end
+
+  @impl true
+  def handle_event("suggest", %{"q" => query}, socket) do
+    {:noreply, socket |> assign(results: search(query), query: query)}
+  end
+
+  @impl true
+  def handle_event("search", %{"q" => query}, socket) do
+    case search(query) do
+      %{^query => vsn} ->
+        {:noreply, redirect(socket, external: "https://hexdocs.pm/#{query}/#{vsn}")}
+
+      _no_query ->
+        {:noreply,
+         socket
+         |> put_flash(:error, "No dependencies found matching \"#{query}\"")
+         |> assign(results: %{}, query: query)}
+    end
+  end
+
+  @impl true
+  def render(assigns) do
+    ~H"""
+    <div class="mx-auto px-8 sm:px-16 flex flex-col justify-center items-center text-center space-y-4 max-w-3xl">
+      <h1 class="title text-primary-600 text-2xl">
+        <%= gettext("Welcome to %{name}", name: "Cannery") %>
+      </h1>
+
+      <h2 class="title text-primary-600 text-lg">
+        <%= gettext("The self-hosted firearm tracker website") %>
+      </h2>
+
+      <hr class="hr" />
+
+      <ul class="flex flex-col space-y-4 text-center">
+        <li class="flex flex-col justify-center items-center
+          space-y-2">
+          <b class="whitespace-nowrap">
+            <%= gettext("Easy to Use:") %>
+          </b>
+          <p>
+            <%= gettext(
+              "%{name} lets you easily keep an eye on your ammo levels before and after range day",
+              name: "Cannery"
+            ) %>
+          </p>
+        </li>
+        <li class="flex flex-col justify-center items-center
+          space-y-2">
+          <b class="whitespace-nowrap">
+            <%= gettext("Secure:") %>
+          </b>
+          <p>
+            <%= gettext("Self-host your own instance, or use an instance from someone you trust.") %>
+            <%= gettext("Your data stays with you, period") %>
+          </p>
+        </li>
+        <li class="flex flex-col justify-center items-center
+          space-y-2">
+          <b class="whitespace-nowrap">
+            <%= gettext("Simple:") %>
+          </b>
+          <p>
+            <%= gettext("Access from any internet-capable device") %>
+          </p>
+        </li>
+      </ul>
+
+      <hr class="hr" />
+
+      <ul class="flex flex-col space-y-2 text-center justify-center">
+        <h2 class="title text-primary-600 text-lg">
+          <%= gettext("Instance Information") %>
+        </h2>
+
+        <li class="flex flex-col justify-center space-x-2">
+          <b>
+            <%= gettext("Admins:") %>
+          </b>
+          <p>
+            <%= if @admins |> Enum.empty?() do %>
+              <%= link(dgettext("prompts", "Register to setup %{name}", name: "Cannery"),
+                class: "hover:underline",
+                to: Routes.user_registration_path(CanneryWeb.Endpoint, :new)
+              ) %>
+            <% else %>
+              <div class="flex flex-wrap justify-center space-x-2">
+                <%= for admin <- @admins do %>
+                  <a class="hover:underline" href={"mailto:#{admin.email}"}>
+                    <%= admin.email %>
+                  </a>
+                <% end %>
+              </div>
+            <% end %>
+          </p>
+        </li>
+
+        <li class="flex flex-row justify-center space-x-2">
+          <b>Registration:</b>
+          <p>
+            <%= Application.get_env(:cannery, CanneryWeb.Endpoint)[:registration]
+            |> case do
+              "public" -> gettext("Public Signups")
+              _ -> gettext("Invite Only")
+            end %>
+          </p>
+        </li>
+
+        <li class="flex flex-row justify-center items-center space-x-2">
+          <b>Version:</b>
+          <%= link class: "flex flex-row justify-center items-center space-x-2 hover:underline",
+                to: "https://gitea.bubbletea.dev/shibao/cannery/src/branch/stable/CHANGELOG.md",
+                target: "_blank",
+                rel: "noopener noreferrer" do %>
+            <p>0.5.3</p>
+            <i class="fas fa-md fa-info-circle"></i>
+          <% end %>
+        </li>
+      </ul>
+
+      <hr class="hr" />
+
+      <ul class="flex flex-col space-y-2 text-center justify-center">
+        <h2 class="title text-primary-600 text-lg">
+          <%= gettext("Get involved!") %>
+        </h2>
+
+        <li class="flex flex-col justify-center space-x-2">
+          <%= link class: "flex flex-row justify-center items-center space-x-2 hover:underline",
+                to: "https://gitea.bubbletea.dev/shibao/cannery",
+                target: "_blank",
+                rel: "noopener noreferrer" do %>
+            <p><%= gettext("View the source code") %></p>
+            <i class="fas fa-md fa-code"></i>
+          <% end %>
+        </li>
+        <li class="flex flex-col justify-center space-x-2">
+          <%= link class: "flex flex-row justify-center items-center space-x-2 hover:underline",
+              to: "https://weblate.bubbletea.dev/engage/cannery",
+              target: "_blank",
+              rel: "noopener noreferrer" do %>
+            <p><%= gettext("Help translate") %></p>
+            <i class="fas fa-md fa-language"></i>
+          <% end %>
+        </li>
+        <li class="flex flex-col justify-center space-x-2">
+          <%= link class: "flex flex-row justify-center items-center space-x-2 hover:underline",
+              to: "https://gitea.bubbletea.dev/shibao/cannery/issues/new",
+              target: "_blank",
+              rel: "noopener noreferrer" do %>
+            <p><%= gettext("Report bugs or request features") %></p>
+            <i class="fas fa-md fa-spider"></i>
+          <% end %>
+        </li>
+      </ul>
+    </div>
+    """
+  end
+
+  defp search(query) do
+    if not CanneryWeb.Endpoint.config(:code_reloader) do
+      raise "action disabled when not in development"
+    end
+
+    for {app, desc, vsn} <- Application.started_applications(),
+        app = to_string(app),
+        String.starts_with?(app, query) and not List.starts_with?(desc, ~c"ERTS"),
+        into: %{},
+        do: {app, vsn}
   end
 end