shibao/cannery
1
2
Fork 1
Code Issues 14 Pull Requests Projects 1 Releases 40 Wiki Activity

fixes test warnings

Browse Source
This commit is contained in:
shibao
2022-02-17 20:01:14 -05:00
parent 7948f44c05
commit a1554879cc
5 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/cannery_web/controllers/user_auth.ex
View File

@@ -31,7 +31,7 @@ defmodule CanneryWeb.UserAuth do
""" """
def log_in_user(conn, user, params \\ %{}) def log_in_user(conn, user, params \\ %{})
def log_in_user(conn, %User{confirmed_at: nil}, params) do def log_in_user(conn, %User{confirmed_at: nil}, _params) do
conn conn
|> put_flash( |> put_flash(
:error, :error,

2
test/cannery_web/live/ammo_group_live_test.exs
View File

@@ -11,7 +11,7 @@ defmodule CanneryWeb.AmmoGroupLiveTest do
@moduletag :ammo_group_live_test @moduletag :ammo_group_live_test
@create_attrs %{count: 42, notes: "some notes", price_paid: 120.5} @create_attrs %{count: 42, notes: "some notes", price_paid: 120.5}
@update_attrs %{count: 43, notes: "some updated notes", price_paid: 456.7} @update_attrs %{count: 43, notes: "some updated notes", price_paid: 456.7}
@invalid_attrs %{count: -1, notes: nil, price_paid: nil} # @invalid_attrs %{count: -1, notes: nil, price_paid: nil}
defp create_ammo_group(%{current_user: current_user}) do defp create_ammo_group(%{current_user: current_user}) do
ammo_type = ammo_type_fixture(current_user) ammo_type = ammo_type_fixture(current_user)

2
test/cannery_web/live/invite_live_test.exs
View File

@@ -11,7 +11,7 @@ defmodule CanneryWeb.InviteLiveTest do
@moduletag :invite_live_test @moduletag :invite_live_test
@create_attrs %{"name" => "some name"} @create_attrs %{"name" => "some name"}
@update_attrs %{"name" => "some updated name"} @update_attrs %{"name" => "some updated name"}
@invalid_attrs %{"name" => nil} # @invalid_attrs %{"name" => nil}
describe "Index" do describe "Index" do
setup [:register_and_log_in_user] setup [:register_and_log_in_user]

4
test/cannery_web/live/range_live_test.exs
View File

@@ -11,7 +11,7 @@ defmodule CanneryWeb.RangeLiveTest do
@moduletag :range_live_test @moduletag :range_live_test
@create_attrs %{"ammo_left" => 5, "notes" => "some notes"} @create_attrs %{"ammo_left" => 5, "notes" => "some notes"}
@update_attrs %{"count" => 16, "notes" => "some updated notes"} @update_attrs %{"count" => 16, "notes" => "some updated notes"}
@invalid_attrs %{"count" => nil, "notes" => nil} # @invalid_attrs %{"count" => nil, "notes" => nil}
defp create_shot_group(%{current_user: current_user}) do defp create_shot_group(%{current_user: current_user}) do
container = container_fixture(%{"staged" => true}, current_user) container = container_fixture(%{"staged" => true}, current_user)
@@ -39,7 +39,7 @@ defmodule CanneryWeb.RangeLiveTest do
{:ok, index_live, _html} = live(conn, Routes.range_index_path(conn, :index)) {:ok, index_live, _html} = live(conn, Routes.range_index_path(conn, :index))
assert index_live |> element("a", dgettext("actions", "Record shots")) |> render_click() =~ assert index_live |> element("a", dgettext("actions", "Record shots")) |> render_click() =~
gettext("Record shots") gettext("Record shots")
assert_patch(index_live, Routes.range_index_path(conn, :add_shot_group, ammo_group)) assert_patch(index_live, Routes.range_index_path(conn, :add_shot_group, ammo_group))

16
test/cannery_web/live/tag_live_test.exs
View File

@@ -19,13 +19,13 @@ defmodule CanneryWeb.TagLiveTest do
"name" => "some updated name", "name" => "some updated name",
"text_color" => "some updated text-color" "text_color" => "some updated text-color"
} }
@invalid_attrs %{ # @invalid_attrs %{
"bg_color" => nil, # "bg_color" => nil,
"name" => nil, # "name" => nil,
"text_color" => nil # "text_color" => nil
} # }
def create_tag %{current_user: current_user} do def create_tag(%{current_user: current_user}) do
tag = tag_fixture(current_user) tag = tag_fixture(current_user)
%{tag: tag, current_user: current_user} %{tag: tag, current_user: current_user}
end end
@@ -80,7 +80,9 @@ defmodule CanneryWeb.TagLiveTest do
|> render_submit() |> render_submit()
|> follow_redirect(conn, Routes.tag_index_path(conn, :index)) |> follow_redirect(conn, Routes.tag_index_path(conn, :index))
assert html =~ dgettext("prompts", "%{name} updated successfully", name: "some updated name") assert html =~
dgettext("prompts", "%{name} updated successfully", name: "some updated name")
assert html =~ "some updated bg-color" assert html =~ "some updated bg-color"
end end