use credo style

test/lokal/accounts_test.exs

@@ -316,7 +316,7 @@ defmodule Lokal.AccountsTest do
     end
 
     test "deletes all tokens for the given user", %{user: user} do
-      _ = Accounts.generate_user_session_token(user)
+      _session_token = Accounts.generate_user_session_token(user)
 
       {:ok, _} =
         Accounts.update_user_password(user, valid_user_password(), %{
@@ -513,7 +513,7 @@ defmodule Lokal.AccountsTest do
     end
 
     test "deletes all tokens for the given user", %{user: user} do
-      _ = Accounts.generate_user_session_token(user)
+      _session_token = Accounts.generate_user_session_token(user)
       {:ok, _} = Accounts.reset_user_password(user, %{"password" => "new valid password"})
       refute Repo.get_by(UserToken, user_id: user.id)
     end

test/lokal_web/controllers/user_auth_test.exs

@@ -116,7 +116,7 @@ defmodule LokalWeb.UserAuthTest do
     end
 
     test "does not authenticate if data is missing", %{conn: conn, current_user: current_user} do
-      _ = Accounts.generate_user_session_token(current_user)
+      _session_token = Accounts.generate_user_session_token(current_user)
       conn = UserAuth.fetch_current_user(conn, [])
       refute get_session(conn, :user_token)
       refute conn.assigns.current_user

test/lokal_web/controllers/user_confirmation_controller_test.exs

@@ -5,8 +5,7 @@ defmodule LokalWeb.UserConfirmationControllerTest do
 
   use LokalWeb.ConnCase, async: true
   import LokalWeb.Gettext
-  alias Lokal.Accounts
-  alias Lokal.Repo
+  alias Lokal.{Accounts, Repo}
 
   @moduletag :user_confirmation_controller_test
 

test/lokal_web/live/invite_live_test.exs

@@ -40,7 +40,7 @@ defmodule LokalWeb.InviteLiveTest do
       #        |> form("#invite-form", invite: @invalid_attrs)
       #        |> render_change() =~ dgettext("errors", "can't be blank")
 
-      {:ok, _, html} =
+      {:ok, _live, html} =
         index_live
         |> form("#invite-form", invite: @create_attrs)
         |> render_submit()
@@ -64,7 +64,7 @@ defmodule LokalWeb.InviteLiveTest do
       #        |> form("#invite-form", invite: @invalid_attrs)
       #        |> render_change() =~ dgettext("errors", "can't be blank")
 
-      {:ok, _, html} =
+      {:ok, _live, html} =
         index_live
         |> form("#invite-form", invite: @update_attrs)
         |> render_submit()

test/lokal_web/views/error_view_test.exs

@@ -5,12 +5,11 @@ defmodule LokalWeb.ErrorViewTest do
 
   use LokalWeb.ConnCase, async: true
   import LokalWeb.Gettext
-
-  @moduletag :error_view_test
-
   # Bring render/3 and render_to_string/3 for testing custom views
   import Phoenix.View
 
+  @moduletag :error_view_test
+
   test "renders 404.html" do
     assert render_to_string(LokalWeb.ErrorView, "404.html", []) =~
              dgettext("errors", "Not found")

test/support/conn_case.ex

@@ -25,6 +25,7 @@ defmodule LokalWeb.ConnCase do
       # Import conveniences for testing with connections
       import Plug.Conn
       import Phoenix.ConnTest
+      # credo:disable-for-next-line Credo.Check.Consistency.MultiAliasImportRequireUse
       import Lokal.Fixtures
       import LokalWeb.ConnCase
 

test/support/data_case.ex

@@ -22,10 +22,8 @@ defmodule Lokal.DataCase do
       alias Lokal.Repo
 
       import Ecto
-      import Ecto.Changeset
-      import Ecto.Query
-      import Lokal.DataCase
-      import Lokal.Fixtures
+      import Ecto.{Changeset, Query}
+      import Lokal.{DataCase, Fixtures}
     end
   end
 
@@ -45,7 +43,7 @@ defmodule Lokal.DataCase do
   """
   def errors_on(changeset) do
     Ecto.Changeset.traverse_errors(changeset, fn {message, opts} ->
-      Regex.replace(~r"%{(\w+)}", message, fn _, key ->
+      Regex.replace(~r"%{(\w+)}", message, fn _capture, key ->
         opts |> Keyword.get(String.to_existing_atom(key), key) |> to_string()
       end)
     end)