improve templates

lib/cannery_web/views/error_helpers.ex

@@ -17,11 +17,13 @@ defmodule CanneryWeb.ErrorHelpers do
     assigns = %{extra_class: extra_class, form: form, field: field}
 
     ~H"""
-    <%= for error <- Keyword.get_values(@form.errors, @field) do %>
-      <span class={["invalid-feedback", @extra_class]} phx-feedback-for={input_name(@form, @field)}>
-        <%= translate_error(error) %>
-      </span>
-    <% end %>
+    <span
+      :for={error <- Keyword.get_values(@form.errors, @field)}
+      class={["invalid-feedback", @extra_class]}
+      phx-feedback-for={input_name(@form, @field)}
+    >
+      <%= translate_error(error) %>
+    </span>
     """
   end
 

lib/cannery_web/views/layout_view.ex

@@ -7,11 +7,11 @@ defmodule CanneryWeb.LayoutView do
   # so we instruct Elixir to not warn if the dashboard route is missing.
   @compile {:no_warn_undefined, {Routes, :live_dashboard_path, 2}}
 
-  def get_title(conn) do
-    if conn.assigns |> Map.has_key?(:title) do
-      "Cannery | #{conn.assigns.title}"
-    else
-      "Cannery"
-    end
+  def get_title(%{assigns: %{title: title}}) when title not in [nil, ""] do
+    gettext("Cannery | %{title}", title: title)
+  end
+
+  def get_title(_conn) do
+    gettext("Cannery")
   end
 end

lib/cannery_web/views/view_helpers.ex

@@ -16,19 +16,18 @@ defmodule CanneryWeb.ViewHelpers do
 
   def datetime(assigns) do
     ~H"""
-    <%= if @datetime do %>
-      <time
-        datetime={cast_datetime(@datetime)}
-        x-data={"{
-          datetime:
-            Intl.DateTimeFormat([], {dateStyle: 'short', timeStyle: 'long'})
-              .format(new Date(\"#{cast_datetime(@datetime)}\"))
-        }"}
-        x-text="datetime"
-      >
-        <%= cast_datetime(@datetime) %>
-      </time>
-    <% end %>
+    <time
+      :if={@datetime}
+      datetime={cast_datetime(@datetime)}
+      x-data={"{
+        datetime:
+          Intl.DateTimeFormat([], {dateStyle: 'short', timeStyle: 'long'})
+            .format(new Date(\"#{cast_datetime(@datetime)}\"))
+      }"}
+      x-text="datetime"
+    >
+      <%= cast_datetime(@datetime) %>
+    </time>
     """
   end
 
@@ -48,19 +47,18 @@ defmodule CanneryWeb.ViewHelpers do
 
   def date(assigns) do
     ~H"""
-    <%= if @date do %>
-      <time
-        datetime={@date |> Date.to_iso8601(:extended)}
-        x-data={"{
-          date:
-            Intl.DateTimeFormat([], {timeZone: 'Etc/UTC', dateStyle: 'short'})
-              .format(new Date(\"#{@date |> Date.to_iso8601(:extended)}\"))
-        }"}
-        x-text="date"
-      >
-        <%= @date |> Date.to_iso8601(:extended) %>
-      </time>
-    <% end %>
+    <time
+      :if={@date}
+      datetime={@date |> Date.to_iso8601(:extended)}
+      x-data={"{
+        date:
+          Intl.DateTimeFormat([], {timeZone: 'Etc/UTC', dateStyle: 'short'})
+            .format(new Date(\"#{@date |> Date.to_iso8601(:extended)}\"))
+      }"}
+      x-text="date"
+    >
+      <%= @date |> Date.to_iso8601(:extended) %>
+    </time>
     """
   end